232180 2021-10-22 15:32:00 -0700 Fix nits from 232019 2021-10-22 16:32:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 justin_michaud justin_michaud ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1807902 0 justin_michaud 2021-10-22 15:32:00 -0700 Fix nits from 232019 1807906 1 442205 justin_michaud 2021-10-22 15:40:10 -0700 Created attachment 442205 Patch 1807912 2 442205 saam 2021-10-22 15:46:34 -0700 Comment on attachment 442205 Patch r=me 1807944 3 ews-feeder 2021-10-22 16:31:14 -0700 Committed r284726 (243438@main): <https://commits.webkit.org/243438@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442205. 1807945 4 webkit-bug-importer 2021-10-22 16:32:17 -0700 <rdar://problem/84568214> 442205 2021-10-22 15:40:10 -0700 2021-10-22 16:31:15 -0700 Patch bug-232180-20211022154009.patch text/plain 4680 justin_michaud U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk MmIwYjk0ZTRlNDgwNzQyZjk1YjZkZWIxMDg2MzM1NGE5ODY5MzRhLi41NzkxNTRiOGU4OTc5YmY2 NDMxNGUzMzlmNjk0NmQyMDE2YTY0Yzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMS0xMC0yMiAgSnVzdGluIE1pY2hhdWQgIDxqdXN0aW5fbWljaGF1ZEBh cHBsZS5jb20+CisKKyAgICAgICAgRml4IG5pdHMgZnJvbSAyMzIwMTkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjE4MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG9ubHkgbmVlZCBvbmUgd3JpdGUg YmFycmllciwgc2luY2Ugd2Ugb25seSBuZWVkIHRvIGd1YXJhbnRlZSB0aGF0IHdlIHJlYWQgdGhl IHN0YXR1cyBvZiB0aGUgd3JpdGUgYmFycmllciBiZWZvcmUgd2UgcmVhZCBmcm9tIHRoZSBzdHJ1 Y3R1cmUgY2FjaGUuCisgICAgICAgIElmIHdlIGFyZSBkZWxheWVkIGluIHdhdGNoaW5nIHRoZSB3 YXRjaHBvaW50LCBpdCBkb2VzIG5vdCBjaGFuZ2UgYW55IG9mIHRoZSBpbnRlcmxlYXZpbmdzLgor CisgICAgICAgICogZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmg6CisgICAgICAg IChKU0M6OkRGRzo6QWJzdHJhY3RJbnRlcnByZXRlcjxBYnN0cmFjdFN0YXRlVHlwZT46OmV4ZWN1 dGVFZmZlY3RzKToKKyAgICAgICAgKiBkZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhhc2UuY3BwOgor ICAgICAgICAoSlNDOjpERkc6OkNvbnN0YW50Rm9sZGluZ1BoYXNlOjpmb2xkQ29uc3RhbnRzKToK KwogMjAyMS0xMC0yMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAg ICAgIFtKU0NdIEdldFR5cGVkQXJyYXlMZW5ndGhBc0ludDUyIG11c3QgYmUgaW5zZXJ0ZWQgb25s eSB3aGVuIHdlIGVuc3VyZSB0aGF0IGlucHV0IGlzIFR5cGVkQXJyYXkgdmlhIGFycmF5LW1vZGUt YmFzZWQgZmlsdGVyaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmgKaW5kZXggMmE4ODVjNTEzODM4MTJkNDkw ZDE3Nzk0Y2U0MjEwOWNhYjZlMTE2ZS4uMzg4ZTA2NmE4ODg1MDAyOTg5OTgxOGUzOTM5NTJiZjBm YmQwYzI1ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFj dEludGVycHJldGVySW5saW5lcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH QWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaApAQCAtMzEyNywxNSArMzEyNywxMyBAQCBib29s IEFic3RyYWN0SW50ZXJwcmV0ZXI8QWJzdHJhY3RTdGF0ZVR5cGU+OjpleGVjdXRlRWZmZWN0cyh1 bnNpZ25lZCBjbG9iYmVyTGltaQogICAgICAgICAgICAgZWxzZSBpZiAoYmFzZS5pc09iamVjdCgp KSB7CiAgICAgICAgICAgICAgICAgLy8gSGF2aW5nIGEgYmFkIHRpbWUgY2xlYXJzIHRoZSBzdHJ1 Y3R1cmVDYWNoZSwgYW5kIHNvIGl0IHNob3VsZCBpbnZhbGlkYXRlIHRoaXMgc3RydWN0dXJlLgog ICAgICAgICAgICAgICAgIGJvb2wgaXNIYXZpbmdBQmFkVGltZSA9IGdsb2JhbE9iamVjdC0+aXNI YXZpbmdBQmFkVGltZSgpOwotICAgICAgICAgICAgICAgIFdURjo6bG9hZExvYWRGZW5jZSgpOwot ICAgICAgICAgICAgICAgIGlmICghaXNIYXZpbmdBQmFkVGltZSkKLSAgICAgICAgICAgICAgICAg ICAgbV9ncmFwaC53YXRjaHBvaW50cygpLmFkZExhemlseShnbG9iYWxPYmplY3QtPmhhdmluZ0FC YWRUaW1lV2F0Y2hwb2ludCgpKTsKICAgICAgICAgICAgICAgICAvLyBOb3JtYWxseSwgd2Ugd291 bGQgYWx3YXlzIGluc3RhbGwgYSB3YXRjaHBvaW50LiBJbiB0aGlzIGNhc2UsIGhvd2V2ZXIsIGlm IHdlIGhhdmVBQmFkVGltZSwgd2UKICAgICAgICAgICAgICAgICAvLyBzdGlsbCB3YW50IHRvIG9w dGltaXplLiBUaGVyZSBpcyBubyB3YXRjaHBvaW50IGZvciB0aGF0IGNhc2UgdGhvdWdoLCBzbyB3 ZSBuZWVkIHRvIG1ha2Ugc3VyZSB0aGlzIGxvYWQKICAgICAgICAgICAgICAgICAvLyBkb2VzIG5v dCBnZXQgaG9pc3RlZCBhYm92ZSB0aGUgY2hlY2suCiAgICAgICAgICAgICAgICAgV1RGOjpsb2Fk TG9hZEZlbmNlKCk7Ci0gICAgICAgICAgICAgICAgc3RydWN0dXJlID0gbV92bS5zdHJ1Y3R1cmVD YWNoZQotICAgICAgICAgICAgICAgICAgICAuZW1wdHlPYmplY3RTdHJ1Y3R1cmVDb25jdXJyZW50 bHkoZ2xvYmFsT2JqZWN0LCBiYXNlLmdldE9iamVjdCgpLCBKU0ZpbmFsT2JqZWN0OjpkZWZhdWx0 SW5saW5lQ2FwYWNpdHkoKSk7CisgICAgICAgICAgICAgICAgaWYgKCFpc0hhdmluZ0FCYWRUaW1l KQorICAgICAgICAgICAgICAgICAgICBtX2dyYXBoLndhdGNocG9pbnRzKCkuYWRkTGF6aWx5KGds b2JhbE9iamVjdC0+aGF2aW5nQUJhZFRpbWVXYXRjaHBvaW50KCkpOworICAgICAgICAgICAgICAg IHN0cnVjdHVyZSA9IG1fdm0uc3RydWN0dXJlQ2FjaGUuZW1wdHlPYmplY3RTdHJ1Y3R1cmVDb25j dXJyZW50bHkoZ2xvYmFsT2JqZWN0LCBiYXNlLmdldE9iamVjdCgpLCBKU0ZpbmFsT2JqZWN0Ojpk ZWZhdWx0SW5saW5lQ2FwYWNpdHkoKSk7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICAKICAg ICAgICAgICAgIGlmIChzdHJ1Y3R1cmUpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhhc2UuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHAKaW5kZXggZjFlMjczNjlhZTJkODUy ZjY3MWUzZGI4Yzc0NTk5ZTg4MDk1YjZjZS4uNjBlNGJlZjVlMzk0NTU5NmY2MGZkMjE3NzMxMzVh NWE0ODRlZDU3YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb25z dGFudEZvbGRpbmdQaGFzZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdD b25zdGFudEZvbGRpbmdQaGFzZS5jcHAKQEAgLTgzOSwxNSArODM5LDEzIEBAIHByaXZhdGU6CiAg ICAgICAgICAgICAgICAgICAgIGVsc2UgaWYgKGJhc2UuaXNPYmplY3QoKSkgewogICAgICAgICAg ICAgICAgICAgICAgICAgLy8gSGF2aW5nIGEgYmFkIHRpbWUgY2xlYXJzIHRoZSBzdHJ1Y3R1cmVD YWNoZSwgYW5kIHNvIGl0IHNob3VsZCBpbnZhbGlkYXRlIHRoaXMgc3RydWN0dXJlLgogICAgICAg ICAgICAgICAgICAgICAgICAgYm9vbCBpc0hhdmluZ0FCYWRUaW1lID0gZ2xvYmFsT2JqZWN0LT5p c0hhdmluZ0FCYWRUaW1lKCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICBXVEY6OmxvYWRMb2Fk RmVuY2UoKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIGlmICghaXNIYXZpbmdBQmFkVGltZSkK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICBtX2dyYXBoLndhdGNocG9pbnRzKCkuYWRkTGF6 aWx5KGdsb2JhbE9iamVjdC0+aGF2aW5nQUJhZFRpbWVXYXRjaHBvaW50KCkpOwogICAgICAgICAg ICAgICAgICAgICAgICAgLy8gTm9ybWFsbHksIHdlIHdvdWxkIGFsd2F5cyBpbnN0YWxsIGEgd2F0 Y2hwb2ludC4gSW4gdGhpcyBjYXNlLCBob3dldmVyLCBpZiB3ZSBoYXZlQUJhZFRpbWUsIHdlCiAg ICAgICAgICAgICAgICAgICAgICAgICAvLyBzdGlsbCB3YW50IHRvIG9wdGltaXplLiBUaGVyZSBp cyBubyB3YXRjaHBvaW50IGZvciB0aGF0IGNhc2UgdGhvdWdoLCBzbyB3ZSBuZWVkIHRvIG1ha2Ug c3VyZSB0aGlzIGxvYWQKICAgICAgICAgICAgICAgICAgICAgICAgIC8vIGRvZXMgbm90IGdldCBo b2lzdGVkIGFib3ZlIHRoZSBjaGVjay4KICAgICAgICAgICAgICAgICAgICAgICAgIFdURjo6bG9h ZExvYWRGZW5jZSgpOwotICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0dXJlID0gZ2xvYmFs T2JqZWN0LT52bSgpLnN0cnVjdHVyZUNhY2hlCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg LmVtcHR5T2JqZWN0U3RydWN0dXJlQ29uY3VycmVudGx5KGdsb2JhbE9iamVjdCwgYmFzZS5nZXRP YmplY3QoKSwgSlNGaW5hbE9iamVjdDo6ZGVmYXVsdElubGluZUNhcGFjaXR5KCkpOworICAgICAg ICAgICAgICAgICAgICAgICAgaWYgKCFpc0hhdmluZ0FCYWRUaW1lKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgIG1fZ3JhcGgud2F0Y2hwb2ludHMoKS5hZGRMYXppbHkoZ2xvYmFsT2JqZWN0 LT5oYXZpbmdBQmFkVGltZVdhdGNocG9pbnQoKSk7CisgICAgICAgICAgICAgICAgICAgICAgICBz dHJ1Y3R1cmUgPSBnbG9iYWxPYmplY3QtPnZtKCkuc3RydWN0dXJlQ2FjaGUuZW1wdHlPYmplY3RT dHJ1Y3R1cmVDb25jdXJyZW50bHkoZ2xvYmFsT2JqZWN0LCBiYXNlLmdldE9iamVjdCgpLCBKU0Zp bmFsT2JqZWN0OjpkZWZhdWx0SW5saW5lQ2FwYWNpdHkoKSk7CiAgICAgICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgIGlmIChzdHJ1Y3R1 cmUpIHsK