232172 2021-10-22 13:53:05 -0700 Change Heap::writeBarrier() to do the cheaper check first. 2021-10-22 14:48:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1807862 0 mark.lam 2021-10-22 13:53:05 -0700 It's cheaper to do a check using incoming args (which are already loaded in registers) than to do a check which requires memory loads. 1807863 1 442195 mark.lam 2021-10-22 13:55:18 -0700 Created attachment 442195 proposed patch. 1807865 2 442195 rmorisset 2021-10-22 13:57:16 -0700 Comment on attachment 442195 proposed patch. r=me 1807867 3 442195 mark.lam 2021-10-22 14:00:59 -0700 Comment on attachment 442195 proposed patch. Thanks for the review. 1807887 4 ews-feeder 2021-10-22 14:47:41 -0700 Committed r284715 (243430@main): <https://commits.webkit.org/243430@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442195. 1807888 5 webkit-bug-importer 2021-10-22 14:48:20 -0700 <rdar://problem/84564524> 442195 2021-10-22 13:55:18 -0700 2021-10-22 14:47:42 -0700 proposed patch. bug-232172.patch text/plain 1377 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjg0NzEyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDIxLTEwLTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD aGFuZ2UgSGVhcDo6d3JpdGVCYXJyaWVyKCkgdG8gZG8gdGhlIGNoZWFwZXIgY2hlY2sgZmlyc3Qu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzIxNzIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCdzIGNo ZWFwZXIgdG8gZG8gYSBjaGVjayB1c2luZyBpbmNvbWluZyBhcmdzICh3aGljaCBhcmUgYWxyZWFk eSBsb2FkZWQgaW4KKyAgICAgICAgcmVnaXN0ZXJzKSB0aGFuIHRvIGRvIGEgY2hlY2sgd2hpY2gg cmVxdWlyZXMgbWVtb3J5IGxvYWRzLgorCisgICAgICAgICogaGVhcC9IZWFwSW5saW5lcy5oOgor ICAgICAgICAoSlNDOjpIZWFwOjp3cml0ZUJhcnJpZXIpOgorCiAyMDIxLTEwLTIyICBBc3VtdSBU YWtpa2F3YSAgPGFzdW11QGlnYWxpYS5jb20+CiAKICAgICAgICAgQ2hhbmdlIFdlYkFzc2VtYmx5 IG1vZHVsZSBpbXBvcnQgbGlua2luZyB0aW1lIHRvIGV2YWx1YXRlIHN0ZXAuCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwSW5saW5lcy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXBJbmxpbmVzLmgJKHJldmlzaW9uIDI4NDcxMikKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXBJbmxpbmVzLmgJKHdvcmtpbmcgY29weSkK QEAgLTEwOSwxMCArMTA5LDEwIEBAIGlubGluZSB2b2lkIEhlYXA6OndyaXRlQmFycmllcihjb25z dCBKU0MKICNlbmRpZgogICAgIGlmICghZnJvbSkKICAgICAgICAgcmV0dXJuOwotICAgIGlmICgh aXNXaXRoaW5UaHJlc2hvbGQoZnJvbS0+Y2VsbFN0YXRlKCksIGJhcnJpZXJUaHJlc2hvbGQoKSkp Ci0gICAgICAgIHJldHVybjsKICAgICBpZiAoTElLRUxZKCF0bykpCiAgICAgICAgIHJldHVybjsK KyAgICBpZiAoIWlzV2l0aGluVGhyZXNob2xkKGZyb20tPmNlbGxTdGF0ZSgpLCBiYXJyaWVyVGhy ZXNob2xkKCkpKQorICAgICAgICByZXR1cm47CiAgICAgd3JpdGVCYXJyaWVyU2xvd1BhdGgoZnJv bSk7CiB9CiAK