<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>232168</bug_id>
          
          <creation_ts>2021-10-22 13:10:39 -0700</creation_ts>
          <short_desc>[JSC] GetTypedArrayLengthAsInt52 must be inserted only when we ensure that input is TypedArray via array-mode-based filtering</short_desc>
          <delta_ts>2021-10-22 14:56:10 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>rmorisset</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1807839</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-10-22 13:10:39 -0700</bug_when>
    <thetext>[JSC] GetTypedArrayLengthAsInt52 must be inserted only when we ensure that input is TypedArray via array-mode-based filtering</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1807840</commentid>
    <comment_count>1</comment_count>
      <attachid>442188</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-10-22 13:12:26 -0700</bug_when>
    <thetext>Created attachment 442188
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1807841</commentid>
    <comment_count>2</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-10-22 13:12:29 -0700</bug_when>
    <thetext>&lt;rdar://problem/84366658&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1807849</commentid>
    <comment_count>3</comment_count>
      <attachid>442192</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-10-22 13:25:29 -0700</bug_when>
    <thetext>Created attachment 442192
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1807853</commentid>
    <comment_count>4</comment_count>
      <attachid>442192</attachid>
    <who name="Robin Morisset">rmorisset</who>
    <bug_when>2021-10-22 13:33:11 -0700</bug_when>
    <thetext>Comment on attachment 442192
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442192&amp;action=review

&gt; Source/JavaScriptCore/dfg/DFGSSALoweringPhase.cpp:102
&gt; +            if (m_node-&gt;arrayMode().isSomeTypedArrayView() &amp;&amp; m_node-&gt;arrayMode().isOutOfBounds()) {

This actually increases how often we take that code path, as isSomeTypedArrayView() returns true for AnyTypedArray whose typedArrayTyped() is NotTypedArray.
Is it on purpose?

&gt; Source/JavaScriptCore/dfg/DFGSSALoweringPhase.cpp:152
&gt; +        if ((op == GetArrayLength) &amp;&amp; m_node-&gt;arrayMode().isSomeTypedArrayView() &amp;&amp; (m_node-&gt;arrayMode().mayBeLargeTypedArray() || m_graph.hasExitSite(m_node-&gt;origin.semantic, Overflow))) {

Ah, this is the bug, thanks for finding it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1807856</commentid>
    <comment_count>5</comment_count>
      <attachid>442192</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-10-22 13:38:00 -0700</bug_when>
    <thetext>Comment on attachment 442192
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442192&amp;action=review

&gt;&gt; Source/JavaScriptCore/dfg/DFGSSALoweringPhase.cpp:102
&gt;&gt; +            if (m_node-&gt;arrayMode().isSomeTypedArrayView() &amp;&amp; m_node-&gt;arrayMode().isOutOfBounds()) {
&gt; 
&gt; This actually increases how often we take that code path, as isSomeTypedArrayView() returns true for AnyTypedArray whose typedArrayTyped() is NotTypedArray.
&gt; Is it on purpose?

Yes. Currently both will not get AnyArrayType value since it will be used only for some intrinsics, and they are not emitting GetByVal, PutByVal etc.
But I aligned the implementation to using isSomeTypedArrayView since permitsBoundsCheckLowering (this is in the prologue of lowerBoundsCheck) is accepting AnyArrayType, and getting typed array length should work for AnyArrayType type too.

&gt;&gt; Source/JavaScriptCore/dfg/DFGSSALoweringPhase.cpp:152
&gt;&gt; +        if ((op == GetArrayLength) &amp;&amp; m_node-&gt;arrayMode().isSomeTypedArrayView() &amp;&amp; (m_node-&gt;arrayMode().mayBeLargeTypedArray() || m_graph.hasExitSite(m_node-&gt;origin.semantic, Overflow))) {
&gt; 
&gt; Ah, this is the bug, thanks for finding it.

Ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1807857</commentid>
    <comment_count>6</comment_count>
      <attachid>442192</attachid>
    <who name="Robin Morisset">rmorisset</who>
    <bug_when>2021-10-22 13:39:11 -0700</bug_when>
    <thetext>Comment on attachment 442192
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1807891</commentid>
    <comment_count>7</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-10-22 14:56:10 -0700</bug_when>
    <thetext>Committed r284716 (243431@main): &lt;https://commits.webkit.org/243431@main&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>442188</attachid>
            <date>2021-10-22 13:12:26 -0700</date>
            <delta_ts>2021-10-22 13:25:28 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-232168-20211022131226.patch</filename>
            <type>text/plain</type>
            <size>3545</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1
NzkwMjc1N2Q1MGExNzU3YTFjODcyNjRlMjE0ZjAzNmY4N2I5MjdkLi5hYzIzZTI5MjE1NTcwMWU3
NTYwM2ZhMmNmYjI2OWE1YWViM2QxMTE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxOCBAQAorMjAyMS0xMC0yMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t
PgorCisgICAgICAgIFtKU0NdIEdldFR5cGVkQXJyYXlMZW5ndGhBc0ludDUyIG11c3QgYmUgaW5z
ZXJ0ZWQgb25seSB3aGVuIHdlIGVuc3VyZSB0aGF0IGlucHV0IGlzIFR5cGVkQXJyYXkgdmlhIGFy
cmF5LW1vZGUtYmFzZWQgZmlsdGVyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0yMzIxNjgKKyAgICAgICAgcmRhcjovLzg0MzY2NjU4CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2V0VHlwZWRBcnJheUxl
bmd0aEFzSW50NTIgd29ya3Mgb25seSB3aGVuIGlucHV0IGlzIFR5cGVkQXJyYXksIHdoaWNoIHNo
b3VsZCBiZSB2YWxpZGF0ZWQgdmlhIGFycmF5LW1vZGUgKGFuZCBhbHJlYWR5IGluc2VydGVkIGNo
ZWNrcyBpbiBmaXh1cCkuCisgICAgICAgIEFjY2lkZW50YWxseSB3ZSB3ZXJlIGluc2VydGluZyBp
dCB3aXRob3V0IGNoZWNraW5nIHR5cGVkLWFycmF5IGNvbmRpdGlvbiBpbiBTU0EgbG93ZXJpbmcg
cGhhc2UuIFRoaXMgcGF0Y2ggYWRkcyBhIGNvbmRpdGlvbiB3aGljaCBlbnN1cmVzIGl0CisgICAg
ICAgIGlzIFR5cGVkQXJyYXkuCisKKyAgICAgICAgKiBkZmcvREZHU1NBTG93ZXJpbmdQaGFzZS5j
cHA6CisgICAgICAgIChKU0M6OkRGRzo6U1NBTG93ZXJpbmdQaGFzZTo6bG93ZXJCb3VuZHNDaGVj
ayk6CisKIDIwMjEtMTAtMjEgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAog
ICAgICAgICBbSlNDXSBNYWtlIEdldFR5cGVkQXJyYXlMZW5ndGhBc0ludDUyIGFuZCBHZXRUeXBl
ZEFycmF5Qnl0ZU9mZnNldEFzSW50NTIgTm9kZVJlc3VsdEludDUyCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NTQUxvd2VyaW5nUGhhc2UuY3BwIGIvU291cmNlL0ph
dmFTY3JpcHRDb3JlL2RmZy9ERkdTU0FMb3dlcmluZ1BoYXNlLmNwcAppbmRleCA5MzYyMGQ5MjQ0
ZmFjMjJmZWNmYjUyYmY0NzA0MmE3ZjgwZjg2YjkxLi45Yzg5NjA2ZTBmYTFkZTM2MjA0NjliYjA2
MTYyNmFhZWRhZThiNDdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG
R1NTQUxvd2VyaW5nUGhhc2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH
U1NBTG93ZXJpbmdQaGFzZS5jcHAKQEAgLTE0OSw3ICsxNDksNyBAQCBjbGFzcyBTU0FMb3dlcmlu
Z1BoYXNlIDogcHVibGljIFBoYXNlIHsKIAogICAgICAgICBOb2RlKiBjaGVja0luQm91bmRzOwog
I2lmIFVTRShMQVJHRV9UWVBFRF9BUlJBWVMpCi0gICAgICAgIGlmICgob3AgPT0gR2V0QXJyYXlM
ZW5ndGgpICYmIChtX25vZGUtPmFycmF5TW9kZSgpLm1heUJlTGFyZ2VUeXBlZEFycmF5KCkgfHwg
bV9ncmFwaC5oYXNFeGl0U2l0ZShtX25vZGUtPm9yaWdpbi5zZW1hbnRpYywgT3ZlcmZsb3cpKSkg
eworICAgICAgICBpZiAoKG9wID09IEdldEFycmF5TGVuZ3RoKSAmJiBtX25vZGUtPmFycmF5TW9k
ZSgpLnR5cGVkQXJyYXlUeXBlKCkgIT0gTm90VHlwZWRBcnJheSAmJiAobV9ub2RlLT5hcnJheU1v
ZGUoKS5tYXlCZUxhcmdlVHlwZWRBcnJheSgpIHx8IG1fZ3JhcGguaGFzRXhpdFNpdGUobV9ub2Rl
LT5vcmlnaW4uc2VtYW50aWMsIE92ZXJmbG93KSkpIHsKICAgICAgICAgICAgIE5vZGUqIGxlbmd0
aCA9IG1faW5zZXJ0aW9uU2V0Lmluc2VydE5vZGUoCiAgICAgICAgICAgICAgICAgbV9ub2RlSW5k
ZXgsIFNwZWNJbnQ1MkFueSwgR2V0VHlwZWRBcnJheUxlbmd0aEFzSW50NTIsIG1fbm9kZS0+b3Jp
Z2luLAogICAgICAgICAgICAgICAgIE9wSW5mbyhtX25vZGUtPmFycmF5TW9kZSgpLmFzV29yZCgp
KSwgRWRnZShiYXNlLm5vZGUoKSwgS25vd25DZWxsVXNlKSwgc3RvcmFnZSk7CmRpZmYgLS1naXQg
YS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGE4NzMxZWYyZTU0
NDgxNDRiZmEzMmYwNzA4NjQzMjkyMmJlYTUxZDcuLmNmZDllMTUzMjE2MDNlYzEzZTgxNDdjMTM1
MmE0ODQ4MDA0NDc0N2MgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVz
dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMTAtMjIgIFl1c3VrZSBTdXp1a2kg
IDx5c3V6dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBHZXRUeXBlZEFycmF5TGVuZ3Ro
QXNJbnQ1MiBtdXN0IGJlIGluc2VydGVkIG9ubHkgd2hlbiB3ZSBlbnN1cmUgdGhhdCBpbnB1dCBp
cyBUeXBlZEFycmF5IHZpYSBhcnJheS1tb2RlLWJhc2VkIGZpbHRlcmluZworICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyMTY4CisgICAgICAgIHJkYXI6
Ly84NDM2NjY1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgICogc3RyZXNzL2dldHR5cGVkYXJyYXlsZW5ndGhhc2ludDUyLW11c3QtYmUtZW1pdHRlZC1m
b3ItdHlwZWRhcnJheS5qczogQWRkZWQuCisgICAgICAgIChmb28pOgorCiAyMDIxLTEwLTIxICBZ
dXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gSW5zZXJ0
ZWQgR2V0VHlwZWRBcnJheUxlbmd0aEFzSW50NTIgZm9yIFB1dEJ5VmFsIHNob3VsZCBoYXZlIE5v
ZGVSZXN1bHRJbnQ1MgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvZ2V0dHlwZWRhcnJheWxl
bmd0aGFzaW50NTItbXVzdC1iZS1lbWl0dGVkLWZvci10eXBlZGFycmF5LmpzIGIvSlNUZXN0cy9z
dHJlc3MvZ2V0dHlwZWRhcnJheWxlbmd0aGFzaW50NTItbXVzdC1iZS1lbWl0dGVkLWZvci10eXBl
ZGFycmF5LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjI2NjEwNjBmMTA5NWZkMDBjMDBhMWZhNGQ5ODNmMmJhOWZm
ZGJlMjIKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9nZXR0eXBlZGFycmF5bGVu
Z3RoYXNpbnQ1Mi1tdXN0LWJlLWVtaXR0ZWQtZm9yLXR5cGVkYXJyYXkuanMKQEAgLTAsMCArMSwx
MCBAQAorLy9AIHJ1bkRlZmF1bHQoIi0taml0UG9saWN5U2NhbGU9MCIpCitmdW5jdGlvbiBmb28o
YXJnMCkgeworICBhcmcwWzAuMV0gPSAnJzsKKyAgZm9yIChsZXQgaiA9IDA7IGogPCAxMDA7IGor
Kyk7Cit9CisKK2ZvbyhbMF0pOworZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwOyBpKyspIHsKKyAg
Zm9vKDApOworfQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>442192</attachid>
            <date>2021-10-22 13:25:29 -0700</date>
            <delta_ts>2021-10-22 13:39:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-232168-20211022132528.patch</filename>
            <type>text/plain</type>
            <size>4170</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1
NzkwMjc1N2Q1MGExNzU3YTFjODcyNjRlMjE0ZjAzNmY4N2I5MjdkLi5jYTUwODI4MDBjNmU1NDZl
Mjk5M2NlNjM1ZDc1MDA1ZGI2YWRiZjU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxOSBAQAorMjAyMS0xMC0yMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t
PgorCisgICAgICAgIFtKU0NdIEdldFR5cGVkQXJyYXlMZW5ndGhBc0ludDUyIG11c3QgYmUgaW5z
ZXJ0ZWQgb25seSB3aGVuIHdlIGVuc3VyZSB0aGF0IGlucHV0IGlzIFR5cGVkQXJyYXkgdmlhIGFy
cmF5LW1vZGUtYmFzZWQgZmlsdGVyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0yMzIxNjgKKyAgICAgICAgcmRhcjovLzg0MzY2NjU4CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2V0VHlwZWRBcnJheUxl
bmd0aEFzSW50NTIgd29ya3Mgb25seSB3aGVuIGlucHV0IGlzIFR5cGVkQXJyYXksIHdoaWNoIHNo
b3VsZCBiZSB2YWxpZGF0ZWQgdmlhIGFycmF5LW1vZGUgKGFuZCBhbHJlYWR5IGluc2VydGVkIGNo
ZWNrcyBpbiBmaXh1cCkuCisgICAgICAgIEFjY2lkZW50YWxseSB3ZSB3ZXJlIGluc2VydGluZyBp
dCB3aXRob3V0IGNoZWNraW5nIHR5cGVkLWFycmF5IGNvbmRpdGlvbiBpbiBTU0EgbG93ZXJpbmcg
cGhhc2UuIFRoaXMgcGF0Y2ggYWRkcyBhIGNvbmRpdGlvbiB3aGljaCBlbnN1cmVzIGl0CisgICAg
ICAgIGlzIFR5cGVkQXJyYXkuCisKKyAgICAgICAgKiBkZmcvREZHU1NBTG93ZXJpbmdQaGFzZS5j
cHA6CisgICAgICAgIChKU0M6OkRGRzo6U1NBTG93ZXJpbmdQaGFzZTo6aGFuZGxlTm9kZSk6Cisg
ICAgICAgIChKU0M6OkRGRzo6U1NBTG93ZXJpbmdQaGFzZTo6bG93ZXJCb3VuZHNDaGVjayk6CisK
IDIwMjEtMTAtMjEgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAg
ICBbSlNDXSBNYWtlIEdldFR5cGVkQXJyYXlMZW5ndGhBc0ludDUyIGFuZCBHZXRUeXBlZEFycmF5
Qnl0ZU9mZnNldEFzSW50NTIgTm9kZVJlc3VsdEludDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvZGZnL0RGR1NTQUxvd2VyaW5nUGhhc2UuY3BwIGIvU291cmNlL0phdmFTY3Jp
cHRDb3JlL2RmZy9ERkdTU0FMb3dlcmluZ1BoYXNlLmNwcAppbmRleCA5MzYyMGQ5MjQ0ZmFjMjJm
ZWNmYjUyYmY0NzA0MmE3ZjgwZjg2YjkxLi5mYmRhYzE3YmE5MjZhODM1NTAzMTY4NmNhY2EyOWE3
ZWYzMWIyOWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NTQUxv
d2VyaW5nUGhhc2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU1NBTG93
ZXJpbmdQaGFzZS5jcHAKQEAgLTk5LDcgKzk5LDcgQEAgY2xhc3MgU1NBTG93ZXJpbmdQaGFzZSA6
IHB1YmxpYyBQaGFzZSB7CiAgICAgICAgICAgICBpZiAobG93ZXJCb3VuZHNDaGVjayhiYXNlLCBp
bmRleCwgc3RvcmFnZSkpCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAKLSAg
ICAgICAgICAgIGlmIChtX25vZGUtPmFycmF5TW9kZSgpLnR5cGVkQXJyYXlUeXBlKCkgIT0gTm90
VHlwZWRBcnJheSAmJiBtX25vZGUtPmFycmF5TW9kZSgpLmlzT3V0T2ZCb3VuZHMoKSkgeworICAg
ICAgICAgICAgaWYgKG1fbm9kZS0+YXJyYXlNb2RlKCkuaXNTb21lVHlwZWRBcnJheVZpZXcoKSAm
JiBtX25vZGUtPmFycmF5TW9kZSgpLmlzT3V0T2ZCb3VuZHMoKSkgewogI2lmIFVTRShMQVJHRV9U
WVBFRF9BUlJBWVMpCiAgICAgICAgICAgICAgICAgaWYgKG1fbm9kZS0+YXJyYXlNb2RlKCkubWF5
QmVMYXJnZVR5cGVkQXJyYXkoKSB8fCBtX2dyYXBoLmhhc0V4aXRTaXRlKG1fbm9kZS0+b3JpZ2lu
LnNlbWFudGljLCBPdmVyZmxvdykpIHsKICAgICAgICAgICAgICAgICAgICAgTm9kZSogbGVuZ3Ro
ID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0Tm9kZSgKQEAgLTE0OSw3ICsxNDksNyBAQCBjbGFzcyBT
U0FMb3dlcmluZ1BoYXNlIDogcHVibGljIFBoYXNlIHsKIAogICAgICAgICBOb2RlKiBjaGVja0lu
Qm91bmRzOwogI2lmIFVTRShMQVJHRV9UWVBFRF9BUlJBWVMpCi0gICAgICAgIGlmICgob3AgPT0g
R2V0QXJyYXlMZW5ndGgpICYmIChtX25vZGUtPmFycmF5TW9kZSgpLm1heUJlTGFyZ2VUeXBlZEFy
cmF5KCkgfHwgbV9ncmFwaC5oYXNFeGl0U2l0ZShtX25vZGUtPm9yaWdpbi5zZW1hbnRpYywgT3Zl
cmZsb3cpKSkgeworICAgICAgICBpZiAoKG9wID09IEdldEFycmF5TGVuZ3RoKSAmJiBtX25vZGUt
PmFycmF5TW9kZSgpLmlzU29tZVR5cGVkQXJyYXlWaWV3KCkgJiYgKG1fbm9kZS0+YXJyYXlNb2Rl
KCkubWF5QmVMYXJnZVR5cGVkQXJyYXkoKSB8fCBtX2dyYXBoLmhhc0V4aXRTaXRlKG1fbm9kZS0+
b3JpZ2luLnNlbWFudGljLCBPdmVyZmxvdykpKSB7CiAgICAgICAgICAgICBOb2RlKiBsZW5ndGgg
PSBtX2luc2VydGlvblNldC5pbnNlcnROb2RlKAogICAgICAgICAgICAgICAgIG1fbm9kZUluZGV4
LCBTcGVjSW50NTJBbnksIEdldFR5cGVkQXJyYXlMZW5ndGhBc0ludDUyLCBtX25vZGUtPm9yaWdp
biwKICAgICAgICAgICAgICAgICBPcEluZm8obV9ub2RlLT5hcnJheU1vZGUoKS5hc1dvcmQoKSks
IEVkZ2UoYmFzZS5ub2RlKCksIEtub3duQ2VsbFVzZSksIHN0b3JhZ2UpOwpkaWZmIC0tZ2l0IGEv
SlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBhODczMWVmMmU1NDQ4
MTQ0YmZhMzJmMDcwODY0MzI5MjJiZWE1MWQ3Li5jZmQ5ZTE1MzIxNjAzZWMxM2U4MTQ3YzEzNTJh
NDg0ODAwNDQ3NDdjIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTEwLTIyICBZdXN1a2UgU3V6dWtpICA8
eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW0pTQ10gR2V0VHlwZWRBcnJheUxlbmd0aEFz
SW50NTIgbXVzdCBiZSBpbnNlcnRlZCBvbmx5IHdoZW4gd2UgZW5zdXJlIHRoYXQgaW5wdXQgaXMg
VHlwZWRBcnJheSB2aWEgYXJyYXktbW9kZS1iYXNlZCBmaWx0ZXJpbmcKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjE2OAorICAgICAgICByZGFyOi8v
ODQzNjY2NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIHN0cmVzcy9nZXR0eXBlZGFycmF5bGVuZ3RoYXNpbnQ1Mi1tdXN0LWJlLWVtaXR0ZWQtZm9y
LXR5cGVkYXJyYXkuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKwogMjAyMS0xMC0yMSAgWXVz
dWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIEluc2VydGVk
IEdldFR5cGVkQXJyYXlMZW5ndGhBc0ludDUyIGZvciBQdXRCeVZhbCBzaG91bGQgaGF2ZSBOb2Rl
UmVzdWx0SW50NTIKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2dldHR5cGVkYXJyYXlsZW5n
dGhhc2ludDUyLW11c3QtYmUtZW1pdHRlZC1mb3ItdHlwZWRhcnJheS5qcyBiL0pTVGVzdHMvc3Ry
ZXNzL2dldHR5cGVkYXJyYXlsZW5ndGhhc2ludDUyLW11c3QtYmUtZW1pdHRlZC1mb3ItdHlwZWRh
cnJheS5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwLi4yNjYxMDYwZjEwOTVmZDAwYzAwYTFmYTRkOTgzZjJiYTlmZmRi
ZTIyCi0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvZ2V0dHlwZWRhcnJheWxlbmd0
aGFzaW50NTItbXVzdC1iZS1lbWl0dGVkLWZvci10eXBlZGFycmF5LmpzCkBAIC0wLDAgKzEsMTAg
QEAKKy8vQCBydW5EZWZhdWx0KCItLWppdFBvbGljeVNjYWxlPTAiKQorZnVuY3Rpb24gZm9vKGFy
ZzApIHsKKyAgYXJnMFswLjFdID0gJyc7CisgIGZvciAobGV0IGogPSAwOyBqIDwgMTAwOyBqKysp
OworfQorCitmb28oWzBdKTsKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDsgaSsrKSB7CisgIGZv
bygwKTsKK30K
</data>
<flag name="review"
          id="466646"
          type_id="1"
          status="+"
          setter="rmorisset"
    />
          </attachment>
      

    </bug>

</bugzilla>