232093 2021-10-21 10:44:32 -0700 Two null box iterators from different paths fail to compare equal 2021-10-22 01:10:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gnavamarino webkit-unassigned koivisto webkit-bug-importer oldest_to_newest 1807243 0 gnavamarino 2021-10-21 10:44:32 -0700 Two null box iterators from different paths fail to compare equal in BoxIterator::operator==( 1807253 1 gnavamarino 2021-10-21 11:02:20 -0700 Per Antti's recommendation, we will compare equal in the case "both box and end get computed to null iterators (atEnd() is true)" as is currently happening in this loop: for (auto box = inlineBox->firstLeafBox(), end = inlineBox->endLeafBox(); box != end; box.traverseNextOnLine()) { if (!box->isText()) continue; 1807256 2 442047 gnavamarino 2021-10-21 11:05:04 -0700 Created attachment 442047 Patch 1807260 3 gnavamarino 2021-10-21 11:06:42 -0700 (In reply to Gabriel Nava Marino from comment #1) > Per Antti's recommendation, we will compare equal in the case "both box and > end get computed to null iterators (atEnd() is true)" as is currently as is *not* currently happening in this loop > happening in this loop: > > for (auto box = inlineBox->firstLeafBox(), end = > inlineBox->endLeafBox(); box != end; box.traverseNextOnLine()) { > if (!box->isText()) > continue; 1807529 4 ews-feeder 2021-10-21 21:52:59 -0700 Committed r284665 (243385@main): <https://commits.webkit.org/243385@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442047. 1807530 5 webkit-bug-importer 2021-10-21 21:53:14 -0700 <rdar://problem/84535523> 442047 2021-10-21 11:05:04 -0700 2021-10-22 01:10:05 -0700 Patch bug-232093-20211021110503.patch text/plain 3150 gnavamarino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThmMmU0NjhkM2UxN2Uw NDNkNWU3M2NkMTcyMzZmNTAyNTcxNWVkMC4uNTc2ZjUwYjM1MGYzOWY2YzBkYzNkMDNjMjIxMzA0 YmExYzMwYmMxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTEwLTIxICBHYWJy aWVsIE5hdmEgTWFyaW5vICA8Z25hdmFtYXJpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFR3byBu dWxsIGJveCBpdGVyYXRvcnMgZnJvbSBkaWZmZXJlbnQgcGF0aHMgZmFpbCB0byBjb21wYXJlIGVx dWFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzIw OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0 OiBmYXN0L2NsaXAvY2xpcC1oaXQtbnVsbC1pdGVyYXRvci1wYXRoLWNvbXBhcmlzb24uaHRtbAor CisgICAgICAgICogbGF5b3V0L2ludGVncmF0aW9uL0lubGluZUl0ZXJhdG9yQm94LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OklubGluZUl0ZXJhdG9yOjpCb3hJdGVyYXRvcjo6b3BlcmF0b3I9PSBj b25zdCk6CisKIDIwMjEtMTAtMjAgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPiBhbmQg RGFuYSBFc3RyYSA8ZGVzdHJhQGFwcGxlLmNvbT4KIAogICAgICAgICBtYWNPUyBrZXktZHJpdmVu IHNtb290aCBzY3JvbGxpbmcgZG9lcyBub3Qgc3RvcCB3aGVuIGZvY3VzIGNoYW5nZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9JbmxpbmVJdGVyYXRvckJv eC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vSW5saW5lSXRlcmF0b3JC b3guY3BwCmluZGV4IDRhMGE3NWRkNjA3OTQyN2E4MzNhYjdmZTU1NzdhMThhOTRmYjkyMWEuLjc1 ZWFlNWUwZDQxZTZjNjNhNzg3NDBlZmIyZjcyMTA2NmU3ZWY2OWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9JbmxpbmVJdGVyYXRvckJveC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0lubGluZUl0ZXJhdG9yQm94LmNwcApA QCAtNDgsNiArNDgsOSBAQCBCb3hJdGVyYXRvcjo6Qm94SXRlcmF0b3IoY29uc3QgQm94JiBydW4p CiAKIGJvb2wgQm94SXRlcmF0b3I6Om9wZXJhdG9yPT0oY29uc3QgQm94SXRlcmF0b3ImIG90aGVy KSBjb25zdAogeworICAgIGlmIChhdEVuZCgpICYmIG90aGVyLmF0RW5kKCkpCisgICAgICAgIHJl dHVybiB0cnVlOworCiAgICAgcmV0dXJuIG1fYm94Lm1fcGF0aFZhcmlhbnQgPT0gb3RoZXIubV9i b3gubV9wYXRoVmFyaWFudDsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGZjN2ZhNzE3NTVmOTkyOWVjNmMzYmY3ODE5 ZDE1OTQ3OTAyZTc5ZjQuLjNhZWZiMDhjMDc4MjRiNzJiZjM1MmQxMzRiMzlmMjBmYTJmMGMxYjQg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMS0xMC0yMSAgR2FicmllbCBOYXZhIE1hcmlubyAg PGduYXZhbWFyaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBUd28gbnVsbCBib3ggaXRlcmF0b3Jz IGZyb20gZGlmZmVyZW50IHBhdGhzIGZhaWwgdG8gY29tcGFyZSBlcXVhbAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyMDkzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2NsaXAvY2xpcC1oaXQt bnVsbC1pdGVyYXRvci1wYXRoLWNvbXBhcmlzb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2NsaXAvY2xpcC1oaXQtbnVsbC1pdGVyYXRvci1wYXRoLWNvbXBhcmlzb24uaHRt bDogQWRkZWQuCisKIDIwMjEtMTAtMjAgIEF5dW1pIEtvamltYSAgPGF5dW1pX2tvamltYUBhcHBs ZS5jb20+CiAKICAgICAgICAgWyBtYWNPUyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMveGhyL2V2ZW50LXVwbG9hZC1wcm9ncmVzcy1jcm9zc29yaWdpbi5hbnkuaHRtbCBpcyBhIGZs YWt5IGZhaWx1cmUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NsaXAvY2xpcC1oaXQt bnVsbC1pdGVyYXRvci1wYXRoLWNvbXBhcmlzb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9jbGlwL2NsaXAtaGl0LW51bGwtaXRlcmF0b3ItcGF0aC1jb21wYXJpc29uLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi42NjBiNDBmNDQwYmIyOTkzM2M3ZGEwMWE2ODdlN2QxY2FhNTU0NjE2 Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jbGlwL2NsaXAtaGl0LW51bGwt aXRlcmF0b3ItcGF0aC1jb21wYXJpc29uLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACisgUEFT UwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jbGlwL2NsaXAtaGl0LW51bGwtaXRlcmF0 b3ItcGF0aC1jb21wYXJpc29uLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2NsaXAvY2xpcC1oaXQt bnVsbC1pdGVyYXRvci1wYXRoLWNvbXBhcmlzb24uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iMTQzYTk5NzQ1 NTYzOGNlYWFmYWFjNjBkY2YxYjE5NWNmZjU5Y2M1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9jbGlwL2NsaXAtaGl0LW51bGwtaXRlcmF0b3ItcGF0aC1jb21wYXJpc29uLmh0 bWwKQEAgLTAsMCArMSwxMiBAQAorPHN0eWxlPgorICA6OmZpcnN0LWxpbmUgeworICAgIGJhY2tn cm91bmQtY2xpcDogdGV4dDsKKyAgfQorPC9zdHlsZT4KKzxpbnB1dD4KK1BBU1MKKzxzY3JpcHQ+ CisgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgp OworPC9zY3JpcHQ+CisK