232068 2021-10-21 01:23:40 -0700 StreamConnectionWorkQueue is not thread-safe 2021-10-22 01:19:14 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=231970 InRadar P2 Normal --- 231970 1 kkinnunen kkinnunen kkinnunen webkit-bug-importer wenson_hsieh oldest_to_newest 1807039 0 kkinnunen 2021-10-21 01:23:40 -0700 StreamConnectionWorkQueue is not thread-safe It should be since RemoteRenderingBackend/RemoteDisplayListRecorder implementation is running on it and they add receivers. 1807041 1 441995 kkinnunen 2021-10-21 01:35:29 -0700 Created attachment 441995 Patch 1807171 2 441995 wenson_hsieh 2021-10-21 08:43:10 -0700 Comment on attachment 441995 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441995&action=review > Source/WebKit/Platform/IPC/StreamConnectionWorkQueue.cpp:38 > + // `StreamConnectionWorkQueue::stop()` should be called if anything has been dispatched or listened to. Should this also assert `m_shouldQuit`? 1807567 3 kkinnunen 2021-10-22 00:50:35 -0700 (In reply to Wenson Hsieh from comment #2) > Should this also assert `m_shouldQuit`? No, it's ok to create the work queue and never start it and then destroy. 1807578 4 ews-feeder 2021-10-22 01:18:24 -0700 Committed r284671 (243391@main): <https://commits.webkit.org/243391@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441995. 1807579 5 webkit-bug-importer 2021-10-22 01:19:14 -0700 <rdar://problem/84540490> 441995 2021-10-21 01:35:29 -0700 2021-10-22 01:18:25 -0700 Patch bug-232068-20211021113528.patch text/plain 6139 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQxNWVmMjdlYTRlODQyNTFk MjczOGNhNjViMGJlNDgyNTE4MGE4MWQuLjFkMjQyNGZmYWZiODg0ZjUxMjFiOTY1NzhkYzkzYzEz NDU0MGEwYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMgQEAKKzIwMjEtMTAtMjEgIEtpbW1vIEtp bm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KKworICAgICAgICBTdHJlYW1Db25uZWN0aW9u V29ya1F1ZXVlIGlzIG5vdCB0aHJlYWQtc2FmZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyMDY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWFrZSBTdHJlYW1Db25uZWN0aW9uV29ya1F1ZXVlIHRocmVh ZC1zYWZlIHNvIHRoYXQKKyAgICAgICAgYWRkU3RyZWFtQ29ubmVjdGlvbiB3b3JrcyBmcm9tIG11 bHRpcGxlIHRocmVhZHMuCisgICAgICAgIEluIHRoZSBmdXR1cmUsIHRoaXMgd2lsbCBiZSBjYWxs ZWQgd2hlbiBhIG5ldyBSZW1vdGVEaXNwbGF5TGlzdFJlY29yZGVyIGlzCisgICAgICAgIGFkZGVk IGR1cmluZyB0aGUgU3RyZWFtQ29ubmVjdGlvbldvcmtRdWV1ZSBtZXNzYWdlIHByb2Nlc3NpbmcK KyAgICAgICAgaW52b2NhdGlvbiBmb3IgUmVtb3RlUmVuZGVyaW5nQmFja2VuZDo6Y3JlYXRlUmVt b3RlSW1hZ2VCdWZmZXIuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvU3RyZWFtQ29ubmVjdGlv bldvcmtRdWV1ZS5jcHA6CisgICAgICAgIChJUEM6OlN0cmVhbUNvbm5lY3Rpb25Xb3JrUXVldWU6 On5TdHJlYW1Db25uZWN0aW9uV29ya1F1ZXVlKToKKyAgICAgICAgKElQQzo6U3RyZWFtQ29ubmVj dGlvbldvcmtRdWV1ZTo6ZGlzcGF0Y2gpOgorICAgICAgICAoSVBDOjpTdHJlYW1Db25uZWN0aW9u V29ya1F1ZXVlOjphZGRTdHJlYW1Db25uZWN0aW9uKToKKyAgICAgICAgKElQQzo6U3RyZWFtQ29u bmVjdGlvbldvcmtRdWV1ZTo6cmVtb3ZlU3RyZWFtQ29ubmVjdGlvbik6CisgICAgICAgIENoYW5n ZSBzZW1hbnRpY3Mgc28gdGhhdCBhZGRpbmcgYW5kIHJlbW92aW5nIGNvbm5lY3Rpb25zIGR1cmlu ZworICAgICAgICBzaHV0ZG93biBpcyBvay4gVGhpcyBpcyByZXF1aXJlZCBmb3Igc2ltcGxlciBj b2RlIHNpbmNlCisgICAgICAgIGR1cmluZyBzdG9wIHdlIG11c3QgZGlzcGF0Y2ggYWxsIHBlbmRp bmcgbWVzc2FnZXMsIGJ1dCBkdXJpbmcKKyAgICAgICAgbWVzc2FnZSBjb2RlIHdlIG1pZ2h0IGhh dmUgdW5jb25kaXRpb25hbCBzdGFydCBsaXN0ZW5pbmcgd2hlbgorICAgICAgICB0aGUgbWVzc2Fn ZSBjcmVhdGVzIGEgbmV3IFJlbW90ZURpc3BsYXlMaXN0UmVjb3JkZXIuCisgICAgICAgIEFzIGEg Y29uc2VxdWVuY2UgaXQncyBub3QgYW4gZXJyb3IgdG8gYWRkIGEgY29ubmVjdGlvbiwKKyAgICAg ICAgc3RvcCBhbmQgZGVzdHJveSB0aGUgd29yayBxdWV1ZSB3aXRob3V0IHJlbW92aW5nIGl0Lgor ICAgICAgICAoSVBDOjpTdHJlYW1Db25uZWN0aW9uV29ya1F1ZXVlOjpzdG9wKToKKyAgICAgICAg KElQQzo6U3RyZWFtQ29ubmVjdGlvbldvcmtRdWV1ZTo6c3RhcnRQcm9jZXNzaW5nVGhyZWFkKToK KyAgICAgICAgKElQQzo6U3RyZWFtQ29ubmVjdGlvbldvcmtRdWV1ZTo6d2FrZVVwUHJvY2Vzc2lu Z1RocmVhZCk6IERlbGV0ZWQuCisgICAgICAgICogUGxhdGZvcm0vSVBDL1N0cmVhbUNvbm5lY3Rp b25Xb3JrUXVldWUuaDoKKwogMjAyMS0xMC0yMCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViS2l0IE1hbmFnZWQgTm90aWZpY2F0aW9uczogU2tlbGV0b24g Tm90aWZpY2F0aW9uUHJvdmlkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0v SVBDL1N0cmVhbUNvbm5lY3Rpb25Xb3JrUXVldWUuY3BwIGIvU291cmNlL1dlYktpdC9QbGF0Zm9y bS9JUEMvU3RyZWFtQ29ubmVjdGlvbldvcmtRdWV1ZS5jcHAKaW5kZXggZjg0OWVhM2NkZmY0OTJi Y2RmYzRkNGE2ZTI5MzQ3NGU3YTY1YWJhMy4uYzYxY2VlMDMyOTdhN2M3NWJlMGU5NzQ3ZDBmODM0 OTJjYTQ2MDM4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvU3RyZWFt Q29ubmVjdGlvbldvcmtRdWV1ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMv U3RyZWFtQ29ubmVjdGlvbldvcmtRdWV1ZS5jcHAKQEAgLTMzLDQ1ICszMyw2MSBAQCBTdHJlYW1D b25uZWN0aW9uV29ya1F1ZXVlOjpTdHJlYW1Db25uZWN0aW9uV29ya1F1ZXVlKGNvbnN0IGNoYXIq IG5hbWUpCiB7CiB9CiAKK1N0cmVhbUNvbm5lY3Rpb25Xb3JrUXVldWU6On5TdHJlYW1Db25uZWN0 aW9uV29ya1F1ZXVlKCkKK3sKKyAgICAvLyBgU3RyZWFtQ29ubmVjdGlvbldvcmtRdWV1ZTo6c3Rv cCgpYCBzaG91bGQgYmUgY2FsbGVkIGlmIGFueXRoaW5nIGhhcyBiZWVuIGRpc3BhdGNoZWQgb3Ig bGlzdGVuZWQgdG8uCisgICAgQVNTRVJUKCFtX3Byb2Nlc3NpbmdUaHJlYWQpOworfQorCiB2b2lk IFN0cmVhbUNvbm5lY3Rpb25Xb3JrUXVldWU6OmRpc3BhdGNoKFdURjo6RnVuY3Rpb248dm9pZCgp PiYmIGZ1bmN0aW9uKQogeworICAgIEFTU0VSVCghbV9zaG91bGRRdWl0KTsgLy8gUmUtZW50ZXJp bmcgZHVyaW5nIHNodXRkb3duIG5vdCBzdXBwb3J0ZWQuCiAgICAgewogICAgICAgICBMb2NrZXIg bG9ja2VyIHsgbV9sb2NrIH07CiAgICAgICAgIG1fZnVuY3Rpb25zLmFwcGVuZChXVEZNb3ZlKGZ1 bmN0aW9uKSk7Ci0gICAgICAgIEFTU0VSVCghbV9zaG91bGRRdWl0KTsgLy8gUmUtZW50ZXJpbmcg ZHVyaW5nIHNodXRkb3duIG5vdCBzdXBwb3J0ZWQuCisgICAgICAgIGlmICghbV9zaG91bGRRdWl0 ICYmICFtX3Byb2Nlc3NpbmdUaHJlYWQpIHsKKyAgICAgICAgICAgIHN0YXJ0UHJvY2Vzc2luZ1Ro cmVhZCgpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CiAgICAgfQotICAgIHdha2VV cFByb2Nlc3NpbmdUaHJlYWQoKTsKLQorICAgIHdha2VVcCgpOwogfQorCiB2b2lkIFN0cmVhbUNv bm5lY3Rpb25Xb3JrUXVldWU6OmFkZFN0cmVhbUNvbm5lY3Rpb24oU3RyZWFtU2VydmVyQ29ubmVj dGlvbkJhc2UmIGNvbm5lY3Rpb24pCiB7CiAgICAgewogICAgICAgICBMb2NrZXIgbG9ja2VyIHsg bV9sb2NrIH07CiAgICAgICAgIG1fY29ubmVjdGlvbnMuYWRkKGNvbm5lY3Rpb24pOwotICAgICAg ICBBU1NFUlQoIW1fc2hvdWxkUXVpdCk7IC8vIFJlLWVudGVyaW5nIGR1cmluZyBzaHV0ZG93biBu b3Qgc3VwcG9ydGVkLgorICAgICAgICBpZiAoIW1fc2hvdWxkUXVpdCAmJiAhbV9wcm9jZXNzaW5n VGhyZWFkKSB7CisgICAgICAgICAgICBzdGFydFByb2Nlc3NpbmdUaHJlYWQoKTsKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgfQogICAgIH0KLSAgICB3YWtlVXBQcm9jZXNzaW5nVGhyZWFk KCk7CisgICAgd2FrZVVwKCk7CiB9CiAKIHZvaWQgU3RyZWFtQ29ubmVjdGlvbldvcmtRdWV1ZTo6 cmVtb3ZlU3RyZWFtQ29ubmVjdGlvbihTdHJlYW1TZXJ2ZXJDb25uZWN0aW9uQmFzZSYgY29ubmVj dGlvbikKIHsKLSAgICBBU1NFUlQobV9wcm9jZXNzaW5nVGhyZWFkKTsKICAgICB7CiAgICAgICAg IExvY2tlciBsb2NrZXIgeyBtX2xvY2sgfTsKICAgICAgICAgbV9jb25uZWN0aW9ucy5yZW1vdmUo Y29ubmVjdGlvbik7Ci0gICAgICAgIEFTU0VSVCghbV9zaG91bGRRdWl0KTsgLy8gUmUtZW50ZXJp bmcgZHVyaW5nIHNodXRkb3duIG5vdCBzdXBwb3J0ZWQuCiAgICAgfQotICAgIG1fd2FrZVVwU2Vt YXBob3JlLnNpZ25hbCgpOworICAgIHdha2VVcCgpOwogfQogCiB2b2lkIFN0cmVhbUNvbm5lY3Rp b25Xb3JrUXVldWU6OnN0b3AoKQogewogICAgIG1fc2hvdWxkUXVpdCA9IHRydWU7Ci0gICAgaWYg KCFtX3Byb2Nlc3NpbmdUaHJlYWQpCisgICAgUmVmUHRyPFRocmVhZD4gcHJvY2Vzc2luZ1RocmVh ZDsKKyAgICB7CisgICAgICAgIExvY2tlciBsb2NrZXIgeyBtX2xvY2sgfTsKKyAgICAgICAgcHJv Y2Vzc2luZ1RocmVhZCA9IFdURk1vdmUobV9wcm9jZXNzaW5nVGhyZWFkKTsKKyAgICB9CisgICAg aWYgKCFwcm9jZXNzaW5nVGhyZWFkKQogICAgICAgICByZXR1cm47Ci0gICAgbV93YWtlVXBTZW1h cGhvcmUuc2lnbmFsKCk7Ci0gICAgbV9wcm9jZXNzaW5nVGhyZWFkLT53YWl0Rm9yQ29tcGxldGlv bigpOwotICAgIG1fcHJvY2Vzc2luZ1RocmVhZCA9IG51bGxwdHI7CisgICAgQVNTRVJUKFRocmVh ZDo6Y3VycmVudCgpLnVpZCgpICE9IHByb2Nlc3NpbmdUaHJlYWQtPnVpZCgpKTsKKyAgICB3YWtl VXAoKTsKKyAgICBwcm9jZXNzaW5nVGhyZWFkLT53YWl0Rm9yQ29tcGxldGlvbigpOwogfQogCiB2 b2lkIFN0cmVhbUNvbm5lY3Rpb25Xb3JrUXVldWU6Ondha2VVcCgpCkBAIC04NCwxMyArMTAwLDgg QEAgSVBDOjpTZW1hcGhvcmUmIFN0cmVhbUNvbm5lY3Rpb25Xb3JrUXVldWU6Ondha2VVcFNlbWFw aG9yZSgpCiAgICAgcmV0dXJuIG1fd2FrZVVwU2VtYXBob3JlOwogfQogCi12b2lkIFN0cmVhbUNv bm5lY3Rpb25Xb3JrUXVldWU6Ondha2VVcFByb2Nlc3NpbmdUaHJlYWQoKQordm9pZCBTdHJlYW1D b25uZWN0aW9uV29ya1F1ZXVlOjpzdGFydFByb2Nlc3NpbmdUaHJlYWQoKQogewotICAgIGlmICht X3Byb2Nlc3NpbmdUaHJlYWQpIHsKLSAgICAgICAgbV93YWtlVXBTZW1hcGhvcmUuc2lnbmFsKCk7 Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0KICAgICBhdXRvIHRhc2sgPSBbdGhpc10oKSBtdXRh YmxlIHsKICAgICAgICAgZm9yICg7OykgewogICAgICAgICAgICAgcHJvY2Vzc1N0cmVhbXMoKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL1N0cmVhbUNvbm5lY3Rpb25X b3JrUXVldWUuaCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL1N0cmVhbUNvbm5lY3Rpb25X b3JrUXVldWUuaAppbmRleCBkYTM1MjJkZjljNGM5MjAxYTA1ZWY2MjJmM2RhZGE1YjgyODZmNGRm Li4yMjBiY2JlZDU5NjM3MWQxN2IyM2FlMmQwNTM2Y2MzZDk2ZWM2NjBjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9TdHJlYW1Db25uZWN0aW9uV29ya1F1ZXVlLmgKKysr IGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvU3RyZWFtQ29ubmVjdGlvbldvcmtRdWV1ZS5o CkBAIC00NCw3ICs0NCw3IEBAIHB1YmxpYzoKICAgICB9CiAKICAgICBTdHJlYW1Db25uZWN0aW9u V29ya1F1ZXVlKGNvbnN0IGNoYXIqKTsKLSAgICB+U3RyZWFtQ29ubmVjdGlvbldvcmtRdWV1ZSgp ID0gZGVmYXVsdDsKKyAgICB+U3RyZWFtQ29ubmVjdGlvbldvcmtRdWV1ZSgpOwogICAgIHZvaWQg YWRkU3RyZWFtQ29ubmVjdGlvbihTdHJlYW1TZXJ2ZXJDb25uZWN0aW9uQmFzZSYpOwogICAgIHZv aWQgcmVtb3ZlU3RyZWFtQ29ubmVjdGlvbihTdHJlYW1TZXJ2ZXJDb25uZWN0aW9uQmFzZSYpOwog CkBAIC01NSwxNyArNTUsMTYgQEAgcHVibGljOgogCiAgICAgU2VtYXBob3JlJiB3YWtlVXBTZW1h cGhvcmUoKTsKIHByaXZhdGU6Ci0gICAgdm9pZCB3YWtlVXBQcm9jZXNzaW5nVGhyZWFkKCk7Cisg ICAgdm9pZCBzdGFydFByb2Nlc3NpbmdUaHJlYWQoKSBXVEZfUkVRVUlSRVNfTE9DSyhtX2xvY2sp OwogICAgIHZvaWQgcHJvY2Vzc1N0cmVhbXMoKTsKIAogICAgIGNvbnN0IGNoYXIqIGNvbnN0IG1f bmFtZTsKIAogICAgIFNlbWFwaG9yZSBtX3dha2VVcFNlbWFwaG9yZTsKLSAgICBSZWZQdHI8VGhy ZWFkPiBtX3Byb2Nlc3NpbmdUaHJlYWQ7Ci0KICAgICBzdGQ6OmF0b21pYzxib29sPiBtX3Nob3Vs ZFF1aXQgeyBmYWxzZSB9OwogCiAgICAgTG9jayBtX2xvY2s7CisgICAgUmVmUHRyPFRocmVhZD4g bV9wcm9jZXNzaW5nVGhyZWFkIFdURl9HVUFSREVEX0JZX0xPQ0sobV9sb2NrKTsKICAgICBEZXF1 ZTxGdW5jdGlvbjx2b2lkKCk+PiBtX2Z1bmN0aW9ucyBXVEZfR1VBUkRFRF9CWV9MT0NLKG1fbG9j ayk7CiAgICAgSGFzaFNldDxSZWY8U3RyZWFtU2VydmVyQ29ubmVjdGlvbkJhc2U+PiBtX2Nvbm5l Y3Rpb25zIFdURl9HVUFSREVEX0JZX0xPQ0sobV9sb2NrKTsKIH07Cg==