232063 2021-10-20 17:47:38 -0700 Minimize WebCore/Header.h includes inside WebCore 2021-10-27 17:48:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 don.olmstead webkit-unassigned ap eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1806962 0 don.olmstead 2021-10-20 17:47:38 -0700 Should be using "Header.h" still unless there's a very very good reason otherwise. 1806964 1 441968 don.olmstead 2021-10-20 17:48:15 -0700 Created attachment 441968 WIP Patch 1807005 2 441968 ap 2021-10-20 21:14:47 -0700 Comment on attachment 441968 WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441968&action=review > Source/WebCore/platform/ios/WebItemProviderPasteboard.h:-27 > -#import <WebCore/AbstractPasteboard.h> I do not think that this is right. As WebCore is an implementation detail of WebKit, it should be very easy to promote headers to SPI. And this they should all use framework style includes in this project. 1809514 3 webkit-bug-importer 2021-10-27 17:48:18 -0700 <rdar://problem/84735872> 441968 2021-10-20 17:48:15 -0700 2021-10-20 19:02:09 -0700 WIP Patch bug-232063.diff text/plain 3426 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlTZXR1 cFdlYkNvcmUuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlTZXR1 cFdlYkNvcmUuaAppbmRleCBmZWYyYmVkN2VkNWUuLjQ3ZmUwMjI4YTRhYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9hcHBsZXBheS9BcHBsZVBheVNldHVwV2ViQ29yZS5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYXBwbGVwYXkvQXBwbGVQYXlTZXR1cFdlYkNvcmUu aApAQCAtMjcsOSArMjcsOSBAQAogCiAjaWYgRU5BQkxFKEFQUExFX1BBWSkKIAorI2luY2x1ZGUg IkFjdGl2ZURPTU9iamVjdC5oIgogI2luY2x1ZGUgIkFwcGxlUGF5U2V0dXBDb25maWd1cmF0aW9u LmgiCi0jaW5jbHVkZSA8V2ViQ29yZS9BY3RpdmVET01PYmplY3QuaD4KLSNpbmNsdWRlIDxXZWJD b3JlL0pTRE9NUHJvbWlzZURlZmVycmVkLmg+CisjaW5jbHVkZSAiSlNET01Qcm9taXNlRGVmZXJy ZWQuaCIKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogI2luY2x1ZGUgPHd0Zi9SZWYuaD4KICNp bmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW9zL1dlYkl0ZW1Qcm92aWRlclBhc3RlYm9hcmQuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2lvcy9XZWJJdGVtUHJvdmlkZXJQYXN0ZWJvYXJkLmgKaW5kZXggMzk4ODJhYTZhNGYw Li41ZGU0N2UxNDk3MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9X ZWJJdGVtUHJvdmlkZXJQYXN0ZWJvYXJkLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW9zL1dlYkl0ZW1Qcm92aWRlclBhc3RlYm9hcmQuaApAQCAtMjQsNyArMjQsNyBAQAogICovCiAK ICNpZiBUQVJHRVRfT1NfSVBIT05FCi0jaW1wb3J0IDxXZWJDb3JlL0Fic3RyYWN0UGFzdGVib2Fy ZC5oPgorI2ltcG9ydCAiQWJzdHJhY3RQYXN0ZWJvYXJkLmgiCiAjZW5kaWYKIAogI2lmIFRBUkdF VF9PU19JT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJJdGVt UHJvdmlkZXJQYXN0ZWJvYXJkLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkl0 ZW1Qcm92aWRlclBhc3RlYm9hcmQubW0KaW5kZXggZDJhMWRiYzNhODlmLi41OTk0YWNlMmQ3Y2Ig MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJJdGVtUHJvdmlkZXJQ YXN0ZWJvYXJkLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJJdGVtUHJv dmlkZXJQYXN0ZWJvYXJkLm1tCkBAIC0yOCwxMyArMjgsMTMgQEAKIAogI2lmIFBMQVRGT1JNKElP U19GQU1JTFkpICYmIEVOQUJMRShEUkFHX1NVUFBPUlQpCiAKKyNpbXBvcnQgIlBhc3RlYm9hcmQu aCIKICNpbXBvcnQgPEZvdW5kYXRpb24vTlNJdGVtUHJvdmlkZXIuaD4KICNpbXBvcnQgPEZvdW5k YXRpb24vTlNQcm9ncmVzcy5oPgogI2ltcG9ydCA8TW9iaWxlQ29yZVNlcnZpY2VzL01vYmlsZUNv cmVTZXJ2aWNlcy5oPgogI2ltcG9ydCA8VUlLaXQvTlNJdGVtUHJvdmlkZXIrVUlLaXRBZGRpdGlv bnMuaD4KICNpbXBvcnQgPFVJS2l0L1VJQ29sb3IuaD4KICNpbXBvcnQgPFVJS2l0L1VJSW1hZ2Uu aD4KLSNpbXBvcnQgPFdlYkNvcmUvUGFzdGVib2FyZC5oPgogI2ltcG9ydCA8cGFsL2lvcy9VSUtp dFNvZnRMaW5rLmg+CiAjaW1wb3J0IDxwYWwvc3BpL2lvcy9VSUtpdFNQSS5oPgogI2ltcG9ydCA8 d3RmL0Jsb2NrUHRyLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mv V2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vaW9zL1dlYlNRTGl0ZURhdGFiYXNlVHJhY2tlckNsaWVudC5tbQppbmRleCAyN2RiNTMyZmMw YjIuLjEyNWY4NzAyOGE4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9z L1dlYlNRTGl0ZURhdGFiYXNlVHJhY2tlckNsaWVudC5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pb3MvV2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50Lm1tCkBAIC0yOCw5ICsy OCw5IEBACiAKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKQogCisjaW1wb3J0ICJEYXRhYmFzZVRy YWNrZXIuaCIKKyNpbXBvcnQgIlNRTGl0ZURhdGFiYXNlVHJhY2tlci5oIgogI2ltcG9ydCAiV2Vi QmFja2dyb3VuZFRhc2tDb250cm9sbGVyLmgiCi0jaW1wb3J0IDxXZWJDb3JlL0RhdGFiYXNlVHJh Y2tlci5oPgotI2ltcG9ydCA8V2ViQ29yZS9TUUxpdGVEYXRhYmFzZVRyYWNrZXIuaD4KICNpbXBv cnQgPHd0Zi9Mb2NrLmg+CiAjaW1wb3J0IDx3dGYvTWFpblRocmVhZC5oPgogI2ltcG9ydCA8d3Rm L05ldmVyRGVzdHJveWVkLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p b3MvV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlckFWS2l0LmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlckFWS2l0LmgKaW5kZXggYjRl MWFiN2E3MWM0Li5lMjBjYzU4ZWZiYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5Db250cm9sbGVyQVZLaXQuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlckFWS2l0LmgK QEAgLTI1LDcgKzI1LDcgQEAKIAogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCiAKLSNpbXBvcnQg PFdlYkNvcmUvSFRNTE1lZGlhRWxlbWVudEVudW1zLmg+CisjaW1wb3J0ICJIVE1MTWVkaWFFbGVt ZW50RW51bXMuaCIKICNpbXBvcnQgPHd0Zi9OYWtlZFB0ci5oPgogCiBAY2xhc3MgVUlWaWV3Owpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9jb2NvYS9XZWJWaWV3VmlzdWFsSWRl bnRpZmljYXRpb25PdmVybGF5LmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL2NvY29hL1dlYlZp ZXdWaXN1YWxJZGVudGlmaWNhdGlvbk92ZXJsYXkuaAppbmRleCBhODVhZmMxNzA2YmQuLjA0YjQ3 ZDE4ZmYxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9jb2NvYS9XZWJWaWV3 VmlzdWFsSWRlbnRpZmljYXRpb25PdmVybGF5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGlu Zy9jb2NvYS9XZWJWaWV3VmlzdWFsSWRlbnRpZmljYXRpb25PdmVybGF5LmgKQEAgLTI5LDcgKzI5 LDcgQEAKICNpbXBvcnQgPFVJS2l0L1VJS2l0Lmg+CiAjZW5kaWYKIAotI2ltcG9ydCA8V2ViQ29y ZS9QbGF0Zm9ybVZpZXcuaD4KKyNpbXBvcnQgIlBsYXRmb3JtVmlldy5oIgogCiBXRUJDT1JFX0VY UE9SVAogQGludGVyZmFjZSBXZWJWaWV3VmlzdWFsSWRlbnRpZmljYXRpb25PdmVybGF5IDogTlNP YmplY3QK