232051 2021-10-20 15:12:51 -0700 [JSC] ArithAbs should care about INT32_MIN 2021-10-20 17:00:39 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1806878 0 ysuzuki 2021-10-20 15:12:51 -0700 [JSC] ArithAbs should care about INT32_MIN 1806879 1 441946 ysuzuki 2021-10-20 15:14:03 -0700 Created attachment 441946 Patch 1806880 2 ysuzuki 2021-10-20 15:14:07 -0700 <rdar://problem/84338648> 1806888 3 441946 msaboff 2021-10-20 15:20:40 -0700 Comment on attachment 441946 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441946&action=review r=me > Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1395 > + // If ArithAbs cares overflow, then INT32_MIN input will cause OSR exit. "cares about" sounds better. > Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1402 > + // If ArithAbs does not care overflow, it can return INT32_MIN if the input is INT32_MIN. "... care about overflow" sounds better. 1806908 4 441946 ysuzuki 2021-10-20 15:58:35 -0700 Comment on attachment 441946 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441946&action=review >> Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1395 >> + // If ArithAbs cares overflow, then INT32_MIN input will cause OSR exit. > > "cares about" sounds better. Sounds good! >> Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1402 >> + // If ArithAbs does not care overflow, it can return INT32_MIN if the input is INT32_MIN. > > "... care about overflow" sounds better. Nice, fixed. 1806933 5 ysuzuki 2021-10-20 17:00:39 -0700 Committed r284585 (243320@main): <https://commits.webkit.org/243320@main> 441946 2021-10-20 15:14:03 -0700 2021-10-20 15:23:01 -0700 Patch bug-232051-20211020151402.patch text/plain 2475 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz OTIyNjRkNTE1NWZjOTNmODhiNmUxMDQ4ZjI2MWNjZjM5MzJlMzVjLi43N2Y3NzU3ZDYxMThmZjYz NGIwZTdmNzRhZGFiNDRlZGIxODE1ZjA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMS0xMC0yMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEFyaXRoQWJzIHNob3VsZCBjYXJlIGFib3V0IElOVDMyX01JTgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyMDUxCisg ICAgICAgIHJkYXI6Ly84NDMzODY0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFyaXRoQWJzICh3aXRob3V0IG92ZXJmbG93IGNoZWNrKSBjYW4gcmV0 dXJuIG5lZ2F0aXZlIHZhbHVlIGlmIHRoZSBpbnB1dCBpcyBJTlQzMl9NSU4gd2l0aCBJbnQzMlVz ZS4KKworICAgICAgICAqIGRmZy9ERkdJbnRlZ2VyUmFuZ2VPcHRpbWl6YXRpb25QaGFzZS5jcHA6 CisKIDIwMjEtMTAtMjAgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+ CiAKICAgICAgICAgRG8gbm90IHVzZSBzdHJlcnJvcigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0ludGVnZXJSYW5nZU9wdGltaXphdGlvblBoYXNlLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdlT3B0aW1pemF0aW9uUGhhc2Uu Y3BwCmluZGV4IDZkZWRhMDM3ZWU5NDI3ZTcxMzViM2ExMTQ1M2EyNzJiNDIwYjdkNTkuLmJiNmEy ZjVlZGE1YTM0NmUzMTgxYTM2ZjE5ODA0MjViZTgxM2MyMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdlT3B0aW1pemF0aW9uUGhhc2UuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW50ZWdlclJhbmdlT3B0aW1pemF0aW9u UGhhc2UuY3BwCkBAIC0xMzkxLDcgKzEzOTEsMjUgQEAgY2xhc3MgSW50ZWdlclJhbmdlT3B0aW1p emF0aW9uUGhhc2UgOiBwdWJsaWMgUGhhc2UgewogICAgICAgICBjYXNlIEFyaXRoQWJzOiB7CiAg ICAgICAgICAgICBpZiAobm9kZS0+Y2hpbGQxKCkudXNlS2luZCgpICE9IEludDMyVXNlKQogICAg ICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgc2V0UmVsYXRpb25zaGlwKFJlbGF0aW9u c2hpcChub2RlLCBtX3plcm8sIFJlbGF0aW9uc2hpcDo6R3JlYXRlclRoYW4sIC0xKSk7CisKKyAg ICAgICAgICAgIC8vIElmIEFyaXRoQWJzIGNhcmVzIG92ZXJmbG93LCB0aGVuIElOVDMyX01JTiBp bnB1dCB3aWxsIGNhdXNlIE9TUiBleGl0LgorICAgICAgICAgICAgLy8gVGh1cyB3ZSBjYW4gc2Fm ZWx5IHNheSBgeCA+PSAwYC4KKyAgICAgICAgICAgIGlmIChzaG91bGRDaGVja092ZXJmbG93KG5v ZGUtPmFyaXRoTW9kZSgpKSkgeworICAgICAgICAgICAgICAgIHNldFJlbGF0aW9uc2hpcChSZWxh dGlvbnNoaXAobm9kZSwgbV96ZXJvLCBSZWxhdGlvbnNoaXA6OkdyZWF0ZXJUaGFuLCAtMSkpOwor ICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICAvLyBJ ZiBBcml0aEFicyBkb2VzIG5vdCBjYXJlIG92ZXJmbG93LCBpdCBjYW4gcmV0dXJuIElOVDMyX01J TiBpZiB0aGUgaW5wdXQgaXMgSU5UMzJfTUlOLgorICAgICAgICAgICAgLy8gSWYgbWluVmFsdWUg aXMgbm90IElOVDMyX01JTiwgd2UgY2FuIHN0aWxsIHNheSBpdCBpcyBgeCA+PSAwYC4KKyAgICAg ICAgICAgIGludCBtaW5WYWx1ZSA9IHN0ZDo6bnVtZXJpY19saW1pdHM8aW50Pjo6bWluKCk7Cisg ICAgICAgICAgICBhdXRvIGl0ZXIgPSBtX3JlbGF0aW9uc2hpcHMuZmluZChub2RlLT5jaGlsZDEo KS5ub2RlKCkpOworICAgICAgICAgICAgaWYgKGl0ZXIgIT0gbV9yZWxhdGlvbnNoaXBzLmVuZCgp KSB7CisgICAgICAgICAgICAgICAgZm9yIChSZWxhdGlvbnNoaXAgcmVsYXRpb25zaGlwIDogaXRl ci0+dmFsdWUpCisgICAgICAgICAgICAgICAgICAgIG1pblZhbHVlID0gc3RkOjptYXgobWluVmFs dWUsIHJlbGF0aW9uc2hpcC5taW5WYWx1ZU9mTGVmdCgpKTsKKyAgICAgICAgICAgIH0KKworICAg ICAgICAgICAgaWYgKG1pblZhbHVlID4gc3RkOjpudW1lcmljX2xpbWl0czxpbnQ+OjptaW4oKSkK KyAgICAgICAgICAgICAgICBzZXRSZWxhdGlvbnNoaXAoUmVsYXRpb25zaGlwKG5vZGUsIG1femVy bywgUmVsYXRpb25zaGlwOjpHcmVhdGVyVGhhbiwgLTEpKTsKICAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICB9CiAgICAgICAgICAgICAK