232049 2021-10-20 15:11:41 -0700 Web Inspector: extension iframes leak when disabling an extension 2021-10-27 14:23:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg ews-watchlist hi inspector-bugzilla-changes pangle timothy webkit-bug-importer oldest_to_newest 1806874 0 bburg 2021-10-20 15:11:41 -0700 D'oh. 1806894 1 webkit-bug-importer 2021-10-20 15:33:44 -0700 <rdar://problem/84482021> 1807269 2 442050 bburg 2021-10-21 11:17:49 -0700 Created attachment 442050 Patch v1.0 1807284 3 442050 hi 2021-10-21 11:30:39 -0700 Comment on attachment 442050 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=442050&action=review > Source/WebInspectorUI/ChangeLog:9 > + Since shouldNotRemoveFromDOMWhenHidden() is true, the <iframe> will not > + be detached and unload its document in the normal tab-closing code path. This will still remove the `WI.View` from the parent `_subviews` even though the node wont be removed from the DOM, right? Can we somehow confirm that removing an extension does in fact GC all the related objects? > Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js:74 > + tabContentView.dispose(); I would _strongly_ prefer that this be on `WI.WebInspectorExtensionTabContentView` instead of the more generic `WI.TabContentView` as the latter shouldn't ever need this mechanism (i.e. it should _always_ use `WI.View.prototype.removeSubview`) 1807305 4 442050 bburg 2021-10-21 12:19:34 -0700 Comment on attachment 442050 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=442050&action=review >> Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js:74 >> + tabContentView.dispose(); > > I would _strongly_ prefer that this be on `WI.WebInspectorExtensionTabContentView` instead of the more generic `WI.TabContentView` as the latter shouldn't ever need this mechanism (i.e. it should _always_ use `WI.View.prototype.removeSubview`) Oh, woops, wrong file :)( 1809009 5 442525 bburg 2021-10-26 13:42:58 -0700 Created attachment 442525 Patch v1.1 1809429 6 ews-feeder 2021-10-27 14:23:50 -0700 Committed r284958 (243610@main): <https://commits.webkit.org/243610@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442525. 442050 2021-10-21 11:17:49 -0700 2021-10-26 13:42:56 -0700 Patch v1.0 bug-232049-20211021111748.patch text/plain 3007 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 MTQ0NjQxYzQyY2QzMjZhZmI2ZDk1MTk3Mzk1OGFlZDg3ZTJmZDRjLi5lMTE5NWI3OWM1MGRjNDc1 MGE3ZmU5YWZlMjEwYmE0Nzg3OTQ4N2ZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMS0xMC0yMCAgQkogQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiBleHRlbnNpb24gaWZyYW1lcyBsZWFrIHdoZW4gZGlzYWJsaW5n IGFuIGV4dGVuc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjMyMDQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU2luY2Ugc2hvdWxkTm90UmVtb3ZlRnJvbURPTVdoZW5IaWRkZW4oKSBpcyB0cnVlLCB0 aGUgPGlmcmFtZT4gd2lsbCBub3QKKyAgICAgICAgYmUgZGV0YWNoZWQgYW5kIHVubG9hZCBpdHMg ZG9jdW1lbnQgaW4gdGhlIG5vcm1hbCB0YWItY2xvc2luZyBjb2RlIHBhdGguCisgICAgICAgIEFk ZCBhIGBkaXNwb3NlKClgIG1ldGhvZCBmb3IgY2xlYW5pbmcgdXAgdGhlIHRhYiB3aGVuIGl0cyBl eHRlbnNpb24gaXMKKyAgICAgICAgdW5yZWdpc3RlcmVkLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9Db250cm9sbGVycy9XZWJJbnNwZWN0b3JFeHRlbnNpb25Db250cm9sbGVyLmpzOgorICAg ICAgICAoV0kuV2ViSW5zcGVjdG9yRXh0ZW5zaW9uQ29udHJvbGxlci5wcm90b3R5cGUudW5yZWdp c3RlckV4dGVuc2lvbik6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJDb250ZW50 Vmlldy5qczoKKyAgICAgICAgKFdJLlRhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5kaXNwb3NlKToK KwogMjAyMS0xMC0xNSAgQkogQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29j b2FdIFdlYiBJbnNwZWN0b3I6IGhhbmRsZSBQcm9taXNlIG9iamVjdHMgcmV0dXJuZWQgZnJvbSBl dmFsdWF0ZVNjcmlwdEluRXh0ZW5zaW9uVGFiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9XZWJJbnNwZWN0b3JFeHRlbnNpb25Db250 cm9sbGVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxl cnMvV2ViSW5zcGVjdG9yRXh0ZW5zaW9uQ29udHJvbGxlci5qcwppbmRleCAxNTRjMGEyYzc2OGVh N2EyYWY2MTljMTZiMDljNmM2MDQxNTM0MjJiLi42ZWVmMDAxNjViNDg4OTg2ZDQyMTUzZDM1Y2Zm OGU3MDIxODM3MTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Db250cm9sbGVycy9XZWJJbnNwZWN0b3JFeHRlbnNpb25Db250cm9sbGVyLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1dlYkluc3Bl Y3RvckV4dGVuc2lvbkNvbnRyb2xsZXIuanMKQEAgLTY4LDcgKzY4LDEwIEBAIFdJLldlYkluc3Bl Y3RvckV4dGVuc2lvbkNvbnRyb2xsZXIgPSBjbGFzcyBXZWJJbnNwZWN0b3JFeHRlbnNpb25Db250 cm9sbGVyIGV4dGVuCiAgICAgICAgIGxldCBleHRlbnNpb25UYWJJRHNUb1JlbW92ZSA9IHRoaXMu X3RhYklEc0ZvckV4dGVuc2lvbklETWFwLnRha2UoZXh0ZW5zaW9uSUQpIHx8IFtdOwogICAgICAg ICBmb3IgKGxldCBleHRlbnNpb25UYWJJRCBvZiBleHRlbnNpb25UYWJJRHNUb1JlbW92ZSkgewog ICAgICAgICAgICAgbGV0IHRhYkNvbnRlbnRWaWV3ID0gdGhpcy5fZXh0ZW5zaW9uVGFiQ29udGVu dFZpZXdGb3JFeHRlbnNpb25UYWJJRE1hcC50YWtlKGV4dGVuc2lvblRhYklEKTsKKworICAgICAg ICAgICAgLy8gRW5zdXJlIHRoYXQgdGhlIGlmcmFtZSBpcyBhY3R1YWxseSBkZXRhY2hlZCBhbmQg ZG9lcyBub3QgbGVhay4KICAgICAgICAgICAgIFdJLnRhYkJyb3dzZXIuY2xvc2VUYWJGb3JDb250 ZW50Vmlldyh0YWJDb250ZW50Vmlldywge3N1cHByZXNzQW5pbWF0aW9uczogdHJ1ZX0pOworICAg ICAgICAgICAgdGFiQ29udGVudFZpZXcuZGlzcG9zZSgpOwogICAgICAgICB9CiAKICAgICAgICAg dGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV0kuV2ViSW5zcGVjdG9yRXh0ZW5zaW9uQ29u dHJvbGxlci5FdmVudC5FeHRlbnNpb25SZW1vdmVkLCB7ZXh0ZW5zaW9ufSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJDb250ZW50Vmll dy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkNvbnRl bnRWaWV3LmpzCmluZGV4IGUwNGNjOGZlZTllMDhlOWY4NjcxOTBiNzlkNWUwMDk3Y2ZmMzM0YjAu LjJmYzNjZDMwNGIxYTFlMDNiYjZjZDgwNjI3MTRlMjYxZTE0YmY1MzAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkNvbnRlbnRWaWV3Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkNvbnRl bnRWaWV3LmpzCkBAIC0xNDMsNiArMTQzLDExIEBAIFdJLlRhYkNvbnRlbnRWaWV3ID0gY2xhc3Mg VGFiQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogICAgICAgICAgICAgdGhpcy5y ZXN0b3JlU3RhdGVGcm9tQ29va2llKFdJLlN0YXRlUmVzdG9yYXRpb25UeXBlLkRlbGF5ZWQpOwog ICAgIH0KIAorICAgIGRpc3Bvc2UoKQorICAgIHsKKyAgICAgICAgdGhpcy5lbGVtZW50Py5yZW1v dmUoKTsKKyAgICB9CisKICAgICByZXN0b3JlU3RhdGVGcm9tQ29va2llKHJlc3RvcmF0aW9uVHlw ZSkKICAgICB7CiAgICAgICAgIGlmICghdGhpcy5pc0F0dGFjaGVkKSB7Cg== 442525 2021-10-26 13:42:58 -0700 2021-10-27 14:23:52 -0700 Patch v1.1 bug-232049-20211026134257.patch text/plain 3067 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0ODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk ZmZmZTAxMzBjNDcxMWUxMTZlOTA1N2UwODllY2JhM2YzMzAxZDE0Li5hOTAwOTRiN2VjZjQ0ODQx ZmFiOTA3ZjM5YjIzNjc3NzFlYzA3NTJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMS0xMC0yNiAgQkogQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiBleHRlbnNpb24gaWZyYW1lcyBsZWFrIHdoZW4gZGlzYWJsaW5n IGFuIGV4dGVuc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjMyMDQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU2luY2Ugc2hvdWxkTm90UmVtb3ZlRnJvbURPTVdoZW5IaWRkZW4oKSBpcyB0cnVlLCB0 aGUgPGlmcmFtZT4gd2lsbCBub3QKKyAgICAgICAgYmUgZGV0YWNoZWQgYW5kIHVubG9hZCBpdHMg ZG9jdW1lbnQgaW4gdGhlIG5vcm1hbCB0YWItY2xvc2luZyBjb2RlIHBhdGguCisgICAgICAgIEFk ZCBhIGBkaXNwb3NlKClgIG1ldGhvZCBmb3IgY2xlYW5pbmcgdXAgdGhlIHRhYiB3aGVuIGl0cyBl eHRlbnNpb24gaXMKKyAgICAgICAgdW5yZWdpc3RlcmVkLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9Db250cm9sbGVycy9XZWJJbnNwZWN0b3JFeHRlbnNpb25Db250cm9sbGVyLmpzOgorICAg ICAgICAoV0kuV2ViSW5zcGVjdG9yRXh0ZW5zaW9uQ29udHJvbGxlci5wcm90b3R5cGUudW5yZWdp c3RlckV4dGVuc2lvbik6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9XZWJJbnNwZWN0 b3JFeHRlbnNpb25UYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLldlYkluc3BlY3RvckV4 dGVuc2lvblRhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5kaXNwb3NlKToKKwogMjAyMS0xMC0yMSAg RGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgW2Nzcy12YWx1ZXMt NF0gU3VwcG9ydCBzbWFsbCAoc3YqKSwgbGFyZ2UgKGx2KikgYW5kIGR5bmFtaWMgKGR2Kikgdmll d3BvcnQgdW5pdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0NvbnRyb2xsZXJzL1dlYkluc3BlY3RvckV4dGVuc2lvbkNvbnRyb2xsZXIuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9XZWJJbnNwZWN0b3JF eHRlbnNpb25Db250cm9sbGVyLmpzCmluZGV4IDE1NGMwYTJjNzY4ZWE3YTJhZjYxOWMxNmIwOWM2 YzYwNDE1MzQyMmIuLjZlZWYwMDE2NWI0ODg5ODZkNDIxNTNkMzVjZmY4ZTcwMjE4MzcxNzkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJz L1dlYkluc3BlY3RvckV4dGVuc2lvbkNvbnRyb2xsZXIuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvV2ViSW5zcGVjdG9yRXh0ZW5zaW9uQ29u dHJvbGxlci5qcwpAQCAtNjgsNyArNjgsMTAgQEAgV0kuV2ViSW5zcGVjdG9yRXh0ZW5zaW9uQ29u dHJvbGxlciA9IGNsYXNzIFdlYkluc3BlY3RvckV4dGVuc2lvbkNvbnRyb2xsZXIgZXh0ZW4KICAg ICAgICAgbGV0IGV4dGVuc2lvblRhYklEc1RvUmVtb3ZlID0gdGhpcy5fdGFiSURzRm9yRXh0ZW5z aW9uSURNYXAudGFrZShleHRlbnNpb25JRCkgfHwgW107CiAgICAgICAgIGZvciAobGV0IGV4dGVu c2lvblRhYklEIG9mIGV4dGVuc2lvblRhYklEc1RvUmVtb3ZlKSB7CiAgICAgICAgICAgICBsZXQg dGFiQ29udGVudFZpZXcgPSB0aGlzLl9leHRlbnNpb25UYWJDb250ZW50Vmlld0ZvckV4dGVuc2lv blRhYklETWFwLnRha2UoZXh0ZW5zaW9uVGFiSUQpOworCisgICAgICAgICAgICAvLyBFbnN1cmUg dGhhdCB0aGUgaWZyYW1lIGlzIGFjdHVhbGx5IGRldGFjaGVkIGFuZCBkb2VzIG5vdCBsZWFrLgog ICAgICAgICAgICAgV0kudGFiQnJvd3Nlci5jbG9zZVRhYkZvckNvbnRlbnRWaWV3KHRhYkNvbnRl bnRWaWV3LCB7c3VwcHJlc3NBbmltYXRpb25zOiB0cnVlfSk7CisgICAgICAgICAgICB0YWJDb250 ZW50Vmlldy5kaXNwb3NlKCk7CiAgICAgICAgIH0KIAogICAgICAgICB0aGlzLmRpc3BhdGNoRXZl bnRUb0xpc3RlbmVycyhXSS5XZWJJbnNwZWN0b3JFeHRlbnNpb25Db250cm9sbGVyLkV2ZW50LkV4 dGVuc2lvblJlbW92ZWQsIHtleHRlbnNpb259KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1dlYkluc3BlY3RvckV4dGVuc2lvblRhYkNvbnRl bnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvV2Vi SW5zcGVjdG9yRXh0ZW5zaW9uVGFiQ29udGVudFZpZXcuanMKaW5kZXggMDhmZTBiZThjYTU2YmJl ZjgwZGIzOGUxNTNhYzQ0YzMwZGMyMzZhZi4uYmVhYmU0YjA2NmEyNjllZTFiZTcxYWZkY2FjYzFi YWNmYjc5MTQ5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvV2ViSW5zcGVjdG9yRXh0ZW5zaW9uVGFiQ29udGVudFZpZXcuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvV2ViSW5zcGVjdG9yRXh0ZW5z aW9uVGFiQ29udGVudFZpZXcuanMKQEAgLTg3LDYgKzg3LDExIEBAIFdJLldlYkluc3BlY3RvckV4 dGVuc2lvblRhYkNvbnRlbnRWaWV3ID0gY2xhc3MgV2ViSW5zcGVjdG9yRXh0ZW5zaW9uVGFiQ29u dGVudFZpCiAgICAgICAgIHN1cGVyLmRldGFjaGVkKCk7CiAgICAgfQogCisgICAgZGlzcG9zZSgp CisgICAgeworICAgICAgICB0aGlzLmVsZW1lbnQ/LnJlbW92ZSgpOworICAgIH0KKwogICAgIHRh YkluZm8oKQogICAgIHsKICAgICAgICAgcmV0dXJuIHRoaXMuX3RhYkluZm87Cg==