231977 2021-10-19 12:41:20 -0700 REGRESSION (r284220): [PAL] TCCSPI.h should be a project header, not a private header 2021-10-19 14:10:48 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 231621 1 ddkilzer ddkilzer eric.carlson katherine_cheney webkit-bug-importer wenson_hsieh oldest_to_newest 1806236 0 ddkilzer 2021-10-19 12:41:20 -0700 TCCSPI.h should be a project header, not a private header. Regressed in r284220 for Bug 231621. <rdar://problem/84425384> 1806243 1 441772 ddkilzer 2021-10-19 12:47:33 -0700 Created attachment 441772 Patch v1 1806244 2 441772 wenson_hsieh 2021-10-19 12:48:09 -0700 Comment on attachment 441772 Patch v1 r=mews 1806275 3 441772 ddkilzer 2021-10-19 13:40:19 -0700 Comment on attachment 441772 Patch v1 There are a quorum of successful Apple Cocoa builds, so marking cq+ since this patch is needed to fix builds on other internal build systems. Note that ios, tv and tv-sim builders seem to be stuck on obsolete patches, and the mac build is ongoing (orange bubble is due to failed jinja Python module install, which isn't a hard failure, and is being investigated by Jonathan Bedard). 1806305 4 ews-feeder 2021-10-19 14:10:46 -0700 Committed r284494 (243248@main): <https://commits.webkit.org/243248@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441772. 441772 2021-10-19 12:47:33 -0700 2021-10-19 14:10:47 -0700 Patch v1 bug-231977-20211019124732.patch text/plain 2403 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCAzNjI4Y2Qz NmQ0YjEzNTQxMmQxMTU2N2E5YjFhOWM4NjExNjdmNmEzLi5iMDA4MWQzNGEwZmYzZmRkNDZhNGZl MDNmMjI1OTJlYjc2NjNkNTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAyMS0xMC0xOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIyODQyMjApOiBbUEFMXSBUQ0NTUEkuaCBzaG91bGQgYmUgYSBwcm9qZWN0 IGhlYWRlciwgbm90IGEgcHJpdmF0ZSBoZWFkZXIKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzIzMTk3Nz4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg0NDI1Mzg0PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUEFMLnhjb2RlcHJvai9w cm9qZWN0LnBieHByb2o6CisgICAgICAgIC0gQ2hhbmdlIFRDQ1NQSS5oIGZyb20gYSBwcml2YXRl IGhlYWRlciB0byBhIHByb2plY3QgaGVhZGVyLgorICAgICAgICAgIFBBTCB1c2VzIGEgYnVpbGQg cGhhc2Ugc2NyaXB0IHRvIGluc3RhbGwgaXRzIGhlYWRlcnMuCisKIDIwMjEtMTAtMTggIERhdmlk IEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWcgMjMxODgyOiBXZWJL aXQ6OkdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnNldFRDQ0lkZW50aXR5KCkgbGVha3MgYSB0 Y2NfaWRlbnRpdHlfdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML1BBTC54Y29kZXBy b2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL1dlYkNvcmUvUEFML1BBTC54Y29kZXByb2ovcHJv amVjdC5wYnhwcm9qCmluZGV4IGM2ZGE2MDA1ZDBiODVlMGFhYzBhN2Q2ZDUyZTk5NjYyNTE2NWJm ZWYuLmZkZWVkY2Y0MDdmZjc1M2Q3NGExMWE4YWE3NzBmNDIzODZhYTk5ZGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL1BBTC9QQUwueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagorKysgYi9T b3VyY2UvV2ViQ29yZS9QQUwvUEFMLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKQEAgLTE0MCw3 ICsxNDAsNyBAQAogCQk0NDUwRkNBMDIxRjVGNjAyMDA0REZBNTYgLyogUXVpY2tMb29rU29mdExp bmsuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDQ0NTBG QzlFMjFGNUY2MDIwMDRERkE1NiAvKiBRdWlja0xvb2tTb2Z0TGluay5oICovOyB9OwogCQk0NEUx QThBRjIxRkE1NEU2MDBDMzA0OEUgLyogTG9va3VwU29mdExpbmsuaCBpbiBIZWFkZXJzICovID0g e2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDQ0RTFBOEFEMjFGQTU0REEwMEMzMDQ4RSAv KiBMb29rdXBTb2Z0TGluay5oICovOyB9OwogCQk0NEUxQThCMDIxRkE1NEVCMDBDMzA0OEUgLyog TG9va3VwU29mdExpbmsubW0gaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZp bGVSZWYgPSA0NEUxQThBRTIxRkE1NERBMDBDMzA0OEUgLyogTG9va3VwU29mdExpbmsubW0gKi87 IH07Ci0JCTQ5OTZDMEYzMjcxNzY0NEMwMDJDMTI1RCAvKiBUQ0NTUEkuaCBpbiBIZWFkZXJzICov ID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDQ5OTZDMEYyMjcxNzY0MkIwMDJDMTI1 RCAvKiBUQ0NTUEkuaCAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2YXRlLCApOyB9 OyB9OworCQk0OTk2QzBGMzI3MTc2NDRDMDAyQzEyNUQgLyogVENDU1BJLmggaW4gSGVhZGVycyAq LyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA0OTk2QzBGMjI3MTc2NDJCMDAyQzEy NUQgLyogVENDU1BJLmggKi87IH07CiAJCTUxN0UwM0Y5MjRCN0MwMDcwMDU0ODk1QSAvKiBJT0tp dFNQSU1hYy5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0g NTE3RTAzRjgyNEI3QzAwNjAwNTQ4OTVBIC8qIElPS2l0U1BJTWFjLmggKi87IH07CiAJCTU3MEFC OEYxMjBBRTJFOEQwMEI4QkU4NyAvKiBTZWNLZXlQcm94eVNQSS5oIGluIEhlYWRlcnMgKi8gPSB7 aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gNTcwQUI4RjAyMEFFMkU4RDAwQjhCRTg3IC8q IFNlY0tleVByb3h5U1BJLmggKi87IH07CiAJCTU3MEFCOEY5MjBBRjZFM0QwMEI4QkU4NyAvKiBO U1hQQ0Nvbm5lY3Rpb25TUEkuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsg ZmlsZVJlZiA9IDU3MEFCOEY4MjBBRjZFM0QwMEI4QkU4NyAvKiBOU1hQQ0Nvbm5lY3Rpb25TUEku aCAqLzsgfTsK