231976 2021-10-19 12:39:25 -0700 canDoFastSpread should also check that the Structure is from the global object we're watching 2021-10-22 11:23:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist keith_miller mark.lam msaboff tzagallo webkit-bug-importer oldest_to_newest 1806233 0 saam 2021-10-19 12:39:25 -0700 ... 1806235 1 saam 2021-10-19 12:40:34 -0700 <rdar://84340372> 1806252 2 441776 saam 2021-10-19 12:54:27 -0700 Created attachment 441776 Patch 1806261 3 441776 keith_miller 2021-10-19 13:05:10 -0700 Comment on attachment 441776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441776&action=review > Source/JavaScriptCore/dfg/DFGGraph.cpp:1852 > + && structure->globalObject() == globalObject > && structure->storedPrototype() == arrayPrototype Nit: Can we invert these two lines? 1806361 4 441776 saam 2021-10-19 15:13:37 -0700 Comment on attachment 441776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441776&action=review >> Source/JavaScriptCore/dfg/DFGGraph.cpp:1852 >> && structure->storedPrototype() == arrayPrototype > > Nit: Can we invert these two lines? What's your thinking? The current code actually reads more clearly to me. 1806383 5 ews-feeder 2021-10-19 15:48:33 -0700 Committed r284506 (243252@main): <https://commits.webkit.org/243252@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441776. 1806412 6 saam 2021-10-19 17:05:07 -0700 Will fix Keith's nit. 1806415 7 441820 saam 2021-10-19 17:11:43 -0700 Created attachment 441820 follow up 1806615 8 441820 keith_miller 2021-10-20 08:10:26 -0700 Comment on attachment 441820 follow up r=me. 1807784 9 ews-feeder 2021-10-22 11:23:17 -0700 Committed r284699 (243416@main): <https://commits.webkit.org/243416@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441820. 441776 2021-10-19 12:54:27 -0700 2021-10-19 15:48:34 -0700 Patch c-backup.diff text/plain 1714 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjg0NDgwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDIxLTEwLTE5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IGNhbkRvRmFzdFNwcmVhZCBzaG91bGQgYWxzbyBjaGVjayB0aGF0IHRoZSBTdHJ1Y3R1cmUgaXMg ZnJvbSB0aGUgZ2xvYmFsIG9iamVjdCB3ZSdyZSB3YXRjaGluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxOTc2CisgICAgICAgIDxyZGFyOi8vODQz NDAzNzI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBkZmcvREZHR3JhcGguY3BwOgorICAgICAgICAoSlNDOjpERkc6OkdyYXBoOjpjYW5Eb0Zhc3RT cHJlYWQpOgorCiAyMDIxLTEwLTE5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK ICAgICAgICAgW2NsYW5nIDEzXSBTdXBwcmVzcyBzaWduIGNvbXBhcmlzb24gd2FybmluZ3MKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3BwCShyZXZpc2lvbiAyODQ0Nzgp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTg0MywxMCArMTg0MywxMiBAQCBib29sIEdyYXBoOjpjYW5Eb0Zhc3RTcHJlYWQoTm9k ZSogbm9kZSwgCiAgICAgaWYgKCF2YWx1ZS5tX3N0cnVjdHVyZS5pc0Zpbml0ZSgpKQogICAgICAg ICByZXR1cm4gZmFsc2U7CiAKLSAgICBBcnJheVByb3RvdHlwZSogYXJyYXlQcm90b3R5cGUgPSBn bG9iYWxPYmplY3RGb3Iobm9kZS0+Y2hpbGQxKCktPm9yaWdpbi5zZW1hbnRpYyktPmFycmF5UHJv dG90eXBlKCk7CisgICAgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCA9IGdsb2JhbE9iamVj dEZvcihub2RlLT5jaGlsZDEoKS0+b3JpZ2luLnNlbWFudGljKTsKKyAgICBBcnJheVByb3RvdHlw ZSogYXJyYXlQcm90b3R5cGUgPSBnbG9iYWxPYmplY3QtPmFycmF5UHJvdG90eXBlKCk7CiAgICAg Ym9vbCBhbGxHb29kID0gdHJ1ZTsKICAgICB2YWx1ZS5tX3N0cnVjdHVyZS5mb3JFYWNoKFsmXSAo UmVnaXN0ZXJlZFN0cnVjdHVyZSBzdHJ1Y3R1cmUpIHsKICAgICAgICAgYWxsR29vZCAmPSBzdHJ1 Y3R1cmUtPmhhc01vbm9Qcm90bygpCisgICAgICAgICAgICAmJiBzdHJ1Y3R1cmUtPmdsb2JhbE9i amVjdCgpID09IGdsb2JhbE9iamVjdAogICAgICAgICAgICAgJiYgc3RydWN0dXJlLT5zdG9yZWRQ cm90b3R5cGUoKSA9PSBhcnJheVByb3RvdHlwZQogICAgICAgICAgICAgJiYgIXN0cnVjdHVyZS0+ aXNEaWN0aW9uYXJ5KCkKICAgICAgICAgICAgICYmIHN0cnVjdHVyZS0+Z2V0Q29uY3VycmVudGx5 KG1fdm0ucHJvcGVydHlOYW1lcy0+aXRlcmF0b3JTeW1ib2wuaW1wbCgpKSA9PSBpbnZhbGlkT2Zm c2V0Cg== 441820 2021-10-19 17:11:43 -0700 2021-10-22 11:23:19 -0700 follow up c-backup.diff text/plain 1609 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjg0NTEwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDIxLTEwLTE5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IGNhbkRvRmFzdFNwcmVhZCBzaG91bGQgYWxzbyBjaGVjayB0aGF0IHRoZSBTdHJ1Y3R1cmUgaXMg ZnJvbSB0aGUgZ2xvYmFsIG9iamVjdCB3ZSdyZSB3YXRjaGluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxOTc2CisgICAgICAgIDxyZGFyOi8vODQz NDAzNzI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SnVzdCByZW9yZGVyIHRoZSBjaGVja3MgZm9yIGNsYXJpdHkuCisKKyAgICAgICAgKiBkZmcvREZH R3JhcGguY3BwOgorICAgICAgICAoSlNDOjpERkc6OkdyYXBoOjpjYW5Eb0Zhc3RTcHJlYWQpOgor CiAyMDIxLTEwLTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAg ICAgIEVhZ2VybHkgcmVzb2x2ZSBweXRob24zIHBhdGggaW4gTWFrZWZpbGVzCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcAkocmV2aXNpb24gMjg0NTEwKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4 NDcsOCArMTg0Nyw4IEBAIGJvb2wgR3JhcGg6OmNhbkRvRmFzdFNwcmVhZChOb2RlKiBub2RlLCAK ICAgICBBcnJheVByb3RvdHlwZSogYXJyYXlQcm90b3R5cGUgPSBnbG9iYWxPYmplY3QtPmFycmF5 UHJvdG90eXBlKCk7CiAgICAgYm9vbCBhbGxHb29kID0gdHJ1ZTsKICAgICB2YWx1ZS5tX3N0cnVj dHVyZS5mb3JFYWNoKFsmXSAoUmVnaXN0ZXJlZFN0cnVjdHVyZSBzdHJ1Y3R1cmUpIHsKLSAgICAg ICAgYWxsR29vZCAmPSBzdHJ1Y3R1cmUtPmhhc01vbm9Qcm90bygpCi0gICAgICAgICAgICAmJiBz dHJ1Y3R1cmUtPmdsb2JhbE9iamVjdCgpID09IGdsb2JhbE9iamVjdAorICAgICAgICBhbGxHb29k ICY9IHN0cnVjdHVyZS0+Z2xvYmFsT2JqZWN0KCkgPT0gZ2xvYmFsT2JqZWN0IAorICAgICAgICAg ICAgJiYgc3RydWN0dXJlLT5oYXNNb25vUHJvdG8oKQogICAgICAgICAgICAgJiYgc3RydWN0dXJl LT5zdG9yZWRQcm90b3R5cGUoKSA9PSBhcnJheVByb3RvdHlwZQogICAgICAgICAgICAgJiYgIXN0 cnVjdHVyZS0+aXNEaWN0aW9uYXJ5KCkKICAgICAgICAgICAgICYmIHN0cnVjdHVyZS0+Z2V0Q29u Y3VycmVudGx5KG1fdm0ucHJvcGVydHlOYW1lcy0+aXRlcmF0b3JTeW1ib2wuaW1wbCgpKSA9PSBp bnZhbGlkT2Zmc2V0Cg==