231968 2021-10-19 11:16:55 -0700 Fix build break after r284406 if ENABLE_SERVICE_WORKER=OFF 2021-10-19 21:50:20 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jigen.zhou jigen.zhou don.olmstead webkit-bug-importer oldest_to_newest 1806172 0 jigen.zhou 2021-10-19 11:16:55 -0700 After r284406, build with ENABLE_SERVICE_WORKER=OFF generates errors: C:/work/webkit/jenkins/neko/Source/WebKit/UIProcess/WebPageProxy.h:1973:47: error: use of undeclared identifier 'm_isServiceWorkerPage'; did you mean 'isServiceWorkerPage'? bool isServiceWorkerPage() const { return m_isServiceWorkerPage; } ^~~~~~~~~~~~~~~~~~~~~ isServiceWorkerPage C:/work/webkit/jenkins/neko/Source/WebKit/UIProcess/WebPageProxy.h:1973:10: note: 'isServiceWorkerPage' declared here bool isServiceWorkerPage() const { return m_isServiceWorkerPage; } ^ C:/work/webkit/jenkins/neko/Source/WebKit/UIProcess/WebPageProxy.h:1973:47: error: reference to non-static member function must be called; did you mean to call it with no arguments? bool isServiceWorkerPage() const { return m_isServiceWorkerPage; } ^~~~~~~~~~~~~~~~~~~~~ () 2 errors generated. 1806268 1 441782 jigen.zhou 2021-10-19 13:25:52 -0700 Created attachment 441782 Patch 1806494 2 ews-feeder 2021-10-19 21:49:36 -0700 Committed r284517 (243260@main): <https://commits.webkit.org/243260@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441782. 1806495 3 webkit-bug-importer 2021-10-19 21:50:20 -0700 <rdar://problem/84447444> 441782 2021-10-19 13:25:52 -0700 2021-10-19 21:49:36 -0700 Patch 231968.diff text/plain 2747 jigen.zhou ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZjJmY2Y1OWY3YjJiLi4xODYxZDkzMGZhM2YgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMjEtMTAtMTkgIEppZ2VuIFpob3UgIDxqaWdlbi56aG91QHNvbnkuY29tPgor CisgICAgICAgIEZpeCBidWlsZCBicmVhayBhZnRlciByMjg0NDA2IGlmIEVOQUJMRV9TRVJWSUNF X1dPUktFUj1PRkYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzMTk2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIHIyODQ0MDYgbWFkZSBtX2lzU2VydmljZVdvcmtlclBhZ2Ugb2YgV2ViUGFnZVByb3h5IG5v dCBhdmFpbGFibGUgaWYgIUVOQUJMRShTRVJWSUNFX1dPUktFUiksIAorICAgICAgICBidXQgdGhl IGNoYW5nZSB3YXMgaW5jb21wbGV0ZSBhbmQgY2FuIGNhdXNlIGJ1aWxkIGZhaWx1cmUgaWYgRU5B QkxFX1NFUlZJQ0VfV09SS0VSPU9GRi4gCisgICAgICAgIFRoaXMgcGF0Y2ggYXZvaWRzIGFjY2Vz c2luZyBtX2lzU2VydmljZVdvcmtlclBhZ2UgaWYgIUVOQUJMRShTRVJWSUNFX1dPUktFUikgaW4g V2ViUGFnZVByb3h5IAorICAgICAgICBtZXRob2RzIGlzU2VydmljZVdvcmtlclBhZ2UsIGxvYWRE YXRhV2l0aE5hdmlnYXRpb25TaGFyZWQsIGFuZCByZXNldFN0YXRlQWZ0ZXJQcm9jZXNzRXhpdGVk LiAgCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKiBV SVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisKIDIwMjEtMTAtMTkgIFlvdWVubiBGYWJsZXQgIDx5 b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEd1YXJhbnRlZSBvcmRlciBvZiBXZWJTb2NrZXQg ZXZlbnRzIGluIGNhc2Ugb2YgYmVpbmcgcmVzdW1lZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHAKaW5kZXggMzgyYjUzZWY3ZTk3Li44MjhmMmJhYzAzOTcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtMTUzNCw3ICsxNTM0LDcgQEAg dm9pZCBXZWJQYWdlUHJveHk6OmxvYWREYXRhV2l0aE5hdmlnYXRpb25TaGFyZWQoUmVmPFdlYlBy b2Nlc3NQcm94eT4mJiBwcm9jZXNzLAogICAgIGxvYWRQYXJhbWV0ZXJzLndlYnNpdGVQb2xpY2ll cyA9IFdURk1vdmUod2Vic2l0ZVBvbGljaWVzKTsKICAgICBsb2FkUGFyYW1ldGVycy5zaG91bGRP cGVuRXh0ZXJuYWxVUkxzUG9saWN5ID0gc2hvdWxkT3BlbkV4dGVybmFsVVJMc1BvbGljeTsKICAg ICBsb2FkUGFyYW1ldGVycy5pc05hdmlnYXRpbmdUb0FwcEJvdW5kRG9tYWluID0gaXNOYXZpZ2F0 aW5nVG9BcHBCb3VuZERvbWFpbjsKLSAgICBsb2FkUGFyYW1ldGVycy5pc1NlcnZpY2VXb3JrZXJM b2FkID0gbV9pc1NlcnZpY2VXb3JrZXJQYWdlOworICAgIGxvYWRQYXJhbWV0ZXJzLmlzU2Vydmlj ZVdvcmtlckxvYWQgPSBpc1NlcnZpY2VXb3JrZXJQYWdlKCk7CiAgICAgYWRkUGxhdGZvcm1Mb2Fk UGFyYW1ldGVycyhwcm9jZXNzLCBsb2FkUGFyYW1ldGVycyk7CiAKICAgICBwcm9jZXNzLT5tYXJr UHJvY2Vzc0FzUmVjZW50bHlVc2VkKCk7CkBAIC03OTk2LDcgKzc5OTYsOSBAQCB2b2lkIFdlYlBh Z2VQcm94eTo6cmVzZXRTdGF0ZUFmdGVyUHJvY2Vzc0V4aXRlZChQcm9jZXNzVGVybWluYXRpb25S ZWFzb24gdGVybWluYQogCiAgICAgbV9oYXNSdW5uaW5nUHJvY2VzcyA9IGZhbHNlOwogICAgIG1f YXJlQWN0aXZlRE9NT2JqZWN0c0FuZEFuaW1hdGlvbnNTdXNwZW5kZWQgPSBmYWxzZTsKKyNpZiBF TkFCTEUoU0VSVklDRV9XT1JLRVIpCiAgICAgbV9pc1NlcnZpY2VXb3JrZXJQYWdlID0gZmFsc2U7 CisjZW5kaWYKIAogICAgIG1fdXNlclNjcmlwdHNOb3RpZmllZCA9IGZhbHNlOwogICAgIG1faGFz QWN0aXZlQW5pbWF0ZWRTY3JvbGwgPSBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmgKaW5kZXggMmFlZTA4NGM3NjYxLi5mM2RkMjNjYWE0YTMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCkBAIC0xOTM4LDcgKzE5MzgsMTEgQEAgcHVibGljOgog ICAgIGJvb2wgYWNjZXB0c0ZpcnN0TW91c2UoaW50IGV2ZW50TnVtYmVyLCBjb25zdCBXZWJNb3Vz ZUV2ZW50Jik7CiAjZW5kaWYKIAorI2lmIEVOQUJMRShTRVJWSUNFX1dPUktFUikKICAgICBib29s IGlzU2VydmljZVdvcmtlclBhZ2UoKSBjb25zdCB7IHJldHVybiBtX2lzU2VydmljZVdvcmtlclBh Z2U7IH0KKyNlbHNlCisgICAgYm9vbCBpc1NlcnZpY2VXb3JrZXJQYWdlKCkgY29uc3QgeyByZXR1 cm4gZmFsc2U7IH0KKyNlbmRpZgogCiAgICAgdm9pZCBkaXNwYXRjaFdoZWVsRXZlbnRXaXRob3V0 U2Nyb2xsaW5nKGNvbnN0IFdlYldoZWVsRXZlbnQmLCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKGJv b2wpPiYmKTsKIAo=