231900 2021-10-18 09:18:34 -0700 Web process occasionally crashes under `RemoteDisplayListRecorderProxy::recordRestore()` 2021-10-18 10:20:19 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh kkinnunen thorton webkit-bug-importer oldest_to_newest 1805613 0 wenson_hsieh 2021-10-18 09:18:34 -0700 I can't reproduce this consistently, but I've observed at least one crash... 1805617 1 441614 wenson_hsieh 2021-10-18 09:28:44 -0700 Created attachment 441614 Put the null check back 1805622 2 441614 wenson_hsieh 2021-10-18 09:41:03 -0700 Comment on attachment 441614 Put the null check back Thanks for the review! 1805635 3 ews-feeder 2021-10-18 10:19:09 -0700 Committed r284382 (243165@main): <https://commits.webkit.org/243165@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441614. 1805637 4 webkit-bug-importer 2021-10-18 10:20:19 -0700 <rdar://problem/84376725> 441614 2021-10-18 09:28:44 -0700 2021-10-18 10:19:09 -0700 Put the null check back bug-231900-20211018092843.patch text/plain 2399 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVlOGY3MWEyNWY2ZmY1MzEz NGFhYTM2MjE3ZjM2MTM5NTNkZjZjOTcuLjhmZTdjMjAzOGZjMzM0NmRmZmIwNzZiNmRiNzQxNjlh MzdjNmFkM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjEtMTAtMTggIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIHByb2Nlc3Mgb2Nj YXNpb25hbGx5IGNyYXNoZXMgdW5kZXIgYFJlbW90ZURpc3BsYXlMaXN0UmVjb3JkZXJQcm94eTo6 cmVjb3JkUmVzdG9yZSgpYAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjMxOTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSXQncyBhcHBhcmVudGx5IHBvc3NpYmxlIGZvciBhIFJlbW90ZUltYWdlQnVmZmVy UHJveHkgaW4gdGhlIHdlYiBwcm9jZXNzIHRvIG91dGxpdmUgUmVtb3RlUmVuZGVyaW5nQmFja2Vu ZFByb3h5LgorICAgICAgICBCZWZvcmUgdGhlIElQQyBzdHJlYW0gcmVmYWN0b3JpbmcgaW4gcjI4 NDA3OSwgd2Ugd2VyZSByb2J1c3QgYWdhaW5zdCB0aGlzIHBvc3NpYmlsaXR5IGJlY2F1c2UKKyAg ICAgICAgUmVtb3RlSW1hZ2VCdWZmZXJQcm94eSBjaGVja2VkIGZvciBhIG51bGwgcmVuZGVyaW5n IGJhY2tlbmQgaW4gYGNhbkFwcGVuZEl0ZW1PZlR5cGVgIGFuZCByZXR1cm5lZCBgZmFsc2VgLCB3 aGljaAorICAgICAgICBwcmV2ZW50ZWQgdXMgZnJvbSB0cnlpbmcgdG8gY2FsbCBpbnRvIHRoZSBy ZW5kZXJpbmcgYmFja2VuZC4gSG93ZXZlciwgSSBhY2NpZGVudGFsbHkgb21pdHRlZCB0aGlzIG51 bGwgY2hlY2sKKyAgICAgICAgaW4gdGhlIG5ldyBSZW1vdGVEaXNwbGF5TGlzdFJlY29yZGVyUHJv eHksIHdoaWNoIGN1cnJlbnRseSBhc3N1bWVzIHRoYXQgYG1fcmVuZGVyaW5nQmFja2VuZGAgaXMg YWx3YXlzIG5vbi1udWxsCisgICAgICAgIHdoZW4gc2VuZGluZyBhbnkgSVBDIHN0cmVhbSBtZXNz YWdlcy4KKworICAgICAgICBGaXggdGhpcyBjcmFzaCBieSByZXN0b3JpbmcgdGhlIG51bGwgY2hl Y2sgZm9yIHRoZSB3ZWFrIGBtX3JlbmRlcmluZ0JhY2tlbmRgIHBvaW50ZXIuIEkgb25seSBvYnNl cnZlZCB0aGlzIGNyYXNoCisgICAgICAgIG9uY2UgbG9jYWxseSBhbmQsIHVuZm9ydHVuYXRlbHks IGhhdmVuJ3QgYmVlbiBhYmxlIHRvIGNvbWUgdXAgd2l0aCBhIHRlc3QgY2FzZSB0aGF0IGNvbnNp c3RlbnRseSByZXByb2R1Y2VzIGl0LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9HUFUvZ3JhcGhp Y3MvUmVtb3RlRGlzcGxheUxpc3RSZWNvcmRlclByb3h5Lmg6CisgICAgICAgIChXZWJLaXQ6OlJl bW90ZURpc3BsYXlMaXN0UmVjb3JkZXJQcm94eTo6c2VuZCk6CisKIDIwMjEtMTAtMTggIFdlbnNv biBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAo cjI4NDA3OSk6IGZhc3QvY2FudmFzL2dyYWRpZW50LXdpdGgtY2xpcC5odG1sIGFuZCBmYXN0L2Nh bnZhcy9ncmFkaWVudC10ZXh0LXdpdGgtc2hhZG93Lmh0bWwgYXJlIGZsYWt5IGZhaWx1cmVzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZURp c3BsYXlMaXN0UmVjb3JkZXJQcm94eS5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9n cmFwaGljcy9SZW1vdGVEaXNwbGF5TGlzdFJlY29yZGVyUHJveHkuaAppbmRleCBiZGFmZTllZTIw ZjYzYzlmYzNmYTQyZThkNjU4OWM2YzQ2OWZiMmY4Li43MWZkYjYzZGY0YWM4NDk3NDcyMzI2OWI3 ZjAzZDk5N2I4MTM5ODlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BV L2dyYXBoaWNzL1JlbW90ZURpc3BsYXlMaXN0UmVjb3JkZXJQcm94eS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvUmVtb3RlRGlzcGxheUxpc3RSZWNvcmRlclBy b3h5LmgKQEAgLTU1LDYgKzU1LDkgQEAgcHJpdmF0ZToKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBU PgogICAgIHZvaWQgc2VuZChUJiYgbWVzc2FnZSkKICAgICB7CisgICAgICAgIGlmIChVTkxJS0VM WSghbV9yZW5kZXJpbmdCYWNrZW5kKSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBt X25lZWRzRmx1c2ggPSB0cnVlOwogICAgICAgICBtX3JlbmRlcmluZ0JhY2tlbmQtPnNlbmRUb1N0 cmVhbShXVEZNb3ZlKG1lc3NhZ2UpLCBtX2Rlc3RpbmF0aW9uQnVmZmVySWRlbnRpZmllcik7CiAg ICAgfQo=