231882 2021-10-17 14:49:15 -0700 WebKit::GPUConnectionToWebProcess::setTCCIdentity() leaks a tcc_identity_t 2021-11-03 21:10:00 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 231621 232507 1 ddkilzer ddkilzer achristensen cdumez eric.carlson katherine_cheney kkinnunen webkit-bug-importer oldest_to_newest 1805431 0 ddkilzer 2021-10-17 14:49:15 -0700 WebKit::GPUConnectionToWebProcess::setTCCIdentity() leaks a tcc_identity_t. See Bug 231621, Comment #24 from Alex Christensen: > Comment on attachment 441298 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441298&action=review > > > Source/WebKit/GPUProcess/cocoa/GPUConnectionToWebProcessCocoa.mm:81 > > + identity = tcc_identity_create(TCC_IDENTITY_CODE_BUNDLE_ID, [bundleProxy.bundleIdentifier UTF8String]); > > tcc_identity_create is annotated with OS_OBJECT_RETURNS_RETAINED, which > means this is probably a memory leak. It should probably be auto identity = > adoptOSObject(tcc_identity_create(...)); which means my build fix of calling > tcc_identity_t will probably also need to be changed to OS_OBJECT_DECL if > OS_OBJECT_USE_OBJC is defined. 1805433 1 webkit-bug-importer 2021-10-17 14:50:18 -0700 <rdar://problem/84350854> 1805437 2 ddkilzer 2021-10-17 15:37:01 -0700 I have a potential fix. 1805438 3 ddkilzer 2021-10-17 15:38:02 -0700 Waiting for Bug 231621 Attachment #441550 to land first. 1805445 4 441556 ddkilzer 2021-10-17 16:36:49 -0700 Created attachment 441556 Patch v1 1805575 5 441556 ddkilzer 2021-10-18 08:20:28 -0700 Comment on attachment 441556 Patch v1 Thanks Chris! 1805579 6 ews-feeder 2021-10-18 08:30:30 -0700 Committed r284373 (243158@main): <https://commits.webkit.org/243158@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441556. 441556 2021-10-17 16:36:49 -0700 2021-10-18 08:30:31 -0700 Patch v1 bug-231882-20211017163649.patch text/plain 4101 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCAzMTMyMWI2 ZjYwYWUyODJjMTgwYjk0MWMwN2U1MDBkODdhMjQ1N2VlLi4xNTAyYWZhOThmMWIxNzQ5YzI1OGQy ZDc0ZjM4NThkYTYwOGNkMzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAyMS0xMC0xNyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAg IEJ1ZyAyMzE4ODI6IFdlYktpdDo6R1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6c2V0VENDSWRl bnRpdHkoKSBsZWFrcyBhIHRjY19pZGVudGl0eV90CisgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8yMzE4ODI+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NDM1MDg1ND4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhbC9zcGkvY29jb2Ev VENDU1BJLmg6CisgICAgICAgIC0gUHJvcGVybHkgZGVjbGFyZSB0Y2NfaWRlbnRpdHlfdCBhcyBh biBPU09iamVjdC4KKwogMjAyMS0xMC0xNyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCAjMzogQWRvcHQgYXR0cmlidXRpb24gQVZDYXB0dXJl U2Vzc2lvbiBTUEkgZm9yIEdQVSBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM4ZGUzY2JmMjJiZTA0M2Y2 Mzg1M2FkZDZkNzllNmJjMzhmMjJhNmQuLjQzZjc0YWEzZDhkYWFkZjJiMWZlOWQ1YjY2YjNiOWFm MTAwNTQyOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTAtMTcgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBCdWcgMjMxODgyOiBXZWJLaXQ6 OkdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnNldFRDQ0lkZW50aXR5KCkgbGVha3MgYSB0Y2Nf aWRlbnRpdHlfdAorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjMxODgyPgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vODQzNTA4NTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBHUFVQcm9jZXNzL2NvY29hL0dQVUNvbm5lY3Rpb25Ub1dl YlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6R1BVQ29ubmVjdGlvblRvV2ViUHJv Y2Vzczo6c2V0VENDSWRlbnRpdHkpOgorICAgICAgICAtIFVzZSBXVEY6OmFkb3B0T1NPYmplY3Qo KSB0byBmaXggdGhlIGxlYWsuCisgICAgICAgIC0gRXhwYW5kIHRoZSBzY29wZSBvZiAhUExBVEZP Uk0oTUFDQ0FUQUxZU1QpIHNpbmNlIG5vbmUgb2YgdGhpcworICAgICAgICAgIGNvZGUgbmVlZHMg dG8gcnVuIG9uIHRoZSBNYWNDYXRhbHlzdCBwbGF0Zm9ybS4KKwogMjAyMS0xMC0xNyAgRGF2aWQg S2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCAjMzogQWRv cHQgYXR0cmlidXRpb24gQVZDYXB0dXJlU2Vzc2lvbiBTUEkgZm9yIEdQVSBwcm9jZXNzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jb2NvYS9UQ0NTUEkuaCBiL1NvdXJj ZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NvY29hL1RDQ1NQSS5oCmluZGV4IGYyOWZjNTczZTcwYzMy NTBlZTI0ZGMxZmEyMTU2OGY4NTI1YjhkZGYuLjljMDcxNDhhMjdjYzQzNWM1MWE1NDZmMmEyNGQy ZjhlOTM0YTBhODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NvY29h L1RDQ1NQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NvY29hL1RDQ1NQSS5o CkBAIC0zMSw2ICszMSw4IEBACiAKICNlbHNlCiAKKyNpbmNsdWRlIDxvcy9vYmplY3QuaD4KKwog dHlwZWRlZiBlbnVtIHsKICAgICBrVENDQWNjZXNzUHJlZmxpZ2h0R3JhbnRlZCwKICAgICBrVEND QWNjZXNzUHJlZmxpZ2h0RGVuaWVkLApAQCAtMzksNyArNDEsNyBAQCB0eXBlZGVmIGVudW0gewog I2lmIEhBVkUoVENDX0lPU18xNF9CSUdfU1VSX1NQSSkKIHR5cGVkZWYgdWludDY0X3QgdGNjX2lk ZW50aXR5X3R5cGVfdDsKIGNvbnN0ZXhwciB0Y2NfaWRlbnRpdHlfdHlwZV90IFRDQ19JREVOVElU WV9DT0RFX0JVTkRMRV9JRCA9IDA7Ci10eXBlZGVmIHZvaWQqIHRjY19pZGVudGl0eV90OworT1Nf T0JKRUNUX0RFQ0xfQ0xBU1ModGNjX2lkZW50aXR5KTsKICNlbmRpZiAvLyBIQVZFKFRDQ19JT1Nf MTRfQklHX1NVUl9TUEkpCiAKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9HUFVQ cm9jZXNzL2NvY29hL0dQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3NDb2NvYS5tbSBiL1NvdXJjZS9X ZWJLaXQvR1BVUHJvY2Vzcy9jb2NvYS9HUFVDb25uZWN0aW9uVG9XZWJQcm9jZXNzQ29jb2EubW0K aW5kZXggMjhhYzJhNWRjYWJjZWIyZTBiZTc3ZjFiY2JkNmFmZWI1MjY1NTE5Ni4uNDFmNTk5NGIx NWE3Y2RhMzZiZjZiY2UwODFmZWU3YzUwZDFlMzFkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9HUFVQcm9jZXNzL2NvY29hL0dQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3NDb2NvYS5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvY29jb2EvR1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vz c0NvY29hLm1tCkBAIC0zNSw2ICszNSw3IEBACiAjaW1wb3J0IDxXZWJDb3JlL1JlZ2lzdHJhYmxl RG9tYWluLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1NlY3VyaXR5T3JpZ2luLmg+CiAjaW1wb3J0IDxw YWwvc3BpL2NvY29hL0xhdW5jaFNlcnZpY2VzU1BJLmg+CisjaW1wb3J0IDx3dGYvT1NPYmplY3RQ dHIuaD4KIAogI2ltcG9ydCAiVENDU29mdExpbmsuaCIKICNpbXBvcnQgPHBhbC9pb3MvU3lzdGVt U3RhdHVzU29mdExpbmsuaD4KQEAgLTY4LDYgKzY5LDcgQEAgYm9vbCBHUFVDb25uZWN0aW9uVG9X ZWJQcm9jZXNzOjpzZXRDYXB0dXJlQXR0cmlidXRpb25TdHJpbmcoKQogI2lmIEVOQUJMRShBUFBf UFJJVkFDWV9SRVBPUlQpCiB2b2lkIEdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnNldFRDQ0lk ZW50aXR5KCkKIHsKKyNpZiAhUExBVEZPUk0oTUFDQ0FUQUxZU1QpCiAgICAgYXV0byBhdWRpdFRv a2VuID0gZ3B1UHJvY2VzcygpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPmdldEF1ZGl0VG9r ZW4oKTsKICAgICBpZiAoIWF1ZGl0VG9rZW4pCiAgICAgICAgIHJldHVybjsKQEAgLTc3LDE2ICs3 OSwxNCBAQCB2b2lkIEdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnNldFRDQ0lkZW50aXR5KCkK ICAgICBpZiAoZXJyb3IpCiAgICAgICAgIHJldHVybjsKIAotICAgIHRjY19pZGVudGl0eV90IGlk ZW50aXR5ID0gbmlsOwotICAgIGlkZW50aXR5ID0gdGNjX2lkZW50aXR5X2NyZWF0ZShUQ0NfSURF TlRJVFlfQ09ERV9CVU5ETEVfSUQsIFtidW5kbGVQcm94eS5idW5kbGVJZGVudGlmaWVyIFVURjhT dHJpbmddKTsKKyAgICBhdXRvIGlkZW50aXR5ID0gYWRvcHRPU09iamVjdCh0Y2NfaWRlbnRpdHlf Y3JlYXRlKFRDQ19JREVOVElUWV9DT0RFX0JVTkRMRV9JRCwgW2J1bmRsZVByb3h5LmJ1bmRsZUlk ZW50aWZpZXIgVVRGOFN0cmluZ10pKTsKICAgICBpZiAoIWlkZW50aXR5KQogICAgICAgICByZXR1 cm47CiAKLSNpZiAhUExBVEZPUk0oTUFDQ0FUQUxZU1QpCi0gICAgV2ViQ29yZTo6UmVhbHRpbWVN ZWRpYVNvdXJjZUNlbnRlcjo6c2luZ2xldG9uKCkuc2V0SWRlbnRpdHkoaWRlbnRpdHkpOwotI2Vu ZGlmCisgICAgV2ViQ29yZTo6UmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlcjo6c2luZ2xldG9uKCku c2V0SWRlbnRpdHkoaWRlbnRpdHkuZ2V0KCkpOworI2VuZGlmIC8vICFQTEFURk9STShNQUNDQVRB TFlTVCkKIH0KLSNlbmRpZgorI2VuZGlmIC8vIEVOQUJMRShBUFBfUFJJVkFDWV9SRVBPUlQpCiB9 IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAogI2VuZGlmIC8vIEVOQUJMRShHUFVfUFJPQ0VTUykK