231881 2021-10-17 14:33:29 -0700 overriding RTCVideoDecoderH264/265 color space attachments not always done 2021-10-18 20:43:25 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam eric.carlson ews-watchlist glenn jer.noble osvaldo.rivera1994 philipj sergio webkit-bug-importer youennf oldest_to_newest 1805426 0 heycam 2021-10-17 14:33:29 -0700 I found that in some configurations, e.g. builds on Catalina, the "ColorInfoGuessedBy" attachment is not placed on CVPixelBuffers we get from the VTDecompressionSession, but the guessed, incorrect color space attachments are still there. Since we are currently only supporting sRGB color space video streams in WebRTC, we shouldn't check for "ColorInfoGuessedBy", and instead always override the attachments. 1805428 1 webkit-bug-importer 2021-10-17 14:33:56 -0700 <rdar://problem/84350707> 1805429 2 441551 heycam 2021-10-17 14:35:45 -0700 Created attachment 441551 Patch 1805867 3 ews-feeder 2021-10-18 20:43:23 -0700 Committed r284433 (243195@main): <https://commits.webkit.org/243195@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441551. 441551 2021-10-17 14:35:45 -0700 2021-10-18 20:43:24 -0700 Patch bug-231881-20211018083544.patch text/plain 4834 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCAwMDFjNjgyZjg4ZjllNzAzMzBkOWU5M2NlZjE5MjUwZDEyYTY2NDNkLi43OTMx MTRjOWVkOTIzYjM4MzdkYTU2ZWEwM2M3MjJkZmNiNGEzNTBmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAyMS0xMC0xNyAgQ2FtZXJvbiBN Y0Nvcm1hY2sgIDxoZXljYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFsd2F5cyBzZXQgY29sb3Ig c3BhY2UgZm9yIGluY29taW5nIEguMjY0LzI2NSBzdHJlYW1zCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE4ODEKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzg0MzUwNzA3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZvbGxvd3VwIGZyb20gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzMTM1My4gSW4gc29tZQorICAgICAgICBjb25maWd1cmF0aW9ucywgdGhlICJDb2xvcklu Zm9HdWVzc2VkQnkiIGF0dGFjaG1lbnQgaXMgbm90IHNldCBvbiB0aGUKKyAgICAgICAgQ1ZQaXhl bEJ1ZmZlcnMgY29taW5nIG91dCBvZiB0aGUgVlREZWNvbXByZXNzaW9uU2Vzc2lvbiwgYnV0IHRo ZQorICAgICAgICBndWVzc2VkLCBpbmNvcnJlY3QgY29sb3Igc3BhY2UgYXR0YWNobWVudHMgYXJl IHN0aWxsIHRoZXJlLiBTaW5jZSB3ZQorICAgICAgICBjdXJyZW50bHkgYWx3YXlzIGhhdmUgYW4g c1JHQiBzdHJlYW0sIGRvbid0IGJvdGhlciBsb29raW5nIGZvcgorICAgICAgICAiQ29sb3JJbmZv R3Vlc3NlZEJ5Ii4KKworICAgICAgICAqIFNvdXJjZS93ZWJydGMvc2RrL29iamMvY29tcG9uZW50 cy92aWRlb19jb2RlYy9SVENWaWRlb0RlY29kZXJIMjY0Lm1tOgorICAgICAgICAob3ZlcnJpZGVD b2xvclNwYWNlQXR0YWNobWVudHMpOgorICAgICAgICAoZGVjb21wcmVzc2lvbk91dHB1dENhbGxi YWNrKToKKyAgICAgICAgKG92ZXJyaWRlQ29sb3JTcGFjZUF0dGFjaG1lbnRzSWZOZWVkZWQpOiBE ZWxldGVkLgorICAgICAgICAqIFNvdXJjZS93ZWJydGMvc2RrL29iamMvY29tcG9uZW50cy92aWRl b19jb2RlYy9SVENWaWRlb0RlY29kZXJIMjY1Lm1tOgorICAgICAgICAob3ZlcnJpZGVDb2xvclNw YWNlQXR0YWNobWVudHMpOgorICAgICAgICAoaDI2NURlY29tcHJlc3Npb25PdXRwdXRDYWxsYmFj ayk6CisgICAgICAgIChvdmVycmlkZUNvbG9yU3BhY2VBdHRhY2htZW50c0lmTmVlZGVkKTogRGVs ZXRlZC4KKwogMjAyMS0xMC0xNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIGZpeCB1cCByMjg0MTkwIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2NvbXBv bmVudHMvdmlkZW9fY29kZWMvUlRDVmlkZW9EZWNvZGVySDI2NC5tbSBiL1NvdXJjZS9UaGlyZFBh cnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2NvbXBvbmVudHMvdmlkZW9fY29k ZWMvUlRDVmlkZW9EZWNvZGVySDI2NC5tbQppbmRleCA3ZTkwNDE5NjQ1NGU3OWExMzFkNzk4MmI1 MDgwODFlNmVhZjM3NDJjLi5hY2Y2MTIyM2RmZTE0NmI1MjBkNDc5MDljMDlhNjRiMmQ2MWMxZmQy IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9z ZGsvb2JqYy9jb21wb25lbnRzL3ZpZGVvX2NvZGVjL1JUQ1ZpZGVvRGVjb2RlckgyNjQubW0KKysr IGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvY29t cG9uZW50cy92aWRlb19jb2RlYy9SVENWaWRlb0RlY29kZXJIMjY0Lm1tCkBAIC00MSwxMSArNDEs NyBAQCBAaW50ZXJmYWNlIFJUQ1ZpZGVvRGVjb2RlckgyNjQgKCkKIC0gKHZvaWQpc2V0RXJyb3I6 KE9TU3RhdHVzKWVycm9yOwogQGVuZAogCi1zdGF0aWMgdm9pZCBvdmVycmlkZUNvbG9yU3BhY2VB dHRhY2htZW50c0lmTmVlZGVkKENWSW1hZ2VCdWZmZXJSZWYgaW1hZ2VCdWZmZXIpIHsKLSAgYXV0 byBndWVzcyA9IENWQnVmZmVyR2V0QXR0YWNobWVudChpbWFnZUJ1ZmZlciwgKENGU3RyaW5nUmVm KUAiQ29sb3JJbmZvR3Vlc3NlZEJ5IiwgbnVsbHB0cik7Ci0gIGlmICghZ3Vlc3MgfHwgIUNGRXF1 YWwoZ3Vlc3MsIChDRlN0cmluZ1JlZilAIlZpZGVvVG9vbGJveCIpKQotICAgIHJldHVybjsKLQor c3RhdGljIHZvaWQgb3ZlcnJpZGVDb2xvclNwYWNlQXR0YWNobWVudHMoQ1ZJbWFnZUJ1ZmZlclJl ZiBpbWFnZUJ1ZmZlcikgewogICBDVkJ1ZmZlclJlbW92ZUF0dGFjaG1lbnQoaW1hZ2VCdWZmZXIs IGtDVkltYWdlQnVmZmVyQ0dDb2xvclNwYWNlS2V5KTsKICAgQ1ZCdWZmZXJTZXRBdHRhY2htZW50 KGltYWdlQnVmZmVyLCBrQ1ZJbWFnZUJ1ZmZlckNvbG9yUHJpbWFyaWVzS2V5LCBrQ1ZJbWFnZUJ1 ZmZlckNvbG9yUHJpbWFyaWVzX0lUVV9SXzcwOV8yLCBrQ1ZBdHRhY2htZW50TW9kZV9TaG91bGRQ cm9wYWdhdGUpOwogICBDVkJ1ZmZlclNldEF0dGFjaG1lbnQoaW1hZ2VCdWZmZXIsIGtDVkltYWdl QnVmZmVyVHJhbnNmZXJGdW5jdGlvbktleSwga0NWSW1hZ2VCdWZmZXJUcmFuc2ZlckZ1bmN0aW9u X3NSR0IsIGtDVkF0dGFjaG1lbnRNb2RlX1Nob3VsZFByb3BhZ2F0ZSk7CkBAIC02OSw3ICs2NSw3 IEBAIHZvaWQgZGVjb21wcmVzc2lvbk91dHB1dENhbGxiYWNrKHZvaWQgKmRlY29kZXJSZWYsCiAg ICAgcmV0dXJuOwogICB9CiAKLSAgb3ZlcnJpZGVDb2xvclNwYWNlQXR0YWNobWVudHNJZk5lZWRl ZChpbWFnZUJ1ZmZlcik7CisgIG92ZXJyaWRlQ29sb3JTcGFjZUF0dGFjaG1lbnRzKGltYWdlQnVm ZmVyKTsKIAogICBzdGQ6OnVuaXF1ZV9wdHI8UlRDRnJhbWVEZWNvZGVQYXJhbXM+IGRlY29kZVBh cmFtcyhyZWludGVycHJldF9jYXN0PFJUQ0ZyYW1lRGVjb2RlUGFyYW1zICo+KHBhcmFtcykpOwog ICAvLyBUT0RPKHRrY2hpbik6IEhhbmRsZSBDVk8gcHJvcGVybHkuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9jb21wb25lbnRz L3ZpZGVvX2NvZGVjL1JUQ1ZpZGVvRGVjb2RlckgyNjUubW0gYi9Tb3VyY2UvVGhpcmRQYXJ0eS9s aWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9jb21wb25lbnRzL3ZpZGVvX2NvZGVjL1JU Q1ZpZGVvRGVjb2RlckgyNjUubW0KaW5kZXggODU2NjNkYTZhZWJlNDVlODFjMmRhYjc4ZTIzNzM1 MWU2ZDVjNTViNi4uOTlkMTAwN2VkMmEzYzQxNzczNWU1YjhjNDUxZDk0NjllZWZiZDM2MSAxMDA2 NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29i amMvY29tcG9uZW50cy92aWRlb19jb2RlYy9SVENWaWRlb0RlY29kZXJIMjY1Lm1tCisrKyBiL1Nv dXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2NvbXBvbmVu dHMvdmlkZW9fY29kZWMvUlRDVmlkZW9EZWNvZGVySDI2NS5tbQpAQCAtMzgsMTEgKzM4LDcgQEAg QGludGVyZmFjZSBSVENWaWRlb0RlY29kZXJIMjY1ICgpCiAtICh2b2lkKXNldEVycm9yOihPU1N0 YXR1cyllcnJvcjsKIEBlbmQKIAotc3RhdGljIHZvaWQgb3ZlcnJpZGVDb2xvclNwYWNlQXR0YWNo bWVudHNJZk5lZWRlZChDVkltYWdlQnVmZmVyUmVmIGltYWdlQnVmZmVyKSB7Ci0gIGF1dG8gZ3Vl c3MgPSBDVkJ1ZmZlckdldEF0dGFjaG1lbnQoaW1hZ2VCdWZmZXIsIChDRlN0cmluZ1JlZilAIkNv bG9ySW5mb0d1ZXNzZWRCeSIsIG51bGxwdHIpOwotICBpZiAoIWd1ZXNzIHx8ICFDRkVxdWFsKGd1 ZXNzLCAoQ0ZTdHJpbmdSZWYpQCJWaWRlb1Rvb2xib3giKSkKLSAgICByZXR1cm47Ci0KK3N0YXRp YyB2b2lkIG92ZXJyaWRlQ29sb3JTcGFjZUF0dGFjaG1lbnRzKENWSW1hZ2VCdWZmZXJSZWYgaW1h Z2VCdWZmZXIpIHsKICAgQ1ZCdWZmZXJSZW1vdmVBdHRhY2htZW50KGltYWdlQnVmZmVyLCBrQ1ZJ bWFnZUJ1ZmZlckNHQ29sb3JTcGFjZUtleSk7CiAgIENWQnVmZmVyU2V0QXR0YWNobWVudChpbWFn ZUJ1ZmZlciwga0NWSW1hZ2VCdWZmZXJDb2xvclByaW1hcmllc0tleSwga0NWSW1hZ2VCdWZmZXJD b2xvclByaW1hcmllc19JVFVfUl83MDlfMiwga0NWQXR0YWNobWVudE1vZGVfU2hvdWxkUHJvcGFn YXRlKTsKICAgQ1ZCdWZmZXJTZXRBdHRhY2htZW50KGltYWdlQnVmZmVyLCBrQ1ZJbWFnZUJ1ZmZl clRyYW5zZmVyRnVuY3Rpb25LZXksIGtDVkltYWdlQnVmZmVyVHJhbnNmZXJGdW5jdGlvbl9zUkdC LCBrQ1ZBdHRhY2htZW50TW9kZV9TaG91bGRQcm9wYWdhdGUpOwpAQCAtNjYsNyArNjIsNyBAQCB2 b2lkIGgyNjVEZWNvbXByZXNzaW9uT3V0cHV0Q2FsbGJhY2sodm9pZCogZGVjb2RlclJlZiwKICAg ICByZXR1cm47CiAgIH0KIAotICBvdmVycmlkZUNvbG9yU3BhY2VBdHRhY2htZW50c0lmTmVlZGVk KGltYWdlQnVmZmVyKTsKKyAgb3ZlcnJpZGVDb2xvclNwYWNlQXR0YWNobWVudHMoaW1hZ2VCdWZm ZXIpOwogCiAgIHN0ZDo6dW5pcXVlX3B0cjxSVENIMjY1RnJhbWVEZWNvZGVQYXJhbXM+IGRlY29k ZVBhcmFtcyhyZWludGVycHJldF9jYXN0PFJUQ0gyNjVGcmFtZURlY29kZVBhcmFtcyo+KHBhcmFt cykpOwogICAvLyBUT0RPKHRrY2hpbik6IEhhbmRsZSBDVk8gcHJvcGVybHkuCg==