23187 2009-01-08 10:03:27 -0800 [QT] in ChromeClientQt::repaint, view should be updated with the intersected rect, not whole windowRect 2009-01-13 12:44:23 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 yongjun.zhang yongjun.zhang oldest_to_newest 104890 0 yongjun.zhang 2009-01-08 10:03:27 -0800 In ChromeClientQt::repaint, view should be updated with the intersected rect, not the whole windowRect; This generally is not a problem for normal viewport setup where viewport size is the same as the qwebview widget size. However, if we set the viewport size smaller than qwebkit widget, we will see unwanted painting outside the viewport. 104892 1 26525 yongjun.zhang 2009-01-08 10:06:50 -0800 Created attachment 26525 use intersected rect to update the view. 105551 2 26525 hausmann 2009-01-13 12:42:57 -0800 Comment on attachment 26525 use intersected rect to update the view. Looks good to me, nice catch! I'll paste the description from the bug into the ChangeLog when landing to make it a bit clearer in the ChangeLog what your fix does. 105554 3 hausmann 2009-01-13 12:44:23 -0800 Landed in r39874 26525 2009-01-08 10:06:50 -0800 2009-01-13 12:42:57 -0800 use intersected rect to update the view. qt_clip_paint.patch text/plain 1212 yongjun.zhang SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gMzk3MTApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDEtMDggIFlvbmdqdW4gWmhhbmcgIDx5b25nanVu LnpoYW5nQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubgor ICAgICAgICAKKyAgICAgICAgVXBkYXRlIHdlYnZpZXcgd2l0aCB0aGUgaW50ZXJzZWN0ZWQgcmVj dC4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudFF0OjpyZXBhaW50KToKKwogMjAwOS0wMS0wOCAgQWRh bSBUcmVhdCAgPGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hy b21lQ2xpZW50UXQuY3BwCShyZXZpc2lvbiAzOTcxMCkKKysrIFdlYktpdC9xdC9XZWJDb3JlU3Vw cG9ydC9DaHJvbWVDbGllbnRRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwOSw4ICszMDksOCBA QCB2b2lkIENocm9tZUNsaWVudFF0OjpyZXBhaW50KGNvbnN0IEludFJlCiAgICAgICAgIGlmICh2 aWV3KSB7CiAgICAgICAgICAgICBRUmVjdCByZWN0KHdpbmRvd1JlY3QpOwogICAgICAgICAgICAg cmVjdCA9IHJlY3QuaW50ZXJzZWN0ZWQoUVJlY3QoUVBvaW50KDAsIDApLCBtX3dlYlBhZ2UtPnZp ZXdwb3J0U2l6ZSgpKSk7Ci0gICAgICAgICAgICBpZiAoIXdpbmRvd1JlY3QuaXNFbXB0eSgpKQot ICAgICAgICAgICAgICAgIHZpZXctPnVwZGF0ZSh3aW5kb3dSZWN0KTsKKyAgICAgICAgICAgIGlm ICghcmVjdC5pc0VtcHR5KCkpCisgICAgICAgICAgICAgICAgdmlldy0+dXBkYXRlKHJlY3QpOwog ICAgICAgICB9CiAgICAgICAgIGVtaXQgbV93ZWJQYWdlLT5yZXBhaW50UmVxdWVzdGVkKHdpbmRv d1JlY3QpOwogICAgIH0K