231850 2021-10-15 18:46:54 -0700 Don't load metadata base pointer in EXTRA_CTI_THUNKS 2021-10-18 13:42:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist keith_miller mark.lam msaboff tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1805176 0 saam 2021-10-15 18:46:54 -0700 It's already in a register 1805179 1 441467 saam 2021-10-15 18:52:45 -0700 Created attachment 441467 patch 1805180 2 441467 ysuzuki 2021-10-15 18:54:17 -0700 Comment on attachment 441467 patch Nice. 1805184 3 441467 ysuzuki 2021-10-15 19:53:12 -0700 Comment on attachment 441467 patch Discussed with Saam at slack, we will load this metadata in the thunk-caller side (so that we can save one more executed instruction). 1805612 4 441613 saam 2021-10-18 09:17:29 -0700 Created attachment 441613 patch for landing 1805705 5 ews-feeder 2021-10-18 13:41:57 -0700 Committed r284396 (243172@main): <https://commits.webkit.org/243172@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441613. 1805706 6 webkit-bug-importer 2021-10-18 13:42:22 -0700 <rdar://problem/84385655> 441467 2021-10-15 18:52:45 -0700 2021-10-18 09:17:29 -0700 patch c-backup.diff text/plain 1974 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjg0MzAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDIxLTEwLTE1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IERvbid0IGxvYWQgbWV0YWRhdGEgYmFzZSBwb2ludGVyIGluIEVYVFJBX0NUSV9USFVOS1MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTg1MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHdlcmUgbG9h ZGluZyB0aGUgbWV0YWRhdGEgdGFibGUgYmFzZSBwb2ludGVyIGR5bmFtaWNhbGx5LiBCdXQgaW4K KyAgICAgICAgdW5saW5rZWQgYmFzZWxpbmUgSklULCBpdCdzIGFscmVhZHkgcGlubmVkIGluIGEg cmVnaXN0ZXIuIExldCdzIGp1c3QKKyAgICAgICAgdXNlIHRoZSByZWdpc3RlciBpbnN0ZWFkIG9m IHJlY29tcHV0aW5nIHdoYXQncyBhbHJlYWR5IHRoZXJlLiBUaGlzIGlzCisgICAgICAgIGEgc21h bGwgc3BlZWR1cCBpbiB0aHJvdWdocHV0IG9mIHVubGlua2VkIGJhc2VsaW5lIEpJVCBjb2RlIGZv ciBzY29wZQorICAgICAgICBvcGVyYXRpb25zLgorCisgICAgICAgICogaml0L0pJVFByb3BlcnR5 QWNjZXNzLmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjpnZW5lcmF0ZU9wUmVzb2x2ZVNjb3BlVGh1 bmspOgorICAgICAgICAoSlNDOjpKSVQ6OmdlbmVyYXRlT3BHZXRGcm9tU2NvcGVUaHVuayk6CisK IDIwMjEtMTAtMTUgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAg ICAgICAgIFJlYWxpemUgTWFjIENNYWtlIGJ1aWxkIG9mIFdlYkNvcmUgYW5kIFdlYktpdApJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAJ KHJldmlzaW9uIDI4NDMwMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVy dHlBY2Nlc3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDE1LDkgKzIwMTUsNyBAQCBNYWNyb0Fz c2VtYmxlckNvZGVSZWY8SklUVGh1bmtQdHJUYWc+IEpJCiAKICAgICBqaXQudGFnUmV0dXJuQWRk cmVzcygpOwogCi0gICAgaml0LmxvYWRQdHIoYWRkcmVzc0ZvcihDYWxsRnJhbWVTbG90Ojpjb2Rl QmxvY2spLCByZWdUMyk7Ci0gICAgaml0LmxvYWRQdHIoQWRkcmVzcyhyZWdUMywgQ29kZUJsb2Nr OjpvZmZzZXRPZk1ldGFkYXRhVGFibGUoKSksIHJlZ1QzKTsKLSAgICBqaXQuYWRkUHRyKHJlZ1Qz LCBtZXRhZGF0YUdQUik7CisgICAgaml0LmFkZFB0cihzX21ldGFkYXRhR1BSLCBtZXRhZGF0YUdQ Uik7CiAKICAgICBKdW1wTGlzdCBzbG93Q2FzZTsKIApAQCAtMjQxMSw5ICsyNDA5LDcgQEAgTWFj cm9Bc3NlbWJsZXJDb2RlUmVmPEpJVFRodW5rUHRyVGFnPiBKSQogCiAgICAgaml0LnRhZ1JldHVy bkFkZHJlc3MoKTsKIAotICAgIGppdC5sb2FkUHRyKGFkZHJlc3NGb3IoQ2FsbEZyYW1lU2xvdDo6 Y29kZUJsb2NrKSwgcmVnVDMpOwotICAgIGppdC5sb2FkUHRyKEFkZHJlc3MocmVnVDMsIENvZGVC bG9jazo6b2Zmc2V0T2ZNZXRhZGF0YVRhYmxlKCkpLCByZWdUMyk7Ci0gICAgaml0LmFkZFB0cihy ZWdUMywgbWV0YWRhdGFHUFIpOworICAgIGppdC5hZGRQdHIoc19tZXRhZGF0YUdQUiwgbWV0YWRh dGFHUFIpOwogCiAgICAgSnVtcExpc3Qgc2xvd0Nhc2U7CiAK 441613 2021-10-18 09:17:29 -0700 2021-10-18 13:41:58 -0700 patch for landing c-backup.diff text/plain 3575 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjg0MzAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDIxLTEwLTE1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IERvbid0IGxvYWQgbWV0YWRhdGEgYmFzZSBwb2ludGVyIGluIEVYVFJBX0NUSV9USFVOS1MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTg1MAorCisg ICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAgICAgV2Ugd2VyZSBsb2Fk aW5nIHRoZSBtZXRhZGF0YSB0YWJsZSBiYXNlIHBvaW50ZXIgZHluYW1pY2FsbHkuIEJ1dCBpbgor ICAgICAgICB1bmxpbmtlZCBiYXNlbGluZSBKSVQsIGl0J3MgYWxyZWFkeSBwaW5uZWQgaW4gYSBy ZWdpc3Rlci4gTGV0J3MganVzdAorICAgICAgICB1c2UgdGhlIHJlZ2lzdGVyIGluc3RlYWQgb2Yg cmVjb21wdXRpbmcgd2hhdCdzIGFscmVhZHkgdGhlcmUuIFRoaXMgaXMKKyAgICAgICAgYSBzbWFs bCBzcGVlZHVwIGluIHRocm91Z2hwdXQgb2YgdW5saW5rZWQgYmFzZWxpbmUgSklUIGNvZGUgZm9y IHNjb3BlCisgICAgICAgIG9wZXJhdGlvbnMuCisKKyAgICAgICAgKiBqaXQvSklUUHJvcGVydHlB Y2Nlc3MuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmdlbmVyYXRlT3BSZXNvbHZlU2NvcGVUaHVu ayk6CisgICAgICAgIChKU0M6OkpJVDo6Z2VuZXJhdGVPcEdldEZyb21TY29wZVRodW5rKToKKwog MjAyMS0xMC0xNSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAg ICAgICAgUmVhbGl6ZSBNYWMgQ01ha2UgYnVpbGQgb2YgV2ViQ29yZSBhbmQgV2ViS2l0CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcAko cmV2aXNpb24gMjg0MzAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0 eUFjY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5NjEsMTQgKzE5NjEsMTUgQEAgdm9pZCBK SVQ6OmVtaXRfb3BfcmVzb2x2ZV9zY29wZShjb25zdCBJbgogICAgIGlmIChwcm9maWxlZFJlc29s dmVUeXBlID09IE1vZHVsZVZhcikgCiAgICAgICAgIGxvYWRQdHJGcm9tTWV0YWRhdGEoYnl0ZWNv ZGUsIE9wUmVzb2x2ZVNjb3BlOjpNZXRhZGF0YTo6b2Zmc2V0T2ZMZXhpY2FsRW52aXJvbm1lbnQo KSwgcmVnVDApOwogICAgIGVsc2UgewotICAgICAgICBwdHJkaWZmX3QgbWV0YWRhdGFPZmZzZXQg PSBtX3VubGlua2VkQ29kZUJsb2NrLT5tZXRhZGF0YSgpLm9mZnNldEluTWV0YWRhdGFUYWJsZShi eXRlY29kZSk7CisgICAgICAgIHVpbnQzMl90IG1ldGFkYXRhT2Zmc2V0ID0gbV91bmxpbmtlZENv ZGVCbG9jay0+bWV0YWRhdGEoKS5vZmZzZXRJbk1ldGFkYXRhVGFibGUoYnl0ZWNvZGUpOwogCiAg ICAgICAgIGNvbnN0ZXhwciBHUFJSZWcgbWV0YWRhdGFHUFIgPSByZWdUMjsKICAgICAgICAgY29u c3RleHByIEdQUlJlZyBzY29wZUdQUiA9IHJlZ1QwOwogICAgICAgICBjb25zdGV4cHIgR1BSUmVn IGJ5dGVjb2RlT2Zmc2V0R1BSID0gcmVnVDU7CiAKICAgICAgICAgZW1pdEdldFZpcnR1YWxSZWdp c3RlcihzY29wZSwgc2NvcGVHUFIpOwotICAgICAgICBtb3ZlKFRydXN0ZWRJbW1QdHIobWV0YWRh dGFPZmZzZXQpLCBtZXRhZGF0YUdQUik7CisgICAgICAgIGFkZFB0cihUcnVzdGVkSW1tMzIobWV0 YWRhdGFPZmZzZXQpLCBzX21ldGFkYXRhR1BSLCBtZXRhZGF0YUdQUik7CisKICAgICAgICAgbW92 ZShUcnVzdGVkSW1tMzIoYnl0ZWNvZGVPZmZzZXQpLCBieXRlY29kZU9mZnNldEdQUik7CiAKICAg ICAgICAgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmPEpJVFRodW5rUHRyVGFnPiBjb2RlOwpAQCAtMjAx NSwxMCArMjAxNiw2IEBAIE1hY3JvQXNzZW1ibGVyQ29kZVJlZjxKSVRUaHVua1B0clRhZz4gSkkK IAogICAgIGppdC50YWdSZXR1cm5BZGRyZXNzKCk7CiAKLSAgICBqaXQubG9hZFB0cihhZGRyZXNz Rm9yKENhbGxGcmFtZVNsb3Q6OmNvZGVCbG9jayksIHJlZ1QzKTsKLSAgICBqaXQubG9hZFB0cihB ZGRyZXNzKHJlZ1QzLCBDb2RlQmxvY2s6Om9mZnNldE9mTWV0YWRhdGFUYWJsZSgpKSwgcmVnVDMp OwotICAgIGppdC5hZGRQdHIocmVnVDMsIG1ldGFkYXRhR1BSKTsKLQogICAgIEp1bXBMaXN0IHNs b3dDYXNlOwogCiAgICAgYXV0byBkb1ZhckluamVjdGlvbkNoZWNrID0gWyZdIChib29sIG5lZWRz VmFySW5qZWN0aW9uQ2hlY2tzLCBHUFJSZWcgZ2xvYmFsT2JqZWN0R1BSID0gSW52YWxpZEdQUlJl ZykgewpAQCAtMjM2OCwxMCArMjM2NSwxMCBAQCB2b2lkIEpJVDo6ZW1pdF9vcF9nZXRfZnJvbV9z Y29wZShjb25zdCBJCiAgICAgY29uc3RleHByIEdQUlJlZyBzY29wZUdQUiA9IHJlZ1QyOwogICAg IGNvbnN0ZXhwciBHUFJSZWcgYnl0ZWNvZGVPZmZzZXRHUFIgPSByZWdUNTsKIAotICAgIHB0cmRp ZmZfdCBtZXRhZGF0YU9mZnNldCA9IG1fdW5saW5rZWRDb2RlQmxvY2stPm1ldGFkYXRhKCkub2Zm c2V0SW5NZXRhZGF0YVRhYmxlKGJ5dGVjb2RlKTsKKyAgICB1aW50MzJfdCBtZXRhZGF0YU9mZnNl dCA9IG1fdW5saW5rZWRDb2RlQmxvY2stPm1ldGFkYXRhKCkub2Zmc2V0SW5NZXRhZGF0YVRhYmxl KGJ5dGVjb2RlKTsKIAogICAgIGVtaXRHZXRWaXJ0dWFsUmVnaXN0ZXIoc2NvcGUsIHNjb3BlR1BS KTsKLSAgICBtb3ZlKFRydXN0ZWRJbW1QdHIobWV0YWRhdGFPZmZzZXQpLCBtZXRhZGF0YUdQUik7 CisgICAgYWRkUHRyKFRydXN0ZWRJbW0zMihtZXRhZGF0YU9mZnNldCksIHNfbWV0YWRhdGFHUFIs IG1ldGFkYXRhR1BSKTsKICAgICBtb3ZlKFRydXN0ZWRJbW0zMihieXRlY29kZU9mZnNldCksIGJ5 dGVjb2RlT2Zmc2V0R1BSKTsKIAogICAgIE1hY3JvQXNzZW1ibGVyQ29kZVJlZjxKSVRUaHVua1B0 clRhZz4gY29kZTsKQEAgLTI0MTEsMTAgKzI0MDgsNiBAQCBNYWNyb0Fzc2VtYmxlckNvZGVSZWY8 SklUVGh1bmtQdHJUYWc+IEpJCiAKICAgICBqaXQudGFnUmV0dXJuQWRkcmVzcygpOwogCi0gICAg aml0LmxvYWRQdHIoYWRkcmVzc0ZvcihDYWxsRnJhbWVTbG90Ojpjb2RlQmxvY2spLCByZWdUMyk7 Ci0gICAgaml0LmxvYWRQdHIoQWRkcmVzcyhyZWdUMywgQ29kZUJsb2NrOjpvZmZzZXRPZk1ldGFk YXRhVGFibGUoKSksIHJlZ1QzKTsKLSAgICBqaXQuYWRkUHRyKHJlZ1QzLCBtZXRhZGF0YUdQUik7 Ci0KICAgICBKdW1wTGlzdCBzbG93Q2FzZTsKIAogICAgIGF1dG8gZG9WYXJJbmplY3Rpb25DaGVj ayA9IFsmXSAoYm9vbCBuZWVkc1ZhckluamVjdGlvbkNoZWNrcykgewo=