<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>231846</bug_id>
          
          <creation_ts>2021-10-15 17:16:23 -0700</creation_ts>
          <short_desc>Integrate &quot;Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick&quot; from Google ANGLE</short_desc>
          <delta_ts>2022-02-10 16:42:18 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kyle Piddington">kpiddington</reporter>
          <assigned_to name="Kyle Piddington">kpiddington</assigned_to>
          <cc>dino</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gman</cc>
    
    <cc>kbr</cc>
    
    <cc>kkinnunen</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1805143</commentid>
    <comment_count>0</comment_count>
    <who name="Kyle Piddington">kpiddington</who>
    <bug_when>2021-10-15 17:16:23 -0700</bug_when>
    <thetext>Integrate &quot;Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick&quot; from Google ANGLE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1805146</commentid>
    <comment_count>1</comment_count>
      <attachid>441459</attachid>
    <who name="Kyle Piddington">kpiddington</who>
    <bug_when>2021-10-15 17:17:35 -0700</bug_when>
    <thetext>Created attachment 441459
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1805147</commentid>
    <comment_count>2</comment_count>
      <attachid>441460</attachid>
    <who name="Kyle Piddington">kpiddington</who>
    <bug_when>2021-10-15 17:18:49 -0700</bug_when>
    <thetext>Created attachment 441460
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1805150</commentid>
    <comment_count>3</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2021-10-15 17:20:06 -0700</bug_when>
    <thetext>Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1805154</commentid>
    <comment_count>4</comment_count>
      <attachid>441460</attachid>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2021-10-15 17:32:58 -0700</bug_when>
    <thetext>Comment on attachment 441460
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441460&amp;action=review

&gt; Source/ThirdParty/ANGLE/ChangeLog:3
&gt; +        Integrate &quot;Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick&quot; from Google ANGLE

Is this really a cherry-pick and merge of:

Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick
https://chromium-review.googlesource.com/3169438

? It looks different - the other one inserted a second entry in the attributeBindings map.

Also, could you reference the code review above either in the commit message or the bug?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1807970</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-10-22 17:17:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/84569850&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1830205</commentid>
    <comment_count>6</comment_count>
    <who name="Kyle Piddington">kpiddington</who>
    <bug_when>2022-01-12 10:46:36 -0800</bug_when>
    <thetext>Handled with part of previous ANGLE roll.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>441459</attachid>
            <date>2021-10-15 17:17:35 -0700</date>
            <delta_ts>2021-10-15 17:18:48 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-231846-20211015171735.patch</filename>
            <type>text/plain</type>
            <size>2233</size>
            <attacher name="Kyle Piddington">kpiddington</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0Mjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0
eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k
ZXggNWM0YzViMTM5MGNkNjdmMDUxYjlmYjYwMjdlMGM5MTJlZjU0OWQ2OS4uZjZkMGM3YmFhZGIx
ZTRhMDhhNDZmOGVmYjUxYzFkM2M1MzZkNTliZSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy
dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEwLTE1ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu
Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgSW50ZWdyYXRlICJNZXRhbCBEaXJlY3Q6IFRpbnlE
ZXB0aFN0ZW5jaWxXb3JrYXJvdW5kVGVzdC5EZXB0aFRleHR1cmVzU3RpY2siIGZyb20gR29vZ2xl
IEFOR0xFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y
MzE4NDYKKyAgICAgICAgPHJkYXI6L3Byb2JsZW0vODQxNjcxOTY+CisKKyAgICAgICAgQWRkIHN0
cmljdGVyIHN0cmluZy1tYXRjaGluZyBydWxlcyB0byBhdHRyaWJ1dGVzLCB3aGljaCBzaG91bGQg
Zml4IGZhbHNlIG1hdGNoZXMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2dsc2xhbmdfbXRs
X3V0aWxzLm1tOgorICAgICAgICAocng6Om10bDo6dXBkYXRlU2hhZGVyQXR0cmlidXRlcyk6CisK
IDIwMjEtMTAtMTQgIEt5bGUgUGlkZGluZ3RvbiAgPGtwaWRkaW5ndG9uQGFwcGxlLmNvbT4KIAog
ICAgICAgICBodHRwczovL3Rhbmtpb25saW5lLmNvbS9wbGF5LyBodG1sNSBlbmdpbmUgbm90IHdv
cmtpbmc6IGNyYXNoZXMuIChNZXRhbCBzaGFkZXIgbm90IHdvcmtpbmcpCmRpZmYgLS1naXQgYS9T
b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2ds
c2xhbmdfbXRsX3V0aWxzLm1tIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xF
L3JlbmRlcmVyL21ldGFsL210bF9nbHNsYW5nX210bF91dGlscy5tbQppbmRleCBmNjNiOGY4Y2M4
NDc0ZTBhYWM4OWNmMWU5ZWVkYzQ3N2I1Yzc3N2Y0Li41MjMxMWUyMjhhYTQwODU3NTMxMjkxMTNl
MjM3YjBjOGE5ZDgyMDM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMv
bGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2dsc2xhbmdfbXRsX3V0aWxzLm1tCisrKyBiL1Nv
dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfZ2xz
bGFuZ19tdGxfdXRpbHMubW0KQEAgLTE3MSwxNCArMTcxLDE0IEBAIHN0ZDo6c3RyaW5nIHVwZGF0
ZVNoYWRlckF0dHJpYnV0ZXMoc3RkOjpzdHJpbmcgc2hhZGVyU291cmNlSW4sIGNvbnN0IGdsOjpQ
cm9ncmFtCiAgICAgICAgICAgICBmb3IoaW50IGkgPSAwOyBpIDwgcmVnczsgaSsrKQogICAgICAg
ICAgICAgewogICAgICAgICAgICAgICAgIHN0cmVhbS5zdHIoIiIpOwotICAgICAgICAgICAgICAg
IHN0cmVhbSA8PCBhdHRyaWJ1dGUubmFtZSA8PCAiXyIgPDwgc3RkOjp0b19zdHJpbmcoaSkgPDwg
c2g6OmtVbmFzc2lnbmVkQXR0cmlidXRlU3RyaW5nOworICAgICAgICAgICAgICAgIHN0cmVhbSA8
PCAiIF91IiA8PCBhdHRyaWJ1dGUubmFtZSA8PCAiXyIgPDwgc3RkOjp0b19zdHJpbmcoaSkgPDwg
c2g6OmtVbmFzc2lnbmVkQXR0cmlidXRlU3RyaW5nOwogICAgICAgICAgICAgICAgIGF0dHJpYnV0
ZUJpbmRpbmdzLmluc2VydCh7c3RkOjpzdHJpbmcoc3RyZWFtLnN0cigpKSwgaSthdHRyaWJ1dGUu
bG9jYXRpb259KTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICBlbHNlCiAgICAg
ICAgIHsKICAgICAgICAgICAgIHN0cmVhbS5zdHIoIiIpOwotICAgICAgICAgICAgc3RyZWFtIDw8
IGF0dHJpYnV0ZS5uYW1lIDw8IHNoOjprVW5hc3NpZ25lZEF0dHJpYnV0ZVN0cmluZzsKKyAgICAg
ICAgICAgIHN0cmVhbSA8PCAiIF91IiA8PCBhdHRyaWJ1dGUubmFtZSA8PCBzaDo6a1VuYXNzaWdu
ZWRBdHRyaWJ1dGVTdHJpbmc7CiAgICAgICAgICAgICBhdHRyaWJ1dGVCaW5kaW5ncy5pbnNlcnQo
e3N0ZDo6c3RyaW5nKHN0cmVhbS5zdHIoKSksYXR0cmlidXRlLmxvY2F0aW9ufSk7CiAgICAgICAg
IH0KICAgICB9Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>441460</attachid>
            <date>2021-10-15 17:18:49 -0700</date>
            <delta_ts>2022-02-10 16:42:18 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-231846-20211015171848.patch</filename>
            <type>text/plain</type>
            <size>2281</size>
            <attacher name="Kyle Piddington">kpiddington</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0Mjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0
eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k
ZXggNWM0YzViMTM5MGNkNjdmMDUxYjlmYjYwMjdlMGM5MTJlZjU0OWQ2OS4uZjZkMGM3YmFhZGIx
ZTRhMDhhNDZmOGVmYjUxYzFkM2M1MzZkNTliZSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy
dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEwLTE1ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu
Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgSW50ZWdyYXRlICJNZXRhbCBEaXJlY3Q6IFRpbnlE
ZXB0aFN0ZW5jaWxXb3JrYXJvdW5kVGVzdC5EZXB0aFRleHR1cmVzU3RpY2siIGZyb20gR29vZ2xl
IEFOR0xFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y
MzE4NDYKKyAgICAgICAgPHJkYXI6L3Byb2JsZW0vODQxNjcxOTY+CisKKyAgICAgICAgQWRkIHN0
cmljdGVyIHN0cmluZy1tYXRjaGluZyBydWxlcyB0byBhdHRyaWJ1dGVzLCB3aGljaCBzaG91bGQg
Zml4IGZhbHNlIG1hdGNoZXMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2dsc2xhbmdfbXRs
X3V0aWxzLm1tOgorICAgICAgICAocng6Om10bDo6dXBkYXRlU2hhZGVyQXR0cmlidXRlcyk6CisK
IDIwMjEtMTAtMTQgIEt5bGUgUGlkZGluZ3RvbiAgPGtwaWRkaW5ndG9uQGFwcGxlLmNvbT4KIAog
ICAgICAgICBodHRwczovL3Rhbmtpb25saW5lLmNvbS9wbGF5LyBodG1sNSBlbmdpbmUgbm90IHdv
cmtpbmc6IGNyYXNoZXMuIChNZXRhbCBzaGFkZXIgbm90IHdvcmtpbmcpCmRpZmYgLS1naXQgYS9T
b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2ds
c2xhbmdfbXRsX3V0aWxzLm1tIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xF
L3JlbmRlcmVyL21ldGFsL210bF9nbHNsYW5nX210bF91dGlscy5tbQppbmRleCBmNjNiOGY4Y2M4
NDc0ZTBhYWM4OWNmMWU5ZWVkYzQ3N2I1Yzc3N2Y0Li4yNmVmZDViNDc1ZjExZTZhNjI4Y2ZiNGM2
ODlmYjE3NDRmYTE1MTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMv
bGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2dsc2xhbmdfbXRsX3V0aWxzLm1tCisrKyBiL1Nv
dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfZ2xz
bGFuZ19tdGxfdXRpbHMubW0KQEAgLTE3MSwxNCArMTcxLDE0IEBAIHN0ZDo6c3RyaW5nIHVwZGF0
ZVNoYWRlckF0dHJpYnV0ZXMoc3RkOjpzdHJpbmcgc2hhZGVyU291cmNlSW4sIGNvbnN0IGdsOjpQ
cm9ncmFtCiAgICAgICAgICAgICBmb3IoaW50IGkgPSAwOyBpIDwgcmVnczsgaSsrKQogICAgICAg
ICAgICAgewogICAgICAgICAgICAgICAgIHN0cmVhbS5zdHIoIiIpOwotICAgICAgICAgICAgICAg
IHN0cmVhbSA8PCBhdHRyaWJ1dGUubmFtZSA8PCAiXyIgPDwgc3RkOjp0b19zdHJpbmcoaSkgPDwg
c2g6OmtVbmFzc2lnbmVkQXR0cmlidXRlU3RyaW5nOworICAgICAgICAgICAgICAgIHN0cmVhbSA8
PCAiICIgPDwga1VzZXJEZWZpbmVkTmFtZVByZWZpeCA8PCBhdHRyaWJ1dGUubmFtZSA8PCAiXyIg
PDwgc3RkOjp0b19zdHJpbmcoaSkgPDwgc2g6OmtVbmFzc2lnbmVkQXR0cmlidXRlU3RyaW5nOwog
ICAgICAgICAgICAgICAgIGF0dHJpYnV0ZUJpbmRpbmdzLmluc2VydCh7c3RkOjpzdHJpbmcoc3Ry
ZWFtLnN0cigpKSwgaSthdHRyaWJ1dGUubG9jYXRpb259KTsKICAgICAgICAgICAgIH0KICAgICAg
ICAgfQogICAgICAgICBlbHNlCiAgICAgICAgIHsKICAgICAgICAgICAgIHN0cmVhbS5zdHIoIiIp
OwotICAgICAgICAgICAgc3RyZWFtIDw8IGF0dHJpYnV0ZS5uYW1lIDw8IHNoOjprVW5hc3NpZ25l
ZEF0dHJpYnV0ZVN0cmluZzsKKyAgICAgICAgICAgIHN0cmVhbSA8PCAiICIgPDwga1VzZXJEZWZp
bmVkTmFtZVByZWZpeCA8PCBhdHRyaWJ1dGUubmFtZSA8PCBzaDo6a1VuYXNzaWduZWRBdHRyaWJ1
dGVTdHJpbmc7CiAgICAgICAgICAgICBhdHRyaWJ1dGVCaW5kaW5ncy5pbnNlcnQoe3N0ZDo6c3Ry
aW5nKHN0cmVhbS5zdHIoKSksYXR0cmlidXRlLmxvY2F0aW9ufSk7CiAgICAgICAgIH0KICAgICB9
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>