231842 2021-10-15 16:05:00 -0700 Rename some keyboard-scrolling-related functions on ScrollingEffectsController for clarity 2021-10-15 20:04:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bdakin simon.fraser webkit-bug-importer oldest_to_newest 1805097 0 simon.fraser 2021-10-15 16:05:00 -0700 Rename some keyboard-scrolling-related functions on ScrollingEffectsController for clarity 1805098 1 441447 simon.fraser 2021-10-15 16:06:06 -0700 Created attachment 441447 Patch 1805186 2 ews-feeder 2021-10-15 20:03:59 -0700 Committed r284302 (243100@main): <https://commits.webkit.org/243100@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441447. 1805187 3 webkit-bug-importer 2021-10-15 20:04:17 -0700 <rdar://problem/84326084> 441447 2021-10-15 16:06:06 -0700 2021-10-15 20:04:00 -0700 Patch bug-231842-20211015160605.patch text/plain 4970 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWRmNDA3MDc5NTFmZjFj NTAxNGFhZGUxMzRmNzFmOTkyYTc1MWVlOS4uYWZhN2Y0N2UwZWM5Yjg0ZTdiZTU4YzBmNzU2YzJm NTMzZDA3MGM0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIxLTEwLTE1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlbmFtZSBzb21l IGtleWJvYXJkLXNjcm9sbGluZy1yZWxhdGVkIGZ1bmN0aW9ucyBvbiBTY3JvbGxpbmdFZmZlY3Rz Q29udHJvbGxlciBmb3IgY2xhcml0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjMxODQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVuYW1lIGJlZ2luS2V5Ym9hcmRTY3JvbGxpbmcvc3RvcEtleWJvYXJk U2Nyb2xsaW5nIHRvIHdpbGxCZWdpbiBhbmQgZGlkU3RvcCB0byBtYWtlCisgICAgICAgIGl0IGNs ZWFyIHRoYXQgdGhleSBhcmUgcmVzcG9uZGluZyB0byBLZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9y IHN0YXRlIGNoYW5nZXMuCisKKyAgICAgICAgQWRkIHRoZSBpbXBlcmF0aXZlIFNjcm9sbGluZ0Vm ZmVjdHNDb250cm9sbGVyOjpzdG9wS2V5Ym9hcmRTY3JvbGxpbmcoKSB3aGljaCB3aWxsIGdldAor ICAgICAgICBob29rZWQgdXAgc29vbi4KKworICAgICAgICAqIHBsYXRmb3JtL0tleWJvYXJkU2Ny b2xsaW5nQW5pbWF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6S2V5Ym9hcmRTY3JvbGxpbmdB bmltYXRvcjo6dXBkYXRlS2V5Ym9hcmRTY3JvbGxQb3NpdGlvbik6CisgICAgICAgIChXZWJDb3Jl OjpLZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yOjpiZWdpbktleWJvYXJkU2Nyb2xsR2VzdHVyZSk6 CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsaW5nRWZmZWN0c0NvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nRWZmZWN0c0NvbnRyb2xsZXI6OndpbGxCZWdpbktleWJv YXJkU2Nyb2xsaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0VmZmVjdHNDb250cm9s bGVyOjpkaWRTdG9wS2V5Ym9hcmRTY3JvbGxpbmcpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xs aW5nRWZmZWN0c0NvbnRyb2xsZXI6OnN0b3BLZXlib2FyZFNjcm9sbGluZyk6CisgICAgICAgIChX ZWJDb3JlOjpTY3JvbGxpbmdFZmZlY3RzQ29udHJvbGxlcjo6YmVnaW5LZXlib2FyZFNjcm9sbGlu Zyk6IERlbGV0ZWQuCisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsaW5nRWZmZWN0c0NvbnRyb2xs ZXIuaDoKKwogMjAyMS0xMC0xNCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KIAogICAgICAgICBGdXJ0aGVyIGFkanVzdCBzdHlsZSBvZiBhbHRlcm5hdGUgZm9ybSBjb250 cm9sIGRlc2lnbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS2V5Ym9hcmRT Y3JvbGxpbmdBbmltYXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LZXlib2FyZFNj cm9sbGluZ0FuaW1hdG9yLmNwcAppbmRleCBjYWNkMDQzNDJlZDk1Y2JhYjI3MWM3NTI3NDY0Y2Fh OTRhNDNjNzAwLi5mYmRlYWZmZDJiYzRhMmY4ZDE3MjIwM2UxOTA5ZmNlOTdkMTk4NGYzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9y LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1h dG9yLmNwcApAQCAtMTQwLDcgKzE0MCw3IEBAIHZvaWQgS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRv cjo6dXBkYXRlS2V5Ym9hcmRTY3JvbGxQb3NpdGlvbihNb25vdG9uaWNUaW1lIGN1cnJlCiAgICAg bV9zY3JvbGxBbmltYXRvci5zY3JvbGxUb1Bvc2l0aW9uV2l0aG91dEFuaW1hdGlvbihuZXdQb3Np dGlvbik7CiAKICAgICBpZiAoIW1fc2Nyb2xsVHJpZ2dlcmluZ0tleUlzUHJlc3NlZCAmJiBtX3Zl bG9jaXR5LmRpYWdvbmFsTGVuZ3RoU3F1YXJlZCgpIDwgMSkgewotICAgICAgICBtX3Njcm9sbENv bnRyb2xsZXIuc3RvcEtleWJvYXJkU2Nyb2xsaW5nKCk7CisgICAgICAgIG1fc2Nyb2xsQ29udHJv bGxlci5kaWRTdG9wS2V5Ym9hcmRTY3JvbGxpbmcoKTsKICAgICAgICAgbV92ZWxvY2l0eSA9IHsg fTsKICAgICB9CiB9CkBAIC0yNzksNyArMjc5LDcgQEAgYm9vbCBLZXlib2FyZFNjcm9sbGluZ0Fu aW1hdG9yOjpiZWdpbktleWJvYXJkU2Nyb2xsR2VzdHVyZShjb25zdCBQbGF0Zm9ybUtleWJvYXIK ICAgICBtX3Njcm9sbFRyaWdnZXJpbmdLZXlJc1ByZXNzZWQgPSB0cnVlOwogCiAgICAgbV9pZGVh bFBvc2l0aW9uRm9yTWluaW11bVRyYXZlbCA9IG1fc2Nyb2xsQW5pbWF0b3IuY3VycmVudFBvc2l0 aW9uKCkgKyBtX2N1cnJlbnRLZXlib2FyZFNjcm9sbC0+b2Zmc2V0OwotICAgIG1fc2Nyb2xsQ29u dHJvbGxlci5iZWdpbktleWJvYXJkU2Nyb2xsaW5nKCk7CisgICAgbV9zY3JvbGxDb250cm9sbGVy LndpbGxCZWdpbktleWJvYXJkU2Nyb2xsaW5nKCk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGluZ0VmZmVjdHNDb250cm9s bGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGluZ0VmZmVjdHNDb250cm9s bGVyLmNwcAppbmRleCAzNmFjZDQ2MWZlZWUwNmEwNmI5YWU1N2MwNmNmODgwZmIzOTFhNDQ5Li4w OTQ0MWM0MGFkMDNiNTkyNjgxMWRhY2UzMGZlNzk3ZmZmMTQ2MjQ4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxpbmdFZmZlY3RzQ29udHJvbGxlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsaW5nRWZmZWN0c0NvbnRyb2xsZXIuY3BwCkBA IC04NCwxMiArODQsMTIgQEAgdm9pZCBTY3JvbGxpbmdFZmZlY3RzQ29udHJvbGxlcjo6c3RhcnRP clN0b3BBbmltYXRpb25DYWxsYmFja3MoKQogICAgIG1faXNSdW5uaW5nQW5pbWF0aW5nQ2FsbGJh Y2sgPSBmYWxzZTsKIH0KIAotdm9pZCBTY3JvbGxpbmdFZmZlY3RzQ29udHJvbGxlcjo6YmVnaW5L ZXlib2FyZFNjcm9sbGluZygpCit2b2lkIFNjcm9sbGluZ0VmZmVjdHNDb250cm9sbGVyOjp3aWxs QmVnaW5LZXlib2FyZFNjcm9sbGluZygpCiB7CiAgICAgc2V0SXNBbmltYXRpbmdLZXlib2FyZFNj cm9sbGluZyh0cnVlKTsKIH0KIAotdm9pZCBTY3JvbGxpbmdFZmZlY3RzQ29udHJvbGxlcjo6c3Rv cEtleWJvYXJkU2Nyb2xsaW5nKCkKK3ZvaWQgU2Nyb2xsaW5nRWZmZWN0c0NvbnRyb2xsZXI6OmRp ZFN0b3BLZXlib2FyZFNjcm9sbGluZygpCiB7CiAgICAgc2V0SXNBbmltYXRpbmdLZXlib2FyZFNj cm9sbGluZyhmYWxzZSk7CiB9CkBAIC0xNjgsNiArMTY4LDE0IEBAIHZvaWQgU2Nyb2xsaW5nRWZm ZWN0c0NvbnRyb2xsZXI6OnNldElzQW5pbWF0aW5nS2V5Ym9hcmRTY3JvbGxpbmcoYm9vbCBpc0Fu aW1hdGluCiAgICAgc3RhcnRPclN0b3BBbmltYXRpb25DYWxsYmFja3MoKTsKIH0KIAordm9pZCBT Y3JvbGxpbmdFZmZlY3RzQ29udHJvbGxlcjo6c3RvcEtleWJvYXJkU2Nyb2xsaW5nKCkKK3sKKyAg ICBpZiAoIW1faXNBbmltYXRpbmdLZXlib2FyZFNjcm9sbGluZykKKyAgICAgICAgcmV0dXJuOwor CisgICAgbV9jbGllbnQua2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvcigpLT5oYW5kbGVLZXlVcEV2 ZW50KCk7Cit9CisKIHZvaWQgU2Nyb2xsaW5nRWZmZWN0c0NvbnRyb2xsZXI6OmNvbnRlbnRzU2l6 ZUNoYW5nZWQoKQogewogICAgIGlmIChtX2N1cnJlbnRBbmltYXRpb24pCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxpbmdFZmZlY3RzQ29udHJvbGxlci5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsaW5nRWZmZWN0c0NvbnRyb2xsZXIuaAppbmRleCA3 YzM3MDMxMjNiYTZkNGM2ZTM3NWFhNmU1NDdlMDU3NDdkZGVhM2FjLi41MGVmY2I3ODE0MzY1NzI4 MDI3ZjRhOTg1OWI4ODJiZGNiMmU0M2YxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9TY3JvbGxpbmdFZmZlY3RzQ29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL1Njcm9sbGluZ0VmZmVjdHNDb250cm9sbGVyLmgKQEAgLTEzNywxMCArMTM3LDEyIEBA IHB1YmxpYzoKICAgICBib29sIHJldGFyZ2V0QW5pbWF0ZWRTY3JvbGwoRmxvYXRQb2ludCBuZXdE ZXN0aW5hdGlvbk9mZnNldCk7CiAgICAgdm9pZCBzdG9wQW5pbWF0ZWRTY3JvbGwoKTsKIAorICAg IHZvaWQgc3RvcEtleWJvYXJkU2Nyb2xsaW5nKCk7CisKICAgICBib29sIHN0YXJ0TW9tZW50dW1T Y3JvbGxXaXRoSW5pdGlhbFZlbG9jaXR5KGNvbnN0IEZsb2F0UG9pbnQmIGluaXRpYWxPZmZzZXQs IGNvbnN0IEZsb2F0U2l6ZSYgaW5pdGlhbFZlbG9jaXR5LCBjb25zdCBGbG9hdFNpemUmIGluaXRp YWxEZWx0YSwgY29uc3QgV1RGOjpGdW5jdGlvbjxGbG9hdFBvaW50KGNvbnN0IEZsb2F0UG9pbnQm KT4mIGRlc3RpbmF0aW9uTW9kaWZpZXIpOwogCi0gICAgdm9pZCBiZWdpbktleWJvYXJkU2Nyb2xs aW5nKCk7Ci0gICAgdm9pZCBzdG9wS2V5Ym9hcmRTY3JvbGxpbmcoKTsKKyAgICB2b2lkIHdpbGxC ZWdpbktleWJvYXJkU2Nyb2xsaW5nKCk7CisgICAgdm9pZCBkaWRTdG9wS2V5Ym9hcmRTY3JvbGxp bmcoKTsKICAgICAKICAgICAvLyBTaG91bGQgYmUgY2FsbGVkIHBlcmlvZGljYWxseSBieSB0aGUg Y2xpZW50LiBTdGFydGVkIGJ5IHN0YXJ0QW5pbWF0aW9uQ2FsbGJhY2soKSwgc3RvcHBlZCBieSBz dG9wQW5pbWF0aW9uQ2FsbGJhY2soKS4KICAgICB2b2lkIGFuaW1hdGlvbkNhbGxiYWNrKE1vbm90 b25pY1RpbWUpOwo=