231832 2021-10-15 14:21:35 -0700 Make sure child layers of top layer elements are rendered and correctly z-ordered (top-layer-stacking.html fails) 2021-10-16 03:35:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 84635 1 ntim simon.fraser bfulgham changseok esprehn+autocc ews-watchlist fred.wang glenn graouts kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1805010 0 ntim 2021-10-15 14:21:35 -0700 I suspect something is wrong in RenderLayer::rebuildZOrderLists 1805011 1 webkit-bug-importer 2021-10-15 14:21:44 -0700 <rdar://problem/84316561> 1805149 2 441461 ntim 2021-10-15 17:20:03 -0700 Created attachment 441461 Patch 1805152 3 441461 simon.fraser 2021-10-15 17:30:10 -0700 Comment on attachment 441461 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441461&action=review I think the real bug here is that RenderLayer::collectLayers() just early returns when establishesTopLayer() is true, so top layer layers never get any children. > Source/WebCore/rendering/RenderLayer.cpp:768 > + collectLayersForChildren(includeHiddenLayers, false, posZOrderList, negZOrderList, accumulatedDirtyFlags); This is called the "boolean trap": a true/false argument that is hard to understand here at the call site. We generally avoid this by using enums. > Source/WebCore/rendering/RenderLayer.cpp:803 > + auto startOfSorting = posZOrderList->end(); > + layer->collectLayersForChildren(includeHiddenLayers, true, posZOrderList, negZOrderList, accumulatedDirtyFlags); > + std::stable_sort(startOfSorting, posZOrderList->end(), compareZIndex); I don't think this is right. This will append all descendant layers to 'posZOrderList' but what needs to happen is that 'layer' here, which is a stacking context, builds its own positive and negative z-order lists. > Source/WebCore/rendering/RenderLayer.cpp:827 > + auto& layerList = (zIndex() >= 0 || hasTopLayerAncestor) ? positiveZOrderList : negativeZOrderList; Here all descendants of top layer layers append to the positiveZOrderList but this is wrong. 1805174 4 441466 simon.fraser 2021-10-15 18:35:06 -0700 Created attachment 441466 Patch 1805246 5 ews-feeder 2021-10-16 03:35:27 -0700 Committed r284314 (243110@main): <https://commits.webkit.org/243110@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441466. 441461 2021-10-15 17:20:03 -0700 2021-10-15 18:35:03 -0700 Patch bug-231832-20211016022002.patch text/plain 6728 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZhYWRjN2EzYzdmMGYx YzQyZDU0YzkzOTdhMWY5MWQxMjBkY2M3NS4uZmYyOThjMGYyNDFkNmVlMjUyZWFmMWJjZWFhNTYw ZjVmNzIwZjM4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTEwLTE1ICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuZGVyIGNoaWxkIGxheWVycyBv ZiB0b3AgbGF5ZXIgZWxlbWVudHMgYW5kIHNvcnQgdGhlbSBpbiB6LWluZGV4IG9yZGVyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE4MzIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2ludGVyYWN0aXZlLWVsZW1l bnRzL3RoZS1kaWFsb2ctZWxlbWVudC90b3AtbGF5ZXItc3RhY2tpbmcuaHRtbAorCisgICAgICAg IFRoZSB0ZXN0IGRvZXNuJ3QgcGFzcyByaWdodCBub3csIHNpbmNlIGl0IHJlbGllcyBvbiB0b3Ag bGF5ZXIgZWxlbWVudHMgaGF2aW5nIHRoZSBjb3JyZWN0IGNvbnRhaW5pbmcgYmxvY2suCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyTGF5ZXI6OnJlYnVpbGRaT3JkZXJMaXN0cyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJM YXllcjo6Y29sbGVjdExheWVyc0ZvckNoaWxkcmVuKTogQWRkZWQuCisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJMYXllcjo6Y29sbGVjdExheWVycyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckxheWVyLmg6CisKIDIwMjEtMTAtMTUgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI3NjM3MCk6IEVsZW1lbnRzIHdpdGggYW5p bWF0ZWQgdHJhbnNmb3JtIHByb3BlcnR5IG1pZ2h0IG5vdCBwcm9wZXJseSByZW5kZXJlZApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggMDJjNWMxNWNmNjg3ODE5 MGM1YTJlMjIyODIyOTNjNGZlY2Q4YTgwYy4uNGM2NjRkMDI0OGVjM2YwZWYyOGI0NGY1ZDNkYzFk MTMzMDJiY2MwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBA IC03NjUsMTAgKzc2NSw3IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnJlYnVpbGRaT3JkZXJMaXN0cygp CiB2b2lkIFJlbmRlckxheWVyOjpyZWJ1aWxkWk9yZGVyTGlzdHMoc3RkOjp1bmlxdWVfcHRyPFZl Y3RvcjxSZW5kZXJMYXllcio+PiYgcG9zWk9yZGVyTGlzdCwgc3RkOjp1bmlxdWVfcHRyPFZlY3Rv cjxSZW5kZXJMYXllcio+PiYgbmVnWk9yZGVyTGlzdCwgT3B0aW9uU2V0PENvbXBvc2l0aW5nPiYg YWNjdW11bGF0ZWREaXJ0eUZsYWdzKQogewogICAgIGJvb2wgaW5jbHVkZUhpZGRlbkxheWVycyA9 IGNvbXBvc2l0b3IoKS51c2VzQ29tcG9zaXRpbmcoKTsKLSAgICBmb3IgKFJlbmRlckxheWVyKiBj aGlsZCA9IGZpcnN0Q2hpbGQoKTsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5nKCkp IHsKLSAgICAgICAgaWYgKCFpc1JlZmxlY3Rpb25MYXllcigqY2hpbGQpKQotICAgICAgICAgICAg Y2hpbGQtPmNvbGxlY3RMYXllcnMoaW5jbHVkZUhpZGRlbkxheWVycywgcG9zWk9yZGVyTGlzdCwg bmVnWk9yZGVyTGlzdCwgYWNjdW11bGF0ZWREaXJ0eUZsYWdzKTsKLSAgICB9CisgICAgY29sbGVj dExheWVyc0ZvckNoaWxkcmVuKGluY2x1ZGVIaWRkZW5MYXllcnMsIGZhbHNlLCBwb3NaT3JkZXJM aXN0LCBuZWdaT3JkZXJMaXN0LCBhY2N1bXVsYXRlZERpcnR5RmxhZ3MpOwogCiAgICAgYXV0byBj b21wYXJlWkluZGV4ID0gW10gKGNvbnN0IFJlbmRlckxheWVyKiBmaXJzdCwgY29uc3QgUmVuZGVy TGF5ZXIqIHNlY29uZCkgLT4gYm9vbCB7CiAgICAgICAgIHJldHVybiBmaXJzdC0+ekluZGV4KCkg PCBzZWNvbmQtPnpJbmRleCgpOwpAQCAtNzk5LDIzICs3OTYsMzUgQEAgdm9pZCBSZW5kZXJMYXll cjo6cmVidWlsZFpPcmRlckxpc3RzKHN0ZDo6dW5pcXVlX3B0cjxWZWN0b3I8UmVuZGVyTGF5ZXIq Pj4mIHBvc1oKICAgICAgICAgICAgIGlmIChyZW5kZXJlci0+aGFzTGF5ZXIoKSkgewogICAgICAg ICAgICAgICAgIFJlbmRlckxheWVyKiBsYXllciA9IGRvd25jYXN0PFJlbmRlckxheWVyTW9kZWxP YmplY3Q+KCpyZW5kZXJlcikubGF5ZXIoKTsKICAgICAgICAgICAgICAgICBwb3NaT3JkZXJMaXN0 LT5hcHBlbmQobGF5ZXIpOworCisgICAgICAgICAgICAgICAgLy8gQ29sbGVjdCBjaGlsZCBsYXll cnMgYW5kIHRha2UgaW4gYWNjb3VudCBjaGlsZCB6LWluZGV4IHZhbHVlcy4KKyAgICAgICAgICAg ICAgICBhdXRvIHN0YXJ0T2ZTb3J0aW5nID0gcG9zWk9yZGVyTGlzdC0+ZW5kKCk7CisgICAgICAg ICAgICAgICAgbGF5ZXItPmNvbGxlY3RMYXllcnNGb3JDaGlsZHJlbihpbmNsdWRlSGlkZGVuTGF5 ZXJzLCB0cnVlLCBwb3NaT3JkZXJMaXN0LCBuZWdaT3JkZXJMaXN0LCBhY2N1bXVsYXRlZERpcnR5 RmxhZ3MpOworICAgICAgICAgICAgICAgIHN0ZDo6c3RhYmxlX3NvcnQoc3RhcnRPZlNvcnRpbmcs IHBvc1pPcmRlckxpc3QtPmVuZCgpLCBjb21wYXJlWkluZGV4KTsKICAgICAgICAgICAgIH0KICAg ICAgICAgfQogICAgIH0KIH0KIAotdm9pZCBSZW5kZXJMYXllcjo6Y29sbGVjdExheWVycyhib29s IGluY2x1ZGVIaWRkZW5MYXllcnMsIHN0ZDo6dW5pcXVlX3B0cjxWZWN0b3I8UmVuZGVyTGF5ZXIq Pj4mIHBvc2l0aXZlWk9yZGVyTGlzdCwgc3RkOjp1bmlxdWVfcHRyPFZlY3RvcjxSZW5kZXJMYXll cio+PiYgbmVnYXRpdmVaT3JkZXJMaXN0LCBPcHRpb25TZXQ8Q29tcG9zaXRpbmc+JiBhY2N1bXVs YXRlZERpcnR5RmxhZ3MpCit2b2lkIFJlbmRlckxheWVyOjpjb2xsZWN0TGF5ZXJzRm9yQ2hpbGRy ZW4oYm9vbCBpbmNsdWRlSGlkZGVuTGF5ZXJzLCBib29sIGhhc1RvcExheWVyQW5jZXN0b3IsIHN0 ZDo6dW5pcXVlX3B0cjxWZWN0b3I8UmVuZGVyTGF5ZXIqPj4mIHBvc2l0aXZlWk9yZGVyTGlzdCwg c3RkOjp1bmlxdWVfcHRyPFZlY3RvcjxSZW5kZXJMYXllcio+PiYgbmVnYXRpdmVaT3JkZXJMaXN0 LCBPcHRpb25TZXQ8Q29tcG9zaXRpbmc+JiBhY2N1bXVsYXRlZERpcnR5RmxhZ3MpCiB7Ci0gICAg dXBkYXRlRGVzY2VuZGFudERlcGVuZGVudEZsYWdzKCk7CisgICAgZm9yIChSZW5kZXJMYXllciog Y2hpbGQgPSBmaXJzdENoaWxkKCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygp KSB7CisgICAgICAgIC8vIElnbm9yZSByZWZsZWN0aW9uIGxheWVycy4KKyAgICAgICAgLy8gSWdu b3JlIHRvcCBsYXllciBsYXllcnMgc2luY2UgdGhleSBhcmUgY29sbGVjdGVkIGJ5IHJlYnVpbGRa T3JkZXJMaXN0cy4KKyAgICAgICAgaWYgKCFpc1JlZmxlY3Rpb25MYXllcigqY2hpbGQpICYmICFj aGlsZC0+ZXN0YWJsaXNoZXNUb3BMYXllcigpKQorICAgICAgICAgICAgY2hpbGQtPmNvbGxlY3RM YXllcnMoaW5jbHVkZUhpZGRlbkxheWVycywgaGFzVG9wTGF5ZXJBbmNlc3RvciwgcG9zaXRpdmVa T3JkZXJMaXN0LCBuZWdhdGl2ZVpPcmRlckxpc3QsIGFjY3VtdWxhdGVkRGlydHlGbGFncyk7Cisg ICAgfQorfQogCi0gICAgaWYgKGVzdGFibGlzaGVzVG9wTGF5ZXIoKSkKLSAgICAgICAgcmV0dXJu Owordm9pZCBSZW5kZXJMYXllcjo6Y29sbGVjdExheWVycyhib29sIGluY2x1ZGVIaWRkZW5MYXll cnMsIGJvb2wgaGFzVG9wTGF5ZXJBbmNlc3Rvciwgc3RkOjp1bmlxdWVfcHRyPFZlY3RvcjxSZW5k ZXJMYXllcio+PiYgcG9zaXRpdmVaT3JkZXJMaXN0LCBzdGQ6OnVuaXF1ZV9wdHI8VmVjdG9yPFJl bmRlckxheWVyKj4+JiBuZWdhdGl2ZVpPcmRlckxpc3QsIE9wdGlvblNldDxDb21wb3NpdGluZz4m IGFjY3VtdWxhdGVkRGlydHlGbGFncykKK3sKKyAgICB1cGRhdGVEZXNjZW5kYW50RGVwZW5kZW50 RmxhZ3MoKTsKIAogICAgIGJvb2wgaXNTdGFja2luZyA9IGlzU3RhY2tpbmdDb250ZXh0KCk7CiAg ICAgLy8gT3ZlcmZsb3cgbGF5ZXJzIGFyZSBqdXN0IHBhaW50ZWQgYnkgdGhlaXIgZW5jbG9zaW5n IGxheWVycywgc28gdGhleSBkb24ndCBnZXQgcHV0IGluIHpvcmRlciBsaXN0cy4KICAgICBib29s IGluY2x1ZGVIaWRkZW5MYXllciA9IGluY2x1ZGVIaWRkZW5MYXllcnMgfHwgKG1faGFzVmlzaWJs ZUNvbnRlbnQgfHwgKG1faGFzVmlzaWJsZURlc2NlbmRhbnQgJiYgaXNTdGFja2luZykpOwogICAg IGlmIChpbmNsdWRlSGlkZGVuTGF5ZXIgJiYgIWlzTm9ybWFsRmxvd09ubHkoKSkgewotICAgICAg ICBhdXRvJiBsYXllckxpc3QgPSAoekluZGV4KCkgPj0gMCkgPyBwb3NpdGl2ZVpPcmRlckxpc3Qg OiBuZWdhdGl2ZVpPcmRlckxpc3Q7CisgICAgICAgIGF1dG8mIGxheWVyTGlzdCA9ICh6SW5kZXgo KSA+PSAwIHx8IGhhc1RvcExheWVyQW5jZXN0b3IpID8gcG9zaXRpdmVaT3JkZXJMaXN0IDogbmVn YXRpdmVaT3JkZXJMaXN0OwogICAgICAgICBpZiAoIWxheWVyTGlzdCkKICAgICAgICAgICAgIGxh eWVyTGlzdCA9IG1ha2VVbmlxdWU8VmVjdG9yPFJlbmRlckxheWVyKj4+KCk7CiAgICAgICAgIGxh eWVyTGlzdC0+YXBwZW5kKHRoaXMpOwpAQCAtODI1LDExICs4MzQsNyBAQCB2b2lkIFJlbmRlckxh eWVyOjpjb2xsZWN0TGF5ZXJzKGJvb2wgaW5jbHVkZUhpZGRlbkxheWVycywgc3RkOjp1bmlxdWVf cHRyPFZlY3RvcgogICAgIC8vIFJlY3VyIGludG8gb3VyIGNoaWxkcmVuIHRvIGNvbGxlY3QgbW9y ZSBsYXllcnMsIGJ1dCBvbmx5IGlmIHdlIGRvbid0IGVzdGFibGlzaAogICAgIC8vIGEgc3RhY2tp bmcgY29udGV4dC9jb250YWluZXIuCiAgICAgaWYgKChpbmNsdWRlSGlkZGVuTGF5ZXJzIHx8IG1f aGFzVmlzaWJsZURlc2NlbmRhbnQpICYmICFpc1N0YWNraW5nKSB7Ci0gICAgICAgIGZvciAoUmVu ZGVyTGF5ZXIqIGNoaWxkID0gZmlyc3RDaGlsZCgpOyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+bmV4 dFNpYmxpbmcoKSkgewotICAgICAgICAgICAgLy8gSWdub3JlIHJlZmxlY3Rpb25zLgotICAgICAg ICAgICAgaWYgKCFpc1JlZmxlY3Rpb25MYXllcigqY2hpbGQpKQotICAgICAgICAgICAgICAgIGNo aWxkLT5jb2xsZWN0TGF5ZXJzKGluY2x1ZGVIaWRkZW5MYXllcnMsIHBvc2l0aXZlWk9yZGVyTGlz dCwgbmVnYXRpdmVaT3JkZXJMaXN0LCBhY2N1bXVsYXRlZERpcnR5RmxhZ3MpOwotICAgICAgICB9 CisgICAgICAgIGNvbGxlY3RMYXllcnNGb3JDaGlsZHJlbihpbmNsdWRlSGlkZGVuTGF5ZXJzLCBo YXNUb3BMYXllckFuY2VzdG9yLCBwb3NpdGl2ZVpPcmRlckxpc3QsIG5lZ2F0aXZlWk9yZGVyTGlz dCwgYWNjdW11bGF0ZWREaXJ0eUZsYWdzKTsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyLmgKaW5kZXggMWJmMjJlNDJjMzUxODYxODc5ZWY1YWYwY2YxZWMwYjQ3 MTQ5YjVlYS4uZmQ5NmQzNGJjOTg0ZjU0MTZiZjg0YzZhNTFjYThjMDQ0Y2Q1ZmE3ZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTg4NSw3ICs4ODUsOCBAQCBwcml2 YXRlOgogICAgIHZvaWQgdXBkYXRlWk9yZGVyTGlzdHMoKTsKICAgICB2b2lkIHJlYnVpbGRaT3Jk ZXJMaXN0cygpOwogICAgIHZvaWQgcmVidWlsZFpPcmRlckxpc3RzKHN0ZDo6dW5pcXVlX3B0cjxW ZWN0b3I8UmVuZGVyTGF5ZXIqPj4mLCBzdGQ6OnVuaXF1ZV9wdHI8VmVjdG9yPFJlbmRlckxheWVy Kj4+JiwgT3B0aW9uU2V0PENvbXBvc2l0aW5nPiYpOwotICAgIHZvaWQgY29sbGVjdExheWVycyhi b29sIGluY2x1ZGVIaWRkZW5MYXllcnMsIHN0ZDo6dW5pcXVlX3B0cjxWZWN0b3I8UmVuZGVyTGF5 ZXIqPj4mLCBzdGQ6OnVuaXF1ZV9wdHI8VmVjdG9yPFJlbmRlckxheWVyKj4+JiwgT3B0aW9uU2V0 PENvbXBvc2l0aW5nPiYpOworICAgIHZvaWQgY29sbGVjdExheWVyc0ZvckNoaWxkcmVuKGJvb2wg aW5jbHVkZUhpZGRlbkxheWVycywgYm9vbCBoYXNUb3BMYXllckFuY2VzdG9yLCBzdGQ6OnVuaXF1 ZV9wdHI8VmVjdG9yPFJlbmRlckxheWVyKj4+Jiwgc3RkOjp1bmlxdWVfcHRyPFZlY3RvcjxSZW5k ZXJMYXllcio+PiYsIE9wdGlvblNldDxDb21wb3NpdGluZz4mKTsKKyAgICB2b2lkIGNvbGxlY3RM YXllcnMoYm9vbCBpbmNsdWRlSGlkZGVuTGF5ZXJzLCBib29sIGhhc1RvcExheWVyQW5jZXN0b3Is IHN0ZDo6dW5pcXVlX3B0cjxWZWN0b3I8UmVuZGVyTGF5ZXIqPj4mLCBzdGQ6OnVuaXF1ZV9wdHI8 VmVjdG9yPFJlbmRlckxheWVyKj4+JiwgT3B0aW9uU2V0PENvbXBvc2l0aW5nPiYpOwogICAgIHZv aWQgY2xlYXJaT3JkZXJMaXN0cygpOwogCiAgICAgdm9pZCB1cGRhdGVOb3JtYWxGbG93TGlzdCgp Owo= 441466 2021-10-15 18:35:06 -0700 2021-10-16 03:35:29 -0700 Patch bug-231832-20211015183505.patch text/plain 5759 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWRmNDA3MDc5NTFmZjFj NTAxNGFhZGUxMzRmNzFmOTkyYTc1MWVlOS4uZGMwZThjYWQzMGIyODJlYWZjODVjOTU4ZmIxZTdk ZjA0ZjZkNGU1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTEwLTE1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2Ugc3VyZSBj aGlsZCBsYXllcnMgb2YgdG9wIGxheWVyIGVsZW1lbnRzIGFyZSByZW5kZXJlZCBhbmQgY29ycmVj dGx5IHotb3JkZXJlZCAodG9wLWxheWVyLXN0YWNraW5nLmh0bWwgZmFpbHMpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE4MzIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRvcCBsYXllciBl bGVtZW50cyBzaG91bGQgY3JlYXRlIENTUyBzdGFja2luZyBjb250ZXh0LCBwZXIgaHR0cHM6Ly9m dWxsc2NyZWVuLnNwZWMud2hhdHdnLm9yZy8jcmVuZGVyaW5nCisKKyAgICAgICAgSSBkZWNpZGVk IHRvIGNhbGwgaXNJblRvcExheWVyT3JCYWNrZHJvcCgpIHR3aWNlIHRvIGF2b2lkIGNhbGxpbmcg aXQgZXZlcnkgdGltZSB0aGlzIGZ1bmN0aW9uCisgICAgICAgIGlzIGNhbGxlZC4gSXQncyBhIGNo ZWFwIGZ1bmN0aW9uLgorCisgICAgICAgIFRlc3Q6IGZhc3QvbGF5ZXJzL2RpYWxvZy1pcy1zdGFj a2luZy1jb250ZXh0Lmh0bWwKKworICAgICAgICAqIHN0eWxlL1N0eWxlQWRqdXN0ZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U3R5bGU6OkFkanVzdGVyOjphZGp1c3QgY29uc3QpOgorCiAyMDIx LTEwLTE0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAg IEZ1cnRoZXIgYWRqdXN0IHN0eWxlIG9mIGFsdGVybmF0ZSBmb3JtIGNvbnRyb2wgZGVzaWduCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZUFkanVzdGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3N0eWxlL1N0eWxlQWRqdXN0ZXIuY3BwCmluZGV4IDE1YTRiNzM5NTBmYTQ4MjY1 ZTc4ZjI5MjcyNTkwMzZmNzFiN2I2NzEuLmY1ZDQ3MDcwMjc2NzAzZGQ4OWU3Yjc3MmUxZmI1MDJj ZGM3Zjc4NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlQWRqdXN0ZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlQWRqdXN0ZXIuY3BwCkBAIC0zMTYs OCArMzE2LDcgQEAgdm9pZCBBZGp1c3Rlcjo6YWRqdXN0KFJlbmRlclN0eWxlJiBzdHlsZSwgY29u c3QgUmVuZGVyU3R5bGUqIHVzZXJBZ2VudEFwcGVhcmFuY2UKIAogICAgICAgICAvLyBUb3AgbGF5 ZXIgZWxlbWVudHMgYXJlIGFsd2F5cyBwb3NpdGlvbjogYWJzb2x1dGU7IHVubGVzcyB0aGUgcG9z aXRpb24gaXMgc2V0IHRvIGZpeGVkLgogICAgICAgICAvLyBodHRwczovL2Z1bGxzY3JlZW4uc3Bl Yy53aGF0d2cub3JnLyNuZXctc3RhY2tpbmctbGF5ZXIKLSAgICAgICAgYm9vbCBpc0luVG9wTGF5 ZXIgPSBpc0luVG9wTGF5ZXJPckJhY2tkcm9wKHN0eWxlLCBtX2VsZW1lbnQpOwotICAgICAgICBp ZiAoc3R5bGUucG9zaXRpb24oKSAhPSBQb3NpdGlvblR5cGU6OkFic29sdXRlICYmIHN0eWxlLnBv c2l0aW9uKCkgIT0gUG9zaXRpb25UeXBlOjpGaXhlZCAmJiBpc0luVG9wTGF5ZXIpCisgICAgICAg IGlmIChzdHlsZS5wb3NpdGlvbigpICE9IFBvc2l0aW9uVHlwZTo6QWJzb2x1dGUgJiYgc3R5bGUu cG9zaXRpb24oKSAhPSBQb3NpdGlvblR5cGU6OkZpeGVkICYmIGlzSW5Ub3BMYXllck9yQmFja2Ry b3Aoc3R5bGUsIG1fZWxlbWVudCkpCiAgICAgICAgICAgICBzdHlsZS5zZXRQb3NpdGlvbihQb3Np dGlvblR5cGU6OkFic29sdXRlKTsKIAogICAgICAgICAvLyBBYnNvbHV0ZS9maXhlZCBwb3NpdGlv bmVkIGVsZW1lbnRzLCBmbG9hdGluZyBlbGVtZW50cyBhbmQgdGhlIGRvY3VtZW50IGVsZW1lbnQg bmVlZCBibG9jay1saWtlIG91dHNpZGUgZGlzcGxheS4KQEAgLTM4Miw3ICszODEsOCBAQCB2b2lk IEFkanVzdGVyOjphZGp1c3QoUmVuZGVyU3R5bGUmIHN0eWxlLCBjb25zdCBSZW5kZXJTdHlsZSog dXNlckFnZW50QXBwZWFyYW5jZQogICAgICAgICAgICAgfHwgc3R5bGUuaGFzSXNvbGF0aW9uKCkK ICAgICAgICAgICAgIHx8IHN0eWxlLnBvc2l0aW9uKCkgPT0gUG9zaXRpb25UeXBlOjpTdGlja3kK ICAgICAgICAgICAgIHx8IHN0eWxlLnBvc2l0aW9uKCkgPT0gUG9zaXRpb25UeXBlOjpGaXhlZAot ICAgICAgICAgICAgfHwgc3R5bGUud2lsbENoYW5nZUNyZWF0ZXNTdGFja2luZ0NvbnRleHQoKSkK KyAgICAgICAgICAgIHx8IHN0eWxlLndpbGxDaGFuZ2VDcmVhdGVzU3RhY2tpbmdDb250ZXh0KCkK KyAgICAgICAgICAgIHx8IGlzSW5Ub3BMYXllck9yQmFja2Ryb3Aoc3R5bGUsIG1fZWxlbWVudCkp CiAgICAgICAgICAgICBzdHlsZS5zZXRVc2VkWkluZGV4KDApOwogICAgIH0KIApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDc1 MjIyY2RhMGNiZTg0YWYzNjVmMWM0YWNlODNiZWU5MTkzMjE4MTIuLmMzZWQ1N2M5OTNjZWU4MjJj Y2FkZWJlZDExMjU0ZDk1OWY4NGQzZmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMS0xMC0x NSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtl IHN1cmUgY2hpbGQgbGF5ZXJzIG9mIHRvcCBsYXllciBlbGVtZW50cyBhcmUgcmVuZGVyZWQgYW5k IGNvcnJlY3RseSB6LW9yZGVyZWQgKHRvcC1sYXllci1zdGFja2luZy5odG1sIGZhaWxzKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxODMyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVmIHRlc3QgdGhh dCBjb21wYXJlcyBhIGRpYWxvZyB3aXRoIHBvc2l0aW9uZWQgY2hpbGRyZW4gYW5kIG9uZSB3aXRo IGNoaWxkcmVuIHBsYWNlCisgICAgICAgIHdpdGggbWFyZ2lucy4KKworICAgICAgICAqIGZhc3Qv bGF5ZXJzL2RpYWxvZy1pcy1zdGFja2luZy1jb250ZXh0LWV4cGVjdGVkLmh0bWw6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvbGF5ZXJzL2RpYWxvZy1pcy1zdGFja2luZy1jb250ZXh0Lmh0bWw6IEFk ZGVkLgorCiAyMDIxLTEwLTE0ICBBeXVtaSBLb2ppbWEgIDxheXVtaV9rb2ppbWFAYXBwbGUuY29t PgogCiAgICAgICAgIFsgaU9TIEVXUyBdIGh0dHAvdGVzdHMvcHJpdmF0ZUNsaWNrTWVhc3VyZW1l bnQvYXR0cmlidXRpb24tY29udmVyc2lvbi10aHJvdWdoLWltYWdlLXJlZGlyZWN0LWVwaGVtZXJh bC5odG1sIGlzIGEgZmxha3kgY3Jhc2guCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2xh eWVycy9kaWFsb2ctaXMtc3RhY2tpbmctY29udGV4dC1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9sYXllcnMvZGlhbG9nLWlzLXN0YWNraW5nLWNvbnRleHQtZXhwZWN0ZWQuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi5kYzdhNjI0NGMwZWZkYmRlNTRlMzU2YzczNTE1MWY1MjI4YzQzZGQ4Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9sYXllcnMvZGlhbG9nLWlzLXN0YWNraW5n LWNvbnRleHQtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDM2IEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPGhlYWQ+CisgICAgPHN0eWxlPgorICAgICAgICBkaWFsb2cgeworICAgICAgICAg ICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgICAgICAgdG9wOiAxMHB4OworICAgICAgICAg ICAgbGVmdDogMTBweDsKKyAgICAgICAgICAgIHdpZHRoOiAzMDBweDsKKyAgICAgICAgICAgIGhl aWdodDogMjAwcHg7CisgICAgICAgIH0KKworICAgICAgICAuYm94IHsKKyAgICAgICAgICAgIG1h cmdpbjogLTIwMHB4IDA7CisgICAgICAgICAgICB3aWR0aDogMTAwcHg7CisgICAgICAgICAgICBo ZWlnaHQ6IDEwMHB4OworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CisgICAg ICAgIH0KKyAgICAgICAgCisgICAgICAgIC5uZWdhdGl2ZSB7CisgICAgICAgICAgICBtYXJnaW46 IDUwcHg7CisgICAgICAgICAgICB6LWluZGV4OiAtMTsKKyAgICAgICAgICAgIGJhY2tncm91bmQt Y29sb3I6IG9yYW5nZTsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4K KyAgICA8ZGlhbG9nIGlkPSJ0aGVEaWFsb2ciPgorICAgICAgICA8ZGl2IGNsYXNzPSJuZWdhdGl2 ZSBib3giPjwvZGl2PgorICAgICAgICA8ZGl2IGNsYXNzPSJib3giPjwvZGl2PgorICAgIDwvZGlh bG9nPgorPHNjcmlwdD4KKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGhlRGlhbG9nJyku c2hvd01vZGFsKCk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvbGF5ZXJzL2RpYWxvZy1pcy1zdGFja2luZy1jb250ZXh0Lmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2xheWVycy9kaWFsb2ctaXMtc3RhY2tpbmctY29udGV4dC5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLmJkYzZjNTE1YWYzOTk4YTA3NGE3MzNmMzMwOTQ5YjhlODk2ZTE4YzMKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xheWVycy9kaWFsb2ctaXMtc3RhY2tpbmct Y29udGV4dC5odG1sCkBAIC0wLDAgKzEsMzcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8 aGVhZD4KKyAgICA8c3R5bGU+CisgICAgICAgIGRpYWxvZyB7CisgICAgICAgICAgICBwb3NpdGlv bjogYWJzb2x1dGU7CisgICAgICAgICAgICB0b3A6IDEwcHg7CisgICAgICAgICAgICBsZWZ0OiAx MHB4OworICAgICAgICAgICAgd2lkdGg6IDMwMHB4OworICAgICAgICAgICAgaGVpZ2h0OiAyMDBw eDsKKyAgICAgICAgfQorCisgICAgICAgIC5ib3ggeworICAgICAgICAgICAgcG9zaXRpb246IGFi c29sdXRlOworICAgICAgICAgICAgei1pbmRleDogMDsKKyAgICAgICAgICAgIHdpZHRoOiAxMDBw eDsKKyAgICAgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWNv bG9yOiBncmVlbjsKKyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgLm5lZ2F0aXZlIHsKKyAg ICAgICAgICAgIG1hcmdpbjogNTBweDsKKyAgICAgICAgICAgIHotaW5kZXg6IC0xOworICAgICAg ICAgICAgYmFja2dyb3VuZC1jb2xvcjogb3JhbmdlOworICAgICAgICB9CisgICAgPC9zdHlsZT4K KzwvaGVhZD4KKzxib2R5PgorICAgIDxkaWFsb2cgaWQ9InRoZURpYWxvZyI+CisgICAgICAgIDxk aXYgY2xhc3M9ImJveCI+PC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9Im5lZ2F0aXZlIGJveCI+ PC9kaXY+CisgICAgPC9kaWFsb2c+Cis8c2NyaXB0PgorICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCd0aGVEaWFsb2cnKS5zaG93TW9kYWwoKTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s Pgo=