231830 2021-10-15 14:06:43 -0700 _WKRemoteWebInspectorViewController leaks an instance variable and should use a weak delegate 2021-10-16 20:59:01 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer bfulgham hi inspector-bugzilla-changes joepeck pangle webkit-bug-importer oldest_to_newest 1804999 0 ddkilzer 2021-10-15 14:06:43 -0700 _WKRemoteWebInspectorViewController leaks its instance variables and should use a weak delegate. Leaks found by clang static analyzer. 1805001 1 webkit-bug-importer 2021-10-15 14:07:02 -0700 <rdar://problem/84316056> 1805008 2 441426 ddkilzer 2021-10-15 14:16:05 -0700 Created attachment 441426 Patch v1 1805020 3 441426 ddkilzer 2021-10-15 14:27:36 -0700 Comment on attachment 441426 Patch v1 Oops, didn't see the implementation of -webView and -window. 1805022 4 441428 ddkilzer 2021-10-15 14:29:49 -0700 Created attachment 441428 Patch v2 1805344 5 441428 ddkilzer 2021-10-16 20:37:58 -0700 Comment on attachment 441428 Patch v2 Adding cq+ since api-gtk failures are unrelated. 1805347 6 ews-feeder 2021-10-16 20:58:59 -0700 Committed r284329 (243124@main): <https://commits.webkit.org/243124@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441428. 441426 2021-10-15 14:16:05 -0700 2021-10-15 14:27:36 -0700 Patch v1 bug-231830-20211015141604.patch text/plain 2921 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdkZTU3YjU2ODA2YjcwNmY4 NTQzMjQ2MjllOTA5MzQwOTk5YmQ5YWYuLmU0NGEwZDA2MzMzOTc4MGM3OWIwZmEwOWEyNWE4N2U1 MTUzMDIzZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTAtMTUgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBfV0tSZW1vdGVXZWJJbnNwZWN0 b3JWaWV3Q29udHJvbGxlciBsZWFrcyBpdHMgaW5zdGFuY2UgdmFyaWFibGVzIGFuZCBzaG91bGQg dXNlIGEgd2VhayBkZWxlZ2F0ZQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjMxODMw PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODQzMTYwNTY+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS1Jl bW90ZVdlYkluc3BlY3RvclZpZXdDb250cm9sbGVyLmg6CisgICAgICAgIC0gVXNlIGEgd2VhayBy ZWZlcmVuY2UgZm9yIHRoZSBkZWxlZ2F0ZS4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29h L19XS1JlbW90ZVdlYkluc3BlY3RvclZpZXdDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtfV0tS ZW1vdGVXZWJJbnNwZWN0b3JWaWV3Q29udHJvbGxlciBkZWFsbG9jXSk6IEFkZC4KKyAgICAgICAg LSBGaXggbGVha3MgYnkgcmVsZWFzaW5nIEBwcm9wZXJ0eSBpbnN0YW5jZSB2YXJpYWJsZXMuCisK IDIwMjEtMTAtMTUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBSRUdSRVNTSU9OIChyMjgyMjMwKTogV2ViS2l0OjpyZWdpc3RlclNjaGVkdWxlZEFjdGl2aXR5 SGFuZGxlcigpIGxlYWtzIGFuIHhwY19vYmplY3RfdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1JlbW90ZVdlYkluc3BlY3RvclZpZXdDb250cm9sbGVy LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLUmVtb3RlV2ViSW5zcGVj dG9yVmlld0NvbnRyb2xsZXIuaAppbmRleCBhNDc1MmM1MzRhN2MzMjU4OWNjYTNlZmNhNGIzMTg1 ZDYwY2QyYWFiLi44YTFhOGY1OTk0ZGFmZGNjYjdmMzJkYzU1MmUzZWRhZmIyOWI5OTY1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLUmVtb3RlV2ViSW5z cGVjdG9yVmlld0NvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Q29jb2EvX1dLUmVtb3RlV2ViSW5zcGVjdG9yVmlld0NvbnRyb2xsZXIuaApAQCAtNDAsNyArNDAs NyBAQCBOU19BU1NVTUVfTk9OTlVMTF9CRUdJTgogV0tfQ0xBU1NfQVZBSUxBQkxFKG1hY29zKDEw LjEyLjMpKQogQGludGVyZmFjZSBfV0tSZW1vdGVXZWJJbnNwZWN0b3JWaWV3Q29udHJvbGxlciA6 IE5TT2JqZWN0IDxfV0tJbnNwZWN0b3JFeHRlbnNpb25Ib3N0LCBfV0tJbnNwZWN0b3JJQkFjdGlv bnM+CiAKLUBwcm9wZXJ0eSAobm9uYXRvbWljLCBhc3NpZ24pIGlkIDxfV0tSZW1vdGVXZWJJbnNw ZWN0b3JWaWV3Q29udHJvbGxlckRlbGVnYXRlPiBkZWxlZ2F0ZTsKK0Bwcm9wZXJ0eSAobm9uYXRv bWljLCB3ZWFrKSBpZCA8X1dLUmVtb3RlV2ViSW5zcGVjdG9yVmlld0NvbnRyb2xsZXJEZWxlZ2F0 ZT4gZGVsZWdhdGU7CiAKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSwgcmV0YWluKSBO U1dpbmRvdyAqd2luZG93OwogQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5LCByZXRhaW4p IFdLV2ViVmlldyAqd2ViVmlldzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9Db2NvYS9fV0tSZW1vdGVXZWJJbnNwZWN0b3JWaWV3Q29udHJvbGxlci5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tSZW1vdGVXZWJJbnNwZWN0b3JWaWV3Q29u dHJvbGxlci5tbQppbmRleCAxMTRmNzQ5ZDQ2NjI0MzkzZmMyMWQxOThjMmEyOWM0OTk5ZGQ3ZTMw Li5hZDc1NzkyMTBkNzE0NTJiMDZiZjBmNzdkYTc0MzJlZDQ5MmJlZmJmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLUmVtb3RlV2ViSW5zcGVjdG9yVmll d0NvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19X S1JlbW90ZVdlYkluc3BlY3RvclZpZXdDb250cm9sbGVyLm1tCkBAIC0xLDUgKzEsNSBAQAogLyoK LSAqIENvcHlyaWdodCAoQykgMjAxNiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAyMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlk ZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTEwNSw2ICsxMDUsMTQgQEAgLSAo aW5zdGFuY2V0eXBlKWluaXRXaXRoQ29uZmlndXJhdGlvbjooX1dLSW5zcGVjdG9yQ29uZmlndXJh dGlvbiAqKWNvbmZpZ3VyYXRpb24KICAgICByZXR1cm4gc2VsZjsKIH0KIAorLSAodm9pZClkZWFs bG9jCit7CisgICAgW193aW5kb3cgcmVsZWFzZV07CisgICAgW193ZWJWaWV3IHJlbGVhc2VdOwor ICAgIFtfY29uZmlndXJhdGlvbiByZWxlYXNlXTsKKyAgICBbc3VwZXIgZGVhbGxvY107Cit9CisK IC0gKE5TV2luZG93ICopd2luZG93CiB7CiAgICAgcmV0dXJuIG1fcmVtb3RlSW5zcGVjdG9yUHJv eHktPndpbmRvdygpOwo= 441428 2021-10-15 14:29:49 -0700 2021-10-16 20:59:00 -0700 Patch v2 bug-231830-20211015142948.patch text/plain 2873 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdkZTU3YjU2ODA2YjcwNmY4 NTQzMjQ2MjllOTA5MzQwOTk5YmQ5YWYuLjhiNTc0ZDAxNjY2YWMyMTNlMjYzMzU2NTg5MTIwZDQy MWM2MTI4YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTAtMTUgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBfV0tSZW1vdGVXZWJJbnNwZWN0 b3JWaWV3Q29udHJvbGxlciBsZWFrcyBhbiBpbnN0YW5jZSB2YXJpYWJsZSBhbmQgc2hvdWxkIHVz ZSBhIHdlYWsgZGVsZWdhdGUKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIzMTgzMD4K KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg0MzE2MDU2PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tSZW1v dGVXZWJJbnNwZWN0b3JWaWV3Q29udHJvbGxlci5oOgorICAgICAgICAtIFVzZSBhIHdlYWsgcmVm ZXJlbmNlIGZvciB0aGUgZGVsZWdhdGUuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9f V0tSZW1vdGVXZWJJbnNwZWN0b3JWaWV3Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bX1dLUmVt b3RlV2ViSW5zcGVjdG9yVmlld0NvbnRyb2xsZXIgZGVhbGxvY10pOiBBZGQuCisgICAgICAgIC0g Rml4IGxlYWsgYnkgcmVsZWFzaW5nIF9jb25maWd1cmF0aW9uIGluc3RhbmNlIHZhcmlhYmxlLgor CiAyMDIxLTEwLTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTiAocjI4MjIzMCk6IFdlYktpdDo6cmVnaXN0ZXJTY2hlZHVsZWRBY3Rpdml0 eUhhbmRsZXIoKSBsZWFrcyBhbiB4cGNfb2JqZWN0X3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tSZW1vdGVXZWJJbnNwZWN0b3JWaWV3Q29udHJvbGxl ci5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1JlbW90ZVdlYkluc3Bl Y3RvclZpZXdDb250cm9sbGVyLmgKaW5kZXggYTQ3NTJjNTM0YTdjMzI1ODljY2EzZWZjYTRiMzE4 NWQ2MGNkMmFhYi4uOGExYThmNTk5NGRhZmRjY2I3ZjMyZGM1NTJlM2VkYWZiMjliOTk2NSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1JlbW90ZVdlYklu c3BlY3RvclZpZXdDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0NvY29hL19XS1JlbW90ZVdlYkluc3BlY3RvclZpZXdDb250cm9sbGVyLmgKQEAgLTQwLDcgKzQw LDcgQEAgTlNfQVNTVU1FX05PTk5VTExfQkVHSU4KIFdLX0NMQVNTX0FWQUlMQUJMRShtYWNvcygx MC4xMi4zKSkKIEBpbnRlcmZhY2UgX1dLUmVtb3RlV2ViSW5zcGVjdG9yVmlld0NvbnRyb2xsZXIg OiBOU09iamVjdCA8X1dLSW5zcGVjdG9yRXh0ZW5zaW9uSG9zdCwgX1dLSW5zcGVjdG9ySUJBY3Rp b25zPgogCi1AcHJvcGVydHkgKG5vbmF0b21pYywgYXNzaWduKSBpZCA8X1dLUmVtb3RlV2ViSW5z cGVjdG9yVmlld0NvbnRyb2xsZXJEZWxlZ2F0ZT4gZGVsZWdhdGU7CitAcHJvcGVydHkgKG5vbmF0 b21pYywgd2VhaykgaWQgPF9XS1JlbW90ZVdlYkluc3BlY3RvclZpZXdDb250cm9sbGVyRGVsZWdh dGU+IGRlbGVnYXRlOwogCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIHJldGFpbikg TlNXaW5kb3cgKndpbmRvdzsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSwgcmV0YWlu KSBXS1dlYlZpZXcgKndlYlZpZXc7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvX1dLUmVtb3RlV2ViSW5zcGVjdG9yVmlld0NvbnRyb2xsZXIubW0gYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLUmVtb3RlV2ViSW5zcGVjdG9yVmlld0Nv bnRyb2xsZXIubW0KaW5kZXggMTE0Zjc0OWQ0NjYyNDM5M2ZjMjFkMTk4YzJhMjljNDk5OWRkN2Uz MC4uZDEwNjkwNmVkMDNlNjAwZTAzODFiNWUyMmRjZDNkYjAxNmU5NTRlMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1JlbW90ZVdlYkluc3BlY3RvclZp ZXdDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9f V0tSZW1vdGVXZWJJbnNwZWN0b3JWaWV3Q29udHJvbGxlci5tbQpAQCAtMSw1ICsxLDUgQEAKIC8q Ci0gKiBDb3B5cmlnaHQgKEMpIDIwMTYgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgor ICogQ29weXJpZ2h0IChDKSAyMDE2LTIwMjEgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0xMDUsNiArMTA1LDEyIEBAIC0g KGluc3RhbmNldHlwZSlpbml0V2l0aENvbmZpZ3VyYXRpb246KF9XS0luc3BlY3RvckNvbmZpZ3Vy YXRpb24gKiljb25maWd1cmF0aW9uCiAgICAgcmV0dXJuIHNlbGY7CiB9CiAKKy0gKHZvaWQpZGVh bGxvYworeworICAgIFtfY29uZmlndXJhdGlvbiByZWxlYXNlXTsKKyAgICBbc3VwZXIgZGVhbGxv Y107Cit9CisKIC0gKE5TV2luZG93ICopd2luZG93CiB7CiAgICAgcmV0dXJuIG1fcmVtb3RlSW5z cGVjdG9yUHJveHktPndpbmRvdygpOwo=