231824 2021-10-15 11:44:15 -0700 Make submit to ews error messages readable 2021-10-15 12:22:05 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard rmorisset ryanhaddad webkit-bug-importer zalan oldest_to_newest 1804929 0 aakash_jain 2021-10-15 11:44:15 -0700 Submit to EWS button errors out in few conditions (e.g.: bug closed, obsolete patch, security bug without r? patch etc.). In such cases EWS Django app generates an error message. However the iframe doesn't render it properly and only first few words are easily readable, rest of the words are not in sight. Ideally we should fix the issue by ensuring that complete message is displayed. However, until we figure out how to do that, we should re-word the error messages so that most relevant information is in first few words. (Note that current workaround is to triple click on the message, copy it and paste it somewhere to see the complete message) 1804931 1 441409 aakash_jain 2021-10-15 11:45:44 -0700 Created attachment 441409 [fast-cq] Patch 1804949 2 ews-feeder 2021-10-15 12:13:38 -0700 Committed r284262 (243070@main): <https://commits.webkit.org/243070@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441409. 1804950 3 webkit-bug-importer 2021-10-15 12:14:16 -0700 <rdar://problem/84312080> 1804956 4 aakash_jain 2021-10-15 12:22:05 -0700 Deployed on production server, seems to be working as expected. 441409 2021-10-15 11:45:44 -0700 2021-10-15 12:13:39 -0700 [fast-cq] Patch bug-231824-20211015144543.patch text/plain 1892 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4NDI1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIxLTEwLTE1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBNYWtlIHN1Ym1pdCB0byBld3MgZXJyb3IgbWVzc2FnZXMgcmVhZGFibGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTgyNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ0lTdXBw b3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N1Ym1pdHRvZXdzLnB5OgorICAgICAgICAoU3VibWl0VG9F V1MucG9zdCk6CisKIDIwMjEtMTAtMTQgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5j b20+CiAKICAgICAgICAgVGVzdFdlYktpdEFQSS5Qcml2YXRlQ2xpY2tNZWFzdXJlbWVudC5GcmF1 ZFByZXZlbnRpb24gaXMgYSBjb25zdGFudCB0aW1lb3V0CkluZGV4OiBUb29scy9DSVN1cHBvcnQv ZXdzLWFwcC9ld3Mvdmlld3Mvc3VibWl0dG9ld3MucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lT dXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N1Ym1pdHRvZXdzLnB5CShyZXZpc2lvbiAyODQyNTcp CisrKyBUb29scy9DSVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3VibWl0dG9ld3MucHkJKHdv cmtpbmcgY29weSkKQEAgLTU4LDExICs1OCwxMSBAQCBjbGFzcyBTdWJtaXRUb0VXUyhWaWV3KToK IAogICAgICAgICByYyA9IEJ1Z3ppbGxhUGF0Y2hGZXRjaGVyKCkuZmV0Y2goW3BhdGNoX2lkXSkK ICAgICAgICAgaWYgcmMgPT0gRVJSX1VOQUJMRV9UT19GRVRDSF9QQVRDSDoKLSAgICAgICAgICAg IHJldHVybiBIdHRwUmVzcG9uc2UoJ0VXUyBpcyB1bmFibGUgdG8gYWNjZXNzIHBhdGNoIHt9LiBQ bGVhc2UgZW5zdXJlIHRoYXQgdGhpcyBwYXRjaCBpcyBwdWJsaWNseSBhY2Nlc3NpYmxlIG9yIGhh cyByPyBzZXQuJy5mb3JtYXQocGF0Y2hfaWQpKQorICAgICAgICAgICAgcmV0dXJuIEh0dHBSZXNw b25zZSgnU2V0IHI/IG9uIHBhdGNoLCBFV1MgaXMgY3VycmVudGx5IHVuYWJsZSB0byBhY2Nlc3Mg cGF0Y2gge30uJy5mb3JtYXQocGF0Y2hfaWQpKQogICAgICAgICBpZiByYyA9PSBFUlJfT0JTT0xF VEVfUEFUQ0g6Ci0gICAgICAgICAgICByZXR1cm4gSHR0cFJlc3BvbnNlKCdQYXRjaCB7fSBpcyBv YnNvbGV0ZSwgbm90IHN1Ym1pdHRpbmcgdG8gRVdTLicuZm9ybWF0KHBhdGNoX2lkKSkKKyAgICAg ICAgICAgIHJldHVybiBIdHRwUmVzcG9uc2UoJ09ic29sZXRlIFBhdGNoOiB7fSwgbm90IHN1Ym1p dHRpbmcgdG8gRVdTLicuZm9ybWF0KHBhdGNoX2lkKSkKICAgICAgICAgaWYgcmMgPT0gRVJSX0JV R19DTE9TRUQ6Ci0gICAgICAgICAgICByZXR1cm4gSHR0cFJlc3BvbnNlKCdCdWcgZm9yIHBhdGNo IHt9IGlzIGNsb3NlZCwgbm90IHN1Ym1pdHRpbmcgdG8gRVdTLicuZm9ybWF0KHBhdGNoX2lkKSkK KyAgICAgICAgICAgIHJldHVybiBIdHRwUmVzcG9uc2UoJ0Nsb3NlZCBCdWcgZm9yIHBhdGNoOiB7 fSwgbm90IHN1Ym1pdHRpbmcgdG8gRVdTLicuZm9ybWF0KHBhdGNoX2lkKSkKIAogICAgICAgICBp ZiByZXF1ZXN0LlBPU1QuZ2V0KCduZXh0X2FjdGlvbicpID09ICdyZXR1cm5fdG9fYnViYmxlcyc6 CiAgICAgICAgICAgICByZXR1cm4gcmVkaXJlY3QoJy9zdGF0dXMtYnViYmxlL3t9Jy5mb3JtYXQo cGF0Y2hfaWQpKQo=