23182 2009-01-08 08:17:30 -0800 [CURL] POST without body becomes GET 2009-01-09 19:48:36 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 adam.bergkvist webkit-unassigned oldest_to_newest 104872 0 adam.bergkvist 2009-01-08 08:17:30 -0800 When doing a POST using XMLHttpRequest and sending null or an empty string as body, the method is never set to POST in ResourceHandleManager::setupPOST() (WebCore/platform/network/curl/ResourceHandleManager.cpp). This will make the POST method test on http://www.mnot.net/javascript/xmlhttprequest/ fail since the method sent is GET. 104874 1 26523 adam.bergkvist 2009-01-08 08:49:04 -0800 Created attachment 26523 Makes sure method is always set to POST in setupPOST(). 105004 2 zecke 2009-01-08 23:52:23 -0800 The only thing that saddens me is this would have been caugh with the http tests in the LayoutTest directory but we do not run them... 105005 3 26523 zecke 2009-01-08 23:56:19 -0800 Comment on attachment 26523 Makes sure method is always set to POST in setupPOST(). > + if (!job->request().httpBody()) > + return; This does not look correct. An empty PUT will not be finished and the ResourceHandle will be leaked? Could you explain that? 105012 4 adam.bergkvist 2009-01-09 02:10:28 -0800 (In reply to comment #3) I'm not sure I follow.. Instead of creating a Vector that is never assigned in case of job->request().httpBody() being null and checking that it has zero elements before returning, I thought it would be better to just return directly. 105032 5 26523 zecke 2009-01-09 11:40:58 -0800 Comment on attachment 26523 Makes sure method is always set to POST in setupPOST(). You are right. 105103 6 zecke 2009-01-09 19:48:36 -0800 Landed in r39774. 26523 2009-01-08 08:49:04 -0800 2009-01-09 11:40:58 -0800 Makes sure method is always set to POST in setupPOST(). patch_23182 text/plain 2604 adam.bergkvist SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTcwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDEtMDggIEFkYW0gQmVyZ2t2aXN0IDxhZGFtLmJlcmdrdmlz dEBlcmljc3Nvbi5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW0NVUkxdIFBPU1Qgd2l0aG91dCBib2R5IGJlY29tZXMgR0VUCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE4MgorCisgICAgICAgIE1h a2Ugc3VyZSB0aGF0IG1ldGhvZCBpcyBhbHdheXMgc2V0IHRvIFBPU1QgZXZlbiB3aGVuIHRoZSBi b2R5IGlzCisgICAgICAgIGVtcHR5LiBDbGVhbmVkIHVwIGh0dHBCb2R5IG51bGwgY2hlY2suCisK KyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlTWFuYWdlcjo6c2V0dXBQT1NUKToK KwogMjAwOS0wMS0wOCAgSnVzdGluIE1jUGhlcnNvbiA8anVzdGluLm1jcGhlcnNvbkBub2tpYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdl ci5jcHAJKHJldmlzaW9uIDM5NzA3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwv UmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzY0LDEyICszNjQs MTQgQEAgdm9pZCBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OnNldHVwUFVUKFJlcwogdm9pZCBSZXNv dXJjZUhhbmRsZU1hbmFnZXI6OnNldHVwUE9TVChSZXNvdXJjZUhhbmRsZSogam9iLCBzdHJ1Y3Qg Y3VybF9zbGlzdCoqIGhlYWRlcnMpCiB7CiAgICAgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbCogZCA9 IGpvYi0+Z2V0SW50ZXJuYWwoKTsKLSAgICBWZWN0b3I8Rm9ybURhdGFFbGVtZW50PiBlbGVtZW50 czsKLSAgICAvLyBGaXggY3Jhc2ggd2hlbiBodHRwQm9keSBpcyBudWxsIChzZWUgYnVnICMxNjkw NikuCi0gICAgaWYgKGpvYi0+cmVxdWVzdCgpLmh0dHBCb2R5KCkpCi0gICAgICAgIGVsZW1lbnRz ID0gam9iLT5yZXF1ZXN0KCkuaHR0cEJvZHkoKS0+ZWxlbWVudHMoKTsKLSAgICBzaXplX3QgbnVt RWxlbWVudHMgPSBlbGVtZW50cy5zaXplKCk7CisgICAgY3VybF9lYXN5X3NldG9wdChkLT5tX2hh bmRsZSwgQ1VSTE9QVF9QT1NULCBUUlVFKTsKKyAgICBjdXJsX2Vhc3lfc2V0b3B0KGQtPm1faGFu ZGxlLCBDVVJMT1BUX1BPU1RGSUVMRFNJWkUsIDApOworCisgICAgaWYgKCFqb2ItPnJlcXVlc3Qo KS5odHRwQm9keSgpKQorICAgICAgICByZXR1cm47CiAKKyAgICBWZWN0b3I8Rm9ybURhdGFFbGVt ZW50PiBlbGVtZW50cyA9IGpvYi0+cmVxdWVzdCgpLmh0dHBCb2R5KCktPmVsZW1lbnRzKCk7Cisg ICAgc2l6ZV90IG51bUVsZW1lbnRzID0gZWxlbWVudHMuc2l6ZSgpOwogICAgIGlmICghbnVtRWxl bWVudHMpCiAgICAgICAgIHJldHVybjsKIApAQCAtMzc3LDcgKzM3OSw2IEBAIHZvaWQgUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyOjpzZXR1cFBPU1QoUmUKICAgICBpZiAobnVtRWxlbWVudHMgPT0gMSkg ewogICAgICAgICBqb2ItPnJlcXVlc3QoKS5odHRwQm9keSgpLT5mbGF0dGVuKGQtPm1fcG9zdEJ5 dGVzKTsKICAgICAgICAgaWYgKGQtPm1fcG9zdEJ5dGVzLnNpemUoKSAhPSAwKSB7Ci0gICAgICAg ICAgICBjdXJsX2Vhc3lfc2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BUX1BPU1QsIFRSVUUpOwog ICAgICAgICAgICAgY3VybF9lYXN5X3NldG9wdChkLT5tX2hhbmRsZSwgQ1VSTE9QVF9QT1NURklF TERTSVpFLCBkLT5tX3Bvc3RCeXRlcy5zaXplKCkpOwogICAgICAgICAgICAgY3VybF9lYXN5X3Nl dG9wdChkLT5tX2hhbmRsZSwgQ1VSTE9QVF9QT1NURklFTERTLCBkLT5tX3Bvc3RCeXRlcy5kYXRh KCkpOwogICAgICAgICB9CkBAIC00MjQsOCArNDI1LDYgQEAgdm9pZCBSZXNvdXJjZUhhbmRsZU1h bmFnZXI6OnNldHVwUE9TVChSZQogICAgICAgICAgICAgc2l6ZSArPSBlbGVtZW50c1tpXS5tX2Rh dGEuc2l6ZSgpOwogICAgIH0KIAotICAgIGN1cmxfZWFzeV9zZXRvcHQoZC0+bV9oYW5kbGUsIENV UkxPUFRfUE9TVCwgVFJVRSk7Ci0KICAgICAvLyBjVVJMIGd1ZXNzZXMgdGhhdCB3ZSB3YW50IGNo dW5rZWQgZW5jb2RpbmcgYXMgbG9uZyBhcyB3ZSBzcGVjaWZ5IHRoZSBoZWFkZXIKICAgICBpZiAo Y2h1bmtlZFRyYW5zZmVyKQogICAgICAgICAqaGVhZGVycyA9IGN1cmxfc2xpc3RfYXBwZW5kKCpo ZWFkZXJzLCAiVHJhbnNmZXItRW5jb2Rpbmc6IGNodW5rZWQiKTsK