231817 2021-10-15 10:34:57 -0700 REGRESSION (r282230): WebKit::registerScheduledActivityHandler() leaks an xpc_object_t 2021-10-15 12:20:47 -0700 1 1 1 Unclassified WebKit WebXR WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 231309 https://bugs.webkit.org/show_bug.cgi?id=231819 InRadar P2 Normal --- 230052 1 ddkilzer ddkilzer achristensen cdumez ews-watchlist jiewen_tan webkit-bug-importer wilander oldest_to_newest 1804893 0 ddkilzer 2021-10-15 10:34:57 -0700 WebKit::registerScheduledActivityHandler() leaks an xpc_object_t. Found by the clang static analyzer. Regressed here: Add PrivateClickMeasurement daemon <https://bugs.webkit.org/show_bug.cgi?id=230052> <https://trac.webkit.org/282230> 1804894 1 ddkilzer 2021-10-15 10:36:19 -0700 Fixed link: <https://trac.webkit.org/r282230> 1804896 2 webkit-bug-importer 2021-10-15 10:36:40 -0700 <rdar://problem/84307774> 1804897 3 441400 ddkilzer 2021-10-15 10:38:29 -0700 Created attachment 441400 Patch v1 1804942 4 441400 ddkilzer 2021-10-15 12:09:30 -0700 Comment on attachment 441400 Patch v1 Wrong patch! 1804944 5 441413 ddkilzer 2021-10-15 12:10:54 -0700 Created attachment 441413 Patch v2 1804947 6 441413 ddkilzer 2021-10-15 12:12:02 -0700 Comment on attachment 441413 Patch v2 Looks like I need to update. Maybe this was fixed already? 1804951 7 ddkilzer 2021-10-15 12:14:20 -0700 Fixed by Bug 231309 using adoptNS. ¯\_(ツ)_/¯ *** This bug has been marked as a duplicate of bug 231309 *** 1804955 8 ddkilzer 2021-10-15 12:20:47 -0700 (In reply to David Kilzer (:ddkilzer) from comment #7) > Fixed by Bug 231309 using adoptNS. ¯\_(ツ)_/¯ To be clear, adoptNS() should work fine with xpc_object_t in Cocoa source files. 441400 2021-10-15 10:38:29 -0700 2021-10-15 12:09:30 -0700 Patch v1 bug-231817-20211015103828.patch text/plain 2639 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVkZDdhMzExZTZlODFkM2Q5 NTE4NTJiZWYxOTRhN2IyMjg3YWZjNTcuLjY2NWRjZDczZmVkNjgyOWRlNzlkNmExZDM0MmJmNmI4 ODg0MDY3ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMTAtMTUgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXQ6OkxvY2FsQ29ubmVj dGlvbjo6Y3JlYXRlQ3JlZGVudGlhbFByaXZhdGVLZXkgbGVha3MgYW4gTlNNdXRhYmxlRGljdGlv bmFyeQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjMxODE0PgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vODQzMDcwNTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvTG9jYWxD b25uZWN0aW9uLm1tOgorICAgICAgICAoV2ViS2l0OjpMb2NhbENvbm5lY3Rpb246OmNyZWF0ZUNy ZWRlbnRpYWxQcml2YXRlS2V5IGNvbnN0KToKKyAgICAgICAgLSBVc2UgUmV0YWluUHRyPD4gYW5k IGFkb3B0TlMgdG8gZml4IHRoZSBsZWFrLgorCiAyMDIxLTEwLTE0ICBEYXZpZCBLaWx6ZXIgIDxk ZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlLWFmdGVyLW1vdmUgb2YgbV9zb2NrZXRz IGluIE5ldHdvcmtSVENQcm92aWRlcjo6Y2xvc2UoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvTG9jYWxDb25uZWN0aW9uLm1tIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvTG9jYWxDb25u ZWN0aW9uLm1tCmluZGV4IDM1OGYxMTZmYTU3YTM0Y2Q5MGFlYzNiNTA1OTU5MjE4NTVlYjFiOTcu LjU3OTc1NjI3ZjZiZmNmN2M4MzUzYTYzNjlmMjAyMmI0MzZkMjJkYmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsQ29ubmVj dGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9D b2NvYS9Mb2NhbENvbm5lY3Rpb24ubW0KQEAgLTE2Nyw3ICsxNjcsNyBAQCB2b2lkIExvY2FsQ29u bmVjdGlvbjo6dmVyaWZ5VXNlcihTZWNBY2Nlc3NDb250cm9sUmVmIGFjY2Vzc0NvbnRyb2wsIExB Q29udGV4dCAqYwogCiBSZXRhaW5QdHI8U2VjS2V5UmVmPiBMb2NhbENvbm5lY3Rpb246OmNyZWF0 ZUNyZWRlbnRpYWxQcml2YXRlS2V5KExBQ29udGV4dCAqY29udGV4dCwgU2VjQWNjZXNzQ29udHJv bFJlZiBhY2Nlc3NDb250cm9sUmVmLCBjb25zdCBTdHJpbmcmIHNlY0F0dHJMYWJlbCwgTlNEYXRh ICpzZWNBdHRyQXBwbGljYXRpb25UYWcpIGNvbnN0CiB7Ci0gICAgTlNEaWN0aW9uYXJ5ICpwcml2 YXRlS2V5QXR0cmlidXRlcyA9IEB7CisgICAgUmV0YWluUHRyIHByaXZhdGVLZXlBdHRyaWJ1dGVz ID0gQHsKICAgICAgICAgKGlkKWtTZWNBdHRyQWNjZXNzQ29udHJvbDogKGlkKWFjY2Vzc0NvbnRy b2xSZWYsCiAgICAgICAgIChpZClrU2VjQXR0cklzUGVybWFuZW50OiBAWUVTLAogICAgICAgICAo aWQpa1NlY0F0dHJBY2Nlc3NHcm91cDogKGlkKVN0cmluZyhMb2NhbEF1dGhlbnRpY2F0aW9yQWNj ZXNzR3JvdXApLApAQCAtMTc2LDE1ICsxNzYsMTUgQEAgUmV0YWluUHRyPFNlY0tleVJlZj4gTG9j YWxDb25uZWN0aW9uOjpjcmVhdGVDcmVkZW50aWFsUHJpdmF0ZUtleShMQUNvbnRleHQgKmNvbnQK ICAgICB9OwogCiAgICAgaWYgKGNvbnRleHQpIHsKLSAgICAgICAgcHJpdmF0ZUtleUF0dHJpYnV0 ZXMgPSBbcHJpdmF0ZUtleUF0dHJpYnV0ZXMgbXV0YWJsZUNvcHldOwotICAgICAgICAoKE5TTXV0 YWJsZURpY3Rpb25hcnkgKilwcml2YXRlS2V5QXR0cmlidXRlcylbKGlkKWtTZWNVc2VBdXRoZW50 aWNhdGlvbkNvbnRleHRdID0gY29udGV4dDsKKyAgICAgICAgcHJpdmF0ZUtleUF0dHJpYnV0ZXMg PSBhZG9wdE5TKFtwcml2YXRlS2V5QXR0cmlidXRlcyBtdXRhYmxlQ29weV0pOworICAgICAgICAo KE5TTXV0YWJsZURpY3Rpb25hcnkgKilwcml2YXRlS2V5QXR0cmlidXRlcy5nZXQoKSlbKGlkKWtT ZWNVc2VBdXRoZW50aWNhdGlvbkNvbnRleHRdID0gY29udGV4dDsKICAgICB9CiAKICAgICBOU0Rp Y3Rpb25hcnkgKmF0dHJpYnV0ZXMgPSBAewogICAgICAgICAoaWQpa1NlY0F0dHJUb2tlbklEOiAo aWQpa1NlY0F0dHJUb2tlbklEU2VjdXJlRW5jbGF2ZSwKICAgICAgICAgKGlkKWtTZWNBdHRyS2V5 VHlwZTogKGlkKWtTZWNBdHRyS2V5VHlwZUVDU0VDUHJpbWVSYW5kb20sCiAgICAgICAgIChpZClr U2VjQXR0cktleVNpemVJbkJpdHM6IEAyNTYsCi0gICAgICAgIChpZClrU2VjUHJpdmF0ZUtleUF0 dHJzOiBwcml2YXRlS2V5QXR0cmlidXRlcywKKyAgICAgICAgKGlkKWtTZWNQcml2YXRlS2V5QXR0 cnM6IHByaXZhdGVLZXlBdHRyaWJ1dGVzLmdldCgpLAogICAgIH07CiAKICAgICBMT0NBTF9DT05O RUNUSU9OX0FERElUSU9OUwo= 441413 2021-10-15 12:10:54 -0700 2021-10-15 12:12:02 -0700 Patch v2 bug-231817-20211015121053.patch text/plain 1986 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY2NWRjZDczZmVkNjgyOWRl NzlkNmExZDM0MmJmNmI4ODg0MDY3ZWQuLjdkZTU3YjU2ODA2YjcwNmY4NTQzMjQ2MjllOTA5MzQw OTk5YmQ5YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMTAtMTUgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjgyMjMw KTogV2ViS2l0OjpyZWdpc3RlclNjaGVkdWxlZEFjdGl2aXR5SGFuZGxlcigpIGxlYWtzIGFuIHhw Y19vYmplY3RfdAorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjMxODE3PgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vODQzMDc3NzQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9Db2NvYS9E YWVtb24vUENNRGFlbW9uRW50cnlQb2ludC5tbToKKyAgICAgICAgKFdlYktpdDo6cmVnaXN0ZXJT Y2hlZHVsZWRBY3Rpdml0eUhhbmRsZXIpOgorICAgICAgICAtIFVzZSBhZG9wdE9TT2JqZWN0KCkg dG8gZml4IHRoZSBsZWFrLgorCiAyMDIxLTEwLTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh cHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0OjpMb2NhbENvbm5lY3Rpb246OmNyZWF0ZUNyZWRl bnRpYWxQcml2YXRlS2V5IGxlYWtzIGFuIE5TTXV0YWJsZURpY3Rpb25hcnkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvRGFlbW9uL1BD TURhZW1vbkVudHJ5UG9pbnQubW0gYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRp bGl0aWVzL0NvY29hL0RhZW1vbi9QQ01EYWVtb25FbnRyeVBvaW50Lm1tCmluZGV4IGVkMjMwMDUz MzFiOTU4ZDVlNDYxMDY0OTg5ZjVhZDg1OTBiMGUzZGEuLjE3MzI1OGI3YjA1NDcyOTY2ZDA1MzYx MDM2NmJhN2MyNDNmZTNmN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0VudHJ5 UG9pbnRVdGlsaXRpZXMvQ29jb2EvRGFlbW9uL1BDTURhZW1vbkVudHJ5UG9pbnQubW0KKysrIGIv U291cmNlL1dlYktpdC9TaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9Db2NvYS9EYWVtb24vUENN RGFlbW9uRW50cnlQb2ludC5tbQpAQCAtMTEyLDExICsxMTIsMTEgQEAgc3RhdGljIHZvaWQgcmVn aXN0ZXJTY2hlZHVsZWRBY3Rpdml0eUhhbmRsZXIoKQogICAgIE5TTG9nKEAiUmVnaXN0ZXJpbmcg WFBDIGFjdGl2aXR5Iik7CiAgICAgeHBjX2FjdGl2aXR5X3JlZ2lzdGVyKCJjb20uYXBwbGUud2Vi a2l0LmFkYXR0cmlidXRpb25kLmFjdGl2aXR5IiwgWFBDX0FDVElWSVRZX0NIRUNLX0lOLCBeKHhw Y19hY3Rpdml0eV90IGFjdGl2aXR5KSB7CiAgICAgICAgIGlmICh4cGNfYWN0aXZpdHlfZ2V0X3N0 YXRlKGFjdGl2aXR5KSA9PSBYUENfQUNUSVZJVFlfU1RBVEVfQ0hFQ0tfSU4pIHsKLSAgICAgICAg ICAgIHhwY19vYmplY3RfdCBjcml0ZXJpYSA9IHhwY19hY3Rpdml0eV9jb3B5X2NyaXRlcmlhKGFj dGl2aXR5KTsKKyAgICAgICAgICAgIGF1dG8gY3JpdGVyaWEgPSBhZG9wdE9TT2JqZWN0KHhwY19h Y3Rpdml0eV9jb3B5X2NyaXRlcmlhKGFjdGl2aXR5KSk7CiAKICAgICAgICAgICAgIC8vIEZJWE1F OiBzZXQgdmFsdWVzIGhlcmUgdGhhdCBhbGlnbiB3aXRoIHZhbHVlcyBmcm9tIHRoZSBwbGlzdC4K IAotICAgICAgICAgICAgeHBjX2FjdGl2aXR5X3NldF9jcml0ZXJpYShhY3Rpdml0eSwgY3JpdGVy aWEpOworICAgICAgICAgICAgeHBjX2FjdGl2aXR5X3NldF9jcml0ZXJpYShhY3Rpdml0eSwgY3Jp dGVyaWEuZ2V0KCkpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAK