231807 2021-10-15 08:43:54 -0700 [iOS] Screen Sharing doesn't switch to AirPlay when <video> enters fullscreen mode 2021-10-15 17:00:17 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble eric.carlson ews-watchlist glenn peng.liu6 philipj sergio oldest_to_newest 1804828 0 jer.noble 2021-10-15 08:43:54 -0700 [iOS] Screen Sharing doesn't switch to AirPlay when <video> enters fullscreen mode 1804829 1 jer.noble 2021-10-15 08:45:11 -0700 <rdar://82995799> 1804833 2 441383 jer.noble 2021-10-15 08:55:11 -0700 Created attachment 441383 Patch 1804847 3 441383 peng.liu6 2021-10-15 09:24:45 -0700 Comment on attachment 441383 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441383&action=review > Source/WebKit/ChangeLog:10 > + <video> element is in fullscreen mode. However, the fullscreen state this code depends on Is this true for element fullscreen as well? 1804930 4 jer.noble 2021-10-15 11:45:41 -0700 (In reply to Peng Liu from comment #3) > Comment on attachment 441383 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441383&action=review > > > Source/WebKit/ChangeLog:10 > > + <video> element is in fullscreen mode. However, the fullscreen state this code depends on > > Is this true for element fullscreen as well? No, only for video fullscreen. 1804932 5 jer.noble 2021-10-15 11:47:01 -0700 (In reply to Jer Noble from comment #4) > (In reply to Peng Liu from comment #3) > > Comment on attachment 441383 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=441383&action=review > > > > > Source/WebKit/ChangeLog:10 > > > + <video> element is in fullscreen mode. However, the fullscreen state this code depends on > > > > Is this true for element fullscreen as well? > > No, only for video fullscreen. Oh, disregard, it's true for "standby mode" as well, so element fullscreen too. (Also fixed by this patch). 1805132 6 ews-feeder 2021-10-15 17:00:16 -0700 Committed r284294 (243092@main): <https://commits.webkit.org/243092@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441383. 441383 2021-10-15 08:55:11 -0700 2021-10-15 17:00:17 -0700 Patch bug-231807-20211015085510.patch text/plain 5835 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhlZTM0MWVhZDlhZWVkNmFk MmZiNDAyMWFjNjFlN2QwOWRiOGM4MDcuLmFjOGQzZTRhMzQ1YTQzZmQ4NDA5NTFhNDRhMzcxOGQ3 ZTYwZjkyOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMjEtMTAtMTUgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gU2NyZWVuIFNoYXJpbmcg ZG9lc24ndCBzd2l0Y2ggdG8gQWlyUGxheSB3aGVuIDx2aWRlbz4gZW50ZXJzIGZ1bGxzY3JlZW4g bW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMx ODA3CisgICAgICAgIDxyZGFyOi8vODI5OTU3OTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0IHdpbGwgYWxsb3cgQVZQbGF5ZXIgdG8gc3dp dGNoIHRvIEFpclBsYXkgVmlkZW8gbW9kZSBmcm9tIFNjcmVlbiBTaGFyaW5nIHdoZW4gYQorICAg ICAgICA8dmlkZW8+IGVsZW1lbnQgaXMgaW4gZnVsbHNjcmVlbiBtb2RlLiBIb3dldmVyLCB0aGUg ZnVsbHNjcmVlbiBzdGF0ZSB0aGlzIGNvZGUgZGVwZW5kcyBvbgorICAgICAgICBpcyBub3Qgc3Rv cmVkIGluIHRoZSBHUFUgcHJvY2Vzcy4KKworICAgICAgICBJbXBsZW1lbnQgUmVtb3RlTWVkaWFQ bGF5ZXJQcm94eTo6bWVkaWFQbGF5ZXJGdWxsc2NyZWVuTW9kZSgpCisgICAgICAgIGFuZCA6Om1l ZGlhUGxheWVySXNWaWRlb0Z1bGxzY3JlZW5TdGFuZGJ5KCkuCisKKyAgICAgICAgKiBHUFVQcm9j ZXNzL21lZGlhL1JlbW90ZU1lZGlhUGxheWVyUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpS ZW1vdGVNZWRpYVBsYXllclByb3h5OjpzZXRWaWRlb0Z1bGxzY3JlZW5Nb2RlKToKKyAgICAgICAg KFdlYktpdDo6UmVtb3RlTWVkaWFQbGF5ZXJQcm94eTo6dmlkZW9GdWxsc2NyZWVuU3RhbmRieUNo YW5nZWQpOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVNZWRpYVBsYXllclByb3h5OjptZWRpYVBs YXllckZ1bGxzY3JlZW5Nb2RlIGNvbnN0KToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTWVkaWFQ bGF5ZXJQcm94eTo6bWVkaWFQbGF5ZXJJc1ZpZGVvRnVsbHNjcmVlblN0YW5kYnkgY29uc3QpOgor ICAgICAgICAqIEdQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJQcm94eS5oOgorICAg ICAgICAqIEdQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJQcm94eS5tZXNzYWdlcy5p bjoKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9tZWRpYS9NZWRpYVBsYXllclByaXZhdGVSZW1v dGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpNZWRpYVBsYXllclByaXZhdGVSZW1vdGU6OnZpZGVv RnVsbHNjcmVlblN0YW5kYnlDaGFuZ2VkKToKKwogMjAyMS0xMC0xNCAgQ2FybG9zIEdhcmNpYSBD YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBNb3ZlIGdl dEN1cnJlbnRFeGVjdXRhYmxlUGF0aCgpIGFuZCBnZXRDdXJyZW50RXhlY3V0YWJsZU5hbWUoKSB0 byBGaWxlU3lzdGVtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWVkaWEv UmVtb3RlTWVkaWFQbGF5ZXJQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWVk aWEvUmVtb3RlTWVkaWFQbGF5ZXJQcm94eS5jcHAKaW5kZXggZWI4ZDgzMDQ2ZjNlYjliMjE4YTkz MjhhMDc1MGYxYTUwYWFkMThiYy4uNTY1YjhiMjkzYWVjZGY1ZTUxZmU1ZTEwMTZjNWI3YTdlNzMz ZDhhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21lZGlhL1JlbW90ZU1l ZGlhUGxheWVyUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9tZWRpYS9S ZW1vdGVNZWRpYVBsYXllclByb3h5LmNwcApAQCAtMzIxLDEyICszMjEsMTMgQEAgdm9pZCBSZW1v dGVNZWRpYVBsYXllclByb3h5Ojp1cGRhdGVWaWRlb0Z1bGxzY3JlZW5JbmxpbmVJbWFnZSgpCiAK IHZvaWQgUmVtb3RlTWVkaWFQbGF5ZXJQcm94eTo6c2V0VmlkZW9GdWxsc2NyZWVuTW9kZShNZWRp YVBsYXllcjo6VmlkZW9GdWxsc2NyZWVuTW9kZSBtb2RlKQogeworICAgIG1fZnVsbHNjcmVlbk1v ZGUgPSBtb2RlOwogICAgIG1fcGxheWVyLT5zZXRWaWRlb0Z1bGxzY3JlZW5Nb2RlKG1vZGUpOwot CiB9CiAKLXZvaWQgUmVtb3RlTWVkaWFQbGF5ZXJQcm94eTo6dmlkZW9GdWxsc2NyZWVuU3RhbmRi eUNoYW5nZWQoKQordm9pZCBSZW1vdGVNZWRpYVBsYXllclByb3h5Ojp2aWRlb0Z1bGxzY3JlZW5T dGFuZGJ5Q2hhbmdlZChib29sIHN0YW5kYnkpCiB7CisgICAgbV92aWRlb0Z1bGxzY3JlZW5TdGFu ZGJ5ID0gc3RhbmRieTsKICAgICBtX3BsYXllci0+dmlkZW9GdWxsc2NyZWVuU3RhbmRieUNoYW5n ZWQoKTsKIH0KICNlbmRpZgpAQCAtODE5LDE0ICs4MjAsMTIgQEAgZG91YmxlIFJlbW90ZU1lZGlh UGxheWVyUHJveHk6Om1lZGlhUGxheWVyUmVxdWVzdGVkUGxheWJhY2tSYXRlKCkgY29uc3QKICNp ZiBFTkFCTEUoVklERU9fUFJFU0VOVEFUSU9OX01PREUpCiBNZWRpYVBsYXllckVudW1zOjpWaWRl b0Z1bGxzY3JlZW5Nb2RlIFJlbW90ZU1lZGlhUGxheWVyUHJveHk6Om1lZGlhUGxheWVyRnVsbHNj cmVlbk1vZGUoKSBjb25zdAogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIE1l ZGlhUGxheWVyRW51bXM6OlZpZGVvRnVsbHNjcmVlbk1vZGVOb25lOworICAgIHJldHVybiBtX2Z1 bGxzY3JlZW5Nb2RlOwogfQogCiBib29sIFJlbW90ZU1lZGlhUGxheWVyUHJveHk6Om1lZGlhUGxh eWVySXNWaWRlb0Z1bGxzY3JlZW5TdGFuZGJ5KCkgY29uc3QKIHsKLSAgICBub3RJbXBsZW1lbnRl ZCgpOwotICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gbV92aWRlb0Z1bGxzY3JlZW5TdGFu ZGJ5OwogfQogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9t ZWRpYS9SZW1vdGVNZWRpYVBsYXllclByb3h5LmggYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3Mv bWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJQcm94eS5oCmluZGV4IGM4Yjc5NDA1ZWI0MWVhZTVjZTc2 YWYzZTU4MzI1YzcxNWE0YWQyODcuLjUyY2I2MTkzZjI1OWU2ZWQzYzkwZmVmNGYzYTM4NjQ2ZTJl YjU2OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9tZWRpYS9SZW1vdGVN ZWRpYVBsYXllclByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21lZGlhL1Jl bW90ZU1lZGlhUGxheWVyUHJveHkuaApAQCAtMTA2LDcgKzEwNiw3IEBAIHB1YmxpYzoKICNpZiBF TkFCTEUoVklERU9fUFJFU0VOVEFUSU9OX01PREUpCiAgICAgdm9pZCB1cGRhdGVWaWRlb0Z1bGxz Y3JlZW5JbmxpbmVJbWFnZSgpOwogICAgIHZvaWQgc2V0VmlkZW9GdWxsc2NyZWVuTW9kZShXZWJD b3JlOjpNZWRpYVBsYXllcjo6VmlkZW9GdWxsc2NyZWVuTW9kZSk7Ci0gICAgdm9pZCB2aWRlb0Z1 bGxzY3JlZW5TdGFuZGJ5Q2hhbmdlZCgpOworICAgIHZvaWQgdmlkZW9GdWxsc2NyZWVuU3RhbmRi eUNoYW5nZWQoYm9vbCk7CiAjZW5kaWYKIAogICAgIHZvaWQgc2V0QnVmZmVyaW5nUG9saWN5KFdl YkNvcmU6Ok1lZGlhUGxheWVyOjpCdWZmZXJpbmdQb2xpY3kpOwpAQCAtMzU3LDYgKzM1Nyw4IEBA IHByaXZhdGU6CiAKICAgICBib29sIG1fYnVmZmVyZWRDaGFuZ2VkIHsgdHJ1ZSB9OwogICAgIGJv b2wgbV9yZW5kZXJpbmdDYW5CZUFjY2VsZXJhdGVkIHsgZmFsc2UgfTsKKyAgICBXZWJDb3JlOjpN ZWRpYVBsYXllcjo6VmlkZW9GdWxsc2NyZWVuTW9kZSBtX2Z1bGxzY3JlZW5Nb2RlIHsgV2ViQ29y ZTo6TWVkaWFQbGF5ZXI6OlZpZGVvRnVsbHNjcmVlbk1vZGVOb25lIH07CisgICAgYm9vbCBtX3Zp ZGVvRnVsbHNjcmVlblN0YW5kYnkgeyBmYWxzZSB9OwogCiAjaWYgRU5BQkxFKExFR0FDWV9FTkNS WVBURURfTUVESUEpICYmIEVOQUJMRShFTkNSWVBURURfTUVESUEpCiAgICAgYm9vbCBtX3Nob3Vs ZENvbnRpbnVlQWZ0ZXJLZXlOZWVkZWQgeyBmYWxzZSB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9HUFVQcm9jZXNzL21lZGlhL1JlbW90ZU1lZGlhUGxheWVyUHJveHkubWVzc2FnZXMuaW4g Yi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJQcm94eS5t ZXNzYWdlcy5pbgppbmRleCA2OGJmOGQzMmI3MWM4NTYxMGMyY2FmNTFiMzFlOGYxY2UwMjE4NDUw Li4xYjBhOWQ0MjhjZGRmZGE1NmVhOTU5YTQ3YjhhYjFmNDg0YTRmYWJiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJQcm94eS5tZXNz YWdlcy5pbgorKysgYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQ bGF5ZXJQcm94eS5tZXNzYWdlcy5pbgpAQCAtNjAsNyArNjAsNyBAQCBtZXNzYWdlcyAtPiBSZW1v dGVNZWRpYVBsYXllclByb3h5IE5vdFJlZkNvdW50ZWQgewogICAgIFVwZGF0ZVZpZGVvRnVsbHNj cmVlbklubGluZUltYWdlKCkKICAgICBTZXRWaWRlb0Z1bGxzY3JlZW5Nb2RlKFdlYkNvcmU6Ok1l ZGlhUGxheWVyOjpWaWRlb0Z1bGxzY3JlZW5Nb2RlIG1vZGUpCiAgICAgU2V0VmlkZW9GdWxsc2Ny ZWVuR3Jhdml0eShlbnVtOnVpbnQ4X3QgV2ViQ29yZTo6TWVkaWFQbGF5ZXJFbnVtczo6VmlkZW9H cmF2aXR5IGdyYXZpdHkpCi0gICAgVmlkZW9GdWxsc2NyZWVuU3RhbmRieUNoYW5nZWQoKQorICAg IFZpZGVvRnVsbHNjcmVlblN0YW5kYnlDaGFuZ2VkKGJvb2wgc3RhbmRieSkKICNlbmRpZgogCiAg ICAgU2V0QnVmZmVyaW5nUG9saWN5KFdlYkNvcmU6Ok1lZGlhUGxheWVyOjpCdWZmZXJpbmdQb2xp Y3kgcG9saWN5KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9tZWRp YS9NZWRpYVBsYXllclByaXZhdGVSZW1vdGUuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L0dQVS9tZWRpYS9NZWRpYVBsYXllclByaXZhdGVSZW1vdGUuY3BwCmluZGV4IGZkZjk2YzU2YzQ5 MWJiMDY0YWI3MmVjMDdmZThlNmZmNTE5NWVjNWIuLjdkNDdmMDU5NjgxNzdmNjljNjA2ODMxOWQx YTVjYmQ4YTJjNjFmZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUv bWVkaWEvTWVkaWFQbGF5ZXJQcml2YXRlUmVtb3RlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvR1BVL21lZGlhL01lZGlhUGxheWVyUHJpdmF0ZVJlbW90ZS5jcHAKQEAgLTg1MSw3 ICs4NTEsMTEgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVSZW1vdGU6OnNldFZpZGVvRnVsbHNj cmVlbk1vZGUoTWVkaWFQbGF5ZXI6OlZpZGVvRnVsbHNjcmUKIAogdm9pZCBNZWRpYVBsYXllclBy aXZhdGVSZW1vdGU6OnZpZGVvRnVsbHNjcmVlblN0YW5kYnlDaGFuZ2VkKCkKIHsKLSAgICBjb25u ZWN0aW9uKCkuc2VuZChNZXNzYWdlczo6UmVtb3RlTWVkaWFQbGF5ZXJQcm94eTo6VmlkZW9GdWxs c2NyZWVuU3RhbmRieUNoYW5nZWQoKSwgbV9pZCk7CisgICAgUmVmUHRyIHBsYXllciA9IG1fcGxh eWVyLmdldCgpOworICAgIGlmICghcGxheWVyKQorICAgICAgICByZXR1cm47CisKKyAgICBjb25u ZWN0aW9uKCkuc2VuZChNZXNzYWdlczo6UmVtb3RlTWVkaWFQbGF5ZXJQcm94eTo6VmlkZW9GdWxs c2NyZWVuU3RhbmRieUNoYW5nZWQocGxheWVyLT5pc1ZpZGVvRnVsbHNjcmVlblN0YW5kYnkoKSks IG1faWQpOwogfQogI2VuZGlmCiAK