231795 2021-10-14 21:40:05 -0700 PlatformUse.h cannot include anything 2021-10-18 16:31:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=229353 P2 Normal --- 229353 1 rmorisset rmorisset benjamin cdumez cmarcelo ews-watchlist oldest_to_newest 1804689 0 rmorisset 2021-10-14 21:40:05 -0700 I got too hasty in landing https://bugs.webkit.org/show_bug.cgi?id=229353, and broke a bunch of tests in the process (I had verified that these tests passed on a previous version of the patch, and did not think that in fixing the watch I would break something else). The root cause appears to be that PlatformUse.h is not a regular header: it gets included in all kinds of places, including files that are not C++ (nor even C!) such as the files defining the sandbox of the network process. And so my including <cstdint> naturally caused massive issues. This patch reverts that particular piece of the previous patch, making USE_LARGE_TYPED_ARRAYS exclusively depend on CPU(ADDRESS64). It is less semantically clean, but seems to be equivalent on all platforms we support (verified with static_asserts in ArrayBuffer.h). 1804690 1 441330 rmorisset 2021-10-14 21:42:29 -0700 Created attachment 441330 Patch 1804711 2 441330 rmorisset 2021-10-14 23:25:05 -0700 Comment on attachment 441330 Patch I am reverting https://bugs.webkit.org/show_bug.cgi?id=229353, so this will be merged into the next version of it. 1805766 3 rmorisset 2021-10-18 16:31:27 -0700 I rolled out the offending patch, and later landed it again with this fix included. 441330 2021-10-14 21:42:29 -0700 2021-10-14 23:25:05 -0700 Patch patch231795 text/plain 2370 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZTZhYTdhMjBlYmM2Li5jYzFhZmRjZmVmYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIw MjEtMTAtMTQgIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAg ICBQbGF0Zm9ybVVzZS5oIGNhbm5vdCBpbmNsdWRlIGFueXRoaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE3OTUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIGdvdCB0b28gaGFzdHkgaW4gbGFuZGlu ZyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI5MzUzLCBhbmQgYnJv a2UgYSBidW5jaCBvZiB0ZXN0cyBpbiB0aGUgcHJvY2VzcworICAgICAgICAoSSBoYWQgdmVyaWZp ZWQgdGhhdCB0aGVzZSB0ZXN0cyBwYXNzZWQgb24gYSBwcmV2aW91cyB2ZXJzaW9uIG9mIHRoZSBw YXRjaCwgYW5kIGRpZCBub3QgdGhpbmsgdGhhdCBpbiBmaXhpbmcgdGhlIHdhdGNoIEkgd291bGQg YnJlYWsgc29tZXRoaW5nIGVsc2UpLgorICAgICAgICBUaGUgcm9vdCBjYXVzZSBhcHBlYXJzIHRv IGJlIHRoYXQgUGxhdGZvcm1Vc2UuaCBpcyBub3QgYSByZWd1bGFyIGhlYWRlcjogaXQgZ2V0cyBp bmNsdWRlZCBpbiBhbGwga2luZHMgb2YgcGxhY2VzLCBpbmNsdWRpbmcgZmlsZXMgdGhhdCBhcmUg bm90IEMrKyAobm9yIGV2ZW4gQyEpCisgICAgICAgIHN1Y2ggYXMgdGhlIGZpbGVzIGRlZmluaW5n IHRoZSBzYW5kYm94IG9mIHRoZSBuZXR3b3JrIHByb2Nlc3MuIEFuZCBzbyBteSBpbmNsdWRpbmcg PGNzdGRpbnQ+IG5hdHVyYWxseSBjYXVzZWQgbWFzc2l2ZSBpc3N1ZXMuCisgICAgICAgIFRoaXMg cGF0Y2ggcmV2ZXJ0cyB0aGF0IHBhcnRpY3VsYXIgcGllY2Ugb2YgdGhlIHByZXZpb3VzIHBhdGNo LCBtYWtpbmcgVVNFX0xBUkdFX1RZUEVEX0FSUkFZUyBleGNsdXNpdmVseSBkZXBlbmQgb24gQ1BV KEFERFJFU1M2NCkuCisgICAgICAgIEl0IGlzIGxlc3Mgc2VtYW50aWNhbGx5IGNsZWFuLCBidXQg c2VlbXMgdG8gYmUgZXF1aXZhbGVudCBvbiBhbGwgcGxhdGZvcm1zIHdlIHN1cHBvcnQgKHZlcmlm aWVkIHdpdGggc3RhdGljX2Fzc2VydHMgaW4gQXJyYXlCdWZmZXIuaCkuCisKKyAgICAgICAgKiB3 dGYvUGxhdGZvcm1Vc2UuaDoKKwogMjAyMS0xMC0xMyAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNz ZXRAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IFdBU00gdG8gdXNlIHVwIHRvIDRHQgpkaWZm IC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1Vc2UuaCBiL1NvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtVXNlLmgKaW5kZXggYjk0ZGJlODkxMDdkLi42NDZlOWJlYTU4ZTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtVXNlLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZv cm1Vc2UuaApAQCAtMjcsMTMgKzI3LDYgQEAKIAogI3ByYWdtYSBvbmNlCiAKLS8vIFRoaXMgaXMg dG8gZ2V0IFNJWkVfTUFYLCB3aGljaCBpbiB0dXJuIGlzIHVzZWQgZm9yIFVTRV9MQVJHRV9UWVBF RF9BUlJBWVMKLSNpZmRlZiBfX2NwbHVzcGx1cwotI2luY2x1ZGUgPGNzdGRpbnQ+Ci0jZWxzZQot I2luY2x1ZGUgPHN0ZGludC5oPgotI2VuZGlmCi0KICNpZm5kZWYgV1RGX1BMQVRGT1JNX0dVQVJE X0FHQUlOU1RfSU5ESVJFQ1RfSU5DTFVTSU9OCiAjZXJyb3IgIlBsZWFzZSAjaW5jbHVkZSA8d3Rm L1BsYXRmb3JtLmg+IGluc3RlYWQgb2YgdGhpcyBmaWxlIGRpcmVjdGx5LiIKICNlbmRpZgpAQCAt MTQ4LDcgKzE0MSwxMCBAQAogI2RlZmluZSBVU0VfSlNWQUxVRTMyXzY0IDEKICNlbmRpZgogCi0j aWYgU0laRV9NQVggPT0gVUlOVDY0X01BWAorLy8gRklYTUU6IHRoaXMgc2hvdWxkIGluc3RlYWQg YmUgYmFzZWQgb24gU0laRV9NQVggPT0gVUlOVDY0X01BWAorLy8gQnV0IHRoaXMgcmVxdWlyZXMg aW5jbHVkaW5nIDxjc3RkaW50PiBhbmQgUGxhdGZvcm0uaCBpcyBpbmNsdWRlZCBpbiBhbGwga2lu ZCBvZiB3ZWlyZCBwbGFjZXMsIGluY2x1ZGluZyBub24tY3BwIGZpbGVzCisvLyBBbmQgaW4gcHJh Y3RpY2UgQ1BVKEFERFJFU1M2NCkgaXMgZXF1aXZhbGVudCBvbiBhbGwgcGxhdGZvcm1zIHdlIHN1 cHBvcnQgKHZlcmlmaWVkIGJ5IHN0YXRpY19hc3NlcnRzIGluIEFycmF5QnVmZmVyLmgpCisjaWYg Q1BVKEFERFJFU1M2NCkKICNkZWZpbmUgVVNFX0xBUkdFX1RZUEVEX0FSUkFZUyAxCiAjZWxzZQog I2RlZmluZSBVU0VfTEFSR0VfVFlQRURfQVJSQVlTIDAK