231783 2021-10-14 16:27:19 -0700 Fix build failures with newer clang 2021-10-14 16:49:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer oldest_to_newest 1804580 0 ysuzuki 2021-10-14 16:27:19 -0700 Use default copy constructor / assignment operators by dropping explicit copy constructor definition in TouchBarMenuItemData 1804581 1 441302 ysuzuki 2021-10-14 16:28:32 -0700 Created attachment 441302 Patch 1804587 2 441305 ysuzuki 2021-10-14 16:39:34 -0700 Created attachment 441305 Patch 1804590 3 ysuzuki 2021-10-14 16:44:47 -0700 Landing it now since it is build failure fix. I ensured it is built locally. 1804596 4 ysuzuki 2021-10-14 16:48:40 -0700 Committed r284215 (243025@main): <https://commits.webkit.org/243025@main> 1804599 5 webkit-bug-importer 2021-10-14 16:49:27 -0700 <rdar://problem/84280768> 441302 2021-10-14 16:28:32 -0700 2021-10-14 16:39:32 -0700 Patch bug-231783-20211014162831.patch text/plain 1689 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJjNmM1MTMwNTMyMTBhMWRj YjM4YTYxMGUwNDEyZGQ3NDUyNGNjZDAuLjcxNGFmMmY0YTEzNmQxYWEwM2QzMWEyN2RiNzE4NGIx N2EwNjRlMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTAtMTQgIFl1c3VrZSBT dXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgZGVmYXVsdCBjb3B5IGNv bnN0cnVjdG9yIC8gYXNzaWdubWVudCBvcGVyYXRvcnMgYnkgZHJvcHBpbmcgZXhwbGljaXQgY29w eSBjb25zdHJ1Y3RvciBkZWZpbml0aW9uIGluIFRvdWNoQmFyTWVudUl0ZW1EYXRhCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE3ODMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBkbyBub3QgbmVlZCB0 byBkZWZpbmUgY29weSBjb25zdHJ1Y3RvciAvIGFzc2lnbm1lbnQgb3BlcmF0b3IgaWYgd2Ugd291 bGQgbGlrZSB0byB1c2UgdGhlIGRlZmF1bHQgaW1wbGVtZW50YXRpb24uCisgICAgICAgIFRoZSBk ZWZhdWx0IGNvcHkgY29uc3RydWN0b3IgLyBhc3NpZ25tZW50IG9wZXJhdG9yIHdvcmtzIHdlbGwg Zm9yIFRvdWNoQmFyTWVudUl0ZW1EYXRhLgorICAgICAgICBEZWZpbmluZyBjb3B5IGNvbnN0cnVj dG9yIHdoaWxlIG5vdCBkZWZpbmluZyBhc3NpZ25tZW50IG9wZXJhdG9yIGNhdXNlcyBidWlsZCBm YWlsdXJlIG9uIG5ld2VyIGNsYW5nLgorCisgICAgICAgICogU2hhcmVkL1RvdWNoQmFyTWVudUl0 ZW1EYXRhLmg6CisKIDIwMjEtMTAtMTQgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFttYWNPU10gQ3Jhc2ggb24gV1Agc3RhcnR1cApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9TaGFyZWQvVG91Y2hCYXJNZW51SXRlbURhdGEuaCBiL1NvdXJjZS9XZWJL aXQvU2hhcmVkL1RvdWNoQmFyTWVudUl0ZW1EYXRhLmgKaW5kZXggNDk4MTMyYTBhMzVlZGYzZDNj ZjU5M2QwNmI4NjE0MTY3YTRmNmExMC4uMDVjNmRkZGJjZGI1ZGVmNDkwYmFhNjA2NTBlNThhNWM1 MjY1NWRlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvVG91Y2hCYXJNZW51SXRl bURhdGEuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Ub3VjaEJhck1lbnVJdGVtRGF0YS5o CkBAIC01MCw3ICs1MCw2IEBAIGVudW0gSXRlbVR5cGUgewogc3RydWN0IFRvdWNoQmFyTWVudUl0 ZW1EYXRhIHsKICAgICBleHBsaWNpdCBUb3VjaEJhck1lbnVJdGVtRGF0YSgpID0gZGVmYXVsdDsK ICAgICBleHBsaWNpdCBUb3VjaEJhck1lbnVJdGVtRGF0YShjb25zdCBXZWJDb3JlOjpIVE1MTWVu dUl0ZW1FbGVtZW50Jik7Ci0gICAgZXhwbGljaXQgVG91Y2hCYXJNZW51SXRlbURhdGEoY29uc3Qg VG91Y2hCYXJNZW51SXRlbURhdGEmKSA9IGRlZmF1bHQ7CiAgICAgCiAgICAgdm9pZCBlbmNvZGUo SVBDOjpFbmNvZGVyJikgY29uc3Q7CiAgICAgc3RhdGljIHN0ZDo6b3B0aW9uYWw8VG91Y2hCYXJN ZW51SXRlbURhdGE+IGRlY29kZShJUEM6OkRlY29kZXImKTsK 441305 2021-10-14 16:39:34 -0700 2021-10-14 16:40:43 -0700 Patch bug-231783-20211014163933.patch text/plain 4591 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDg1MGI4OTQ0YzIyZjgxM2E2ZmUxMWJi NDVjOWM4M2U2MzViN2VmZmMuLjAxM2IxNzA0YWUwNGI4Y2IxMWRiYjcwYzliYzQ3ZDA1YjIyYTRk OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTAtMTQgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgZmFpbHVyZXMgd2l0aCBuZXdlciBj bGFuZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMx NzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4g SWRlbnRpZmllZCBjYXNlLCB3ZSBtYWtlIGNvcHkgY29uc3RydWN0b3IgYW5kIGFzc2lnbm1lbnQg b3BlcmF0b3IgcHJvdGVjdGVkIGluIElkZW50aWZpZWRCYXNlIHRvIGhpZGUKKyAgICAgICAgdGhl IGFiaWxpdHkgdG8gY29weSBJZGVudGlmaWVkIC8gVGhyZWFkU2FmZUlkZW50aWZpZWQgdG8gYmUg Y29waWVkIHRvIElkZW50aWZpZWRCYXNlLiBTbywgaW4gdGhlIGRlcml2ZWQKKyAgICAgICAgY2xh c3Nlcywgd2Ugc2hvdWxkIGRlZmluZSBib3RoIGNvcHkgY29uc3RydWN0b3IgYW5kIGFzc2lnbm1l bnQgb3BlcmF0b3IuCisKKyAgICAgICAgKiB3dGYvSWRlbnRpZmllZC5oOgorCiAyMDIxLTEwLTE0 ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAg U2hhcmUgSVBDIGNvbW11bmljYXRpb24gY29kZSBiZXR3ZWVuIHdlYnB1c2hkIGFuZCBhZGF0dHJp YnV0aW9uZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L0NoYW5nZUxvZwppbmRleCAyYzZjNTEzMDUzMjEwYTFkY2IzOGE2MTBlMDQxMmRkNzQ1MjRj Y2QwLi44NTA2MGFhOWZjYjk5NjM4NTQ4MGFlMWEyMGU3NTYxZmZlOWM3M2VhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDIxLTEwLTE0ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBs ZS5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIGZhaWx1cmVzIHdpdGggbmV3ZXIgY2xhbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTc4MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGRvIG5vdCBu ZWVkIHRvIGRlZmluZSBjb3B5IGNvbnN0cnVjdG9yIGFuZCBhc3NpZ25tZW50IG9wZXJhdG9yIGlm IHdlIHdvdWxkIGxpa2UgdG8gdXNlIHRoZSBkZWZhdWx0IGltcGxlbWVudGF0aW9uLgorICAgICAg ICBUaGUgZGVmYXVsdCBjb3B5IGNvbnN0cnVjdG9yIGFuZCBhc3NpZ25tZW50IG9wZXJhdG9yIHdv cmtzIHdlbGwgZm9yIFRvdWNoQmFyTWVudUl0ZW1EYXRhLCBzbyBsZXQncyBkcm9wIGl0LgorCisg ICAgICAgICogU2hhcmVkL1RvdWNoQmFyTWVudUl0ZW1EYXRhLmg6CisKIDIwMjEtMTAtMTQgIFBl ciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gQ3Jh c2ggb24gV1Agc3RhcnR1cApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvSWRlbnRpZmllZC5o IGIvU291cmNlL1dURi93dGYvSWRlbnRpZmllZC5oCmluZGV4IDY4ZmY3ZmE2NTAzMjFiYzYxMmZh MjdhMGZiNzgwMmIxY2QzMTU2NjguLjU3MjU1Y2FhNzJmNzA5ZGMzMTFhNjRiY2E3NDAxMDEyNTdh YmM1YmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0lkZW50aWZpZWQuaAorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi9JZGVudGlmaWVkLmgKQEAgLTYxLDYgKzYxLDcgQEAgY2xhc3MgSWRlbnRpZmll ZCA6IHB1YmxpYyBJZGVudGlmaWVkQmFzZTx1aW50NjRfdCwgVD4gewogICAgIH0KIAogICAgIElk ZW50aWZpZWQoY29uc3QgSWRlbnRpZmllZCYpID0gZGVmYXVsdDsKKyAgICBJZGVudGlmaWVkJiBv cGVyYXRvcj0oY29uc3QgSWRlbnRpZmllZCYpID0gZGVmYXVsdDsKIAogICAgIGV4cGxpY2l0IElk ZW50aWZpZWQodWludDY0X3QgaWRlbnRpZmllcikKICAgICAgICAgOiBJZGVudGlmaWVkQmFzZTx1 aW50NjRfdCwgVD4oaWRlbnRpZmllcikKQEAgLTg0LDYgKzg1LDcgQEAgY2xhc3MgVGhyZWFkU2Fm ZUlkZW50aWZpZWQgOiBwdWJsaWMgSWRlbnRpZmllZEJhc2U8dWludDY0X3QsIFQ+IHsKICAgICB9 CiAKICAgICBUaHJlYWRTYWZlSWRlbnRpZmllZChjb25zdCBUaHJlYWRTYWZlSWRlbnRpZmllZCYp ID0gZGVmYXVsdDsKKyAgICBUaHJlYWRTYWZlSWRlbnRpZmllZCYgb3BlcmF0b3I9KGNvbnN0IFRo cmVhZFNhZmVJZGVudGlmaWVkJikgPSBkZWZhdWx0OwogCiAgICAgZXhwbGljaXQgVGhyZWFkU2Fm ZUlkZW50aWZpZWQodWludDY0X3QgaWRlbnRpZmllcikKICAgICAgICAgOiBJZGVudGlmaWVkQmFz ZTx1aW50NjRfdCwgVD4oaWRlbnRpZmllcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hh cmVkL1RvdWNoQmFyTWVudUl0ZW1EYXRhLmggYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Ub3VjaEJh ck1lbnVJdGVtRGF0YS5oCmluZGV4IDQ5ODEzMmEwYTM1ZWRmM2QzY2Y1OTNkMDZiODYxNDE2N2E0 ZjZhMTAuLjA1YzZkZGRiY2RiNWRlZjQ5MGJhYTYwNjUwZTU4YTVjNTI2NTVkZTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1RvdWNoQmFyTWVudUl0ZW1EYXRhLmgKKysrIGIvU291 cmNlL1dlYktpdC9TaGFyZWQvVG91Y2hCYXJNZW51SXRlbURhdGEuaApAQCAtNTAsNyArNTAsNiBA QCBlbnVtIEl0ZW1UeXBlIHsKIHN0cnVjdCBUb3VjaEJhck1lbnVJdGVtRGF0YSB7CiAgICAgZXhw bGljaXQgVG91Y2hCYXJNZW51SXRlbURhdGEoKSA9IGRlZmF1bHQ7CiAgICAgZXhwbGljaXQgVG91 Y2hCYXJNZW51SXRlbURhdGEoY29uc3QgV2ViQ29yZTo6SFRNTE1lbnVJdGVtRWxlbWVudCYpOwot ICAgIGV4cGxpY2l0IFRvdWNoQmFyTWVudUl0ZW1EYXRhKGNvbnN0IFRvdWNoQmFyTWVudUl0ZW1E YXRhJikgPSBkZWZhdWx0OwogICAgIAogICAgIHZvaWQgZW5jb2RlKElQQzo6RW5jb2RlciYpIGNv bnN0OwogICAgIHN0YXRpYyBzdGQ6Om9wdGlvbmFsPFRvdWNoQmFyTWVudUl0ZW1EYXRhPiBkZWNv ZGUoSVBDOjpEZWNvZGVyJik7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggZmNlMjAwYzQyNmVmYjIzODhlMWE3ZjUxYmZiY2Q4OGY1NmY3YzFiOS4u ZTJmNGRhMmVkNDQ0YzFiN2UwNjA2NGU2MzY5N2I2NmU1OGJiODBhZCAxMDA2NDQKLS0tIGEvVG9v bHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIx LTEwLTE0ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4 IGJ1aWxkIGZhaWx1cmVzIHdpdGggbmV3ZXIgY2xhbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTc4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHRoaXMgaXMgT2JqZWN0aXZlLUMgKG5vdCBP YmplY3RpdmUtQysrKSwgd2UgY2Fubm90IHVzZSBgc3RhdGljIGNvbnN0IHVpbnQzMl90YCB2YWx1 ZSBmb3IgYXJyYXkgc2l6ZS4KKyAgICAgICAgVXNlIGVudW0gaGFjayBpbnN0ZWFkLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0xheW91dFRlc3RIZWxwZXIubToKKyAgICAgICAgKGRp c3BsYXlVVUlEU3RyaW5ncyk6CisKIDIwMjEtMTAtMTQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBTaGFyZSBJUEMgY29tbXVuaWNhdGlvbiBj b2RlIGJldHdlZW4gd2VicHVzaGQgYW5kIGFkYXR0cmlidXRpb25kCmRpZmYgLS1naXQgYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdEhlbHBlci5tIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvbWFjL0xheW91dFRlc3RIZWxwZXIubQppbmRleCBjMTdjOGFlZWE2MmEzYzIyZWMxNjNl OTgzNjdjZDY5MDU0MDg0ZDNjLi41ZTljZDdhYWYwOTk5MzNlMDY3NTViNWZkMDgwOTc1NjYzYmRm OWM5IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdEhlbHBl ci5tCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9MYXlvdXRUZXN0SGVscGVyLm0KQEAg LTExMCw3ICsxMTAsNyBAQAogewogICAgIE5TTXV0YWJsZUFycmF5ICpyZXN1bHQgPSBbTlNNdXRh YmxlQXJyYXkgYXJyYXldOwogCi0gICAgc3RhdGljIGNvbnN0IHVpbnQzMl90IG1heERpc3BsYXlD b3VudCA9IDEwOworICAgIGVudW0geyBtYXhEaXNwbGF5Q291bnQgPSAxMCB9OwogICAgIENHRGly ZWN0RGlzcGxheUlEIGRpc3BsYXlJRHNbbWF4RGlzcGxheUNvdW50XSA9IHsgMCB9OwogICAgIHVp bnQzMl90IGRpc3BsYXlDb3VudCA9IDA7CiAgICAgCg==