23178 2009-01-07 16:42:24 -0800 offsetTop is wrong in some cases 2009-02-03 15:53:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://finance.google.com/finance?q=aapl P2 Normal --- 1 klobag klobag oldest_to_newest 104813 0 klobag 2009-01-07 16:42:24 -0800 Load the site, "http://finance.google.com/finance?q=aapl". Click on the search box and type "aapl". It should pop up an auto-complete list and the list is currently too high so it overlaps the text input box. I have narrowed it down to a simple case with attached file. 104814 1 26512 klobag 2009-01-07 16:43:17 -0800 Created attachment 26512 A simple test case. 104821 2 klobag 2009-01-07 17:21:23 -0800 This seems to be caused by http://trac.webkit.org/changeset/35551. Instead of int y = yPos() - borderTopExtra() - offsetPar->borderTop(); it should be int y = yPos() - borderTopExtra() + offsetPar->borderTopExtra() - offsetPar->borderTop(); 104948 3 26541 klobag 2009-01-08 15:16:09 -0800 Created attachment 26541 The patch to fix the bug 104956 4 26541 darin 2009-01-08 16:09:53 -0800 Comment on attachment 26541 The patch to fix the bug This fix looks great! But we need a regression test for it. Please add a test to LayoutTests that demonstrates the bug is fixed. 105044 5 26570 klobag 2009-01-09 13:01:19 -0800 Created attachment 26570 patch with layout test file 105115 6 26570 darin 2009-01-10 10:28:45 -0800 Comment on attachment 26570 patch with layout test file Looking good. > +2009-01-09 Grace Kloba <klobag@gmail.com> > + > + https://bugs.webkit.org/show_bug.cgi?id=23178 > + Added a case to test the offsetTop of table cell's children. > + > + * fast/dom/Element/offsetTop-table-cell.html: This change log entry has tabs in it. We need one that uses spaces instead. > Index: LayoutTests/fast/dom/Element/offsetTop-table-cell.html > =================================================================== > --- LayoutTests/fast/dom/Element/offsetTop-table-cell.html (revision 39716) > +++ LayoutTests/fast/dom/Element/offsetTop-table-cell.html (working copy) Since this test has changed, then the expected results have also changed. We need a patch that includes the changes to the expected results files too. 105383 7 26647 klobag 2009-01-12 13:40:45 -0800 Created attachment 26647 Include layout test and expected result for the proposed patch 105392 8 26647 darin 2009-01-12 14:23:50 -0800 Comment on attachment 26647 Include layout test and expected result for the proposed patch > + https://bugs.webkit.org/show_bug.cgi?id=23178 > + Added a case to test the offsetTop of table cell's children. There are tabs here, which make it hard to land the patch. > + <div style="margin: 50pt 0pt 50pt 0pt;"></div> You want px here, not pt. I'm surprised the test works if you're specifying pt, since they are not the same as px. Did you try the test case in other browsers? Does Firefox give the same results? I'm going to say r=me but I am slightly worried about the pt in the test case. And I want to be sure we're matching the other browsers here -- the fix looks clearly right, but I'd like to see the test to be sure. 105425 9 26656 klobag 2009-01-12 18:14:40 -0800 Created attachment 26656 Remove tab in the text file. I have changed it to use px instead of pt. For some reason, px and pt gave the same result on both Safari and FireFox. 105426 10 26656 darin 2009-01-12 18:16:34 -0800 Comment on attachment 26656 Remove tab in the text file. Looks fine. LayoutTests/ChangeLog still has tabs in it, but I guess that’s OK. 108195 11 bfulgham 2009-02-03 15:43:58 -0800 This bug was resolved in the recent RenderBox changes (http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderObject.cpp?rev=40107#L189) 108198 12 bfulgham 2009-02-03 15:53:46 -0800 Test cases committed in @r40552. 26512 2009-01-07 16:43:17 -0800 2009-01-07 16:43:17 -0800 A simple test case. finance.html text/html 566 klobag PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIiAiaHR0cDov L3d3dy53My5vcmcvVFIvaHRtbDQvc3RyaWN0LmR0ZCI+CjxodG1sPgo8Ym9keT4KCTxzY3JpcHQ+ CglmdW5jdGlvbiByZXBvcnQoeCkgewoJCXZhciB0b3AgPSAwOwoJCXZhciBwYXJlbnQgPSB4OwoJ CXdoaWxlIChwYXJlbnQpIHsKCQkJYWxlcnQoJ3BhcmVudCAnICsgcGFyZW50Lm5vZGVOYW1lICsg Jy5vZmZzZXRUb3A6ICcgKyBwYXJlbnQub2Zmc2V0VG9wKTsKCQkJdG9wICs9IHBhcmVudC5vZmZz ZXRUb3A7CgkJCXBhcmVudCA9IHBhcmVudC5vZmZzZXRQYXJlbnQ7CgkJfQoJCWFsZXJ0KCdub2Rl IHRvcCAnICsgdG9wKTsKCX0KCTwvc2NyaXB0PgoJPHRhYmxlPjx0Ym9keT48dHI+Cgk8dGQ+Cgk8 ZGl2IHN0eWxlPSJtYXJnaW46IDQwcHQgMHB0IDBwdCAwcHQ7Ij5BPC9kaXY+Cgk8L3RkPgoJPHRk PgoJPGlucHV0IHZhbHVlPSJjbGljayBtZSIgdHlwZT0iYnV0dG9uIiBvbmNsaWNrPSJyZXBvcnQo dGhpcykiPgoJPC90ZD4KCTwvdHI+PC90Ym9keT48L3RhYmxlPgoKPC9ib2R5PjwvaHRtbD4= 26541 2009-01-08 15:16:09 -0800 2009-01-12 13:40:45 -0800 The patch to fix the bug patch.txt text/plain 1282 klobag SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTcxOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTAgQEAKKzIwMDktMDEtMDggIEdyYWNlIEtsb2JhICA8a2xvYmFnQGdtYWlsLmNv bT4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzE3OC4gQ29ycmVjdGVkIG9mZnNldFRvcCBmb3IgdGFibGUgY2VsbCdzIGNoaWxkcmVu IGJ5IGFkZGluZyBpdHMgcGFyZW50J3MgYm9yZGVyVG9wRXh0cmEuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6 b2Zmc2V0VG9wKToKKwogMjAwOS0wMS0wOCAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+ CiAKICAgICAgICAgRml4IGZvciA8cmRhcjovL3Byb2JsZW0vNjQ2NTY4Mj4gUkVHUkVTU0lPTjog SW4gTWFpbCwgY2FuJ3QgZm9yY2UgYSBtZXNzYWdlIHRvIGF1dG8gc2Nyb2xsLgpJbmRleDogV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiAzOTcxNikKKysrIFdlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzNCw3ICs1MzQsNyBA QCBpbnQgUmVuZGVyT2JqZWN0OjpvZmZzZXRUb3AoKSBjb25zdAogICAgIFJlbmRlck9iamVjdCog b2Zmc2V0UGFyID0gb2Zmc2V0UGFyZW50KCk7CiAgICAgaWYgKCFvZmZzZXRQYXIpCiAgICAgICAg IHJldHVybiAwOwotICAgIGludCB5ID0geVBvcygpIC0gYm9yZGVyVG9wRXh0cmEoKSAtIG9mZnNl dFBhci0+Ym9yZGVyVG9wKCk7CisgICAgaW50IHkgPSB5UG9zKCkgLSBib3JkZXJUb3BFeHRyYSgp ICsgb2Zmc2V0UGFyLT5ib3JkZXJUb3BFeHRyYSgpIC0gb2Zmc2V0UGFyLT5ib3JkZXJUb3AoKTsK ICAgICBpZiAoIWlzUG9zaXRpb25lZCgpKSB7CiAgICAgICAgIGlmIChpc1JlbFBvc2l0aW9uZWQo KSkKICAgICAgICAgICAgIHkgKz0gc3RhdGljX2Nhc3Q8Y29uc3QgUmVuZGVyQm94Kj4odGhpcykt PnJlbGF0aXZlUG9zaXRpb25PZmZzZXRZKCk7Cg== 26570 2009-01-09 13:01:19 -0800 2009-01-12 13:40:45 -0800 patch with layout test file patch23178.txt text/plain 3058 klobag SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTc1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTAgQEAKKzIwMDktMDEtMDggIEdyYWNlIEtsb2JhICA8a2xvYmFnQGdtYWlsLmNv bT4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzE3OC4gQ29ycmVjdGVkIG9mZnNldFRvcCBmb3IgdGFibGUgY2VsbCdzIGNoaWxkcmVu IGJ5IGFkZGluZyBpdHMgcGFyZW50J3MgYm9yZGVyVG9wRXh0cmEuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6 b2Zmc2V0VG9wKToKKwogMjAwOS0wMS0wOSAgUGV0ZXIgS2FzdGluZyAgPHBrYXN0aW5nQGdvb2ds ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgSHlhdHQuCkluZGV4OiBXZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDM5NzE2KQorKysgV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTM0LDcgKzUzNCw3IEBAIGlu dCBSZW5kZXJPYmplY3Q6Om9mZnNldFRvcCgpIGNvbnN0CiAgICAgUmVuZGVyT2JqZWN0KiBvZmZz ZXRQYXIgPSBvZmZzZXRQYXJlbnQoKTsKICAgICBpZiAoIW9mZnNldFBhcikKICAgICAgICAgcmV0 dXJuIDA7Ci0gICAgaW50IHkgPSB5UG9zKCkgLSBib3JkZXJUb3BFeHRyYSgpIC0gb2Zmc2V0UGFy LT5ib3JkZXJUb3AoKTsKKyAgICBpbnQgeSA9IHlQb3MoKSAtIGJvcmRlclRvcEV4dHJhKCkgKyBv ZmZzZXRQYXItPmJvcmRlclRvcEV4dHJhKCkgLSBvZmZzZXRQYXItPmJvcmRlclRvcCgpOwogICAg IGlmICghaXNQb3NpdGlvbmVkKCkpIHsKICAgICAgICAgaWYgKGlzUmVsUG9zaXRpb25lZCgpKQog ICAgICAgICAgICAgeSArPSBzdGF0aWNfY2FzdDxjb25zdCBSZW5kZXJCb3gqPih0aGlzKS0+cmVs YXRpdmVQb3NpdGlvbk9mZnNldFkoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5NzU2KQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDkt MDEtMDkgIEdyYWNlIEtsb2JhICA8a2xvYmFnQGdtYWlsLmNvbT4KKworCWh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE3OAorCUFkZGVkIGEgY2FzZSB0byB0ZXN0IHRo ZSBvZmZzZXRUb3Agb2YgdGFibGUgY2VsbCdzIGNoaWxkcmVuLgorCisgICAgICAgICogZmFzdC9k b20vRWxlbWVudC9vZmZzZXRUb3AtdGFibGUtY2VsbC5odG1sOgorCiAyMDA5LTAxLTA5ICBKb2Vs IFdlaW5iZXJnZXIgIDxqd3dAY3MuYmVya2VsZXkuZWR1PgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vRWxlbWVudC9vZmZzZXRU b3AtdGFibGUtY2VsbC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0Vs ZW1lbnQvb2Zmc2V0VG9wLXRhYmxlLWNlbGwuaHRtbAkocmV2aXNpb24gMzk3MTYpCisrKyBMYXlv dXRUZXN0cy9mYXN0L2RvbS9FbGVtZW50L29mZnNldFRvcC10YWJsZS1jZWxsLmh0bWwJKHdvcmtp bmcgY29weSkKQEAgLTI4LDkgKzI4LDEyIEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgIGNvbnNvbGUu aW5uZXJUZXh0ICs9ICJcbiI7CiAgICAgY29uc29sZS5pbm5lclRleHQgKz0gIlRhYmxlIDMgY2Vs bCAxIHRvcCBvZmZzZXQ6IiArIHRkNE9mZnNldDsKICAgICBjb25zb2xlLmlubmVyVGV4dCArPSAi XG4iOworICAgIGRpdjVPZmZzZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZGl2NSIpLm9m ZnNldFRvcDsKKyAgICBjb25zb2xlLmlubmVyVGV4dCArPSAiVGFibGUgNCBkaXYgMSB0b3Agb2Zm c2V0OiIgKyBkaXY1T2Zmc2V0OworICAgIGNvbnNvbGUuaW5uZXJUZXh0ICs9ICJcbiI7CiAgICAg Y29uc29sZS5pbm5lclRleHQgKz0gIlRlc3QgcmVzdWx0OiAiCiAgICAgY29uc29sZS5pbm5lclRl eHQgKz0gKHJvd09mZnNldCA9PSA1MCAmJiBjZWxsT2Zmc2V0ID09IDUwICYmIHRyMU9mZnNldCA9 PSAwIAotICAgICAgICAmJiB0cjFPZmZzZXQgPT0gdGQyT2Zmc2V0ICYmIHRyMU9mZnNldCA9PSB0 ZDNPZmZzZXQgJiYgdGQ0T2Zmc2V0ID09IDAgPyAiUEFTUyIgOiAiRkFJTCIpOworICAgICAgICAm JiB0cjFPZmZzZXQgPT0gdGQyT2Zmc2V0ICYmIHRyMU9mZnNldCA9PSB0ZDNPZmZzZXQgJiYgdGQ0 T2Zmc2V0ID09IDAgJiYgZGl2NU9mZnNldCA9PSA1MCA/ICJQQVNTIiA6ICJGQUlMIik7CiB9CiA8 L3NjcmlwdD4KIDwvaGVhZD4KQEAgLTU4LDUgKzYxLDE0IEBAIGZ1bmN0aW9uIHRlc3QoKQogYmx1 ZTsiPjx0ZCBpZD0idGQ0IiBzdHlsZT0id2lkdGg6IDEwMHB4OyBoZWlnaHQ6CiA1MDBweDtiYWNr Z3JvdW5kLWNvbG9yOiByZWQiPjwvdGQ+PC90cj48L3RhYmxlPgogCisJPHRhYmxlIGNlbGxzcGFj aW5nPSIwIiBjZWxscGFkZGluZz0iMCI+PHRib2R5Pjx0cj4KKwkJPHRkIHN0eWxlPSJoZWlnaHQ6 IDEwMHB4OyI+CisJCQk8ZGl2IHN0eWxlPSJtYXJnaW46IDUwcHQgMHB0IDUwcHQgMHB0OyI+PC9k aXY+CisJCTwvdGQ+CisJCTx0ZD4KKwkJCTxkaXYgaWQ9J2RpdjUnPgorCQk8L3RkPgorCTwvdHI+ PC90Ym9keT48L3RhYmxlPgorCiA8L2JvZHk+CiA8L2h0bWw+Cg== 26647 2009-01-12 13:40:45 -0800 2009-01-12 18:14:40 -0800 Include layout test and expected result for the proposed patch patch2.txt text/plain 3617 klobag SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTgzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTAgQEAKKzIwMDktMDEtMTIgIEdyYWNlIEtsb2JhICA8a2xvYmFnQGdtYWlsLmNv bT4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzE3OC4gQ29ycmVjdGVkIG9mZnNldFRvcCBmb3IgdGFibGUgY2VsbCdzIGNoaWxkcmVu IGJ5IGFkZGluZyBpdHMgcGFyZW50J3MgYm9yZGVyVG9wRXh0cmEuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6 b2Zmc2V0VG9wKToKKwogMjAwOS0wMS0xMiAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhA cGxleW8uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEhvbGdlciBGcmV5dGhlci4KSW5kZXg6 IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAkocmV2aXNpb24gMzk3MTYpCisrKyBXZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MzQsNyArNTM0 LDcgQEAgaW50IFJlbmRlck9iamVjdDo6b2Zmc2V0VG9wKCkgY29uc3QKICAgICBSZW5kZXJPYmpl Y3QqIG9mZnNldFBhciA9IG9mZnNldFBhcmVudCgpOwogICAgIGlmICghb2Zmc2V0UGFyKQogICAg ICAgICByZXR1cm4gMDsKLSAgICBpbnQgeSA9IHlQb3MoKSAtIGJvcmRlclRvcEV4dHJhKCkgLSBv ZmZzZXRQYXItPmJvcmRlclRvcCgpOworICAgIGludCB5ID0geVBvcygpIC0gYm9yZGVyVG9wRXh0 cmEoKSArIG9mZnNldFBhci0+Ym9yZGVyVG9wRXh0cmEoKSAtIG9mZnNldFBhci0+Ym9yZGVyVG9w KCk7CiAgICAgaWYgKCFpc1Bvc2l0aW9uZWQoKSkgewogICAgICAgICBpZiAoaXNSZWxQb3NpdGlv bmVkKCkpCiAgICAgICAgICAgICB5ICs9IHN0YXRpY19jYXN0PGNvbnN0IFJlbmRlckJveCo+KHRo aXMpLT5yZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0WSgpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMzk4MzIp CisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMSBA QAorMjAwOS0wMS0xMiAgR3JhY2UgS2xvYmEgIDxrbG9iYWdAZ21haWwuY29tPgorCisJaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTc4CisJQWRkZWQgYSBjYXNlIHRv IHRlc3QgdGhlIG9mZnNldFRvcCBvZiB0YWJsZSBjZWxsJ3MgY2hpbGRyZW4uCisKKyAgICAgICAg KiBmYXN0L2RvbS9FbGVtZW50L29mZnNldFRvcC10YWJsZS1jZWxsLWV4cGVjdGVkLnR4dDoKKyAg ICAgICAgKiBmYXN0L2RvbS9FbGVtZW50L29mZnNldFRvcC10YWJsZS1jZWxsLmh0bWw6CisKIDIw MDktMDEtMTIgIEVyaWMgUm9tYW4gIDxlcm9tYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vRWxlbWVu dC9vZmZzZXRUb3AtdGFibGUtY2VsbC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9kb20vRWxlbWVudC9vZmZzZXRUb3AtdGFibGUtY2VsbC1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDM5NzE2KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vRWxlbWVudC9vZmZzZXRU b3AtdGFibGUtY2VsbC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTcsNiArNyw3IEBA IFRhYmxlIDIgY2VsbCAxIHRvcCBvZmZzZXQ6MAogVGFibGUgMiBjZWxsIDIgdG9wIG9mZnNldDow CiBUYWJsZSAyIGNlbGwgMyB0b3Agb2Zmc2V0OjAKIFRhYmxlIDMgY2VsbCAxIHRvcCBvZmZzZXQ6 MAorVGFibGUgNCBkaXYgMSB0b3Agb2Zmc2V0OjUwCiBUZXN0IHJlc3VsdDogUEFTUwogeAkKIFRo aXMKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0VsZW1lbnQvb2Zmc2V0VG9wLXRhYmxlLWNl bGwuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9FbGVtZW50L29mZnNl dFRvcC10YWJsZS1jZWxsLmh0bWwJKHJldmlzaW9uIDM5NzE2KQorKysgTGF5b3V0VGVzdHMvZmFz dC9kb20vRWxlbWVudC9vZmZzZXRUb3AtdGFibGUtY2VsbC5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0yOCw5ICsyOCwxMiBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICBjb25zb2xlLmlubmVyVGV4dCAr PSAiXG4iOwogICAgIGNvbnNvbGUuaW5uZXJUZXh0ICs9ICJUYWJsZSAzIGNlbGwgMSB0b3Agb2Zm c2V0OiIgKyB0ZDRPZmZzZXQ7CiAgICAgY29uc29sZS5pbm5lclRleHQgKz0gIlxuIjsKKyAgICBk aXY1T2Zmc2V0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRpdjUiKS5vZmZzZXRUb3A7Cisg ICAgY29uc29sZS5pbm5lclRleHQgKz0gIlRhYmxlIDQgZGl2IDEgdG9wIG9mZnNldDoiICsgZGl2 NU9mZnNldDsKKyAgICBjb25zb2xlLmlubmVyVGV4dCArPSAiXG4iOwogICAgIGNvbnNvbGUuaW5u ZXJUZXh0ICs9ICJUZXN0IHJlc3VsdDogIgogICAgIGNvbnNvbGUuaW5uZXJUZXh0ICs9IChyb3dP ZmZzZXQgPT0gNTAgJiYgY2VsbE9mZnNldCA9PSA1MCAmJiB0cjFPZmZzZXQgPT0gMCAKLSAgICAg ICAgJiYgdHIxT2Zmc2V0ID09IHRkMk9mZnNldCAmJiB0cjFPZmZzZXQgPT0gdGQzT2Zmc2V0ICYm IHRkNE9mZnNldCA9PSAwID8gIlBBU1MiIDogIkZBSUwiKTsKKyAgICAgICAgJiYgdHIxT2Zmc2V0 ID09IHRkMk9mZnNldCAmJiB0cjFPZmZzZXQgPT0gdGQzT2Zmc2V0ICYmIHRkNE9mZnNldCA9PSAw ICYmIGRpdjVPZmZzZXQgPT0gNTAgPyAiUEFTUyIgOiAiRkFJTCIpOwogfQogPC9zY3JpcHQ+CiA8 L2hlYWQ+CkBAIC01OCw1ICs2MSwxNCBAQCBmdW5jdGlvbiB0ZXN0KCkKIGJsdWU7Ij48dGQgaWQ9 InRkNCIgc3R5bGU9IndpZHRoOiAxMDBweDsgaGVpZ2h0OgogNTAwcHg7YmFja2dyb3VuZC1jb2xv cjogcmVkIj48L3RkPjwvdHI+PC90YWJsZT4KIAorCTx0YWJsZSBjZWxsc3BhY2luZz0iMCIgY2Vs bHBhZGRpbmc9IjAiPjx0Ym9keT48dHI+CisJCTx0ZCBzdHlsZT0iaGVpZ2h0OiAxMDBweDsiPgor CQkJPGRpdiBzdHlsZT0ibWFyZ2luOiA1MHB0IDBwdCA1MHB0IDBwdDsiPjwvZGl2PgorCQk8L3Rk PgorCQk8dGQ+CisJCQk8ZGl2IGlkPSdkaXY1Jz4KKwkJPC90ZD4KKwk8L3RyPjwvdGJvZHk+PC90 YWJsZT4KKwogPC9ib2R5PgogPC9odG1sPgo= 26656 2009-01-12 18:14:40 -0800 2009-01-12 18:16:34 -0800 Remove tab in the text file. patch3.txt text/plain 3645 klobag SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTg0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTAgQEAKKzIwMDktMDEtMTIgIEdyYWNlIEtsb2JhICA8a2xvYmFnQGdtYWlsLmNv bT4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzE3OC4gQ29ycmVjdGVkIG9mZnNldFRvcCBmb3IgdGFibGUgY2VsbCdzIGNoaWxkcmVu IGJ5IGFkZGluZyBpdHMgcGFyZW50J3MgYm9yZGVyVG9wRXh0cmEuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6 b2Zmc2V0VG9wKToKKwogMjAwOS0wMS0xMiAgQ2hyaXMgTWFycmluICA8Y21hcnJpbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyT2JqZWN0LmNwcAkocmV2aXNpb24gMzk3MTYpCisrKyBXZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MzQsNyArNTM0LDcgQEAgaW50 IFJlbmRlck9iamVjdDo6b2Zmc2V0VG9wKCkgY29uc3QKICAgICBSZW5kZXJPYmplY3QqIG9mZnNl dFBhciA9IG9mZnNldFBhcmVudCgpOwogICAgIGlmICghb2Zmc2V0UGFyKQogICAgICAgICByZXR1 cm4gMDsKLSAgICBpbnQgeSA9IHlQb3MoKSAtIGJvcmRlclRvcEV4dHJhKCkgLSBvZmZzZXRQYXIt PmJvcmRlclRvcCgpOworICAgIGludCB5ID0geVBvcygpIC0gYm9yZGVyVG9wRXh0cmEoKSArIG9m ZnNldFBhci0+Ym9yZGVyVG9wRXh0cmEoKSAtIG9mZnNldFBhci0+Ym9yZGVyVG9wKCk7CiAgICAg aWYgKCFpc1Bvc2l0aW9uZWQoKSkgewogICAgICAgICBpZiAoaXNSZWxQb3NpdGlvbmVkKCkpCiAg ICAgICAgICAgICB5ICs9IHN0YXRpY19jYXN0PGNvbnN0IFJlbmRlckJveCo+KHRoaXMpLT5yZWxh dGl2ZVBvc2l0aW9uT2Zmc2V0WSgpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMzk4NDkpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMSBAQAorMjAwOS0w MS0xMiAgR3JhY2UgS2xvYmEgIDxrbG9iYWdAZ21haWwuY29tPgorCisJaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTc4CisJQWRkZWQgYSBjYXNlIHRvIHRlc3QgdGhl IG9mZnNldFRvcCBvZiB0YWJsZSBjZWxsJ3MgY2hpbGRyZW4uCisKKyAgICAgICAgKiBmYXN0L2Rv bS9FbGVtZW50L29mZnNldFRvcC10YWJsZS1jZWxsLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBm YXN0L2RvbS9FbGVtZW50L29mZnNldFRvcC10YWJsZS1jZWxsLmh0bWw6CisKIDIwMDktMDEtMTIg IFJvYmVydCBCbGF1dCAgPHdlYmtpdEBibGF1dC5iaXo+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0VsZW1lbnQvb2Zmc2V0VG9w LXRhYmxlLWNlbGwtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv ZG9tL0VsZW1lbnQvb2Zmc2V0VG9wLXRhYmxlLWNlbGwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAz OTcxNikKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0VsZW1lbnQvb2Zmc2V0VG9wLXRhYmxlLWNl bGwtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC03LDYgKzcsNyBAQCBUYWJsZSAyIGNl bGwgMSB0b3Agb2Zmc2V0OjAKIFRhYmxlIDIgY2VsbCAyIHRvcCBvZmZzZXQ6MAogVGFibGUgMiBj ZWxsIDMgdG9wIG9mZnNldDowCiBUYWJsZSAzIGNlbGwgMSB0b3Agb2Zmc2V0OjAKK1RhYmxlIDQg ZGl2IDEgdG9wIG9mZnNldDo1MAogVGVzdCByZXN1bHQ6IFBBU1MKIHgJCiBUaGlzCkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L2RvbS9FbGVtZW50L29mZnNldFRvcC10YWJsZS1jZWxsLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vRWxlbWVudC9vZmZzZXRUb3AtdGFibGUt Y2VsbC5odG1sCShyZXZpc2lvbiAzOTcxNikKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0VsZW1l bnQvb2Zmc2V0VG9wLXRhYmxlLWNlbGwuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMjgsOSArMjgs MTIgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgY29uc29sZS5pbm5lclRleHQgKz0gIlxuIjsKICAg ICBjb25zb2xlLmlubmVyVGV4dCArPSAiVGFibGUgMyBjZWxsIDEgdG9wIG9mZnNldDoiICsgdGQ0 T2Zmc2V0OwogICAgIGNvbnNvbGUuaW5uZXJUZXh0ICs9ICJcbiI7CisgICAgZGl2NU9mZnNldCA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkaXY1Iikub2Zmc2V0VG9wOworICAgIGNvbnNvbGUu aW5uZXJUZXh0ICs9ICJUYWJsZSA0IGRpdiAxIHRvcCBvZmZzZXQ6IiArIGRpdjVPZmZzZXQ7Cisg ICAgY29uc29sZS5pbm5lclRleHQgKz0gIlxuIjsKICAgICBjb25zb2xlLmlubmVyVGV4dCArPSAi VGVzdCByZXN1bHQ6ICIKICAgICBjb25zb2xlLmlubmVyVGV4dCArPSAocm93T2Zmc2V0ID09IDUw ICYmIGNlbGxPZmZzZXQgPT0gNTAgJiYgdHIxT2Zmc2V0ID09IDAgCi0gICAgICAgICYmIHRyMU9m ZnNldCA9PSB0ZDJPZmZzZXQgJiYgdHIxT2Zmc2V0ID09IHRkM09mZnNldCAmJiB0ZDRPZmZzZXQg PT0gMCA/ICJQQVNTIiA6ICJGQUlMIik7CisgICAgICAgICYmIHRyMU9mZnNldCA9PSB0ZDJPZmZz ZXQgJiYgdHIxT2Zmc2V0ID09IHRkM09mZnNldCAmJiB0ZDRPZmZzZXQgPT0gMCAmJiBkaXY1T2Zm c2V0ID09IDUwID8gIlBBU1MiIDogIkZBSUwiKTsKIH0KIDwvc2NyaXB0PgogPC9oZWFkPgpAQCAt NTgsNSArNjEsMTQgQEAgZnVuY3Rpb24gdGVzdCgpCiBibHVlOyI+PHRkIGlkPSJ0ZDQiIHN0eWxl PSJ3aWR0aDogMTAwcHg7IGhlaWdodDoKIDUwMHB4O2JhY2tncm91bmQtY29sb3I6IHJlZCI+PC90 ZD48L3RyPjwvdGFibGU+CiAKKyAgICA8dGFibGUgY2VsbHNwYWNpbmc9IjAiIGNlbGxwYWRkaW5n PSIwIj48dGJvZHk+PHRyPgorICAgICAgICA8dGQgc3R5bGU9ImhlaWdodDogMTAwcHg7Ij4KKyAg ICAgICAgICAgIDxkaXYgc3R5bGU9Im1hcmdpbjogNTBweCAwcHg7Ij48L2Rpdj4KKyAgICAgICAg PC90ZD4KKyAgICAgICAgPHRkPgorICAgICAgICAgICAgPGRpdiBpZD0nZGl2NSc+CisgICAgICAg IDwvdGQ+CisgICAgPC90cj48L3Rib2R5PjwvdGFibGU+CisKIDwvYm9keT4KIDwvaHRtbD4K