231769 2021-10-14 13:34:44 -0700 [AppleWin] Controls are not being rendered 2021-10-14 15:22:16 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=227828 InRadar P2 Normal --- 1 pvollan pvollan akeerthi bfulgham fujii webkit-bug-importer zalan oldest_to_newest 1804475 0 pvollan 2021-10-14 13:34:44 -0700 Controls like checkboxes and buttons are not being rendered in AppleWin. 1804477 1 pvollan 2021-10-14 13:35:18 -0700 <rdar://problem/83670287> 1804481 2 441273 pvollan 2021-10-14 13:39:49 -0700 Created attachment 441273 Patch 1804486 3 441273 fujii 2021-10-14 13:53:42 -0700 Comment on attachment 441273 Patch Sorry for the breakage. LGTM. But, I'm wondering why layout tests didn't catch the regression. 1804523 4 pvollan 2021-10-14 14:42:25 -0700 (In reply to Fujii Hironori from comment #3) > Comment on attachment 441273 [details] > Patch > > Sorry for the breakage. LGTM. But, I'm wondering why layout tests didn't > catch the regression. Yes, that is a good point. I would expect there to be test coverage for this. Thanks for reviewing! 1804537 5 ews-feeder 2021-10-14 15:22:14 -0700 Committed r284201 (243015@main): <https://commits.webkit.org/243015@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441273. 441273 2021-10-14 13:39:49 -0700 2021-10-14 15:22:15 -0700 Patch bug-231769-20211014133948.patch text/plain 1606 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NDE5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTE0ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbQXBwbGVXaW5dIENvbnRy b2xzIGFyZSBub3QgYmVpbmcgcmVuZGVyZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzMTc2OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODM2NzAy ODc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29u dHJvbHMgYXJlIG5vdCBiZWluZyByZW5kZXJlZCBiZWNhdXNlIHRoZSBMb2NhbFdpbmRvd3NDb250 ZXh0IGRlc3RydWN0b3IgaXMgbm8gbG9uZ2VyIGJsaXR0aW5nIHRoZSBiaXRtYXAgY29udGVudHMg dG8gdGhlIGhkYy4KKyAgICAgICAgVGhlIHRlc3QgaW4gR3JhcGhpY3NDb250ZXh0OjpnZXRXaW5k b3dzQ29udGV4dCBuZWVkcyB0byBtYXRjaCB0aGUgdGVzdCBpbiBHcmFwaGljc0NvbnRleHQ6OnJl bGVhc2VXaW5kb3dzQ29udGV4dC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9H cmFwaGljc0NvbnRleHRXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0 OjpnZXRXaW5kb3dzQ29udGV4dCk6CisKIDIwMjEtMTAtMTQgIEFudHRpIEtvaXZpc3RvICA8YW50 dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBFbmFibGUgaW5saW5l IGJveGVzIHdpdGggYmFja2dyb3VuZApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dFdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dFdpbi5jcHAJKHJldmlz aW9uIDI4NDEyMSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFw aGljc0NvbnRleHRXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Niw3ICs1Niw3IEBAIEhEQyBH cmFwaGljc0NvbnRleHQ6OmdldFdpbmRvd3NDb250ZXh0KGMKICAgICBIREMgaGRjID0gbnVsbHB0 cjsKICNpZiAhVVNFKENBSVJPKQogICAgIGhkYyA9IGRlcHJlY2F0ZWRQcml2YXRlQ29udGV4dCgp LT5tX2hkYzsKLSAgICBpZiAoaGRjICYmIGlzSW5UcmFuc3BhcmVuY3lMYXllcigpKSB7CisgICAg aWYgKGhkYyAmJiAhaXNJblRyYW5zcGFyZW5jeUxheWVyKCkpIHsKICAgICAgICAgZGVwcmVjYXRl ZFByaXZhdGVDb250ZXh0KCktPmZsdXNoKCk7CiAgICAgICAgIGRlcHJlY2F0ZWRQcml2YXRlQ29u dGV4dCgpLT5zYXZlKCk7CiAgICAgICAgIHJldHVybiBkZXByZWNhdGVkUHJpdmF0ZUNvbnRleHQo KS0+bV9oZGM7Cg==