23176 2009-01-07 15:25:40 -0800 WebCore::Event::timeStamp() should be const 2009-01-08 16:30:57 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jamesr webkit-unassigned oldest_to_newest 104793 0 jamesr 2009-01-07 15:25:40 -0800 WebCore::Event's timeStamp() is a trivial accessor and should be const so code with a const reference or pointer can query the field. 104794 1 26509 jamesr 2009-01-07 15:26:36 -0800 Created attachment 26509 Changes the accessor to be const 104796 2 26509 sam 2009-01-07 15:32:40 -0800 Comment on attachment 26509 Changes the accessor to be const > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 39688) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,12 @@ > +2009-01-07 James Robinson <jamesr@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + WARNING: NO TEST CASES ADDED OR CHANGED Please add at least the name and url of the bug and short description of your change. 104798 3 26510 jamesr 2009-01-07 15:45:02 -0800 Created attachment 26510 Changes the accessor to be const and adds name/bug url to ChangeLog 104960 4 pam 2009-01-08 16:30:57 -0800 Landed in r39726. 26509 2009-01-07 15:26:36 -0800 2009-01-07 15:45:02 -0800 Changes the accessor to be const dom_event_patch.diff text/plain 1015 jamesr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTY4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDEtMDcgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBkb20v RXZlbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50Ojp0aW1lU3RhbXApOgorCiAyMDA5LTAx LTA3ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvZG9tL0V2ZW50LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9kb20vRXZlbnQuaAkocmV2aXNpb24gMzk2ODIpCisrKyBXZWJDb3JlL2RvbS9FdmVu dC5oCSh3b3JraW5nIGNvcHkpCkBAIC04Nyw3ICs4Nyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAogICAgICAgICBib29sIGJ1YmJsZXMoKSBjb25zdCB7IHJldHVybiBtX2NhbkJ1YmJsZTsgfQog ICAgICAgICBib29sIGNhbmNlbGFibGUoKSBjb25zdCB7IHJldHVybiBtX2NhbmNlbGFibGU7IH0K LSAgICAgICAgRE9NVGltZVN0YW1wIHRpbWVTdGFtcCgpIHsgcmV0dXJuIG1fY3JlYXRlVGltZTsg fQorICAgICAgICBET01UaW1lU3RhbXAgdGltZVN0YW1wKCkgY29uc3QgeyByZXR1cm4gbV9jcmVh dGVUaW1lOyB9CiAgICAgICAgIHZvaWQgc3RvcFByb3BhZ2F0aW9uKCkgeyBtX3Byb3BhZ2F0aW9u U3RvcHBlZCA9IHRydWU7IH0KIAogICAgICAgICAvLyBJRSBFeHRlbnNpb25zCg== 26510 2009-01-07 15:45:02 -0800 2009-01-07 16:24:53 -0800 Changes the accessor to be const and adds name/bug url to ChangeLog dom_event_patch.diff text/plain 1101 jamesr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTY4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDEtMDcgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2ViQ29yZTo6RXZlbnQ6OnRpbWVTdGFtcCgpIGlzIGEgc2ltcGxlIGFjY2Vzc29yIGFuZCBzaG91 bGQgYmUgY29uc3QKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjMxNzYKKworICAgICAgICAqIGRvbS9FdmVudC5oOgorICAgICAgICAoV2ViQ29yZTo6 RXZlbnQ6OnRpbWVTdGFtcCk6CisKIDIwMDktMDEtMDcgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29y ZS9kb20vRXZlbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9FdmVudC5oCShyZXZpc2lv biAzOTY4MikKKysrIFdlYkNvcmUvZG9tL0V2ZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTg3LDcg Kzg3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIGJvb2wgYnViYmxlcygpIGNv bnN0IHsgcmV0dXJuIG1fY2FuQnViYmxlOyB9CiAgICAgICAgIGJvb2wgY2FuY2VsYWJsZSgpIGNv bnN0IHsgcmV0dXJuIG1fY2FuY2VsYWJsZTsgfQotICAgICAgICBET01UaW1lU3RhbXAgdGltZVN0 YW1wKCkgeyByZXR1cm4gbV9jcmVhdGVUaW1lOyB9CisgICAgICAgIERPTVRpbWVTdGFtcCB0aW1l U3RhbXAoKSBjb25zdCB7IHJldHVybiBtX2NyZWF0ZVRpbWU7IH0KICAgICAgICAgdm9pZCBzdG9w UHJvcGFnYXRpb24oKSB7IG1fcHJvcGFnYXRpb25TdG9wcGVkID0gdHJ1ZTsgfQogCiAgICAgICAg IC8vIElFIEV4dGVuc2lvbnMK