231758 2021-10-14 12:33:19 -0700 Null check the context in -[WKWebProcessPlugInFrame jsContextForServiceWorkerWorld:] 2021-10-14 13:42:18 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy cdumez webkit-bug-importer oldest_to_newest 1804421 0 timothy 2021-10-14 12:33:19 -0700 _frame->jsContextForServiceWorkerWorld() can return nullptr, so we should null check before using the result. 1804425 1 441257 timothy 2021-10-14 12:37:45 -0700 Created attachment 441257 Patch 1804428 2 441257 cdumez 2021-10-14 12:38:25 -0700 Comment on attachment 441257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441257&action=review > Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:76 > + if (JSGlobalContextRef context = _frame->jsContextForServiceWorkerWorld(&[world _scriptWorld])) auto 1804433 3 441259 timothy 2021-10-14 12:40:57 -0700 Created attachment 441259 Patch 1804482 4 ews-feeder 2021-10-14 13:41:21 -0700 Committed r284195 (243009@main): <https://commits.webkit.org/243009@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441259. 1804483 5 webkit-bug-importer 2021-10-14 13:42:18 -0700 <rdar://problem/84272222> 441257 2021-10-14 12:37:45 -0700 2021-10-14 12:40:55 -0700 Patch bug-231758-20211014123744.patch text/plain 1848 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFmY2QwZTFlMWJiZGEyNTlj YjRjNDQ5Nzc4YzhjY2Q3OWEyMWRjNzAuLjZlNTkzOTM3NWE1Y2ZmMjhkNTVlNjIwYWFhNzA4ZDhh OGNmYTQxMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMTAtMTQgIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIE51bGwgY2hlY2sgdGhlIGNv bnRleHQgaW4gLVtXS1dlYlByb2Nlc3NQbHVnSW5GcmFtZSBqc0NvbnRleHRGb3JTZXJ2aWNlV29y a2VyV29ybGQ6XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMxNzU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVn SW5GcmFtZS5tbToKKyAgICAgICAgKC1bV0tXZWJQcm9jZXNzUGx1Z0luRnJhbWUganNDb250ZXh0 Rm9yU2VydmljZVdvcmtlcldvcmxkOl0pOgorICAgICAgICBfZnJhbWUtPmpzQ29udGV4dEZvclNl cnZpY2VXb3JrZXJXb3JsZCgpIGNhbiByZXR1cm4gbnVsbHB0ciwgc28gbnVsbCBjaGVjayBiZWZv cmUgdXNpbmcgdGhlIHJlc3VsdC4KKwogMjAyMS0xMC0xMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIERyb3AgbWFrZVdlYWtQdHIoKSBhbmQgdXNlIFdlYWtQdHIg eyB9IGRpcmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbkZyYW1lLm1tIGIvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVn SW5GcmFtZS5tbQppbmRleCAwZTBkZTVmN2VlODgzY2ZiNzNiY2I4NjJiZDMxNWZkZjgyMjU0MzY1 Li4wMDJjZjRjZDZkMDllM2Y0ODU3YjNlNzE5ZTY1Y2ZmMGFhZWE2ZWIxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJv Y2Vzc1BsdWdJbkZyYW1lLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3Rl ZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luRnJhbWUubW0KQEAgLTczLDcgKzcz LDkgQEAgLSAoSlNDb250ZXh0ICopanNDb250ZXh0Rm9yV29ybGQ6KFdLV2ViUHJvY2Vzc1BsdWdJ blNjcmlwdFdvcmxkICopd29ybGQKIAogLSAoSlNDb250ZXh0ICopanNDb250ZXh0Rm9yU2Vydmlj ZVdvcmtlcldvcmxkOihXS1dlYlByb2Nlc3NQbHVnSW5TY3JpcHRXb3JsZCAqKXdvcmxkCiB7Ci0g ICAgcmV0dXJuIFtKU0NvbnRleHQgY29udGV4dFdpdGhKU0dsb2JhbENvbnRleHRSZWY6X2ZyYW1l LT5qc0NvbnRleHRGb3JTZXJ2aWNlV29ya2VyV29ybGQoJlt3b3JsZCBfc2NyaXB0V29ybGRdKV07 CisgICAgaWYgKEpTR2xvYmFsQ29udGV4dFJlZiBjb250ZXh0ID0gX2ZyYW1lLT5qc0NvbnRleHRG b3JTZXJ2aWNlV29ya2VyV29ybGQoJlt3b3JsZCBfc2NyaXB0V29ybGRdKSkKKyAgICAgICAgcmV0 dXJuIFtKU0NvbnRleHQgY29udGV4dFdpdGhKU0dsb2JhbENvbnRleHRSZWY6Y29udGV4dF07Cisg ICAgcmV0dXJuIG5pbDsKIH0KIAogLSAoV0tXZWJQcm9jZXNzUGx1Z0luSGl0VGVzdFJlc3VsdCAq KWhpdFRlc3Q6KENHUG9pbnQpcG9pbnQK 441259 2021-10-14 12:40:57 -0700 2021-10-14 13:41:22 -0700 Patch bug-231758-20211014124056.patch text/plain 1831 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFmY2QwZTFlMWJiZGEyNTlj YjRjNDQ5Nzc4YzhjY2Q3OWEyMWRjNzAuLjk1ZTg0MzcwYjAzMGUyYzc3MGVmMGMyY2YyYmI2YTQz YWU5ZDlkMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMTAtMTQgIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIE51bGwgY2hlY2sgdGhlIGNv bnRleHQgaW4gLVtXS1dlYlByb2Nlc3NQbHVnSW5GcmFtZSBqc0NvbnRleHRGb3JTZXJ2aWNlV29y a2VyV29ybGQ6XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMxNzU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgRHVtZXouCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVnSW5G cmFtZS5tbToKKyAgICAgICAgKC1bV0tXZWJQcm9jZXNzUGx1Z0luRnJhbWUganNDb250ZXh0Rm9y U2VydmljZVdvcmtlcldvcmxkOl0pOgorICAgICAgICBfZnJhbWUtPmpzQ29udGV4dEZvclNlcnZp Y2VXb3JrZXJXb3JsZCgpIGNhbiByZXR1cm4gbnVsbHB0ciwgc28gbnVsbCBjaGVjayBiZWZvcmUg dXNpbmcgdGhlIHJlc3VsdC4KKwogMjAyMS0xMC0xMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIERyb3AgbWFrZVdlYWtQdHIoKSBhbmQgdXNlIFdlYWtQdHIgeyB9 IGRpcmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRC dW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbkZyYW1lLm1tIGIvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVnSW5G cmFtZS5tbQppbmRleCAwZTBkZTVmN2VlODgzY2ZiNzNiY2I4NjJiZDMxNWZkZjgyMjU0MzY1Li5m ZGFkMTMwZTAyYmMzYzU2OGFhNDk5NDczZTJiMWQ3ODA4NGFlMjRlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vz c1BsdWdJbkZyYW1lLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luRnJhbWUubW0KQEAgLTczLDcgKzczLDkg QEAgLSAoSlNDb250ZXh0ICopanNDb250ZXh0Rm9yV29ybGQ6KFdLV2ViUHJvY2Vzc1BsdWdJblNj cmlwdFdvcmxkICopd29ybGQKIAogLSAoSlNDb250ZXh0ICopanNDb250ZXh0Rm9yU2VydmljZVdv cmtlcldvcmxkOihXS1dlYlByb2Nlc3NQbHVnSW5TY3JpcHRXb3JsZCAqKXdvcmxkCiB7Ci0gICAg cmV0dXJuIFtKU0NvbnRleHQgY29udGV4dFdpdGhKU0dsb2JhbENvbnRleHRSZWY6X2ZyYW1lLT5q c0NvbnRleHRGb3JTZXJ2aWNlV29ya2VyV29ybGQoJlt3b3JsZCBfc2NyaXB0V29ybGRdKV07Cisg ICAgaWYgKGF1dG8gY29udGV4dCA9IF9mcmFtZS0+anNDb250ZXh0Rm9yU2VydmljZVdvcmtlcldv cmxkKCZbd29ybGQgX3NjcmlwdFdvcmxkXSkpCisgICAgICAgIHJldHVybiBbSlNDb250ZXh0IGNv bnRleHRXaXRoSlNHbG9iYWxDb250ZXh0UmVmOmNvbnRleHRdOworICAgIHJldHVybiBuaWw7CiB9 CiAKIC0gKFdLV2ViUHJvY2Vzc1BsdWdJbkhpdFRlc3RSZXN1bHQgKiloaXRUZXN0OihDR1BvaW50 KXBvaW50Cg==