231722 2021-10-13 22:33:02 -0700 Remove useless isConnected() check from HTMLDialogElement::close() 2021-10-14 00:05:15 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 84635 227537 1 ntim ntim cdumez changseok esprehn+autocc ews-watchlist gyuyoung.kim koivisto webkit-bug-importer oldest_to_newest 1804165 0 ntim 2021-10-13 22:33:02 -0700 https://webkit-search.igalia.com/webkit/source/Source/WebCore/html/HTMLDialogElement.cpp#98 There is already an early return in Element::focus when the element is not connected, so this check is redundant. See comment 25 in bug 227537. 1804167 1 441185 ntim 2021-10-13 23:00:21 -0700 Created attachment 441185 Patch 1804171 2 ews-feeder 2021-10-14 00:04:12 -0700 Committed r284149 (242969@main): <https://commits.webkit.org/242969@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441185. 1804172 3 webkit-bug-importer 2021-10-14 00:05:15 -0700 <rdar://problem/84236051> 441185 2021-10-13 23:00:21 -0700 2021-10-14 00:04:14 -0700 Patch bug-231722-20211014080020.patch text/plain 1556 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M2MWNjNWYyZjlmMWJl MDFlMWQxYWQyNjAxNjA4MTVlMTAwMGZjOS4uNTk3YTM0NTdhODQxMmI0YTk1MWE2M2I3NzUyNzJj OWE5NjFmZDNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTEzICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVzZWxlc3MgaXNDb25u ZWN0ZWQoKSBjaGVjayBmcm9tIEhUTUxEaWFsb2dFbGVtZW50OjpjbG9zZSgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE3MjIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBiZWhhdmlvciBjaGFuZ2Uu CisKKyAgICAgICAgRWxlbWVudDo6Zm9jdXMoKSBhbHJlYWR5IGVhcmx5IHJldHVybnMgaWYgdGhl IGVsZW1lbnQgaXMgZGlzY29ubmVjdGVkLCBzbyBpdCBpcyByZWR1bmRhbnQuCisKKyAgICAgICAg KiBodG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEaWFs b2dFbGVtZW50OjpjbG9zZSk6CisKIDIwMjEtMTAtMTMgIEdhYnJpZWwgTmF2YSBNYXJpbm8gIDxn bmF2YW1hcmlub0BhcHBsZS5jb20+CiAKICAgICAgICAgU2tpcCBmYWxsYmFja0ZvbnRzRm9yUnVu V2l0aEl0ZXJhdG9yIGZvciBlbXB0eSBydW5zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxv Z0VsZW1lbnQuY3BwCmluZGV4IDc2ZDZhMWRlNjI1NDVhZTEzYmRiNDg2YzVmNzA5ZDYyZTI2OGY4 Y2IuLjJmOTgyOTg2MDEyZjQyMTUwNGM1NjEwMjk2NzJmNzYxODQ2ZjAxMzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwCkBAIC05NSw3ICs5NSw3IEBAIHZvaWQg SFRNTERpYWxvZ0VsZW1lbnQ6OmNsb3NlKGNvbnN0IFN0cmluZyYgcmVzdWx0KQogICAgIGlmIChp c0luVG9wTGF5ZXIoKSkKICAgICAgICAgcmVtb3ZlRnJvbVRvcExheWVyKCk7CiAKLSAgICBpZiAo UmVmUHRyIGVsZW1lbnQgPSBzdGQ6OmV4Y2hhbmdlKG1fcHJldmlvdXNseUZvY3VzZWRFbGVtZW50 LCBudWxscHRyKS5nZXQoKTsgZWxlbWVudCAmJiBlbGVtZW50LT5pc0Nvbm5lY3RlZCgpKSB7Cisg ICAgaWYgKFJlZlB0ciBlbGVtZW50ID0gc3RkOjpleGNoYW5nZShtX3ByZXZpb3VzbHlGb2N1c2Vk RWxlbWVudCwgbnVsbHB0cikuZ2V0KCkpIHsKICAgICAgICAgRm9jdXNPcHRpb25zIG9wdGlvbnM7 CiAgICAgICAgIG9wdGlvbnMucHJldmVudFNjcm9sbCA9IHRydWU7CiAgICAgICAgIGVsZW1lbnQt PmZvY3VzKG9wdGlvbnMpOwo=