231716 2021-10-13 20:28:27 -0700 Compilation error: In file included from ./b3/B3StackmapGenerationParams.h:31: ./b3/B3ValueRep.h:119:5: error: definition of implicit copy assignment operator for 'ValueRep' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecat 2021-10-14 01:25:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jean-yves.avenard jean-yves.avenard ews-watchlist keith_miller mark.lam msaboff saam thorton tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1804136 0 jean-yves.avenard 2021-10-13 20:28:27 -0700 When compiling I get: In file included from ./b3/B3StackmapGenerationParams.h:31: ./b3/B3ValueRep.h:119:5: error: definition of implicit copy assignment operator for 'ValueRep' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy] ValueRep(const ValueRep&) = default; /b3/B3StackmapValue.cpp:77:19: note: in implicit copy assignment operator for 'JSC::B3::ValueRep' first required here m_reps[index] = rep; Per C++11 and later: “The generation of the implicitly-defined copy assignment operator is deprecated if T has a user-declared destructor or user-declared copy constructor. (since C++11)” so it's missing a copy assignment operator definition. 1804137 1 webkit-bug-importer 2021-10-13 20:28:58 -0700 <rdar://problem/84230556> 1804141 2 441180 jean-yves.avenard 2021-10-13 20:45:48 -0700 Created attachment 441180 Patch 1804151 3 ysuzuki 2021-10-13 21:22:52 -0700 Ah, I already landed unreviewed build fix https://github.com/WebKit/WebKit/commit/9068b467eb20d0e553678c13b8eeed8c8d5b7d93 :) 1804153 4 jean-yves.avenard 2021-10-13 21:35:03 -0700 (In reply to Yusuke Suzuki from comment #3) > Ah, I already landed unreviewed build fix > https://github.com/WebKit/WebKit/commit/ > 9068b467eb20d0e553678c13b8eeed8c8d5b7d93 :) that will fix it too. that copy constructor wasn't used. I hesitated between the two fixes 1804154 5 jean-yves.avenard 2021-10-13 21:36:08 -0700 been fixed already 441180 2021-10-13 20:45:48 -0700 2021-10-14 01:25:43 -0700 Patch bug-231716-20211014144547.patch text/plain 1840 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh YzUyN2RkNjgwMzY1ODg3NGNkZTAxMWY0OTcxNjgxYmE1MzMxZDlhLi4wZjc0YTA3NzU1NjQwZDYw ZmVkYzIzM2FlMWVlYWZlNTFhMzk1Mzc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMS0xMC0xMyAgSmVhbi1ZdmVzIEF2ZW5hcmQgIDxqeWFAYXBwbGUuY29t PgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiBlcnJvciBpbiAuL2IzL0IzU3RhY2ttYXBHZW5l cmF0aW9uUGFyYW1zLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzMTcxNgorICAgICAgICByZGFyOi8vcHJvYmxlbS84NDIzMDU1NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBlciBDKysxMSBhbmQgbGF0 ZXI6CisgICAgICAgIOKAnFRoZSBnZW5lcmF0aW9uIG9mIHRoZSBpbXBsaWNpdGx5LWRlZmluZWQg Y29weSBhc3NpZ25tZW50IG9wZXJhdG9yIGlzCisgICAgICAgIGRlcHJlY2F0ZWQgaWYgVCBoYXMg YSB1c2VyLWRlY2xhcmVkIGRlc3RydWN0b3Igb3IgdXNlci1kZWNsYXJlZCBjb3B5CisgICAgICAg IGNvbnN0cnVjdG9yLuKAnQorICAgICAgICBBIGNvcHkgY29uc3RydWN0b3IgaXMgZGVmaW5lZCwg c28gd2UgbmVlZCB0byBkZWNsYXJlIGEgY29weSBhc3NpZ25lbWVudCBvcGVyYXRvci4KKworICAg ICAgICAqIGIzL0IzVmFsdWVSZXAuaDoKKwogMjAyMS0xMC0xMyAgSmVhbi1ZdmVzIEF2ZW5hcmQg IDxqeWFAYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFybHkgZGlzdGluZ3Vpc2ggc2VyaWFsIGZy b20gY29uY3VycmVudCBXb3JrUXVldWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy9CM1ZhbHVlUmVwLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNWYWx1ZVJlcC5o CmluZGV4IDExYjc1Y2M3YmQ4YTk5OGE4YTQ0ODc5NmVjMmY2NjY0MTVjOWQzMTkuLmI0NzVhMjhj Mzc0YWM4Y2NjZGMwMWE5ZTY5OWQzYTZiMWZkYTE5YmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9iMy9CM1ZhbHVlUmVwLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Iz L0IzVmFsdWVSZXAuaApAQCAtMTA1LDEwICsxMDUsNyBAQCBwdWJsaWM6CiAgICAgICAgIENvbnN0 YW50CiAgICAgfTsKICAgICAKLSAgICBWYWx1ZVJlcCgpCi0gICAgICAgIDogbV9raW5kKFdhcm1B bnkpCi0gICAgewotICAgIH0KKyAgICBWYWx1ZVJlcCgpID0gZGVmYXVsdDsKIAogICAgIGV4cGxp Y2l0IFZhbHVlUmVwKFJlZyByZWcpCiAgICAgICAgIDogbV9raW5kKFJlZ2lzdGVyKQpAQCAtMTQ2 LDYgKzE0Myw4IEBAIHB1YmxpYzoKICAgICB9CiAjZW5kaWYKIAorICAgIFZhbHVlUmVwJiBvcGVy YXRvcj0oY29uc3QgVmFsdWVSZXAmKSA9IGRlZmF1bHQ7CisKICAgICBzdGF0aWMgVmFsdWVSZXAg cmVnKFJlZyByZWcpCiAgICAgewogICAgICAgICByZXR1cm4gVmFsdWVSZXAocmVnKTsKQEAgLTMy MCw3ICszMTksNyBAQCBwcml2YXRlOgogICAgICAgICAgICAgbWVtc2V0KHN0YXRpY19jYXN0PHZv aWQqPih0aGlzKSwgMCwgc2l6ZW9mKCp0aGlzKSk7CiAgICAgICAgIH0KICAgICB9IHU7Ci0gICAg S2luZCBtX2tpbmQ7CisgICAgS2luZCBtX2tpbmQgPSBXYXJtQW55OwogfTsKIAogfSB9IC8vIG5h bWVzcGFjZSBKU0M6OkIzCg==