231682 2021-10-13 10:18:49 -0700 REGRESSION (r283667): webgl/2.0.0/deqp/functional/gles3/lifetime.html fails 2021-10-15 16:57:21 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 229378 1 jonlee kpiddington dino ews-watchlist kbr kkinnunen kondapallykalyan kpiddington webkit-bug-importer oldest_to_newest 1803832 0 jonlee 2021-10-13 10:18:49 -0700 WebGL bot shows webgl/2.0.0/deqp/functional/gles3/lifetime.html fails after r283667. 1803834 1 webkit-bug-importer 2021-10-13 10:21:30 -0700 <rdar://problem/84204653> 1803839 2 kbr 2021-10-13 10:30:30 -0700 Kyle, could you investigate this regression? If shaders are failing to compile then arbitrary WebGL applications might be impacted. 1803935 3 441126 kpiddington 2021-10-13 13:25:17 -0700 Created attachment 441126 Patch 1803936 4 ews-watchlist 2021-10-13 13:26:26 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1804342 5 441126 kkinnunen 2021-10-14 10:51:54 -0700 Comment on attachment 441126 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441126&action=review some whitespace issues.. > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:261 > + << "ANGLE_vertexOut."; whitespace: maybe match the indent or align the whole statement. > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:262 > + if(!varying.isBuiltIn()) nit: space after if 1805083 6 441442 kpiddington 2021-10-15 15:42:44 -0700 Created attachment 441442 Patch for landing 1805131 7 ews-feeder 2021-10-15 16:57:19 -0700 Committed r284293 (243091@main): <https://commits.webkit.org/243091@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441442. 441126 2021-10-13 13:25:17 -0700 2021-10-15 15:42:42 -0700 Patch bug-231682-20211013132516.patch text/plain 2045 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZjRiZTQ3MDIwNWJhZjdjYWRlZjVkZTgyZDUzNjE2YzIzNTE5ZWQwYy4uOTZlZjI2MjViZmZm NGNmMDM2YzNjNDU0Zjk4NjgyZTQ1NjM2NTY4MCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEwLTEzICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI4MzY2Nyk6IHdlYmdsLzIu MC4wL2RlcXAvZnVuY3Rpb25hbC9nbGVzMy9saWZldGltZS5odG1sIGZhaWxzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE2ODIKKworICAgICAgICBU cmFuc2Zvcm0gZmVlZGJhY2sgc2hvdWxkIGF2b2lkIGFwcGVuZGluZyBfdSBmb3IgCisgICAgICAg IGJ1aWx0aW4gb3V0cHV0IHZhcmlhYmxlcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHNyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfZ2xz bGFuZ19tdGxfdXRpbHMubW06CisgICAgICAgIChyeDo6bXRsOjpHZW5lcmF0ZVRyYW5zZm9ybUZl ZWRiYWNrVmFyeWluZ091dHB1dCk6CisKIDIwMjEtMTAtMTIgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgSW52b2tlIFRoaXJkUGFydHkgYnVpbGQgc2NyaXB0 cyB3aXRoIHB5dGhvbjMgZXhwbGljaXRseQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkv QU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL210bF9nbHNsYW5nX210bF91dGlscy5t bSBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9t dGxfZ2xzbGFuZ19tdGxfdXRpbHMubW0KaW5kZXggZjYzYjhmOGNjODQ3NGUwYWFjODljZjFlOWVl ZGM0NzdiNWM3NzdmNC4uZDI4OWJiYWVkYzc2MzE3MWRkOWUyNWZjZDFlOWRhNTYyMDc1NWM3OSAx MDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVy L21ldGFsL210bF9nbHNsYW5nX210bF91dGlscy5tbQorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2dsc2xhbmdfbXRsX3V0aWxzLm1t CkBAIC0yNTgsNyArMjU4LDEyIEBAIHN0ZDo6c3RyaW5nIEdlbmVyYXRlVHJhbnNmb3JtRmVlZGJh Y2tWYXJ5aW5nT3V0cHV0KGNvbnN0IGdsOjpUcmFuc2Zvcm1GZWVkYmFja1ZhCiAgICAgICAgICAg ICAgICAgICAgICAgIDw8ICJdICsgKGdsX1ZlcnRleElEICsgQU5HTEVfaW5zdGFuY2VJZE1vZCAq ICIKICAgICAgICAgICAgICAgICAgICAgICAgPDwgIkFOR0xFXyIgPDwgc3RkOjpzdHJpbmcoc2g6 OmtVbmlmb3Jtc1ZhcikgPDwgIi5BTkdMRV94ZmJWZXJ0aWNlc1BlckRyYXcpICogIiA8PCBzdHJp ZGUKICAgICAgICAgICAgICAgICAgICAgICAgPDwgIiArICIgPDwgb2Zmc2V0IDw8ICJdID0gIiA8 PCAiYXNfdHlwZTxmbG9hdD4iIDw8ICIoIgotICAgICAgICAgICAgICAgICAgICAgICA8PCAiQU5H TEVfdmVydGV4T3V0LiIgPDwga1VzZXJEZWZpbmVkTmFtZVByZWZpeCA8PCB2YXJ5aW5nLm5hbWU7 CisgICAgICAgICAgICAgICAgPDwgIkFOR0xFX3ZlcnRleE91dC4iOworICAgICAgICAgICAgICAg IGlmKCF2YXJ5aW5nLmlzQnVpbHRJbigpKQorICAgICAgICAgICAgICAgIHsKKyAgICAgICAgICAg ICAgICAgICAgcmVzdWx0IDw8IGtVc2VyRGVmaW5lZE5hbWVQcmVmaXg7CisgICAgICAgICAgICAg ICAgfQorICAgICAgICAgICAgICAgIHJlc3VsdCA8PCB2YXJ5aW5nLm5hbWU7CiAKICAgICAgICAg ICAgICAgICBpZiAodmFyeWluZy5pc0FycmF5KCkpCiAgICAgICAgICAgICAgICAgewo= 441442 2021-10-15 15:42:44 -0700 2021-10-15 16:57:20 -0700 Patch for landing bug-231682-20211015154243.patch text/plain 2094 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0Mjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNWM0YzViMTM5MGNkNjdmMDUxYjlmYjYwMjdlMGM5MTJlZjU0OWQ2OS4uNDA3NTI2NTUyY2Rh YzlmY2YzZDFlNzYzZjQ3YTA0Njk3Y2ZiMTZiZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEwLTE1ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI4MzY2Nyk6IHdlYmdsLzIu MC4wL2RlcXAvZnVuY3Rpb25hbC9nbGVzMy9saWZldGltZS5odG1sIGZhaWxzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE2ODIKKworICAgICAgICBU cmFuc2Zvcm0gZmVlZGJhY2sgc2hvdWxkIGF2b2lkIGFwcGVuZGluZyBfdSBmb3IgCisgICAgICAg IGJ1aWx0aW4gb3V0cHV0IHZhcmlhYmxlcy4KKworICAgICAgICBSZXZpZXdlZCBieSBLaW1tbyBL aW5udW5lbi4KKworICAgICAgICAqIHNyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfZ2xz bGFuZ19tdGxfdXRpbHMubW06CisgICAgICAgIChyeDo6bXRsOjpHZW5lcmF0ZVRyYW5zZm9ybUZl ZWRiYWNrVmFyeWluZ091dHB1dCk6CisKIDIwMjEtMTAtMTQgIEt5bGUgUGlkZGluZ3RvbiAgPGtw aWRkaW5ndG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL3Rhbmtpb25saW5lLmNvbS9w bGF5LyBodG1sNSBlbmdpbmUgbm90IHdvcmtpbmc6IGNyYXNoZXMuIChNZXRhbCBzaGFkZXIgbm90 IHdvcmtpbmcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5H TEUvcmVuZGVyZXIvbWV0YWwvbXRsX2dsc2xhbmdfbXRsX3V0aWxzLm1tIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL210bF9nbHNsYW5nX210bF91 dGlscy5tbQppbmRleCBmNjNiOGY4Y2M4NDc0ZTBhYWM4OWNmMWU5ZWVkYzQ3N2I1Yzc3N2Y0Li4z ZTc5YjIwNjNiMjQyMjk0YzRmNzRjZDQxODcwMzBjZjAwYzY0MDk5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX2dsc2xh bmdfbXRsX3V0aWxzLm1tCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdM RS9yZW5kZXJlci9tZXRhbC9tdGxfZ2xzbGFuZ19tdGxfdXRpbHMubW0KQEAgLTI1OCw3ICsyNTgs MTIgQEAgc3RkOjpzdHJpbmcgR2VuZXJhdGVUcmFuc2Zvcm1GZWVkYmFja1ZhcnlpbmdPdXRwdXQo Y29uc3QgZ2w6OlRyYW5zZm9ybUZlZWRiYWNrVmEKICAgICAgICAgICAgICAgICAgICAgICAgPDwg Il0gKyAoZ2xfVmVydGV4SUQgKyBBTkdMRV9pbnN0YW5jZUlkTW9kICogIgogICAgICAgICAgICAg ICAgICAgICAgICA8PCAiQU5HTEVfIiA8PCBzdGQ6OnN0cmluZyhzaDo6a1VuaWZvcm1zVmFyKSA8 PCAiLkFOR0xFX3hmYlZlcnRpY2VzUGVyRHJhdykgKiAiIDw8IHN0cmlkZQogICAgICAgICAgICAg ICAgICAgICAgICA8PCAiICsgIiA8PCBvZmZzZXQgPDwgIl0gPSAiIDw8ICJhc190eXBlPGZsb2F0 PiIgPDwgIigiCi0gICAgICAgICAgICAgICAgICAgICAgIDw8ICJBTkdMRV92ZXJ0ZXhPdXQuIiA8 PCBrVXNlckRlZmluZWROYW1lUHJlZml4IDw8IHZhcnlpbmcubmFtZTsKKyAgICAgICAgICAgICAg ICAgICAgICAgPDwgIkFOR0xFX3ZlcnRleE91dC4iOworICAgICAgICAgICAgICAgIGlmICghdmFy eWluZy5pc0J1aWx0SW4oKSkKKyAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAg IHJlc3VsdCA8PCBrVXNlckRlZmluZWROYW1lUHJlZml4OworICAgICAgICAgICAgICAgIH0KKyAg ICAgICAgICAgICAgICByZXN1bHQgPDwgdmFyeWluZy5uYW1lOwogCiAgICAgICAgICAgICAgICAg aWYgKHZhcnlpbmcuaXNBcnJheSgpKQogICAgICAgICAgICAgICAgIHsK