231672 2021-10-13 06:15:39 -0700 CLang build warning in CheckedPtr.h 2021-10-13 07:34:17 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand achristensen benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer oldest_to_newest 1803724 0 pnormand 2021-10-13 06:15:39 -0700 /app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/CheckedPtr.h:108:52: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] inline const T& operator*() const { do { if (!(this)) { WTFReportAssertionFailure("/app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/CheckedPtr.h", 108, __PRETTY_FUNCTION__, "this"); do { WTF::isIntegralOrPointerType(); compilerFenceForCrash(); WTFCrashWithInfo(108, "/app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/CheckedPtr.h", __PRETTY_FUNCTION__, 2989); } while (false); } } while (0); return *get(); } ~ ^~~~ /app/webkit/Source/WebCore/layout/integration/LayoutIntegrationInlineContent.h:74:51: note: in instantiation of member function 'WTF::CheckedPtr<const WebCore::LayoutIntegration::LineLayout>::operator*' requested here const LineLayout& lineLayout() const { return *m_lineLayout; } ^ 2 warnings generated. 1803725 1 441065 pnormand 2021-10-13 06:21:52 -0700 Created attachment 441065 Patch 1803737 2 441068 pnormand 2021-10-13 06:39:31 -0700 Created attachment 441068 Patch 1803738 3 441069 pnormand 2021-10-13 06:39:58 -0700 Created attachment 441069 Patch 1803760 4 ews-feeder 2021-10-13 07:33:13 -0700 Committed r284092 (242920@main): <https://commits.webkit.org/242920@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441069. 1803761 5 webkit-bug-importer 2021-10-13 07:34:17 -0700 <rdar://problem/84197572> 441065 2021-10-13 06:21:52 -0700 2021-10-13 06:39:25 -0700 Patch bug-231672-20211013062151.patch text/plain 1626 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBjNjBkMTlhYTE1ZTg1ODJmMDEyMjE4 ZWY5ZGRjYTIzMzhhZDBjNDYuLjQ2ZWEyMzcwMDgwNGFkZmJlZDg1MzJjOTZhOTE0YjdkODZhYTMz ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTAtMTMgIFBoaWxpcHBlIE5vcm1hbmQgIDxw bm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIENMYW5nIGJ1aWxkIHdhcm5pbmcgaW4gQ2hl Y2tlZFB0ci5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzE2NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBc3NlcnQgb24gdGhlIHdyYXBwZWQgcG9pbnRlci4gQXNzZXJ0aW5nIG9uIGB0aGlzYCBhbHdh eXMgcmVzdWx0cyB0byB0cnVlLCBkZWZlYXRpbmcgdGhlCisgICAgICAgIHB1cnBvc2Ugb2YgdGhl IEFTU0VSVC4KKworICAgICAgICAqIHd0Zi9DaGVja2VkUHRyLmg6CisgICAgICAgIChXVEY6OkNo ZWNrZWRQdHI6Om9wZXJhdG9yKiBjb25zdCk6CisgICAgICAgIChXVEY6OkNoZWNrZWRQdHI6Om9w ZXJhdG9yKik6CisKIDIwMjEtMTAtMTIgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBVc2Ugc3RkOjp2YXJpYW50IGluc3RlYWQgb2YgV1RGOjpW YXJpYW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9DaGVja2VkUHRyLmggYi9Tb3VyY2Uv V1RGL3d0Zi9DaGVja2VkUHRyLmgKaW5kZXggYTc0YjhkZGFkZGRlOTZhMDVkNWI1ZDFjZjBkN2Q4 Yjc0YzAwYzEyMi4uYTFjZjE2MzFmZGNhOWMyZmE4ZDk4OWFjNzhkOTUwOWEzYjc4ODNiZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ2hlY2tlZFB0ci5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L0NoZWNrZWRQdHIuaApAQCAtMTA1LDggKzEwNSw4IEBAIHB1YmxpYzoKIAogICAgIEFMV0FZU19J TkxJTkUgY29uc3QgVCogZ2V0KCkgY29uc3QgeyByZXR1cm4gUHRyVHJhaXRzOjp1bndyYXAobV9w dHIpOyB9CiAgICAgQUxXQVlTX0lOTElORSBUKiBnZXQoKSB7IHJldHVybiBQdHJUcmFpdHM6OnVu d3JhcChtX3B0cik7IH0KLSAgICBBTFdBWVNfSU5MSU5FIGNvbnN0IFQmIG9wZXJhdG9yKigpIGNv bnN0IHsgQVNTRVJUKHRoaXMpOyByZXR1cm4gKmdldCgpOyB9Ci0gICAgQUxXQVlTX0lOTElORSBU JiBvcGVyYXRvciooKSB7IEFTU0VSVCh0aGlzKTsgcmV0dXJuICpnZXQoKTsgfQorICAgIEFMV0FZ U19JTkxJTkUgY29uc3QgVCYgb3BlcmF0b3IqKCkgY29uc3QgeyBBU1NFUlQobV9wdHIpOyByZXR1 cm4gKmdldCgpOyB9CisgICAgQUxXQVlTX0lOTElORSBUJiBvcGVyYXRvciooKSB7IEFTU0VSVCht X3B0cik7IHJldHVybiAqZ2V0KCk7IH0KICAgICBBTFdBWVNfSU5MSU5FIGNvbnN0IFQqIG9wZXJh dG9yLT4oKSBjb25zdCB7IHJldHVybiBnZXQoKTsgfQogICAgIEFMV0FZU19JTkxJTkUgVCogb3Bl cmF0b3ItPigpIHsgcmV0dXJuIGdldCgpOyB9CiAK 441068 2021-10-13 06:39:31 -0700 2021-10-13 06:39:52 -0700 Patch bug-231672-20211013063929.patch text/plain 1626 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBjNjBkMTlhYTE1ZTg1ODJmMDEyMjE4 ZWY5ZGRjYTIzMzhhZDBjNDYuLjQ2ZWEyMzcwMDgwNGFkZmJlZDg1MzJjOTZhOTE0YjdkODZhYTMz ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTAtMTMgIFBoaWxpcHBlIE5vcm1hbmQgIDxw bm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIENMYW5nIGJ1aWxkIHdhcm5pbmcgaW4gQ2hl Y2tlZFB0ci5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzE2NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBc3NlcnQgb24gdGhlIHdyYXBwZWQgcG9pbnRlci4gQXNzZXJ0aW5nIG9uIGB0aGlzYCBhbHdh eXMgcmVzdWx0cyB0byB0cnVlLCBkZWZlYXRpbmcgdGhlCisgICAgICAgIHB1cnBvc2Ugb2YgdGhl IEFTU0VSVC4KKworICAgICAgICAqIHd0Zi9DaGVja2VkUHRyLmg6CisgICAgICAgIChXVEY6OkNo ZWNrZWRQdHI6Om9wZXJhdG9yKiBjb25zdCk6CisgICAgICAgIChXVEY6OkNoZWNrZWRQdHI6Om9w ZXJhdG9yKik6CisKIDIwMjEtMTAtMTIgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBVc2Ugc3RkOjp2YXJpYW50IGluc3RlYWQgb2YgV1RGOjpW YXJpYW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9DaGVja2VkUHRyLmggYi9Tb3VyY2Uv V1RGL3d0Zi9DaGVja2VkUHRyLmgKaW5kZXggYTc0YjhkZGFkZGRlOTZhMDVkNWI1ZDFjZjBkN2Q4 Yjc0YzAwYzEyMi4uYTFjZjE2MzFmZGNhOWMyZmE4ZDk4OWFjNzhkOTUwOWEzYjc4ODNiZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ2hlY2tlZFB0ci5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L0NoZWNrZWRQdHIuaApAQCAtMTA1LDggKzEwNSw4IEBAIHB1YmxpYzoKIAogICAgIEFMV0FZU19J TkxJTkUgY29uc3QgVCogZ2V0KCkgY29uc3QgeyByZXR1cm4gUHRyVHJhaXRzOjp1bndyYXAobV9w dHIpOyB9CiAgICAgQUxXQVlTX0lOTElORSBUKiBnZXQoKSB7IHJldHVybiBQdHJUcmFpdHM6OnVu d3JhcChtX3B0cik7IH0KLSAgICBBTFdBWVNfSU5MSU5FIGNvbnN0IFQmIG9wZXJhdG9yKigpIGNv bnN0IHsgQVNTRVJUKHRoaXMpOyByZXR1cm4gKmdldCgpOyB9Ci0gICAgQUxXQVlTX0lOTElORSBU JiBvcGVyYXRvciooKSB7IEFTU0VSVCh0aGlzKTsgcmV0dXJuICpnZXQoKTsgfQorICAgIEFMV0FZ U19JTkxJTkUgY29uc3QgVCYgb3BlcmF0b3IqKCkgY29uc3QgeyBBU1NFUlQobV9wdHIpOyByZXR1 cm4gKmdldCgpOyB9CisgICAgQUxXQVlTX0lOTElORSBUJiBvcGVyYXRvciooKSB7IEFTU0VSVCht X3B0cik7IHJldHVybiAqZ2V0KCk7IH0KICAgICBBTFdBWVNfSU5MSU5FIGNvbnN0IFQqIG9wZXJh dG9yLT4oKSBjb25zdCB7IHJldHVybiBnZXQoKTsgfQogICAgIEFMV0FZU19JTkxJTkUgVCogb3Bl cmF0b3ItPigpIHsgcmV0dXJuIGdldCgpOyB9CiAK 441069 2021-10-13 06:39:58 -0700 2021-10-13 07:33:15 -0700 Patch bug-231672-20211013063956.patch text/plain 1626 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBjNjBkMTlhYTE1ZTg1ODJmMDEyMjE4 ZWY5ZGRjYTIzMzhhZDBjNDYuLjQ2ZWEyMzcwMDgwNGFkZmJlZDg1MzJjOTZhOTE0YjdkODZhYTMz ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTAtMTMgIFBoaWxpcHBlIE5vcm1hbmQgIDxw bm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIENMYW5nIGJ1aWxkIHdhcm5pbmcgaW4gQ2hl Y2tlZFB0ci5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzE2NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBc3NlcnQgb24gdGhlIHdyYXBwZWQgcG9pbnRlci4gQXNzZXJ0aW5nIG9uIGB0aGlzYCBhbHdh eXMgcmVzdWx0cyB0byB0cnVlLCBkZWZlYXRpbmcgdGhlCisgICAgICAgIHB1cnBvc2Ugb2YgdGhl IEFTU0VSVC4KKworICAgICAgICAqIHd0Zi9DaGVja2VkUHRyLmg6CisgICAgICAgIChXVEY6OkNo ZWNrZWRQdHI6Om9wZXJhdG9yKiBjb25zdCk6CisgICAgICAgIChXVEY6OkNoZWNrZWRQdHI6Om9w ZXJhdG9yKik6CisKIDIwMjEtMTAtMTIgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBVc2Ugc3RkOjp2YXJpYW50IGluc3RlYWQgb2YgV1RGOjpW YXJpYW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9DaGVja2VkUHRyLmggYi9Tb3VyY2Uv V1RGL3d0Zi9DaGVja2VkUHRyLmgKaW5kZXggYTc0YjhkZGFkZGRlOTZhMDVkNWI1ZDFjZjBkN2Q4 Yjc0YzAwYzEyMi4uYTFjZjE2MzFmZGNhOWMyZmE4ZDk4OWFjNzhkOTUwOWEzYjc4ODNiZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ2hlY2tlZFB0ci5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L0NoZWNrZWRQdHIuaApAQCAtMTA1LDggKzEwNSw4IEBAIHB1YmxpYzoKIAogICAgIEFMV0FZU19J TkxJTkUgY29uc3QgVCogZ2V0KCkgY29uc3QgeyByZXR1cm4gUHRyVHJhaXRzOjp1bndyYXAobV9w dHIpOyB9CiAgICAgQUxXQVlTX0lOTElORSBUKiBnZXQoKSB7IHJldHVybiBQdHJUcmFpdHM6OnVu d3JhcChtX3B0cik7IH0KLSAgICBBTFdBWVNfSU5MSU5FIGNvbnN0IFQmIG9wZXJhdG9yKigpIGNv bnN0IHsgQVNTRVJUKHRoaXMpOyByZXR1cm4gKmdldCgpOyB9Ci0gICAgQUxXQVlTX0lOTElORSBU JiBvcGVyYXRvciooKSB7IEFTU0VSVCh0aGlzKTsgcmV0dXJuICpnZXQoKTsgfQorICAgIEFMV0FZ U19JTkxJTkUgY29uc3QgVCYgb3BlcmF0b3IqKCkgY29uc3QgeyBBU1NFUlQobV9wdHIpOyByZXR1 cm4gKmdldCgpOyB9CisgICAgQUxXQVlTX0lOTElORSBUJiBvcGVyYXRvciooKSB7IEFTU0VSVCht X3B0cik7IHJldHVybiAqZ2V0KCk7IH0KICAgICBBTFdBWVNfSU5MSU5FIGNvbnN0IFQqIG9wZXJh dG9yLT4oKSBjb25zdCB7IHJldHVybiBnZXQoKTsgfQogICAgIEFMV0FZU19JTkxJTkUgVCogb3Bl cmF0b3ItPigpIHsgcmV0dXJuIGdldCgpOyB9CiAK