231653 2021-10-12 19:02:56 -0700 [TextureMapper] large blur filter doesn't look smooth 2023-09-07 03:00:45 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=87695 InRadar P2 Normal --- 261022 261101 261102 1 fujii webkit-unassigned aki.develop8128 cgarcia kdwkleung smoley webkit-bug-importer oldest_to_newest 1803618 0 fujii 2021-10-12 19:02:56 -0700 [TextureMapper] large blur filter doesn't look smooth attachment#413757 https://speakerdeck.com/trishagee/code-review-best-practice 1806454 1 webkit-bug-importer 2021-10-19 19:03:20 -0700 <rdar://problem/84444307> 1811325 2 smoley 2021-11-02 17:19:27 -0700 Thanks for filing, the attached test case and the linked page both look smooth for me on Safari Technology Preview 134. Are you seeing this issue there as well? 1811339 3 fujii 2021-11-02 18:23:25 -0700 TextureMapper is used only by GTK, WPE, WinCairo and PlayStation ports. 1844425 4 452789 fujii 2022-02-21 15:56:44 -0800 Created attachment 452789 test case 1878447 5 fujii 2022-06-26 23:09:27 -0700 FEGaussianBlurSoftwareApplier::boxBlurUnaccelerated is applying box-blur three times. https://github.com/WebKit/WebKit/blob/a713d4c4e774133040e273ce5c2ec5e8ebf85e02/Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp#L302-L328 This is suggested by the spec: https://drafts.fxtf.org/filter-effects/#feGaussianBlurElement > For larger values of "s" (s >= 2.0), an approximation can be > used: Three successive box-blurs build a piece-wise quadratic > convolution kernel, which approximates the Gaussian kernel to > within roughly 3%. 1974941 6 aki.develop8128 2023-09-01 00:30:52 -0700 I will tackle this issue under mentorship of Fujii-san. 1976037 7 fujii 2023-09-06 20:33:30 -0700 All sub tasks have been resovled. No more remaining tasks. Closed. 1976062 8 cgarcia 2023-09-07 00:40:02 -0700 Could you add a link here to the PR fixing this issue? 1976063 9 fujii 2023-09-07 00:48:43 -0700 https://github.com/WebKit/WebKit/pull/17419 fixed the pixelated problem. https://github.com/WebKit/WebKit/pull/17471 is a speed up Gaussian blur filtrer. 1976086 10 cgarcia 2023-09-07 03:00:45 -0700 Thanks, great job! 452789 2022-02-21 15:56:44 -0800 2022-02-21 15:56:44 -0800 test case drop-shadow-and-blur.html text/html 452 fujii PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPHN0eWxlPgogICAgICBkaXYgewog ICAgICAgICAgbWFyZ2luOiAyMDBweCAyMDBweDsKICAgICAgICAgIHdpZHRoOiAyMDBweDsKICAg ICAgICAgIGhlaWdodDogMjAwcHg7CiAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsK ICAgICAgICAgIHdpbGwtY2hhbmdlOiB0cmFuc2Zvcm07CiAgICAgIH0KICAgICAgI3ggewogICAg ICAgICAgZmlsdGVyOiBkcm9wLXNoYWRvdygwIDAgNTBweCBibGFjayk7CiAgICAgIH0KICAgICAg I3kgewoJICBmaWx0ZXI6IGJsdXIoNTBweCk7CiAgICAgIH0KICAgIDwvc3R5bGU+CiAgPC9oZWFk PgogIDxib2R5PgogICAgZHJvcC1zaGFkb3cgZmlsdGVyCiAgICA8ZGl2IGlkPXg+PC9kaXY+CiAg ICBibHVyIGZpbHRlcgogICAgPGRpdiBpZD15PjwvZGl2PgogIDwvYm9keT4KPC9odG1sPgo=