23163 2009-01-07 07:33:26 -0800 suppress scrolling in Element::updateFocusAppearance 2010-01-29 13:41:39 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 23145 1 caryclark caryclark darin eric tonikitoo oldest_to_newest 104713 0 caryclark 2009-01-07 07:33:26 -0800 A device with a directional pad may set the focus while navigating, to allow javascript to modify the DOM as appropriate. The same directional pad may navigate by scrolling -- and there's no way to know if the user intended to move the focus or scroll. On the desktop, changing the focus also attempts to scroll the focused element into view. This is undesirable for devices that use a directional pad for navigation. (patch depends on 23145 for the definition of ENABLE_DIRECTIONAL_PAD_NAVIGATION) 104716 1 26491 caryclark 2009-01-07 07:39:25 -0800 Created attachment 26491 don't scroll when setting focus for devices with directional pad navigation 105159 2 26491 darin 2009-01-10 15:49:24 -0800 Comment on attachment 26491 don't scroll when setting focus for devices with directional pad navigation It seems to me that the real issue here isn't exactly "directional pad navigation" -- it's more "small screen with explicit scrolling", and I suppose the explicit scrolling part is what's really relevant. I could easily imagine someone using WebKit on a web browser for a TV screen, and using a directional pad on a remote control. It's entirely unclear to me whether the presence of the directional pad would also cause the developers to want this behavior in that case. I'm going to say r=me with this, but I think we're being a bit unclear on what DIRECTIONAL_PAD_NAVIGATION means and that could become a problem down the line. 108367 3 eric 2009-02-04 16:36:16 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/Element.cpp Committed r40647 108376 4 eric 2009-02-04 17:28:07 -0800 Patch was wrong, fixed: Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/Element.cpp Committed r40654 185477 5 tonikitoo 2010-01-28 07:39:45 -0800 it is interesing that this patch landed, and its BLOCKER did not. It introduced: ======================================= #if !ENABLE(DIRECTIONAL_PAD_NAVIGATION) else if (renderer() && !renderer()->isWidget()) renderer()->enclosingLayer()->scrollRectToVisible(getRect()); #endif ======================================= but DIRECTIONAL_PAD_NAVIGATION is not even in Platform.h . Grep'ing for it outputs only: $ grep -nHR DIRECTIONAL_PAD_NAVIGATION . ./WebCore/dom/Element.cpp:1293:#if !ENABLE(DIRECTIONAL_PAD_NAVIGATION) cc'ing darin who reviwed and eric who landed it. 185948 6 darin 2010-01-29 13:41:39 -0800 This is something that was put in for Android. Beyond that I have little insight into what it is or if it should be removed or kept. 26491 2009-01-07 07:39:25 -0800 2009-01-10 15:49:24 -0800 don't scroll when setting focus for devices with directional pad navigation patchForBug23163.txt text/plain 1251 caryclark SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTY3OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDEtMDcgIENhcnkgQ2xhcmsgIDxjYXJ5Y2xhcmtAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxNjMKKyAgICAgICAgRG9u J3Qgc2Nyb2xsIHRvIHNob3cgY3VycmVudCBmb2N1cyBvbiBkZXZpY2VzIHRoYXQgdXNlCisgICAg ICAgIGRpcmVjdGlvbmFsIHBhZHMgZm9yIG5hdmlnYXRpb24uCisKKyAgICAgICAgKiBkb20vRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50Ojp1cGRhdGVGb2N1c0FwcGVhcmFu Y2UpOgorCiAyMDA5LTAxLTA3ICBBcml5YSBIaWRheWF0ICA8YXJpeWEuaGlkYXlhdEB0cm9sbHRl Y2guY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRl eDogV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vRWxl bWVudC5jcHAJKHJldmlzaW9uIDM5NjYwKQorKysgV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTExMDMsOCArMTEwMywxMSBAQCB2b2lkIEVsZW1lbnQ6OnVwZGF0ZUZv Y3VzQXBwZWFyYW5jZShib29sCiAgICAgICAgICAgICBmcmFtZS0+c2VsZWN0aW9uKCktPnNldFNl bGVjdGlvbihuZXdTZWxlY3Rpb24pOwogICAgICAgICAgICAgZnJhbWUtPnJldmVhbFNlbGVjdGlv bigpOwogICAgICAgICB9Ci0gICAgfSBlbHNlIGlmIChyZW5kZXJlcigpICYmICFyZW5kZXJlcigp LT5pc1dpZGdldCgpKQorICAgIH0gCisjaWYgRU5BQkxFKERJUkVDVElPTkFMX1BBRF9OQVZJR0FU SU9OKSAgICAKKyAgICBlbHNlIGlmIChyZW5kZXJlcigpICYmICFyZW5kZXJlcigpLT5pc1dpZGdl dCgpKQogICAgICAgICByZW5kZXJlcigpLT5lbmNsb3NpbmdMYXllcigpLT5zY3JvbGxSZWN0VG9W aXNpYmxlKGdldFJlY3QoKSk7CisjZW5kaWYKIH0KIAogdm9pZCBFbGVtZW50OjpibHVyKCkK