231626 2021-10-12 14:56:54 -0700 Upstream ANGLE: PrimitiveRestart tests fail due to incorrect draw commands 2021-10-13 14:34:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kpiddington kpiddington dino ews-watchlist kbr kondapallykalyan webkit-bug-importer oldest_to_newest 1803427 0 kpiddington 2021-10-12 14:56:54 -0700 Upstream ANGLE: PrimitiveRestart tests fail due to incorrect draw commands 1803432 1 440990 kpiddington 2021-10-12 14:59:08 -0700 Created attachment 440990 Patch 1803435 2 ews-watchlist 2021-10-12 15:00:14 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1803490 3 440990 kbr 2021-10-12 15:46:26 -0700 Comment on attachment 440990 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440990&action=review Looks good - one comment. r+ > Source/ThirdParty/ANGLE/ChangeLog:10 > + index buffer was aliased / reused. Please mention "Cherry-pick from upstream anglebug.com/6535" or similar to keep the association clear. 1803952 4 441132 kpiddington 2021-10-13 13:52:35 -0700 Created attachment 441132 Patch for landing 1803971 5 ews-feeder 2021-10-13 14:33:08 -0700 Committed r284125 (242945@main): <https://commits.webkit.org/242945@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441132. 1803972 6 webkit-bug-importer 2021-10-13 14:34:18 -0700 <rdar://problem/84217315> 440990 2021-10-12 14:59:08 -0700 2021-10-13 13:52:33 -0700 Patch bug-231626-20211012145907.patch text/plain 2661 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMDI4OWExOTI4MjQ4YWU2MTg4MWQ0NzUxODBhOWIxNjBiZDUwNDc0MC4uMDcwNmIyYTdhYjMw YWYyZmJmN2IyZWVlMzgwZTc2MTcwZGQ5ZDVkYiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEwLTEyICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXBzdHJlYW0gQU5HTEU6IFByaW1pdGl2ZVJlc3Rh cnQgdGVzdHMgZmFpbCBkdWUgdG8gaW5jb3JyZWN0IGRyYXcgY29tbWFuZHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTYyNgorICAgICAgICA8cmRh cjovcHJvYmxlbS84NDE2NzI0MT4KKyAgIAorICAgICAgICBQcmltaXRpdmUgcmVzdGFydCBkcmF3 IGNvbW1hbmRzIHdlcmUgYmVpbmcgZW5jb2RlZAorICAgICAgICBpbmNvcnJlY3RseS4gU2luZ2xl IGVsZW1lbnQgcmFuZ2VzIHdlcmUgYmVpbmcgZGlzcmVnYXJkZWQsCisgICAgICAgIGFuZCBhIG1h eGltdW0gZHJhdyBzaXplIHdhcyBub3QgYmVpbmcgZW5mb3JjZWQgd2hlbiB0aGUKKyAgICAgICAg aW5kZXggYnVmZmVyIHdhcyBhbGlhc2VkIC8gcmV1c2VkLgorICAgIAorICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9saWJBTkdMRS9yZW5kZXJlci9t ZXRhbC9WZXJ0ZXhBcnJheU10bC5tbToKKyAgICAgICAgKHJ4OjpWZXJ0ZXhBcnJheU10bDo6Z2V0 RHJhd0luZGljZXMpOgorCiAyMDIxLTEwLTA2ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGluZ3Rv bkBhcHBsZS5jb20+CiAKICAgICAgICAgU2hhZGVydG95ICJ0cnVjaGV0IGRpc3RyaWN0IiBmYWls cyB0byBjb21waWxlIHdpdGggZXJyb3I6IEludGVybmFsIGVycm9yIGNvbXBpbGluZyBzaGFkZXIg d2l0aCBNZXRhbCBiYWNrZW5kIgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv c3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL1ZlcnRleEFycmF5TXRsLm1tIGIvU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL1ZlcnRleEFycmF5TXRs Lm1tCmluZGV4IDJiODdmMDUxZWU0NzIxNDllOWFlMDZlOGE2NjQwNjVjOWViMmRlN2QuLjMwMmVh OGEwZTYyMjNjYTU2MzdkOTNhM2E5MWVhOTk5NTdlYjBmMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9WZXJ0ZXhBcnJheU10 bC5tbQorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIv bWV0YWwvVmVydGV4QXJyYXlNdGwubW0KQEAgLTc4NywxMCArNzg3LDE0IEBAIHN0ZDo6dmVjdG9y PERyYXdDb21tYW5kUmFuZ2U+IFZlcnRleEFycmF5TXRsOjpnZXREcmF3SW5kaWNlcyhjb25zdCBn bDo6Q29udGV4dCAqCiAgICAgewogICAgICAgICBpZiAocmFuZ2UucmVzdGFydEJlZ2luID4gY3Vy cmVudEluZGV4T2Zmc2V0KQogICAgICAgICB7Ci0gICAgICAgICAgICBpbnQ2NF90IG5JbmRpY2Vz SW5TbGljZSA9ICgoaW50NjRfdClyYW5nZS5yZXN0YXJ0QmVnaW4gLSBjdXJyZW50SW5kZXhPZmZz ZXQpIC0gKChpbnQ2NF90KSByYW5nZS5yZXN0YXJ0QmVnaW4gLSBjdXJyZW50SW5kZXhPZmZzZXQp ICUgbkluZGljZXNQZXJQcmltaXRpdmU7CisgICAgICAgICAgICBpbnQ2NF90IG5JbmRpY2VzSW5T bGljZSA9IE1JTigoKGludDY0X3QpcmFuZ2UucmVzdGFydEJlZ2luIC0gY3VycmVudEluZGV4T2Zm c2V0KSAtCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoKGludDY0 X3QpcmFuZ2UucmVzdGFydEJlZ2luIC0gY3VycmVudEluZGV4T2Zmc2V0KSAlIG5JbmRpY2VzUGVy UHJpbWl0aXZlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbmRpY2Vz TGVmdCk7CiAgICAgICAgICAgICBzaXplX3QgcmVzdGFydFNpemUgPSAocmFuZ2UucmVzdGFydEVu ZCAtIHJhbmdlLnJlc3RhcnRCZWdpbikgKyAxOwotICAgICAgICAgICAgaWYgKG5JbmRpY2VzSW5T bGljZSA+IG5JbmRpY2VzUGVyUHJpbWl0aXZlKQorICAgICAgICAgICAgaWYgKG5JbmRpY2VzSW5T bGljZSA+PSBuSW5kaWNlc1BlclByaW1pdGl2ZSkKKyAgICAgICAgICAgIHsKICAgICAgICAgICAg ICAgICBkcmF3Q29tbWFuZHMucHVzaF9iYWNrKHsodWludDMyX3QpIG5JbmRpY2VzSW5TbGljZSwg Y3VycmVudEluZGV4T2Zmc2V0ICogaW5kZXhUeXBlQnl0ZXN9KTsKKyAgICAgICAgICAgIH0KICAg ICAgICAgICAgIC8vIEFjY291bnQgZm9yIGRyb3BwZWQgaW5kaWNlcyBkdWUgdG8gaW5jb21wbGV0 ZSBwcmltaXRpdmVzLgogICAgICAgICAgICAgc2l6ZV90IGluZGljZXNVc2VkID0gKCAocmFuZ2Uu cmVzdGFydEJlZ2luICsgcmVzdGFydFNpemUpIC0gY3VycmVudEluZGV4T2Zmc2V0KTsKICAgICAg ICAgICAgIGlmIChpbmRpY2VzTGVmdCA8PSBpbmRpY2VzVXNlZCkK 441132 2021-10-13 13:52:35 -0700 2021-10-13 14:33:09 -0700 Patch for landing bug-231626-20211013135234.patch text/plain 2658 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZjRiZTQ3MDIwNWJhZjdjYWRlZjVkZTgyZDUzNjE2YzIzNTE5ZWQwYy4uNGNmZGJhMWRmNjk3 YmQwZDA0OGJjOTcyNDU4ZjBkNDYxMjM5Y2ZiMCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTEwLTEzICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXBzdHJlYW0gQU5HTEU6IFByaW1pdGl2ZVJlc3Rh cnQgdGVzdHMgZmFpbCBkdWUgdG8gaW5jb3JyZWN0IGRyYXcgY29tbWFuZHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTYyNgorICAgICAgICA8cmRh cjovcHJvYmxlbS84NDE2NzI0MT4KKyAgIAorICAgICAgICBQcmltaXRpdmUgcmVzdGFydCBkcmF3 IGNvbW1hbmRzIHdlcmUgYmVpbmcgZW5jb2RlZAorICAgICAgICBpbmNvcnJlY3RseS4gU2luZ2xl IGVsZW1lbnQgcmFuZ2VzIHdlcmUgYmVpbmcgZGlzcmVnYXJkZWQsCisgICAgICAgIGFuZCBhIG1h eGltdW0gZHJhdyBzaXplIHdhcyBub3QgYmVpbmcgZW5mb3JjZWQgd2hlbiB0aGUKKyAgICAgICAg aW5kZXggYnVmZmVyIHdhcyBhbGlhc2VkIC8gcmV1c2VkLgorCisgICAgICAgIENoZXJyeS1waWNr IGZyb20gdXBzdHJlYW0gYW5nbGVidWcuY29tLzY1MzUKKyAgICAKKyAgICAgICAgUmV2aWV3ZWQg YnkgS2VubmV0aCBSdXNzZWxsLgorCisgICAgICAgICogc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21l dGFsL1ZlcnRleEFycmF5TXRsLm1tOgorICAgICAgICAocng6OlZlcnRleEFycmF5TXRsOjpnZXRE cmF3SW5kaWNlcyk6CisKIDIwMjEtMTAtMTIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CiAKICAgICAgICAgSW52b2tlIFRoaXJkUGFydHkgYnVpbGQgc2NyaXB0cyB3aXRoIHB5 dGhvbjMgZXhwbGljaXRseQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL1ZlcnRleEFycmF5TXRsLm1tIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL1ZlcnRleEFycmF5TXRsLm1t CmluZGV4IDJiODdmMDUxZWU0NzIxNDllOWFlMDZlOGE2NjQwNjVjOWViMmRlN2QuLjMwMmVhOGEw ZTYyMjNjYTU2MzdkOTNhM2E5MWVhOTk5NTdlYjBmMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9WZXJ0ZXhBcnJheU10bC5t bQorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0 YWwvVmVydGV4QXJyYXlNdGwubW0KQEAgLTc4NywxMCArNzg3LDE0IEBAIHN0ZDo6dmVjdG9yPERy YXdDb21tYW5kUmFuZ2U+IFZlcnRleEFycmF5TXRsOjpnZXREcmF3SW5kaWNlcyhjb25zdCBnbDo6 Q29udGV4dCAqCiAgICAgewogICAgICAgICBpZiAocmFuZ2UucmVzdGFydEJlZ2luID4gY3VycmVu dEluZGV4T2Zmc2V0KQogICAgICAgICB7Ci0gICAgICAgICAgICBpbnQ2NF90IG5JbmRpY2VzSW5T bGljZSA9ICgoaW50NjRfdClyYW5nZS5yZXN0YXJ0QmVnaW4gLSBjdXJyZW50SW5kZXhPZmZzZXQp IC0gKChpbnQ2NF90KSByYW5nZS5yZXN0YXJ0QmVnaW4gLSBjdXJyZW50SW5kZXhPZmZzZXQpICUg bkluZGljZXNQZXJQcmltaXRpdmU7CisgICAgICAgICAgICBpbnQ2NF90IG5JbmRpY2VzSW5TbGlj ZSA9IE1JTigoKGludDY0X3QpcmFuZ2UucmVzdGFydEJlZ2luIC0gY3VycmVudEluZGV4T2Zmc2V0 KSAtCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoKGludDY0X3Qp cmFuZ2UucmVzdGFydEJlZ2luIC0gY3VycmVudEluZGV4T2Zmc2V0KSAlIG5JbmRpY2VzUGVyUHJp bWl0aXZlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbmRpY2VzTGVm dCk7CiAgICAgICAgICAgICBzaXplX3QgcmVzdGFydFNpemUgPSAocmFuZ2UucmVzdGFydEVuZCAt IHJhbmdlLnJlc3RhcnRCZWdpbikgKyAxOwotICAgICAgICAgICAgaWYgKG5JbmRpY2VzSW5TbGlj ZSA+IG5JbmRpY2VzUGVyUHJpbWl0aXZlKQorICAgICAgICAgICAgaWYgKG5JbmRpY2VzSW5TbGlj ZSA+PSBuSW5kaWNlc1BlclByaW1pdGl2ZSkKKyAgICAgICAgICAgIHsKICAgICAgICAgICAgICAg ICBkcmF3Q29tbWFuZHMucHVzaF9iYWNrKHsodWludDMyX3QpIG5JbmRpY2VzSW5TbGljZSwgY3Vy cmVudEluZGV4T2Zmc2V0ICogaW5kZXhUeXBlQnl0ZXN9KTsKKyAgICAgICAgICAgIH0KICAgICAg ICAgICAgIC8vIEFjY291bnQgZm9yIGRyb3BwZWQgaW5kaWNlcyBkdWUgdG8gaW5jb21wbGV0ZSBw cmltaXRpdmVzLgogICAgICAgICAgICAgc2l6ZV90IGluZGljZXNVc2VkID0gKCAocmFuZ2UucmVz dGFydEJlZ2luICsgcmVzdGFydFNpemUpIC0gY3VycmVudEluZGV4T2Zmc2V0KTsKICAgICAgICAg ICAgIGlmIChpbmRpY2VzTGVmdCA8PSBpbmRpY2VzVXNlZCkK