231594 2021-10-12 10:34:36 -0700 Restrict "darwin-notification-post" to a minimal set in the WP sandbox 2021-10-13 12:05:46 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham gavin.p mazander webkit-bug-importer oldest_to_newest 1803215 0 pvollan 2021-10-12 10:34:36 -0700 Restrict "darwin-notification-post" to a minimal set in the WP sandbox on macOS and iOS. 1803220 1 pvollan 2021-10-12 10:42:03 -0700 <rdar://66586792> 1803795 2 441088 pvollan 2021-10-13 09:08:58 -0700 Created attachment 441088 Patch 1803828 3 441088 bfulgham 2021-10-13 10:12:43 -0700 Comment on attachment 441088 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441088&action=review r=me > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:1577 > +(allow darwin-notification-post (with telemetry) Do we need to collect telemetry on the items we allow? Presumably we allow them because we know we need them? 1803874 4 pvollan 2021-10-13 11:16:41 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 441088 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441088&action=review > > r=me > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:1577 > > +(allow darwin-notification-post (with telemetry) > > Do we need to collect telemetry on the items we allow? Presumably we allow > them because we know we need them? Yes, that is a good point; I'll remove the telemetry. Thanks for reviewing! 1803875 5 441111 pvollan 2021-10-13 11:19:33 -0700 Created attachment 441111 Patch 1803902 6 ews-feeder 2021-10-13 12:05:44 -0700 Committed r284119 (242939@main): <https://commits.webkit.org/242939@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441111. 441088 2021-10-13 09:08:58 -0700 2021-10-13 10:12:43 -0700 Patch bug-231594-20211013090857.patch text/plain 3053 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODM5OTIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIxLTEwLTEyICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlc3RyaWN0ICJkYXJ3aW4tbm90aWZpY2F0 aW9uLXBvc3QiIHRvIGEgbWluaW1hbCBzZXQgaW4gdGhlIFdQIHNhbmRib3gKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTU5NAorICAgICAgICA8cmRh cjovLzY2NTg2NzkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5X ZWJDb250ZW50LnNiLmluOgorICAgICAgICAqIFdlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nl c3Muc2IuaW46CisKIDIwMjEtMTAtMTIgIFBlciBBcm5lIFZvbGxhbiA8cHZvbGxhbkBhcHBsZS5j b20+CiAKICAgICAgICAgW2lPU11bR1BVUF0gUmVtb3ZlIHNhbmRib3ggYWNjZXNzIHRvIGNvbS5h cHBsZS5hdWRpby5BdWRpb0NvbXBvbmVudFJlZ2lzdHJhcgpJbmRleDogU291cmNlL1dlYktpdC9S ZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQu c2IuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2Zp bGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IuaW4JKHJldmlzaW9uIDI4Mzk3 OSkKKysrIFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFw cGxlLldlYktpdC5XZWJDb250ZW50LnNiLmluCSh3b3JraW5nIGNvcHkpCkBAIC0xNTczLDYgKzE1 NzMsMjIgQEAKICAgICApCiApCiAKLSh3aGVuIChkZWZpbmVkPyAnZGFyd2luLW5vdGlmaWNhdGlv bi1wb3N0KQotICAgIChhbGxvdyBkYXJ3aW4tbm90aWZpY2F0aW9uLXBvc3QgKHdpdGggdGVsZW1l dHJ5KSkKLSkKKyhkZW55IGRhcndpbi1ub3RpZmljYXRpb24tcG9zdCAod2l0aCB0ZWxlbWV0cnkp KQorKGFsbG93IGRhcndpbi1ub3RpZmljYXRpb24tcG9zdCAod2l0aCB0ZWxlbWV0cnkpCisgICAg KG5vdGlmaWNhdGlvbi1uYW1lCisgICAgICAgICJfQVhOb3RpZmljYXRpb25fQVhTQ2xhc3NpY0lu dmVydENvbG9yc1ByZWZlcmVuY2UiCisgICAgICAgICJjb20uYXBwbGUuV2ViQ29udGVudEZpbHRl ci5yZW1vdGVVSS5XZWJDb250ZW50QW5hbHlzaXNVSS1jb20uYXBwbGUudWlraXQudmlld1NlcnZp Y2UuY29ubmVjdGlvblJlcXVlc3QiCisgICAgICAgICJjb20uYXBwbGUuYWNjZXNzaWJpbGl0eS5B aXJQb2RzU3BhdGlhbEF1ZGlvTG9ja1RvRGV2aWNlQ2hhbmdlZCIKKyAgICAgICAgImNvbS5hcHBs ZS5hY2Nlc3NpYmlsaXR5LlF1aWNrU3BlYWtFbmFibGVkIgorICAgICAgICAiY29tLmFwcGxlLmFj Y2Vzc2liaWxpdHkuYXBwbGljYXRpb24uc3RhdHVzIgorICAgICAgICAiY29tLmFwcGxlLmFjY2Vz c2liaWxpdHkuYXV0b21hdGlvbi5lbmFibGVkLnN0YXR1cyIKKyAgICAgICAgImNvbS5hcHBsZS5h Y2Nlc3NpYmlsaXR5LmRhcmtlbi5zeXN0ZW0uY29sb3JzIgorICAgICAgICAiY29tLmFwcGxlLmFj Y2Vzc2liaWxpdHkuZW5oYW5jZS5iYWNrZ3JvdW5kLmNvbnRyYXN0LnN0YXR1cyIKKyAgICAgICAg ImNvbS5hcHBsZS5hY2Nlc3NpYmlsaXR5Lm1vbm9hdWRpby5zdGF0dXMiCisgICAgICAgICJjb20u YXBwbGUuYWNjZXNzaWJpbGl0eS5yZWR1Y2UubW90aW9uLnN0YXR1cyIKKyAgICAgICAgImNvbS5h cHBsZS5hY2Nlc3NpYmlsaXR5LnN0YXR1cyIKKyAgICAgICAgImNvbS5hcHBsZS5hY2Nlc3NpYmls aXR5LnRleHQubGVnaWJpbGl0eS5zdGF0dXMiCisgICAgICAgICJjb20uYXBwbGUuYWNjZXNzaWJp bGl0eS52b2ljZW92ZXJ0b3VjaC5zdGF0dXMiCisgICAgICAgICJjb20uYXBwbGUuYWNjZXNzaWJp bGl0eS53b2Iuc3RhdHVzIgorICAgICAgICAiY29tLmFwcGxlLmF1dG9tYXRpb24uc3RyaW5nbG9v a3VwaW5mb2VuYWJsZWQiCisgICAgICAgICJjb20uYXBwbGUud2ViaW5zcGVjdG9yZC5hdmFpbGFi aWxpdHlfY2hlY2siKSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUu V2ViUHJvY2Vzcy5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv Y29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4JKHJldmlzaW9uIDI4Mzg4NykKKysrIFNvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkod29ya2luZyBjb3B5 KQpAQCAtMjI3Nyw5ICsyMjc3LDExIEBACiApCiAKICNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlO X1JFUVVJUkVEID4gMTEwMDAwCi0od2hlbiAoZGVmaW5lZD8gJ2Rhcndpbi1ub3RpZmljYXRpb24t cG9zdCkKLSAgICAoYWxsb3cgZGFyd2luLW5vdGlmaWNhdGlvbi1wb3N0ICh3aXRoIHRlbGVtZXRy eSkpCi0pCisoZGVueSBkYXJ3aW4tbm90aWZpY2F0aW9uLXBvc3QgKHdpdGggdGVsZW1ldHJ5KSkK KyhhbGxvdyBkYXJ3aW4tbm90aWZpY2F0aW9uLXBvc3QgKHdpdGggdGVsZW1ldHJ5KQorICAgIChu b3RpZmljYXRpb24tbmFtZQorICAgICAgICAiY29tLmFwcGxlLmFjY2Vzc2liaWxpdHkuQWlyUG9k c1NwYXRpYWxBdWRpb0xvY2tUb0RldmljZUNoYW5nZWQiCisgICAgICAgICJjb20uYXBwbGUud2Vi aW5zcGVjdG9yZC5hdmFpbGFiaWxpdHlfY2hlY2siKSkKICNlbmRpZgogCiAjaWYgX19NQUNfT1Nf WF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+IDExMDAwMAo= 441111 2021-10-13 11:19:33 -0700 2021-10-13 12:05:45 -0700 Patch bug-231594-20211013111931.patch text/plain 3018 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODM5OTIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIxLTEwLTEzICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlc3RyaWN0ICJkYXJ3aW4tbm90aWZpY2F0 aW9uLXBvc3QiIHRvIGEgbWluaW1hbCBzZXQgaW4gdGhlIFdQIHNhbmRib3gKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTU5NAorICAgICAgICA8cmRh cjovLzY2NTg2NzkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IEJyZW50IEZ1bGdoYW0uCisKKyAg ICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lldl YkNvbnRlbnQuc2IuaW46CisgICAgICAgICogV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vz cy5zYi5pbjoKKwogMjAyMS0xMC0xMiAgUGVyIEFybmUgVm9sbGFuIDxwdm9sbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBbaU9TXVtHUFVQXSBSZW1vdmUgc2FuZGJveCBhY2Nlc3MgdG8gY29tLmFw cGxlLmF1ZGlvLkF1ZGlvQ29tcG9uZW50UmVnaXN0cmFyCkluZGV4OiBTb3VyY2UvV2ViS2l0L1Jl c291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5z Yi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmls ZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYi5pbgkocmV2aXNpb24gMjg0MDk5 KQorKysgU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBw bGUuV2ViS2l0LldlYkNvbnRlbnQuc2IuaW4JKHdvcmtpbmcgY29weSkKQEAgLTE1OTAsNiArMTU5 MCwyMiBAQAogICAgICkKICkKIAotKHdoZW4gKGRlZmluZWQ/ICdkYXJ3aW4tbm90aWZpY2F0aW9u LXBvc3QpCi0gICAgKGFsbG93IGRhcndpbi1ub3RpZmljYXRpb24tcG9zdCAod2l0aCB0ZWxlbWV0 cnkpKQotKQorKGRlbnkgZGFyd2luLW5vdGlmaWNhdGlvbi1wb3N0ICh3aXRoIHRlbGVtZXRyeSkp CisoYWxsb3cgZGFyd2luLW5vdGlmaWNhdGlvbi1wb3N0CisgICAgKG5vdGlmaWNhdGlvbi1uYW1l CisgICAgICAgICJfQVhOb3RpZmljYXRpb25fQVhTQ2xhc3NpY0ludmVydENvbG9yc1ByZWZlcmVu Y2UiCisgICAgICAgICJjb20uYXBwbGUuV2ViQ29udGVudEZpbHRlci5yZW1vdGVVSS5XZWJDb250 ZW50QW5hbHlzaXNVSS1jb20uYXBwbGUudWlraXQudmlld1NlcnZpY2UuY29ubmVjdGlvblJlcXVl c3QiCisgICAgICAgICJjb20uYXBwbGUuYWNjZXNzaWJpbGl0eS5BaXJQb2RzU3BhdGlhbEF1ZGlv TG9ja1RvRGV2aWNlQ2hhbmdlZCIKKyAgICAgICAgImNvbS5hcHBsZS5hY2Nlc3NpYmlsaXR5LlF1 aWNrU3BlYWtFbmFibGVkIgorICAgICAgICAiY29tLmFwcGxlLmFjY2Vzc2liaWxpdHkuYXBwbGlj YXRpb24uc3RhdHVzIgorICAgICAgICAiY29tLmFwcGxlLmFjY2Vzc2liaWxpdHkuYXV0b21hdGlv bi5lbmFibGVkLnN0YXR1cyIKKyAgICAgICAgImNvbS5hcHBsZS5hY2Nlc3NpYmlsaXR5LmRhcmtl bi5zeXN0ZW0uY29sb3JzIgorICAgICAgICAiY29tLmFwcGxlLmFjY2Vzc2liaWxpdHkuZW5oYW5j ZS5iYWNrZ3JvdW5kLmNvbnRyYXN0LnN0YXR1cyIKKyAgICAgICAgImNvbS5hcHBsZS5hY2Nlc3Np YmlsaXR5Lm1vbm9hdWRpby5zdGF0dXMiCisgICAgICAgICJjb20uYXBwbGUuYWNjZXNzaWJpbGl0 eS5yZWR1Y2UubW90aW9uLnN0YXR1cyIKKyAgICAgICAgImNvbS5hcHBsZS5hY2Nlc3NpYmlsaXR5 LnN0YXR1cyIKKyAgICAgICAgImNvbS5hcHBsZS5hY2Nlc3NpYmlsaXR5LnRleHQubGVnaWJpbGl0 eS5zdGF0dXMiCisgICAgICAgICJjb20uYXBwbGUuYWNjZXNzaWJpbGl0eS52b2ljZW92ZXJ0b3Vj aC5zdGF0dXMiCisgICAgICAgICJjb20uYXBwbGUuYWNjZXNzaWJpbGl0eS53b2Iuc3RhdHVzIgor ICAgICAgICAiY29tLmFwcGxlLmF1dG9tYXRpb24uc3RyaW5nbG9va3VwaW5mb2VuYWJsZWQiCisg ICAgICAgICJjb20uYXBwbGUud2ViaW5zcGVjdG9yZC5hdmFpbGFiaWxpdHlfY2hlY2siKSkKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nl c3Muc2IuaW4JKHJldmlzaW9uIDI4Mzg4NykKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9j b20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkod29ya2luZyBjb3B5KQpAQCAtMjI3Nyw5ICsyMjc3 LDExIEBACiApCiAKICNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID4gMTEwMDAw Ci0od2hlbiAoZGVmaW5lZD8gJ2Rhcndpbi1ub3RpZmljYXRpb24tcG9zdCkKLSAgICAoYWxsb3cg ZGFyd2luLW5vdGlmaWNhdGlvbi1wb3N0ICh3aXRoIHRlbGVtZXRyeSkpCi0pCisoZGVueSBkYXJ3 aW4tbm90aWZpY2F0aW9uLXBvc3QgKHdpdGggdGVsZW1ldHJ5KSkKKyhhbGxvdyBkYXJ3aW4tbm90 aWZpY2F0aW9uLXBvc3QKKyAgICAobm90aWZpY2F0aW9uLW5hbWUKKyAgICAgICAgImNvbS5hcHBs ZS5hY2Nlc3NpYmlsaXR5LkFpclBvZHNTcGF0aWFsQXVkaW9Mb2NrVG9EZXZpY2VDaGFuZ2VkIgor ICAgICAgICAiY29tLmFwcGxlLndlYmluc3BlY3RvcmQuYXZhaWxhYmlsaXR5X2NoZWNrIikpCiAj ZW5kaWYKIAogI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPiAxMTAwMDAK