23158 2009-01-06 23:54:56 -0800 Fix sharing of number / string constants in codeblocks. 2009-01-07 00:30:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 104693 0 barraclough 2009-01-06 23:54:56 -0800 This is broken by https://bugs.webkit.org/show_bug.cgi?id=23114. 104694 1 26486 barraclough 2009-01-07 00:05:28 -0800 Created attachment 26486 The patch 104695 2 26486 mjs 2009-01-07 00:10:23 -0800 Comment on attachment 26486 The patch r=me 104697 3 barraclough 2009-01-07 00:30:32 -0800 Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/bytecompiler/BytecodeGenerator.cpp Transmitting file data .. Committed revision 39675. 26486 2009-01-07 00:05:28 -0800 2009-01-07 00:10:23 -0800 The patch patch.amp.txt text/plain 2993 barraclough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM5Njcz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMDktMDEt MDYgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFyYWNsb3VnaEBhcHBsZS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZSBhY2NpZGVudGFs bHkgcmVtb3ZlZCByZWZlcmVuY2VzIGluIEJ5dGVjb2RlR2VuZXJhdG9yLCBkZWxldGluZyB0aGVz ZQorICAgICAgICB3aWxsIGJlIGhpbmRlcmluZyB0aGUgc2hhcmluZyBvZiBjb25zdGFudCBudW1i ZXJzIGFuZCBzdHJpbmdzLgorCisgICAgICAgIFRoZSBjb2RlIHRvIGFkZCBhIG5ldyBjb25zdGFu dCAoZWl0aGVyIG51bWJlciBvciBzdHJpbmcpIHRvIHRoZWlyIHJlc3BlY3RpdmUKKyAgICAgICAg bWFwIHdvcmtzIGJ5IGF0dGVtcHRpbmcgdG8gYWRkIGEgbnVsbCBlbnRyeSwgdGhlbiBjaGVja2lu ZyB0aGUgcmVzdWx0IG9mIHRoZQorICAgICAgICBhZGQgZm9yIG51bGwuICBUaGUgZmlyc3QgdGlt ZSwgdGhpcyBzaG91bGQgcmV0dXJuIHRoZSBudWxsIChvciBub1ZhbHVlKS4KKyAgICAgICAgVGhl IGNvZGUgY2hlY2tzIGZvciBudWxsICh0byBzZWUgaWYgdGhpcyBpcyB0aGUgaW5pdGlhbCBhZGQp LCBhbmQgdGhlbiBhbGxvY2F0ZXMKKyAgICAgICAgYSBuZXcgbnVtYmVyIC8gc3RyaW5nIG9iamVj dC4gIFRoaXMgY29kZSByZWxpZXMgb24gdGhlIHJlc3VsdCByZXR1cm5lZCBmcm9tCisgICAgICAg IHRoZSBhZGQgdG8gdGhlIG1hcCBiZWluZyBzdG9yZWQgYXMgYSByZWZlcmVuY2UsIHN1Y2ggdGhh dCB0aGUgYWxsb2NhdGVkIG9iamVjdAorICAgICAgICB3aWxsIGJlIHN0b3JlZCBpbiB0aGUgbWFw LCBhbmQgd2lsbCBiZSByZXN1c2VkIGlmIHRoZSBzYW1lIGNvbnN0YW50IGlzIGVuY291bnRlcmVk CisgICAgICAgIGFnYWluLiAgQnkgZmFpbGluZyB0byB1c2UgYSByZWZlcmVuY2Ugd2Ugd2lsbCBi ZSBsZWFraW5nIEdDIG9iamVjdCBmb3IgZWFjaAorICAgICAgICBhZGRpdGlvbmFsIGVudHJ5IGFk ZGVkIHRvIHRoZSBtYXAuICBBcyBHQyBvYmplY3RzIHRoZXkgc2hvdWxkIGJlIGNsb2xsZWN0ZWQs CisgICAgICAgIGJlIHdlIHNob3VsZCBubyBiZSBhbGxvY2F0aW4gdGhlbSBpbiB0aGUgZmlyc3Qg cGxhY2UuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzMTU4CisKKyAgICAgICAgKiBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwOgor ICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdExvYWQpOgorCiAyMDA5LTAxLTA2 ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg R2F2aW4gQmFycmFjbG91Z2guCkluZGV4OiBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3Iu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHJl dmlzaW9uIDM5NjcwKQorKysgYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAkod29y a2luZyBjb3B5KQpAQCAtODY3LDcgKzg2Nyw3IEBAIFJlZ2lzdGVySUQqIEJ5dGVjb2RlR2VuZXJh dG9yOjplbWl0TG9hZCgKICAgICAvLyBMYXRlciB3ZSBjYW4gZG8gdGhlIGV4dHJhIHdvcmsgdG8g aGFuZGxlIHRoYXQgbGlrZSB0aGUgb3RoZXIgY2FzZXMuCiAgICAgaWYgKG51bWJlciA9PSBIYXNo VHJhaXRzPGRvdWJsZT46OmVtcHR5VmFsdWUoKSB8fCBIYXNoVHJhaXRzPGRvdWJsZT46OmlzRGVs ZXRlZFZhbHVlKG51bWJlcikpCiAgICAgICAgIHJldHVybiBlbWl0TG9hZChkc3QsIGpzTnVtYmVy KGdsb2JhbERhdGEoKSwgbnVtYmVyKSk7Ci0gICAgSlNWYWx1ZVB0ciB2YWx1ZUluTWFwID0gbV9u dW1iZXJNYXAuYWRkKG51bWJlciwgbm9WYWx1ZSgpKS5maXJzdC0+c2Vjb25kOworICAgIEpTVmFs dWVQdHImIHZhbHVlSW5NYXAgPSBtX251bWJlck1hcC5hZGQobnVtYmVyLCBub1ZhbHVlKCkpLmZp cnN0LT5zZWNvbmQ7CiAgICAgaWYgKCF2YWx1ZUluTWFwKQogICAgICAgICB2YWx1ZUluTWFwID0g anNOdW1iZXIoZ2xvYmFsRGF0YSgpLCBudW1iZXIpOwogICAgIHJldHVybiBlbWl0TG9hZChkc3Qs IHZhbHVlSW5NYXApOwpAQCAtODc1LDEwICs4NzUsMTAgQEAgUmVnaXN0ZXJJRCogQnl0ZWNvZGVH ZW5lcmF0b3I6OmVtaXRMb2FkKAogCiBSZWdpc3RlcklEKiBCeXRlY29kZUdlbmVyYXRvcjo6ZW1p dExvYWQoUmVnaXN0ZXJJRCogZHN0LCBjb25zdCBJZGVudGlmaWVyJiBpZGVudGlmaWVyKQogewot ICAgIEpTVmFsdWVQdHIgdmFsdWVJbk1hcCA9IG1fc3RyaW5nTWFwLmFkZChpZGVudGlmaWVyLnVz dHJpbmcoKS5yZXAoKSwgMCkuZmlyc3QtPnNlY29uZDsKLSAgICBpZiAoIXZhbHVlSW5NYXApCi0g ICAgICAgIHZhbHVlSW5NYXAgPSBqc093bmVkU3RyaW5nKGdsb2JhbERhdGEoKSwgaWRlbnRpZmll ci51c3RyaW5nKCkpOwotICAgIHJldHVybiBlbWl0TG9hZChkc3QsIHZhbHVlSW5NYXApOworICAg IEpTU3RyaW5nKiYgc3RyaW5nSW5NYXAgPSBtX3N0cmluZ01hcC5hZGQoaWRlbnRpZmllci51c3Ry aW5nKCkucmVwKCksIDApLmZpcnN0LT5zZWNvbmQ7CisgICAgaWYgKCFzdHJpbmdJbk1hcCkKKyAg ICAgICAgc3RyaW5nSW5NYXAgPSBqc093bmVkU3RyaW5nKGdsb2JhbERhdGEoKSwgaWRlbnRpZmll ci51c3RyaW5nKCkpOworICAgIHJldHVybiBlbWl0TG9hZChkc3QsIEpTVmFsdWVQdHIoc3RyaW5n SW5NYXApKTsKIH0KIAogUmVnaXN0ZXJJRCogQnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRMb2FkKFJl Z2lzdGVySUQqIGRzdCwgSlNWYWx1ZVB0ciB2KQo=