231570 2021-10-12 05:47:59 -0700 [iOS] Stop including 'util.sb' in the WebContent process' sandbox 2021-10-19 14:35:48 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 231984 1 pvollan pvollan bfulgham commit-queue gavin.p mazander webkit-bug-importer oldest_to_newest 1803078 0 pvollan 2021-10-12 05:47:59 -0700 This is a step towards being able to test-compile the sandbox on Open Source builders. 1803081 1 webkit-bug-importer 2021-10-12 05:49:42 -0700 <rdar://problem/84143956> 1803082 2 440922 pvollan 2021-10-12 05:51:12 -0700 Created attachment 440922 Patch 1803214 3 440922 bfulgham 2021-10-12 10:32:32 -0700 Comment on attachment 440922 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440922&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:-38 > -(import "util.sb") Can any of the other sandboxes use our slimmed-down util.sb? 1803805 4 pvollan 2021-10-13 09:32:50 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 440922 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440922&action=review > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:-38 > > -(import "util.sb") > > Can any of the other sandboxes use our slimmed-down util.sb? That is a good point! We're only preprocessing the WP sandbox on iOS. When the other sandboxes are preprocessed as well, we should use the new util.sb there too. Thanks for reviewing! 1803821 5 ews-feeder 2021-10-13 10:00:48 -0700 Committed r284099 (242927@main): <https://commits.webkit.org/242927@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440922. 1806320 6 commit-queue 2021-10-19 14:35:48 -0700 Re-opened since this is blocked by bug 231984 440922 2021-10-12 05:51:12 -0700 2021-10-13 10:00:49 -0700 Patch bug-231570-20211012145107.patch text/plain 5917 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODM5NzkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEwLTEyICBQZXIgQXJuZSBW b2xsYW4gPHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFN0b3AgaW5jbHVkaW5n ICd1dGlsLnNiJyBpbiB0aGUgV2ViQ29udGVudCBwcm9jZXNzJyBzYW5kYm94CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE1NzAKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzg0MTQzOTU2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgaXMgYSBzdGVwIHRvd2FyZHMgYmVpbmcgYWJsZSB0byB0ZXN0 LWNvbXBpbGUgdGhlIHNhbmRib3ggb24gT3BlbiBTb3VyY2UgYnVpbGRlcnMuCisKKyAgICAgICAg KiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRl bnQuc2IuaW46CisgICAgICAgICogU2hhcmVkL1NhbmRib3gvdXRpbC5zYjogQWRkZWQuCisKIDIw MjEtMTAtMTIgIFBlciBBcm5lIFZvbGxhbiA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAg W2lPU10gQWRkIHN5c2NhbGwgdGVsZW1ldHJ5IGluIHRoZSBXZWJDb250ZW50IHByb2Nlc3MnIHNh bmRib3gKSW5kZXg6IFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3Mv Y29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiLmluCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJD b250ZW50LnNiLmluCShyZXZpc2lvbiAyODM5NzkpCisrKyBTb3VyY2UvV2ViS2l0L1Jlc291cmNl cy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYi5pbgko d29ya2luZyBjb3B5KQpAQCAtMzAsMTMgKzMwLDEzIEBACiA7OyBTaWxlbmNlIHNwdXJpb3VzIGxv Z2dpbmcgZHVlIHRvIHJkYXI6Ly8yMDExNzkyMyBhbmQgcmRhcjovLzcyMzY2NDc1CiAoZGVueSBz eXN0ZW0tcHJpdmlsZWdlIChwcml2aWxlZ2UtaWQgUFJJVl9HTE9CQUxfUFJPQ19JTkZPKSAod2l0 aCBuby1yZXBvcnQpKQogCisjaW5jbHVkZSAiU2hhcmVkL1NhbmRib3gvdXRpbC5zYiIKKwogOzs7 CiA7OzsgVGhlIGZvbGxvd2luZyBydWxlcyB3ZXJlIG9yaWdpbmFsbHkgY29udGFpbmVkIGluICdj b21tb24uc2InLiBXZSBhcmUgZHVwbGljYXRpbmcgdGhlbSBoZXJlIHNvIHdlIGNhbgogOzs7IHJl bW92ZSB1bm5lZWRlZCBzYW5kYm94IGV4dGVuc2lvbnMuCiA7OzsKIAotKGltcG9ydCAidXRpbC5z YiIpCi0KIChkZWZpbmUtb25jZSAoYWxsb3ctcmVhZC1hbmQtaXNzdWUtZ2VuZXJpYy1leHRlbnNp b25zIC4gZmlsdGVycykKICAgICAoYWxsb3cgZmlsZS1yZWFkKgogICAgICAgICAgICAoYXBwbHkg cmVxdWlyZS1hbnkgZmlsdGVycykpCkluZGV4OiBTb3VyY2UvV2ViS2l0L1NoYXJlZC9TYW5kYm94 L3V0aWwuc2IKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9TaGFyZWQvU2FuZGJveC91dGls LnNiCShub25leGlzdGVudCkKKysrIFNvdXJjZS9XZWJLaXQvU2hhcmVkL1NhbmRib3gvdXRpbC5z Ygkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDk0IEBACis7IENvcHlyaWdodCAoQykgMjAyMSBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCis7Cis7IFJlZGlzdHJpYnV0aW9uIGFuZCB1 c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorOyBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKKzsgYXJlIG1ldDoKKzsgMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3Qg cmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKzsgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorOyAyLiBSZWRpc3RyaWJ1dGlv bnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorOyAg ICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2Ns YWltZXIgaW4gdGhlCis7ICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBw cm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCis7Cis7IFRISVMgU09GVFdBUkUgSVMgUFJP VklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycKKzsgQU5E IEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJ TUlURUQgVE8sCis7IFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFO RCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKKzsgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4g Tk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTCis7IEJFIExJQUJM RSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFS WSwgT1IKKzsgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRF RCBUTywgUFJPQ1VSRU1FTlQgT0YKKzsgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9T UyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTCis7IElOVEVSUlVQVElPTikg SE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElO Cis7IENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElH RU5DRSBPUiBPVEhFUldJU0UpCis7IEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBP RiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YKKzsgVEhFIFBPU1NJQklMSVRZIE9G IFNVQ0ggREFNQUdFLgorCisobWFjcm8gKGRlZmluZS1vbmNlIGZvcm0pCisgIChsZXQqICgocHMg KGNkciBmb3JtKSkKKyAgICAgICAgIChzaWduYXR1cmUgKGNhciBwcykpCisgICAgICAgICAoYm9k eSAoY2RyIHBzKSkKKyAgICAgICAgIChuYW1lIChjYXIgc2lnbmF0dXJlKSkpCisgICAgKGlmIChu b3QgKGRlZmluZWQ/IG5hbWUpKQorICAgICAgICBgKGRlZmluZSAsc2lnbmF0dXJlICxAYm9keSkp KSkKKworKGRlZmluZS1vbmNlIChob21lLWxpdGVyYWwgLiByZWxhdGl2ZS1zdWJwYXRocykKKyAg KGFwcGx5IGxpdGVyYWwgKG1hcCBob21lLXJlbGF0aXZlLXBhdGggcmVsYXRpdmUtc3VicGF0aHMp KSkKKworKGRlZmluZS1vbmNlIChob21lLXN1YnBhdGggLiByZWxhdGl2ZS1zdWJwYXRocykKKyAg KGFwcGx5IHN1YnBhdGggKG1hcCBob21lLXJlbGF0aXZlLXBhdGggcmVsYXRpdmUtc3VicGF0aHMp KSkKKworKGRlZmluZS1vbmNlIChob21lLXByZWZpeCAuIHJlbGF0aXZlLXN1YnBhdGhzKQorICAo YXBwbHkgcHJlZml4IChtYXAgaG9tZS1yZWxhdGl2ZS1wYXRoIHJlbGF0aXZlLXN1YnBhdGhzKSkp CisKKyhkZWZpbmUtb25jZSAoaG9tZS1yZWdleCAuIHJlbGF0aXZlLXJlZ2V4ZXMpCisgIChyZXF1 aXJlLWFsbAorICAgIChhcHBseSBhbnktaG9tZS1yZWdleCByZWxhdGl2ZS1yZWdleGVzKQorICAg IChob21lLXN1YnBhdGggIiIpKSkKKworKGRlZmluZS1vbmNlIChob21lLXJlbGF0aXZlLXBhdGgg cmVsYXRpdmUtc3VicGF0aCkKKyAgKHN0cmluZy1hcHBlbmQgIiR7SE9NRX0iIHJlbGF0aXZlLXN1 YnBhdGgpKQorCisoZGVmaW5lLW9uY2UgKGZyb250LXVzZXItaG9tZS1zdWJwYXRoIC4gcmVsYXRp dmUtc3VicGF0aHMpCisgIChhcHBseSBzdWJwYXRoIChtYXAgZnJvbnQtdXNlci1ob21lLXJlbGF0 aXZlLXBhdGggcmVsYXRpdmUtc3VicGF0aHMpKSkKKworKGRlZmluZS1vbmNlIChmcm9udC11c2Vy LWhvbWUtcmVsYXRpdmUtcGF0aCByZWxhdGl2ZS1zdWJwYXRoKQorICAoc3RyaW5nLWFwcGVuZCAi JHtGUk9OVF9VU0VSX0hPTUV9IiByZWxhdGl2ZS1zdWJwYXRoKSkKKworKGRlZmluZS1vbmNlICgl ZWxldmF0ZWQtcHJlY2VkZW5jZS1maW5hbGl6ZSkKKyAgICAobGFtYmRhICgpICNmKSkKKworKG1h Y3JvICh3aXRoLWVsZXZhdGVkLXByZWNlZGVuY2UgZm9ybSkKKyAgICAobGV0KiAoKHJ1bGVzIChj ZHIgZm9ybSkpKQorICAgICAgICA7OyBMYXRlciBydWxlcyBvdmVycmlkZSBlYXJsaWVyIHJ1bGVz IHNvIGVtaXQgdGhlIGdpdmVuIHJ1bGVzIGFzCisgICAgICAgIDs7IGxhdGUgYXMgcG9zc2libGUg dG8gZ2l2ZSB0aGVtIGhpZ2ggcHJlY2VuZGVuY2UuCisgICAgICAgIGAoJWF0LWVsZXZhdGVkLXBy ZWNlZGVuY2UtZmluYWxpemUgKGxhbWJkYSAoKSAsQHJ1bGVzKSkpKQorCisoZGVmaW5lLW9uY2Ug KCVhdC1lbGV2YXRlZC1wcmVjZWRlbmNlLWZpbmFsaXplIGZ1bmMpCisgICAgKGxldCoKKyAgICAg ICAgKChvcmlnLWZpbmFsaXplICVlbGV2YXRlZC1wcmVjZWRlbmNlLWZpbmFsaXplKQorICAgICAg ICAgKG5ldy1maW5hbGl6ZQorICAgICAgICAgICAgIChsYW1iZGEgKCkKKyAgICAgICAgICAgICAg ICAgKG9yaWctZmluYWxpemUpCisgICAgICAgICAgICAgICAgIChmdW5jKSkpKQorICAgICAgICAo c2V0ISAlZWxldmF0ZWQtcHJlY2VkZW5jZS1maW5hbGl6ZSBuZXctZmluYWxpemUpKSkKKworKGRl ZmluZS1vbmNlICh3ZWxsLWtub3duLXN5c3RlbS1ncm91cC1jb250YWluZXItcGF0aCByZWxhdGl2 ZS1zdWJwYXRoKQorICAoc3RyaW5nLWFwcGVuZCAiL3ByaXZhdGUvdmFyL2NvbnRhaW5lcnMvU2hh cmVkL1N5c3RlbUdyb3VwIiByZWxhdGl2ZS1zdWJwYXRoKSkKKworKGRlZmluZS1vbmNlICh3ZWxs LWtub3duLXN5c3RlbS1ncm91cC1jb250YWluZXItbGl0ZXJhbCAuIHJlbGF0aXZlLXN1YnBhdGhz KQorICAoYXBwbHkgbGl0ZXJhbCAobWFwIHdlbGwta25vd24tc3lzdGVtLWdyb3VwLWNvbnRhaW5l ci1wYXRoIHJlbGF0aXZlLXN1YnBhdGhzKSkpCisKKyhkZWZpbmUtb25jZSAod2VsbC1rbm93bi1z eXN0ZW0tZ3JvdXAtY29udGFpbmVyLXN1YnBhdGggLiByZWxhdGl2ZS1zdWJwYXRocykKKyAgKGFw cGx5IHN1YnBhdGggKG1hcCB3ZWxsLWtub3duLXN5c3RlbS1ncm91cC1jb250YWluZXItcGF0aCBy ZWxhdGl2ZS1zdWJwYXRocykpKQorCisoZGVmaW5lLW9uY2UgKGFsbG93LXdlbGwta25vd24tc3lz dGVtLWdyb3VwLWNvbnRhaW5lci1zdWJwYXRoLXJlYWQgLiBzdWJwYXRocykKKyAgKGZvci1lYWNo CisgICAgKGxhbWJkYSAocmVsYXRpdmUtcGF0aCkKKyAgICAgIChhbGxvdyBmaWxlLXJlYWQqCisg ICAgICAgICAgICAgKHdlbGwta25vd24tc3lzdGVtLWdyb3VwLWNvbnRhaW5lci1zdWJwYXRoIHJl bGF0aXZlLXBhdGgpKSkKKyAgICAgIHN1YnBhdGhzKSkKKworKGRlZmluZS1vbmNlIChhbGxvdy13 ZWxsLWtub3duLXN5c3RlbS1ncm91cC1jb250YWluZXItbGl0ZXJhbC1yZWFkIC4gc3VicGF0aHMp CisgIChmb3ItZWFjaAorICAgIChsYW1iZGEgKHJlbGF0aXZlLXBhdGgpCisgICAgICAoYWxsb3cg ZmlsZS1yZWFkKgorICAgICAgICAgICAgICh3ZWxsLWtub3duLXN5c3RlbS1ncm91cC1jb250YWlu ZXItbGl0ZXJhbCByZWxhdGl2ZS1wYXRoKSkpCisgICAgICBzdWJwYXRocykpCg==