231560 2021-10-11 23:35:37 -0700 Implement alternate style for textarea 2021-10-12 18:00:07 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton akeerthi changseok esprehn+autocc ews-watchlist glenn hi kondapallykalyan pdr webkit-bug-importer wenson_hsieh oldest_to_newest 1803003 0 thorton 2021-10-11 23:35:37 -0700 Implement alternate style for textarea 1803005 1 440899 thorton 2021-10-11 23:38:44 -0700 Created attachment 440899 Patch 1803248 2 440899 hi 2021-10-12 11:18:31 -0700 Comment on attachment 440899 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440899&action=review r=me > Source/WebCore/rendering/RenderThemeIOS.mm:607 > + if (is<HTMLTextAreaElement>(*element)) NIT: Should this be an `else if` so we don't check it if we enter the `if (is<HTMLInputElement>(*element))` above? > Source/WebCore/rendering/RenderThemeIOS.mm:641 > + bool useAlternateDesign = element->document().settings().alternateFormControlDesignEnabled(); NIT: Does this need to be a separate variable? 1803255 3 thorton 2021-10-12 11:23:11 -0700 Both fair! 1803466 4 441000 thorton 2021-10-12 15:19:50 -0700 Created attachment 441000 Patch 1803481 5 webkit-bug-importer 2021-10-12 15:35:58 -0700 <rdar://problem/84169599> 1803594 6 ews-feeder 2021-10-12 18:00:04 -0700 Committed r284070 (242898@main): <https://commits.webkit.org/242898@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441000. 440899 2021-10-11 23:38:44 -0700 2021-10-12 15:19:48 -0700 Patch bug-231560-20211011233843.patch text/plain 3331 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzOTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTVmM2M2N2UzMjVmY2M3 ZDAxNjllMjViZDYzMGIwNjU1YTgyM2FlZC4uYTA5MTI4ZWE4NjU4ZGFjOGEwYzc2ODczYTQ4Y2Ez ZTViNjIwNzU5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTExICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEltcGxlbWVudCBh bHRlcm5hdGUgc3R5bGUgZm9yIHRleHRhcmVhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE1NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5oOgorICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl clRoZW1lSU9TOjpwYWludFRleHRGaWVsZERlY29yYXRpb25zKToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclRoZW1lSU9TOjphZGp1c3RUZXh0QXJlYVN0eWxlIGNvbnN0KToKKyAgICAgICAgRG8g dGhlIHNhbWUgYXMgcjI4Mzk2MiwgYnV0IGZvciA8dGV4dGFyZWE+OyBnaXZlIGl0IGFuIGlubmVy IHNoYWRvdyBhbmQKKyAgICAgICAgcmVtb3ZlIGl0cyBib3JkZXIgd2hlbiB1c2luZyB0aGUgYWx0 ZXJuYXRlIGFwcGVhcmFuY2UuCisKIDIwMjEtMTAtMTEgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBh cHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIEltcGxpY2l0QWRkcmVzcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmggYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MuaAppbmRleCBlMDIxZWUzMzYyN2Q2YzJlNGYwYTM3 NjQyZjM5ZmU3ODMxYzNhYTk4Li5kNjZiNmFkZmRhZjM5MjYwNmFmMGFlMGQxNjYzYTllZDU0NDZh ZmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1Mu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MuaApAQCAtOTMs NiArOTMsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBhZGp1c3RUZXh0RmllbGRTdHlsZShSZW5k ZXJTdHlsZSYsIGNvbnN0IEVsZW1lbnQqKSBjb25zdCBmaW5hbDsKICAgICB2b2lkIHBhaW50VGV4 dEZpZWxkRGVjb3JhdGlvbnMoY29uc3QgUmVuZGVyQm94JiwgY29uc3QgUGFpbnRJbmZvJiwgY29u c3QgRmxvYXRSZWN0Jikgb3ZlcnJpZGU7CisgICAgdm9pZCBhZGp1c3RUZXh0QXJlYVN0eWxlKFJl bmRlclN0eWxlJiwgY29uc3QgRWxlbWVudCopIGNvbnN0IGZpbmFsOwogICAgIHZvaWQgcGFpbnRU ZXh0QXJlYURlY29yYXRpb25zKGNvbnN0IFJlbmRlckJveCYsIGNvbnN0IFBhaW50SW5mbyYsIGNv bnN0IEZsb2F0UmVjdCYpIG92ZXJyaWRlOwogCiAgICAgdm9pZCBwYWludFRleHRGaWVsZElubmVy U2hhZG93KGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEZsb2F0Um91bmRlZFJlY3QmKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbSBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbQppbmRleCBjZDU2YWQ2MWI2ZGRj ZDQzMWY4MDM5MjYxYWU4MWFiNjMwYjMwMGJhLi4xZGE5YTc5MTM4MGE0ZTZjNGYyOWJjYzk0OTA1 NmEyNWEwMTFjYjhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9T Lm1tCkBAIC01NCw2ICs1NCw3IEBACiAjaW1wb3J0ICJIVE1MTWV0ZXJFbGVtZW50LmgiCiAjaW1w b3J0ICJIVE1MTmFtZXMuaCIKICNpbXBvcnQgIkhUTUxTZWxlY3RFbGVtZW50LmgiCisjaW1wb3J0 ICJIVE1MVGV4dEFyZWFFbGVtZW50LmgiCiAjaW1wb3J0ICJJT1N1cmZhY2UuaCIKICNpbXBvcnQg Ikljb24uaCIKICNpbXBvcnQgIkxvY2FsQ3VycmVudFRyYWl0Q29sbGVjdGlvbi5oIgpAQCAtNjAz LDYgKzYwNCw4IEBAIHZvaWQgUmVuZGVyVGhlbWVJT1M6OnBhaW50VGV4dEZpZWxkRGVjb3JhdGlv bnMoY29uc3QgUmVuZGVyQm94JiBib3gsIGNvbnN0IFBhaW50CiAgICAgICAgICAgICBpZiAoaW5w dXQuaXNUZXh0RmllbGQoKSAmJiAhaW5wdXQuaXNTZWFyY2hGaWVsZCgpKQogICAgICAgICAgICAg ICAgIHNob3VsZFBhaW50RmlsbEFuZElubmVyU2hhZG93ID0gdHJ1ZTsKICAgICAgICAgfQorICAg ICAgICBpZiAoaXM8SFRNTFRleHRBcmVhRWxlbWVudD4oKmVsZW1lbnQpKQorICAgICAgICAgICAg c2hvdWxkUGFpbnRGaWxsQW5kSW5uZXJTaGFkb3cgPSB0cnVlOwogCiAgICAgICAgIGJvb2wgdXNl QWx0ZXJuYXRlRGVzaWduID0gYm94LnNldHRpbmdzKCkuYWx0ZXJuYXRlRm9ybUNvbnRyb2xEZXNp Z25FbmFibGVkKCk7CiAgICAgICAgIGlmICh1c2VBbHRlcm5hdGVEZXNpZ24gJiYgc2hvdWxkUGFp bnRGaWxsQW5kSW5uZXJTaGFkb3cpIHsKQEAgLTYzMCw2ICs2MzMsMTkgQEAgdm9pZCBSZW5kZXJU aGVtZUlPUzo6cGFpbnRUZXh0RmllbGREZWNvcmF0aW9ucyhjb25zdCBSZW5kZXJCb3gmIGJveCwg Y29uc3QgUGFpbnQKICAgICB9CiB9CiAKK3ZvaWQgUmVuZGVyVGhlbWVJT1M6OmFkanVzdFRleHRB cmVhU3R5bGUoUmVuZGVyU3R5bGUmIHN0eWxlLCBjb25zdCBFbGVtZW50KiBlbGVtZW50KSBjb25z dAoreworICAgIGlmICghZWxlbWVudCkKKyAgICAgICAgcmV0dXJuOworCisgICAgYm9vbCB1c2VB bHRlcm5hdGVEZXNpZ24gPSBlbGVtZW50LT5kb2N1bWVudCgpLnNldHRpbmdzKCkuYWx0ZXJuYXRl Rm9ybUNvbnRyb2xEZXNpZ25FbmFibGVkKCk7CisgICAgaWYgKHVzZUFsdGVybmF0ZURlc2lnbikg eworICAgICAgICBzdHlsZS5zZXRCYWNrZ3JvdW5kQ29sb3IoQ29sb3I6OnRyYW5zcGFyZW50Qmxh Y2spOworICAgICAgICBzdHlsZS5yZXNldEJvcmRlckV4Y2VwdFJhZGl1cygpOworICAgICAgICBy ZXR1cm47CisgICAgfQorfQorCiB2b2lkIFJlbmRlclRoZW1lSU9TOjpwYWludFRleHRBcmVhRGVj b3JhdGlvbnMoY29uc3QgUmVuZGVyQm94JiBib3gsIGNvbnN0IFBhaW50SW5mbyYgcGFpbnRJbmZv LCBjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiB7CiAgICAgcGFpbnRUZXh0RmllbGREZWNvcmF0aW9u cyhib3gsIHBhaW50SW5mbywgcmVjdCk7Cg== 441000 2021-10-12 15:19:50 -0700 2021-10-12 18:00:06 -0700 Patch bug-231560-20211012151949.patch text/plain 3378 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmEyZjUxODYzNTExYjBi MTJhYzE5ZTQzNzhiZjRhZmFkMWQ5OTQyYS4uOWYwOTIzYTVjOTdjZmQxZTk5MDg4YTFlYTg1YzM2 Y2JjMTExZjA4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTEyICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEltcGxlbWVudCBh bHRlcm5hdGUgc3R5bGUgZm9yIHRleHRhcmVhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE1NjAKKworICAgICAgICBSZXZpZXdlZCBieSBEZXZpbiBS b3Vzc28uCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MuaDoKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW06CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJU aGVtZUlPUzo6cGFpbnRUZXh0RmllbGREZWNvcmF0aW9ucyk6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJUaGVtZUlPUzo6YWRqdXN0VGV4dEFyZWFTdHlsZSBjb25zdCk6CisgICAgICAgIERvIHRo ZSBzYW1lIGFzIHIyODM5NjIsIGJ1dCBmb3IgPHRleHRhcmVhPjsgZ2l2ZSBpdCBhbiBpbm5lciBz aGFkb3cgYW5kCisgICAgICAgIHJlbW92ZSBpdHMgYm9yZGVyIHdoZW4gdXNpbmcgdGhlIGFsdGVy bmF0ZSBhcHBlYXJhbmNlLgorCiAyMDIxLTEwLTEyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0 b25AYXBwbGUuY29tPgogCiAgICAgICAgIEJvcmRlcnMgYXJlIG5vdCBkcmF3biB3aGVuIHVzaW5n IEJpZnVyY2F0ZWRHcmFwaGljc0NvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUaGVtZUlPUy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRoZW1lSU9TLmgKaW5kZXggZTAyMWVlMzM2MjdkNmMyZTRmMGEzNzY0MmYzOWZlNzgzMWMzYWE5 OC4uZDY2YjZhZGZkYWYzOTI2MDZhZjBhZTBkMTY2M2E5ZWQ1NDQ2YWZhOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmgKQEAgLTkzLDYgKzkzLDcgQEAgcHJpdmF0 ZToKIAogICAgIHZvaWQgYWRqdXN0VGV4dEZpZWxkU3R5bGUoUmVuZGVyU3R5bGUmLCBjb25zdCBF bGVtZW50KikgY29uc3QgZmluYWw7CiAgICAgdm9pZCBwYWludFRleHRGaWVsZERlY29yYXRpb25z KGNvbnN0IFJlbmRlckJveCYsIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEZsb2F0UmVjdCYpIG92 ZXJyaWRlOworICAgIHZvaWQgYWRqdXN0VGV4dEFyZWFTdHlsZShSZW5kZXJTdHlsZSYsIGNvbnN0 IEVsZW1lbnQqKSBjb25zdCBmaW5hbDsKICAgICB2b2lkIHBhaW50VGV4dEFyZWFEZWNvcmF0aW9u cyhjb25zdCBSZW5kZXJCb3gmLCBjb25zdCBQYWludEluZm8mLCBjb25zdCBGbG9hdFJlY3QmKSBv dmVycmlkZTsKIAogICAgIHZvaWQgcGFpbnRUZXh0RmllbGRJbm5lclNoYWRvdyhjb25zdCBQYWlu dEluZm8mLCBjb25zdCBGbG9hdFJvdW5kZWRSZWN0Jik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVJT1MubW0KaW5kZXggY2Q1NmFkNjFiNmRkY2Q0MzFmODAzOTI2MWFlODFh YjYzMGIzMDBiYS4uYWM3MGQwMjdlYTUyZmUwN2FjZTgzZTg4MDRhMGZlMTUwZGFlNGU1OCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1tCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbQpAQCAtNTQsNiArNTQs NyBAQAogI2ltcG9ydCAiSFRNTE1ldGVyRWxlbWVudC5oIgogI2ltcG9ydCAiSFRNTE5hbWVzLmgi CiAjaW1wb3J0ICJIVE1MU2VsZWN0RWxlbWVudC5oIgorI2ltcG9ydCAiSFRNTFRleHRBcmVhRWxl bWVudC5oIgogI2ltcG9ydCAiSU9TdXJmYWNlLmgiCiAjaW1wb3J0ICJJY29uLmgiCiAjaW1wb3J0 ICJMb2NhbEN1cnJlbnRUcmFpdENvbGxlY3Rpb24uaCIKQEAgLTYwMiw3ICs2MDMsOCBAQCB2b2lk IFJlbmRlclRoZW1lSU9TOjpwYWludFRleHRGaWVsZERlY29yYXRpb25zKGNvbnN0IFJlbmRlckJv eCYgYm94LCBjb25zdCBQYWludAogICAgICAgICAgICAgYXV0byYgaW5wdXQgPSBkb3duY2FzdDxI VE1MSW5wdXRFbGVtZW50PigqZWxlbWVudCk7CiAgICAgICAgICAgICBpZiAoaW5wdXQuaXNUZXh0 RmllbGQoKSAmJiAhaW5wdXQuaXNTZWFyY2hGaWVsZCgpKQogICAgICAgICAgICAgICAgIHNob3Vs ZFBhaW50RmlsbEFuZElubmVyU2hhZG93ID0gdHJ1ZTsKLSAgICAgICAgfQorICAgICAgICB9IGVs c2UgaWYgKGlzPEhUTUxUZXh0QXJlYUVsZW1lbnQ+KCplbGVtZW50KSkKKyAgICAgICAgICAgIHNo b3VsZFBhaW50RmlsbEFuZElubmVyU2hhZG93ID0gdHJ1ZTsKIAogICAgICAgICBib29sIHVzZUFs dGVybmF0ZURlc2lnbiA9IGJveC5zZXR0aW5ncygpLmFsdGVybmF0ZUZvcm1Db250cm9sRGVzaWdu RW5hYmxlZCgpOwogICAgICAgICBpZiAodXNlQWx0ZXJuYXRlRGVzaWduICYmIHNob3VsZFBhaW50 RmlsbEFuZElubmVyU2hhZG93KSB7CkBAIC02MzAsNiArNjMyLDE4IEBAIHZvaWQgUmVuZGVyVGhl bWVJT1M6OnBhaW50VGV4dEZpZWxkRGVjb3JhdGlvbnMoY29uc3QgUmVuZGVyQm94JiBib3gsIGNv bnN0IFBhaW50CiAgICAgfQogfQogCit2b2lkIFJlbmRlclRoZW1lSU9TOjphZGp1c3RUZXh0QXJl YVN0eWxlKFJlbmRlclN0eWxlJiBzdHlsZSwgY29uc3QgRWxlbWVudCogZWxlbWVudCkgY29uc3QK K3sKKyAgICBpZiAoIWVsZW1lbnQpCisgICAgICAgIHJldHVybjsKKworICAgIGlmICghZWxlbWVu dC0+ZG9jdW1lbnQoKS5zZXR0aW5ncygpLmFsdGVybmF0ZUZvcm1Db250cm9sRGVzaWduRW5hYmxl ZCgpKQorICAgICAgICByZXR1cm47CisKKyAgICBzdHlsZS5zZXRCYWNrZ3JvdW5kQ29sb3IoQ29s b3I6OnRyYW5zcGFyZW50QmxhY2spOworICAgIHN0eWxlLnJlc2V0Qm9yZGVyRXhjZXB0UmFkaXVz KCk7Cit9CisKIHZvaWQgUmVuZGVyVGhlbWVJT1M6OnBhaW50VGV4dEFyZWFEZWNvcmF0aW9ucyhj b25zdCBSZW5kZXJCb3gmIGJveCwgY29uc3QgUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0IEZs b2F0UmVjdCYgcmVjdCkKIHsKICAgICBwYWludFRleHRGaWVsZERlY29yYXRpb25zKGJveCwgcGFp bnRJbmZvLCByZWN0KTsK