231559 2021-10-11 23:25:52 -0700 Fix spec-correctness when inlining __proto__ intrinsic using get_by_id_with_this 2021-10-12 14:52:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist keith_miller mark.lam msaboff tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1802998 0 saam 2021-10-11 23:25:52 -0700 … 1803265 1 440965 saam 2021-10-12 11:37:42 -0700 Created attachment 440965 patch 1803266 2 440965 ysuzuki 2021-10-12 11:40:00 -0700 Comment on attachment 440965 patch r=me 1803413 3 ews-feeder 2021-10-12 14:51:42 -0700 Committed r284036 (242866@main): <https://commits.webkit.org/242866@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440965. 1803416 4 webkit-bug-importer 2021-10-12 14:52:33 -0700 <rdar://problem/84167629> 440965 2021-10-12 11:37:42 -0700 2021-10-12 14:51:43 -0700 patch c-backup.diff text/plain 6315 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjgzOTkyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDIxLTEwLTEyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEZpeCBzcGVjLWNvcnJlY3RuZXNzIHdoZW4gaW5saW5pbmcgX19wcm90b19fIGludHJpbnNpYyB1 c2luZyBnZXRfYnlfaWRfd2l0aF90aGlzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzE1NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNeSBvcmlnaW5hbCBmaXggaW4gcjI4MzUxMiBoYXMgc29tZSB0aGVv cmV0aWNhbCBzcGVjIGNvcnJlY3RuZXNzIGlzc3Vlcy4KKyAgICAgICAgSSdtIG5vdCBzdXJlIGlm IHRoZXkgY2FuIGJlIG1hdGVyaWFsaXplZCBvciBub3Qgc2luY2Ugd2Ugb25seSB1c2UKKyAgICAg ICAgZ2V0X2J5X2lkX3dpdGhfdGhpcyBpbiB2ZXJ5IGxpbWl0ZWQgc2NlbmFyaW9zLiBIb3dldmVy LCB0aGlzIHBhdGNoIGp1c3QKKyAgICAgICAgbWFrZXMgaXQgc28gd2UgY2FsbCB0aGUgZ2V0dGVy IGluc3RlYWQgb2YgYXR0ZW1wdGluZyB0byBpbmxpbmUgaXQKKyAgICAgICAgd2hlbiB1c2luZyBn ZXRfYnlfaWRfd2l0aF90aGlzLgorCisgICAgICAgICogaml0L0Fzc2VtYmx5SGVscGVycy5jcHA6 CisgICAgICAgIChKU0M6OkFzc2VtYmx5SGVscGVyczo6ZW1pdExvYWRQcm90b3R5cGVXaXRob3V0 Q2hlY2spOiBEZWxldGVkLgorICAgICAgICAqIGppdC9Bc3NlbWJseUhlbHBlcnMuaDoKKyAgICAg ICAgKiBqaXQvSW50cmluc2ljRW1pdHRlci5jcHA6CisgICAgICAgIChKU0M6OkludHJpbnNpY0dl dHRlckFjY2Vzc0Nhc2U6OmNhbkVtaXRJbnRyaW5zaWNHZXR0ZXIpOgorICAgICAgICAoSlNDOjpJ bnRyaW5zaWNHZXR0ZXJBY2Nlc3NDYXNlOjplbWl0SW50cmluc2ljR2V0dGVyKToKKwogMjAyMS0x MC0xMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAg ICAgIEJlZ2luIG1pZ3JhdGlvbiBmcm9tIFdURjo6VmFyaWFudCB0byBzdGQ6OnZhcmlhbnQKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQXNzZW1ibHlIZWxwZXJzLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0Fzc2VtYmx5SGVscGVycy5jcHAJKHJl dmlzaW9uIDI4Mzk5MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQXNzZW1ibHlIZWxw ZXJzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDM1LDM2ICs0MzUsNiBAQCB2b2lkIEFzc2VtYmx5 SGVscGVyczo6ZW1pdExvYWRQcm90b3R5cGUoCiAgICAgaGFzTW9ub1Byb3RvLmxpbmsodGhpcyk7 CiB9CiAKLXZvaWQgQXNzZW1ibHlIZWxwZXJzOjplbWl0TG9hZFByb3RvdHlwZVdpdGhvdXRDaGVj ayhWTSYgdm0sIEdQUlJlZyBvYmplY3RHUFIsIEpTVmFsdWVSZWdzIHJlc3VsdFJlZ3MsIEdQUlJl ZyBzY3JhdGNoR1BSLCBHUFJSZWcgc2NyYXRjaDJHUFIpCi17Ci0gICAgQVNTRVJUKG9iamVjdEdQ UiAhPSBzY3JhdGNoR1BSKTsKLSAgICBBU1NFUlQob2JqZWN0R1BSICE9IHNjcmF0Y2gyR1BSKTsK LSAgICBBU1NFUlQocmVzdWx0UmVncy5wYXlsb2FkR1BSKCkgIT0gc2NyYXRjaEdQUik7Ci0gICAg QVNTRVJUKHJlc3VsdFJlZ3MucGF5bG9hZEdQUigpICE9IHNjcmF0Y2gyR1BSKTsKLSNpZiBVU0Uo SlNWQUxVRTMyXzY0KQotICAgIEFTU0VSVChyZXN1bHRSZWdzLnRhZ0dQUigpICE9IHNjcmF0Y2hH UFIpOwotICAgIEFTU0VSVChyZXN1bHRSZWdzLnRhZ0dQUigpICE9IHNjcmF0Y2gyR1BSKTsKLSNl bmRpZgotCi0gICAgZW1pdExvYWRTdHJ1Y3R1cmUodm0sIG9iamVjdEdQUiwgc2NyYXRjaEdQUiwg c2NyYXRjaDJHUFIpOwotI2lmIFVTRShKU1ZBTFVFNjQpCi0gICAgbG9hZFZhbHVlKE1hY3JvQXNz ZW1ibGVyOjpBZGRyZXNzKHNjcmF0Y2hHUFIsIFN0cnVjdHVyZTo6cHJvdG90eXBlT2Zmc2V0KCkp LCBKU1ZhbHVlUmVncyhzY3JhdGNoMkdQUikpOwotI2Vsc2UKLSAgICBsb2FkMzIoTWFjcm9Bc3Nl bWJsZXI6OkFkZHJlc3Moc2NyYXRjaEdQUiwgU3RydWN0dXJlOjpwcm90b3R5cGVPZmZzZXQoKSAr IFRhZ09mZnNldCksIHNjcmF0Y2gyR1BSKTsKLSNlbmRpZgotICAgIGF1dG8gaGFzTW9ub1Byb3Rv ID0gYnJhbmNoSWZOb3RFbXB0eShzY3JhdGNoMkdQUik7Ci0gICAgbG9hZFZhbHVlKE1hY3JvQXNz ZW1ibGVyOjpBZGRyZXNzKG9iamVjdEdQUiwgb2Zmc2V0UmVsYXRpdmVUb0Jhc2Uoa25vd25Qb2x5 UHJvdG9PZmZzZXQpKSwgcmVzdWx0UmVncyk7Ci0gICAgYXV0byBkb25lID0ganVtcCgpOwotICAg IGhhc01vbm9Qcm90by5saW5rKHRoaXMpOwotI2lmIFVTRShKU1ZBTFVFNjQpCi0gICAgbW92ZShz Y3JhdGNoMkdQUiwgcmVzdWx0UmVncy5wYXlsb2FkR1BSKCkpOwotI2Vsc2UKLSAgICBsb2FkMzIo TWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3Moc2NyYXRjaEdQUiwgU3RydWN0dXJlOjpwcm90b3R5cGVP ZmZzZXQoKSArIFBheWxvYWRPZmZzZXQpLCByZXN1bHRSZWdzLnBheWxvYWRHUFIoKSk7Ci0gICAg bW92ZShzY3JhdGNoMkdQUiwgcmVzdWx0UmVncy50YWdHUFIoKSk7Ci0jZW5kaWYKLSAgICBkb25l LmxpbmsodGhpcyk7Ci19Ci0KIHZvaWQgQXNzZW1ibHlIZWxwZXJzOjptYWtlU3BhY2VPblN0YWNr Rm9yQ0NhbGwoKQogewogICAgIHVuc2lnbmVkIHN0YWNrT2Zmc2V0ID0gV1RGOjpyb3VuZFVwVG9N dWx0aXBsZU9mKHN0YWNrQWxpZ25tZW50Qnl0ZXMoKSwgbWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0 aENhbGwpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9Bc3NlbWJseUhlbHBlcnMu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0Fzc2VtYmx5SGVscGVy cy5oCShyZXZpc2lvbiAyODM5OTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0Fzc2Vt Ymx5SGVscGVycy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNTMwLDcgKzE1MzAsNiBAQCBwdWJsaWM6 CiAgICAgCiAgICAgdm9pZCBlbWl0TG9hZFN0cnVjdHVyZShWTSYsIFJlZ2lzdGVySUQgc291cmNl LCBSZWdpc3RlcklEIGRlc3QsIFJlZ2lzdGVySUQgc2NyYXRjaCk7CiAgICAgdm9pZCBlbWl0TG9h ZFByb3RvdHlwZShWTSYsIEdQUlJlZyBvYmplY3RHUFIsIEpTVmFsdWVSZWdzIHJlc3VsdFJlZ3Ms IEdQUlJlZyBzY3JhdGNoR1BSLCBKdW1wTGlzdCYgc2xvd1BhdGgpOwotICAgIHZvaWQgZW1pdExv YWRQcm90b3R5cGVXaXRob3V0Q2hlY2soVk0mLCBHUFJSZWcgb2JqZWN0R1BSLCBKU1ZhbHVlUmVn cyByZXN1bHRSZWdzLCBHUFJSZWcgc2NyYXRjaEdQUiwgR1BSUmVnIHNjcmF0Y2gyR1BSKTsKIAog ICAgIHZvaWQgZW1pdFN0b3JlU3RydWN0dXJlV2l0aFR5cGVJbmZvKFRydXN0ZWRJbW1QdHIgc3Ry dWN0dXJlLCBSZWdpc3RlcklEIGRlc3QsIFJlZ2lzdGVySUQpCiAgICAgewpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9JbnRyaW5zaWNFbWl0dGVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0ludHJpbnNpY0VtaXR0ZXIuY3BwCShyZXZpc2lvbiAy ODM5OTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0ludHJpbnNpY0VtaXR0ZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00OCwxNSArNDgsMTggQEAgdHlwZWRlZiBDQ2FsbEhlbHBlcnM6 OkltbTY0IEltbTY0OwogCiBib29sIEludHJpbnNpY0dldHRlckFjY2Vzc0Nhc2U6OmNhbkVtaXRJ bnRyaW5zaWNHZXR0ZXIoU3RydWN0dXJlU3R1YkluZm8mIHN0dWJJbmZvLCBKU0Z1bmN0aW9uKiBn ZXR0ZXIsIFN0cnVjdHVyZSogc3RydWN0dXJlKQogeworICAgIC8vIFdlIGFyZW4ndCBzdHJ1Y3R1 cmUgY2hlY2tpbmcgdGhlIHRoaXMgdmFsdWUsIHNvIHdlIGRvbid0IGtub3c6CisgICAgLy8gLSBG b3IgdHlwZSBhcnJheSBsb2FkcywgdGhhdCBpdCdzIGEgdHlwZWQgYXJyYXkuCisgICAgLy8gLSBG b3IgX19wcm90b19fIGdldHRlciwgdGhhdCB0aGUgaW5jb21pbmcgdmFsdWUgaXMgYW4gb2JqZWN0 LAorICAgIC8vICAgYW5kIGlmIGl0IG92ZXJyaWRlcyBnZXRQcm90b3R5cGUgc3RydWN0dXJlIGZs YWdzLgorICAgIC8vIFNvIGZvciB0aGVzZSBjYXNlcywgaXQncyBzaW1wbGVyIHRvIGp1c3QgY2Fs bCB0aGUgZ2V0dGVyIGRpcmVjdGx5LgorICAgIGlmIChzdHViSW5mby50aGlzVmFsdWVJc0luVGhp c0dQUigpKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBzd2l0Y2ggKGdldHRlci0+aW50 cmluc2ljKCkpIHsKICAgICBjYXNlIFR5cGVkQXJyYXlCeXRlT2Zmc2V0SW50cmluc2ljOgogICAg IGNhc2UgVHlwZWRBcnJheUJ5dGVMZW5ndGhJbnRyaW5zaWM6CiAgICAgY2FzZSBUeXBlZEFycmF5 TGVuZ3RoSW50cmluc2ljOiB7Ci0gICAgICAgIC8vIFdlIGFyZW4ndCBzdHJ1Y3R1cmUgY2hlY2tp bmcgdGhlIHRoaXMgdmFsdWUsIHNvIHdlIGRvbid0IGtub3cgaXQncyBhIHR5cGVkIGFycmF5Lgot ICAgICAgICBpZiAoc3R1YkluZm8udGhpc1ZhbHVlSXNJblRoaXNHUFIoKSkKLSAgICAgICAgICAg IHJldHVybiBmYWxzZTsKLQogICAgICAgICBUeXBlZEFycmF5VHlwZSB0eXBlID0gc3RydWN0dXJl LT5jbGFzc0luZm8oKS0+dHlwZWRBcnJheVN0b3JhZ2VUeXBlOwogCiAgICAgICAgIGlmICghaXNU eXBlZFZpZXcodHlwZSkpCkBAIC0xMzcsMjEgKzE0MCwxMCBAQCB2b2lkIEludHJpbnNpY0dldHRl ckFjY2Vzc0Nhc2U6OmVtaXRJbnRyCiAgICAgfQogCiAgICAgY2FzZSBVbmRlcnNjb3JlUHJvdG9J bnRyaW5zaWM6IHsKLSAgICAgICAgU3RydWN0dXJlU3R1YkluZm8mIHN0dWJJbmZvID0gKnN0YXRl LnN0dWJJbmZvOwotICAgICAgICBpZiAoc3R1YkluZm8udGhpc1ZhbHVlSXNJblRoaXNHUFIoKSkg ewotICAgICAgICAgICAgYXV0byBhbGxvY2F0b3IgPSBzdGF0ZS5tYWtlRGVmYXVsdFNjcmF0Y2hB bGxvY2F0b3Ioc3RhdGUuc2NyYXRjaEdQUik7Ci0gICAgICAgICAgICBHUFJSZWcgc2NyYXRjaDJH UFIgPSBhbGxvY2F0b3IuYWxsb2NhdGVTY3JhdGNoR1BSKCk7Ci0gICAgICAgICAgICBhdXRvIHBy ZXNlcnZlZFN0YXRlID0gYWxsb2NhdG9yLnByZXNlcnZlUmV1c2VkUmVnaXN0ZXJzQnlQdXNoaW5n KGppdCwgU2NyYXRjaFJlZ2lzdGVyQWxsb2NhdG9yOjpFeHRyYVN0YWNrU3BhY2U6Ok5vRXh0cmFT cGFjZSk7Ci0KLSAgICAgICAgICAgIGppdC5lbWl0TG9hZFByb3RvdHlwZVdpdGhvdXRDaGVjayhz dGF0ZS5tX3ZtLCBzdGF0ZS51LnRoaXNHUFIsIHZhbHVlUmVncywgc3RhdGUuc2NyYXRjaEdQUiwg c2NyYXRjaDJHUFIpOwotCi0gICAgICAgICAgICBhbGxvY2F0b3IucmVzdG9yZVJldXNlZFJlZ2lz dGVyc0J5UG9wcGluZyhqaXQsIHByZXNlcnZlZFN0YXRlKTsKLSAgICAgICAgfSBlbHNlIHsKLSAg ICAgICAgICAgIGlmIChzdHJ1Y3R1cmUoKS0+aGFzUG9seVByb3RvKCkpCi0gICAgICAgICAgICAg ICAgaml0LmxvYWRWYWx1ZShDQ2FsbEhlbHBlcnM6OkFkZHJlc3MoYmFzZUdQUiwgb2Zmc2V0UmVs YXRpdmVUb0Jhc2Uoa25vd25Qb2x5UHJvdG9PZmZzZXQpKSwgdmFsdWVSZWdzKTsKLSAgICAgICAg ICAgIGVsc2UKLSAgICAgICAgICAgICAgICBqaXQubW92ZVZhbHVlKHN0cnVjdHVyZSgpLT5zdG9y ZWRQcm90b3R5cGUoKSwgdmFsdWVSZWdzKTsKLSAgICAgICAgfQorICAgICAgICBpZiAoc3RydWN0 dXJlKCktPmhhc1BvbHlQcm90bygpKQorICAgICAgICAgICAgaml0LmxvYWRWYWx1ZShDQ2FsbEhl bHBlcnM6OkFkZHJlc3MoYmFzZUdQUiwgb2Zmc2V0UmVsYXRpdmVUb0Jhc2Uoa25vd25Qb2x5UHJv dG9PZmZzZXQpKSwgdmFsdWVSZWdzKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgaml0Lm1v dmVWYWx1ZShzdHJ1Y3R1cmUoKS0+c3RvcmVkUHJvdG90eXBlKCksIHZhbHVlUmVncyk7CiAgICAg ICAgIHN0YXRlLnN1Y2NlZWQoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K