231533 2021-10-11 14:03:24 -0700 Fix makeprop.pl to not treat "inherited: false" properties as inherited. 2021-10-12 08:38:43 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kiet.ho webkit-unassigned darin esprehn+autocc ews-watchlist glenn gyuyoung.kim kiet.ho macpherson menard mmaxfield simon.fraser webkit-bug-importer oldest_to_newest 1802788 0 kiet.ho 2021-10-11 14:03:24 -0700 makeprop.pl treats a property as inherited if the "inherited" option in CSSProperties.json is defined, regardless of whether the option value is true or false. Fix makeprop.pl to actually consider the option value. 1802801 1 440834 kiet.ho 2021-10-11 14:23:13 -0700 Created attachment 440834 Patch 1802933 2 ews-feeder 2021-10-11 19:48:39 -0700 Committed r283963 (242810@main): <https://commits.webkit.org/242810@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440834. 1802934 3 webkit-bug-importer 2021-10-11 19:49:18 -0700 <rdar://problem/84128720> 1803129 4 darin 2021-10-12 08:38:43 -0700 Why no tests? Doesn’t this affect anything? 440834 2021-10-11 14:23:13 -0700 2021-10-11 19:48:41 -0700 Patch bug-231533-20211011162312.patch text/plain 1747 kiet.ho U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWQ2ZTFiOWYxYWNhYzkz NTY5YzY1ODk1NzkzNThhMzExM2NjZTJjZC4uNTRlMTE2NmY2ZDE2NGYwYjlhNDkwOGJmMTQ0Mzll Yzk3NWU4ZGJmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTExICBLaWV0 IEhvICA8dGhvMjJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBtYWtlcHJvcC5wbCB0byBub3Qg dHJlYXQgImluaGVyaXRlZDogZmFsc2UiIHByb3BlcnRpZXMgYXMgaW5oZXJpdGVkLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxNTMzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbWFrZXByb3AucGwgdHJl YXRzIGEgcHJvcGVydHkgYXMgaW5oZXJpdGVkIGlmIHRoZSAiaW5oZXJpdGVkIiBvcHRpb24gaW4g CisgICAgICAgIENTU1Byb3BlcnRpZXMuanNvbiBpcyBkZWZpbmVkLCByZWdhcmRsZXNzIG9mIHdo ZXRoZXIgdGhlIG9wdGlvbiB2YWx1ZSBpcyAKKyAgICAgICAgdHJ1ZSBvciBmYWxzZS4gRml4IG1h a2Vwcm9wLnBsIHRvIGFjdHVhbGx5IGNvbnNpZGVyIHRoZSBvcHRpb24gdmFsdWUuCisKKyAgICAg ICAgKiBjc3MvbWFrZXByb3AucGw6CisgICAgICAgIChhZGRQcm9wZXJ0eSk6CisKIDIwMjEtMTAt MTAgIEtpZXQgSG8gIDx0aG8yMkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IHBhcnNp bmcgc3VwcG9ydCBmb3Igb2Zmc2V0LWRpc3RhbmNlLCBvZmZzZXQtcG9zaXRpb24sIG9mZnNldC1h bmNob3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbCBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbAppbmRleCAyY2NmNmVkNWRjNjRhMGY4YmM4NjcxYzAz YzdjMDBmYjFiYzA5YmJkLi4yMDJiNGU5MWNlYTY3MjIyNGUzM2NkN2FmMTBjYmRmNzExYjVlZDRk IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwKKysrIGIvU291cmNl L1dlYkNvcmUvY3NzL21ha2Vwcm9wLnBsCkBAIC0zNDMsOSArMzQzLDkgQEAgc3ViIGFkZFByb3Bl cnR5KCQkKQogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAgfSBlbHNp ZiAoJG9wdGlvbk5hbWUgZXEgImFuaW1hdGFibGUiKSB7Ci0gICAgICAgICAgICAgJHByb3BlcnRp ZXNXaXRoU3R5bGVCdWlsZGVyT3B0aW9uc3skbmFtZX17ImFuaW1hdGFibGUifSA9ICRvcHRpb25z SGFzaFJlZi0+eyJhbmltYXRhYmxlIn07CisgICAgICAgICAgICAkcHJvcGVydGllc1dpdGhTdHls ZUJ1aWxkZXJPcHRpb25zeyRuYW1lfXsiYW5pbWF0YWJsZSJ9ID0gJG9wdGlvbnNIYXNoUmVmLT57 ImFuaW1hdGFibGUifTsKICAgICAgICAgfSBlbHNpZiAoJG9wdGlvbk5hbWUgZXEgImluaGVyaXRl ZCIpIHsKLSAgICAgICAgICAgICRuYW1lSXNJbmhlcml0ZWR7JG5hbWV9ID0gMTsKKyAgICAgICAg ICAgICRuYW1lSXNJbmhlcml0ZWR7JG5hbWV9ID0gJG9wdGlvbnNIYXNoUmVmLT57ImluaGVyaXRl ZCJ9OwogICAgICAgICB9IGVsc2lmICgkb3B0aW9uTmFtZSBlcSAidmFsdWVzIikgewogICAgICAg ICAgICAgIyBGSVhNRTogSW1wbGVtZW50LgogICAgICAgICB9Cg==