231527 2021-10-11 13:18:53 -0700 [build-imagediff] Build universal binaries by default 2021-10-11 15:20:05 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard dewei_zhu ryanhaddad slewis webkit-bug-importer oldest_to_newest 1802766 0 jbedard 2021-10-11 13:18:53 -0700 ImageDiff is a small enough program that we should really just always builds it with both x86 and arm64 on Mac. 1802767 1 webkit-bug-importer 2021-10-11 13:19:26 -0700 <rdar://problem/84113091> 1802769 2 440829 jbedard 2021-10-11 13:20:21 -0700 Created attachment 440829 Patch 1802792 3 440829 ryanhaddad 2021-10-11 14:07:13 -0700 Comment on attachment 440829 Patch Seems reasonable to me. 1802807 4 jbedard 2021-10-11 14:37:18 -0700 Some context, we know we need this for our arm Simulator bots: https://build.webkit.org/#/builders/298/builds/2 1802837 5 ews-feeder 2021-10-11 15:20:03 -0700 Committed r283939 (242798@main): <https://commits.webkit.org/242798@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440829. 440829 2021-10-11 13:20:21 -0700 2021-10-11 15:20:04 -0700 Patch bug-231527-20211011132020.patch text/plain 1047 jbedard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzOTE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmNjN2MwNGM4NzJiZTRiNzc3MzI1M2Q3MTcwNzk3M2U5 OGNiZjgzOS4uNGJmNDhiMTQyNmI3M2FiZmQ3ZTFmNjRhZTgzODk1MGZiYzQyZDZkMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTEwLTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKwor ICAgICAgICBbYnVpbGQtaW1hZ2VkaWZmXSBCdWlsZCB1bml2ZXJzYWwgYmluYXJpZXMgYnkgZGVm YXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMx NTI3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NDExMzA5MT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtaW1hZ2VkaWZm OgorCiAyMDIxLTEwLTExICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAg ICAgICAgIEJyaW5nIHVwIGFuIGlPUyBHUFUgUHJvY2VzcyB0ZXN0ZXIKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvYnVpbGQtaW1hZ2VkaWZmIGIvVG9vbHMvU2NyaXB0cy9idWlsZC1pbWFnZWRp ZmYKaW5kZXggN2NiOTYzZTc2YjNjNzcxYTcxODBiNGY5ZWEwNDUyNTNiNmQyZjQwMC4uZWZiZDhi NTVhYzlkODU5MjlkZTMzOGU3ZGRjMzYzNjlkOTc4OGRlMCAxMDA3NTUKLS0tIGEvVG9vbHMvU2Ny aXB0cy9idWlsZC1pbWFnZWRpZmYKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC1pbWFnZWRpZmYK QEAgLTU1LDYgKzU1LDggQEAgaWYgKCRzaG93SGVscCBvciBub3QgJHJlc3VsdCkgewogICAgZXhp dCAxOwogfQogCitzZXRBcmNoaXRlY3R1cmUoIng4Nl82NCBhcm02NCIpIGlmIGlzQXBwbGVNYWNX ZWJLaXQoKTsKKwogY2hlY2tSZXF1aXJlZFN5c3RlbUNvbmZpZygpOwogc2V0Q29uZmlndXJhdGlv bigpOwogY2hkaXJXZWJLaXQoKTsK