231521 2021-10-11 11:58:56 -0700 Only mark needed JSONImpl::ObjectBase functions with WTF_EXPORT_PRIVATE 2021-10-12 10:28:49 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez ross.kirsling webkit-bug-importer oldest_to_newest 1802718 0 achristensen 2021-10-11 11:58:56 -0700 Only mark needed JSONImpl::ObjectBase functions with WTF_EXPORT_PRIVATE 1802720 1 440813 achristensen 2021-10-11 12:00:44 -0700 Created attachment 440813 Patch 1802732 2 440818 achristensen 2021-10-11 12:17:06 -0700 Created attachment 440818 Patch 1802735 3 440818 cdumez 2021-10-11 12:19:21 -0700 Comment on attachment 440818 Patch r=me if the bots are happy. 1802852 4 ews-feeder 2021-10-11 15:46:26 -0700 Committed r283943 (242801@main): <https://commits.webkit.org/242801@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440818. 1802853 5 webkit-bug-importer 2021-10-11 15:47:23 -0700 <rdar://problem/84119966> 1803211 6 ross.kirsling 2021-10-12 10:28:49 -0700 Landed WinCairo build fix in r283990. 440813 2021-10-11 12:00:44 -0700 2021-10-11 13:03:25 -0700 Patch bug-231521-20211011130043.patch text/plain 2969 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRhMzViMzI3MGYyNDk1NjY2M2ZhY2U2 YzJhYzllMDkxMzBmYTMyZmYuLjZlMmIwNDEwOWY2MmUzZDVjYTdmY2UyMGNmNjE4NWQ4ZWMzNmQ5 ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTAtMTEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBPbmx5IG1hcmsgbmVlZGVkIEpTT05J bXBsOjpPYmplY3RCYXNlIGZ1bmN0aW9ucyB3aXRoIFdURl9FWFBPUlRfUFJJVkFURQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxNTIxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSdtIHRyeWluZyBzb21l IHdpbGQgZXhwZXJpbWVudHMgd2l0aCB0aGUgbGlua2VyLCBhbmQgd2hlbiBJIGRvIHRoZSB3ZWFr IHN5bWJvbCBjaGVja2VyIGZhaWxzIGJlY2F1c2UKKyAgICAgICAgaXQgaXMgdHJ5aW5nIHRvIGV4 cG9ydCBzb21lIG9mIHRoZSBpbmxpbmUgZnVuY3Rpb25zIGF0IHRoZSBib3R0b20gb2YgSlNPTlZh bHVlcy5oLgorICAgICAgICBNb3ZpbmcgV1RGX0VYUE9SVF9QUklWQVRFIGZyb20gZXhwb3J0aW5n IHRoZSB3aG9sZSBjbGFzcyB0byBvbmx5IGV4cG9ydGluZyB0aGUgbm9uLWlubGluZSBmdW5jdGlv bnMgZml4ZXMgaXQuCisKKyAgICAgICAgKiB3dGYvSlNPTlZhbHVlcy5oOgorCiAyMDIxLTEwLTA4 ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIGRlZmF1 bHRBbHRlcm5hdGVGb3JtQ29udHJvbERlc2lnbkVuYWJsZWQoKSBjYW4ndCByZWFkIFVJVXNlcklu dGVyZmFjZUlkaW9tIGluIHRoZSBXZWIgQ29udGVudCBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9KU09OVmFsdWVzLmggYi9Tb3VyY2UvV1RGL3d0Zi9KU09OVmFsdWVzLmgKaW5k ZXggMWMxZmRmMTFmMTllOTlkNWIwMzhlOGNhMGM0MGM5YjVhOTFmNWY2MS4uMGZkNzAxNDZlMzdi NmYzZjJjNmM2YTk5MjFkNmNjOWQ0MzQwMTljOCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv SlNPTlZhbHVlcy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0pTT05WYWx1ZXMuaApAQCAtMTYwLDcg KzE2MCw3IEBAIHByaXZhdGU6CiAgICAgfSBtX3ZhbHVlOwogfTsKIAotY2xhc3MgV1RGX0VYUE9S VF9QUklWQVRFIE9iamVjdEJhc2UgOiBwdWJsaWMgVmFsdWUgeworY2xhc3MgT2JqZWN0QmFzZSA6 IHB1YmxpYyBWYWx1ZSB7CiBwcml2YXRlOgogICAgIHVzaW5nIERhdGFTdG9yYWdlID0gSGFzaE1h cDxTdHJpbmcsIFJlZjxWYWx1ZT4+OwogICAgIHVzaW5nIE9yZGVyU3RvcmFnZSA9IFZlY3RvcjxT dHJpbmc+OwpAQCAtMTY5LDkgKzE2OSw5IEBAIHB1YmxpYzoKICAgICB1c2luZyBpdGVyYXRvciA9 IERhdGFTdG9yYWdlOjppdGVyYXRvcjsKICAgICB1c2luZyBjb25zdF9pdGVyYXRvciA9IERhdGFT dG9yYWdlOjpjb25zdF9pdGVyYXRvcjsKIAotICAgIFJlZlB0cjxPYmplY3Q+IGFzT2JqZWN0KCkg ZmluYWw7CisgICAgV1RGX0VYUE9SVF9QUklWQVRFIFJlZlB0cjxPYmplY3Q+IGFzT2JqZWN0KCkg ZmluYWw7CiAKLSAgICBzaXplX3QgbWVtb3J5Q29zdCgpIGNvbnN0IGZpbmFsOworICAgIFdURl9F WFBPUlRfUFJJVkFURSBzaXplX3QgbWVtb3J5Q29zdCgpIGNvbnN0IGZpbmFsOwogCiBwcm90ZWN0 ZWQ6CiAgICAgfk9iamVjdEJhc2UoKSBvdmVycmlkZTsKQEAgLTE4OCwxMyArMTg4LDEzIEBAIHBy b3RlY3RlZDoKICAgICBpdGVyYXRvciBmaW5kKGNvbnN0IFN0cmluZyYgbmFtZSk7CiAgICAgY29u c3RfaXRlcmF0b3IgZmluZChjb25zdCBTdHJpbmcmIG5hbWUpIGNvbnN0OwogCi0gICAgc3RkOjpv cHRpb25hbDxib29sPiBnZXRCb29sZWFuKGNvbnN0IFN0cmluZyYgbmFtZSkgY29uc3Q7Ci0gICAg c3RkOjpvcHRpb25hbDxkb3VibGU+IGdldERvdWJsZShjb25zdCBTdHJpbmcmIG5hbWUpIGNvbnN0 OwotICAgIHN0ZDo6b3B0aW9uYWw8aW50PiBnZXRJbnRlZ2VyKGNvbnN0IFN0cmluZyYgbmFtZSkg Y29uc3Q7Ci0gICAgU3RyaW5nIGdldFN0cmluZyhjb25zdCBTdHJpbmcmIG5hbWUpIGNvbnN0Owot ICAgIFJlZlB0cjxPYmplY3Q+IGdldE9iamVjdChjb25zdCBTdHJpbmcmIG5hbWUpIGNvbnN0Owot ICAgIFJlZlB0cjxBcnJheT4gZ2V0QXJyYXkoY29uc3QgU3RyaW5nJiBuYW1lKSBjb25zdDsKLSAg ICBSZWZQdHI8VmFsdWU+IGdldFZhbHVlKGNvbnN0IFN0cmluZyYgbmFtZSkgY29uc3Q7CisgICAg V1RGX0VYUE9SVF9QUklWQVRFIHN0ZDo6b3B0aW9uYWw8Ym9vbD4gZ2V0Qm9vbGVhbihjb25zdCBT dHJpbmcmIG5hbWUpIGNvbnN0OworICAgIFdURl9FWFBPUlRfUFJJVkFURSBzdGQ6Om9wdGlvbmFs PGRvdWJsZT4gZ2V0RG91YmxlKGNvbnN0IFN0cmluZyYgbmFtZSkgY29uc3Q7CisgICAgV1RGX0VY UE9SVF9QUklWQVRFIHN0ZDo6b3B0aW9uYWw8aW50PiBnZXRJbnRlZ2VyKGNvbnN0IFN0cmluZyYg bmFtZSkgY29uc3Q7CisgICAgV1RGX0VYUE9SVF9QUklWQVRFIFN0cmluZyBnZXRTdHJpbmcoY29u c3QgU3RyaW5nJiBuYW1lKSBjb25zdDsKKyAgICBXVEZfRVhQT1JUX1BSSVZBVEUgUmVmUHRyPE9i amVjdD4gZ2V0T2JqZWN0KGNvbnN0IFN0cmluZyYgbmFtZSkgY29uc3Q7CisgICAgV1RGX0VYUE9S VF9QUklWQVRFIFJlZlB0cjxBcnJheT4gZ2V0QXJyYXkoY29uc3QgU3RyaW5nJiBuYW1lKSBjb25z dDsKKyAgICBXVEZfRVhQT1JUX1BSSVZBVEUgUmVmUHRyPFZhbHVlPiBnZXRWYWx1ZShjb25zdCBT dHJpbmcmIG5hbWUpIGNvbnN0OwogCiAgICAgdm9pZCByZW1vdmUoY29uc3QgU3RyaW5nJiBuYW1l KTsKIAo= 440818 2021-10-11 12:17:06 -0700 2021-10-11 15:46:26 -0700 Patch bug-231521-20211011131705.patch text/plain 3084 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRhMzViMzI3MGYyNDk1NjY2M2ZhY2U2 YzJhYzllMDkxMzBmYTMyZmYuLjZlMmIwNDEwOWY2MmUzZDVjYTdmY2UyMGNmNjE4NWQ4ZWMzNmQ5 ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTAtMTEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBPbmx5IG1hcmsgbmVlZGVkIEpTT05J bXBsOjpPYmplY3RCYXNlIGZ1bmN0aW9ucyB3aXRoIFdURl9FWFBPUlRfUFJJVkFURQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxNTIxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSdtIHRyeWluZyBzb21l IHdpbGQgZXhwZXJpbWVudHMgd2l0aCB0aGUgbGlua2VyLCBhbmQgd2hlbiBJIGRvIHRoZSB3ZWFr IHN5bWJvbCBjaGVja2VyIGZhaWxzIGJlY2F1c2UKKyAgICAgICAgaXQgaXMgdHJ5aW5nIHRvIGV4 cG9ydCBzb21lIG9mIHRoZSBpbmxpbmUgZnVuY3Rpb25zIGF0IHRoZSBib3R0b20gb2YgSlNPTlZh bHVlcy5oLgorICAgICAgICBNb3ZpbmcgV1RGX0VYUE9SVF9QUklWQVRFIGZyb20gZXhwb3J0aW5n IHRoZSB3aG9sZSBjbGFzcyB0byBvbmx5IGV4cG9ydGluZyB0aGUgbm9uLWlubGluZSBmdW5jdGlv bnMgZml4ZXMgaXQuCisKKyAgICAgICAgKiB3dGYvSlNPTlZhbHVlcy5oOgorCiAyMDIxLTEwLTA4 ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIGRlZmF1 bHRBbHRlcm5hdGVGb3JtQ29udHJvbERlc2lnbkVuYWJsZWQoKSBjYW4ndCByZWFkIFVJVXNlcklu dGVyZmFjZUlkaW9tIGluIHRoZSBXZWIgQ29udGVudCBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9KU09OVmFsdWVzLmggYi9Tb3VyY2UvV1RGL3d0Zi9KU09OVmFsdWVzLmgKaW5k ZXggMWMxZmRmMTFmMTllOTlkNWIwMzhlOGNhMGM0MGM5YjVhOTFmNWY2MS4uMmQ5MjBjMmIyZmQ0 ODA2MmM2ODliOTZiOTVjMWMwNGNkMDQ1MmQ5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv SlNPTlZhbHVlcy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0pTT05WYWx1ZXMuaApAQCAtMTYwLDcg KzE2MCw3IEBAIHByaXZhdGU6CiAgICAgfSBtX3ZhbHVlOwogfTsKIAotY2xhc3MgV1RGX0VYUE9S VF9QUklWQVRFIE9iamVjdEJhc2UgOiBwdWJsaWMgVmFsdWUgeworY2xhc3MgT2JqZWN0QmFzZSA6 IHB1YmxpYyBWYWx1ZSB7CiBwcml2YXRlOgogICAgIHVzaW5nIERhdGFTdG9yYWdlID0gSGFzaE1h cDxTdHJpbmcsIFJlZjxWYWx1ZT4+OwogICAgIHVzaW5nIE9yZGVyU3RvcmFnZSA9IFZlY3RvcjxT dHJpbmc+OwpAQCAtMTY5LDkgKzE2OSw5IEBAIHB1YmxpYzoKICAgICB1c2luZyBpdGVyYXRvciA9 IERhdGFTdG9yYWdlOjppdGVyYXRvcjsKICAgICB1c2luZyBjb25zdF9pdGVyYXRvciA9IERhdGFT dG9yYWdlOjpjb25zdF9pdGVyYXRvcjsKIAotICAgIFJlZlB0cjxPYmplY3Q+IGFzT2JqZWN0KCkg ZmluYWw7CisgICAgV1RGX0VYUE9SVF9QUklWQVRFIFJlZlB0cjxPYmplY3Q+IGFzT2JqZWN0KCkg ZmluYWw7CiAKLSAgICBzaXplX3QgbWVtb3J5Q29zdCgpIGNvbnN0IGZpbmFsOworICAgIFdURl9F WFBPUlRfUFJJVkFURSBzaXplX3QgbWVtb3J5Q29zdCgpIGNvbnN0IGZpbmFsOwogCiBwcm90ZWN0 ZWQ6CiAgICAgfk9iamVjdEJhc2UoKSBvdmVycmlkZTsKQEAgLTE4OCwxNSArMTg4LDE1IEBAIHBy b3RlY3RlZDoKICAgICBpdGVyYXRvciBmaW5kKGNvbnN0IFN0cmluZyYgbmFtZSk7CiAgICAgY29u c3RfaXRlcmF0b3IgZmluZChjb25zdCBTdHJpbmcmIG5hbWUpIGNvbnN0OwogCi0gICAgc3RkOjpv cHRpb25hbDxib29sPiBnZXRCb29sZWFuKGNvbnN0IFN0cmluZyYgbmFtZSkgY29uc3Q7Ci0gICAg c3RkOjpvcHRpb25hbDxkb3VibGU+IGdldERvdWJsZShjb25zdCBTdHJpbmcmIG5hbWUpIGNvbnN0 OwotICAgIHN0ZDo6b3B0aW9uYWw8aW50PiBnZXRJbnRlZ2VyKGNvbnN0IFN0cmluZyYgbmFtZSkg Y29uc3Q7Ci0gICAgU3RyaW5nIGdldFN0cmluZyhjb25zdCBTdHJpbmcmIG5hbWUpIGNvbnN0Owot ICAgIFJlZlB0cjxPYmplY3Q+IGdldE9iamVjdChjb25zdCBTdHJpbmcmIG5hbWUpIGNvbnN0Owot ICAgIFJlZlB0cjxBcnJheT4gZ2V0QXJyYXkoY29uc3QgU3RyaW5nJiBuYW1lKSBjb25zdDsKLSAg ICBSZWZQdHI8VmFsdWU+IGdldFZhbHVlKGNvbnN0IFN0cmluZyYgbmFtZSkgY29uc3Q7CisgICAg V1RGX0VYUE9SVF9QUklWQVRFIHN0ZDo6b3B0aW9uYWw8Ym9vbD4gZ2V0Qm9vbGVhbihjb25zdCBT dHJpbmcmIG5hbWUpIGNvbnN0OworICAgIFdURl9FWFBPUlRfUFJJVkFURSBzdGQ6Om9wdGlvbmFs PGRvdWJsZT4gZ2V0RG91YmxlKGNvbnN0IFN0cmluZyYgbmFtZSkgY29uc3Q7CisgICAgV1RGX0VY UE9SVF9QUklWQVRFIHN0ZDo6b3B0aW9uYWw8aW50PiBnZXRJbnRlZ2VyKGNvbnN0IFN0cmluZyYg bmFtZSkgY29uc3Q7CisgICAgV1RGX0VYUE9SVF9QUklWQVRFIFN0cmluZyBnZXRTdHJpbmcoY29u c3QgU3RyaW5nJiBuYW1lKSBjb25zdDsKKyAgICBXVEZfRVhQT1JUX1BSSVZBVEUgUmVmUHRyPE9i amVjdD4gZ2V0T2JqZWN0KGNvbnN0IFN0cmluZyYgbmFtZSkgY29uc3Q7CisgICAgV1RGX0VYUE9S VF9QUklWQVRFIFJlZlB0cjxBcnJheT4gZ2V0QXJyYXkoY29uc3QgU3RyaW5nJiBuYW1lKSBjb25z dDsKKyAgICBXVEZfRVhQT1JUX1BSSVZBVEUgUmVmUHRyPFZhbHVlPiBnZXRWYWx1ZShjb25zdCBT dHJpbmcmIG5hbWUpIGNvbnN0OwogCi0gICAgdm9pZCByZW1vdmUoY29uc3QgU3RyaW5nJiBuYW1l KTsKKyAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCByZW1vdmUoY29uc3QgU3RyaW5nJiBuYW1l KTsKIAogICAgIHZvaWQgd3JpdGVKU09OKFN0cmluZ0J1aWxkZXImIG91dHB1dCkgY29uc3QgZmlu YWw7CiAK