231512 2021-10-11 07:40:14 -0700 [run-benchmark] Make Python 3 compatible 2021-10-12 12:37:41 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard dewei_zhu ews-watchlist fpizlo glenn slewis webkit-bug-importer ysuzuki oldest_to_newest 1802611 0 jbedard 2021-10-11 07:40:14 -0700 run-benchmark is almost Python 3 compatible, there are a few Popen calls that need to be decoded. 1802613 1 webkit-bug-importer 2021-10-11 07:41:05 -0700 <rdar://problem/84098736> 1802614 2 440792 jbedard 2021-10-11 07:42:06 -0700 Created attachment 440792 Patch 1802704 3 440792 dewei_zhu 2021-10-11 11:25:45 -0700 Comment on attachment 440792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440792&action=review r=me > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:107 > + ) If we decide to go with invoking decode('utf-8') on output, we may not need it here because I don't think use output from `_browser_process` anyway. > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:73 > + **(dict(encoding='utf-8') if sys.version_info >= (3, 0) else dict()) I think encoding only available since python3.6. A most compatible way would be `process.communicate()[0].decode('utf-8')`. 1802705 4 slewis 2021-10-11 11:28:29 -0700 (In reply to dewei_zhu from comment #3) > Comment on attachment 440792 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440792&action=review > > r=me > > > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:107 > > + ) > > If we decide to go with invoking decode('utf-8') on output, we may not need > it here because I don't think use output from `_browser_process` anyway. > > > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:73 > > + **(dict(encoding='utf-8') if sys.version_info >= (3, 0) else dict()) > > I think encoding only available since python3.6. > A most compatible way would be `process.communicate()[0].decode('utf-8')`. +1. We are using decode('utf-8') on pretty much all subprocess output throughout the perf. code 1802755 5 440826 jbedard 2021-10-11 12:57:32 -0700 Created attachment 440826 Patch for landing 1802794 6 ews-feeder 2021-10-11 14:12:15 -0700 Committed r283936 (242795@main): <https://commits.webkit.org/242795@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440826. 1803316 7 ysuzuki 2021-10-12 12:37:41 -0700 Committed r284004 (242847@main): <https://commits.webkit.org/242847@main> 440792 2021-10-11 07:42:06 -0700 2021-10-11 12:57:29 -0700 Patch bug-231512-20211011074205.patch text/plain 3584 jbedard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzODkyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTQ5NGNhOWQ4NTlkOGM5NDY1NTA5ODdjNTY2OTY5NzJl ZGFmOWNmYy4uM2ZmMTY4ZjJiYWFiMzY3NDFlNmI5YTlkMWQ0MjI2NWQ4ZDFkMTdkOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTEwLTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKwor ICAgICAgICBbcnVuLWJlbmNobWFya10gTWFrZSBQeXRob24gMyBjb21wYXRpYmxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE1MTIKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzg0MDk4NzM2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2Jy b3dzZXJfZHJpdmVyL2xpbnV4X2Jyb3dzZXJfZHJpdmVyLnB5OgorICAgICAgICAoTGludXhCcm93 c2VyRHJpdmVyLmxhdW5jaF91cmwpOiBFbmNvZGUgUG9wZW4gY2FsbCBpZiBQeXRob24gMy4KKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIv b3N4X3NhZmFyaV9kcml2ZXIucHk6CisgICAgICAgIChPU1hTYWZhcmlEcml2ZXIubGF1bmNoX3Vy bCk6IERpdHRvLgorCiAyMDIxLTEwLTEwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9A Z25vbWUub3JnPgogCiAgICAgICAgIFtXUEVdIEV4cG9zZSBXS1RleHRDaGVja2VyU2V0Q29udGlu dW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkIGFuZCB1c2UgaXQgZnJvbSBXS1RSCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIv bGludXhfYnJvd3Nlcl9kcml2ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFy a19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIvbGludXhfYnJvd3Nlcl9kcml2ZXIucHkKaW5kZXggODFl YTYwZmFmODU1N2YxNmQ1MjMyNjNkMTlkYjkxODExMWI3OThhZC4uOGJmNzJhYzk1NmM3ZjVmYjEz ZDExYWUzOTlhMzM1NjVlMzQ4NTdkNCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9iZW5jaG1hcmtfcnVubmVyL2Jyb3dzZXJfZHJpdmVyL2xpbnV4X2Jyb3dzZXJfZHJpdmVyLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2VyX2Ry aXZlci9saW51eF9icm93c2VyX2RyaXZlci5weQpAQCAtOTksOSArOTksMTIgQEAgY2xhc3MgTGlu dXhCcm93c2VyRHJpdmVyKEJyb3dzZXJEcml2ZXIpOgogICAgICAgICAgICAgc2VsZi5fYnJvd3Nl cl9hcmd1bWVudHMgPSBbdXJsXQogICAgICAgICBleGVjX2FyZ3MgPSBbc2VsZi5wcm9jZXNzX25h bWVdICsgc2VsZi5fYnJvd3Nlcl9hcmd1bWVudHMKICAgICAgICAgX2xvZy5pbmZvKCdFeGVjdXRp bmc6IHticm93c2VyX2NtZGxpbmV9Jy5mb3JtYXQoYnJvd3Nlcl9jbWRsaW5lPScgJy5qb2luKGV4 ZWNfYXJncykpKQotICAgICAgICBzZWxmLl9icm93c2VyX3Byb2Nlc3MgPSBzdWJwcm9jZXNzLlBv cGVuKGV4ZWNfYXJncywgZW52PXNlbGYuX3Rlc3RfZW52aXJvbiwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBFLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0ZGVycj1z dWJwcm9jZXNzLlNURE9VVCkKKyAgICAgICAgc2VsZi5fYnJvd3Nlcl9wcm9jZXNzID0gc3VicHJv Y2Vzcy5Qb3BlbigKKyAgICAgICAgICAgIGV4ZWNfYXJncywgZW52PXNlbGYuX3Rlc3RfZW52aXJv biwKKyAgICAgICAgICAgIHN0ZG91dD1zdWJwcm9jZXNzLlBJUEUsCisgICAgICAgICAgICBzdGRl cnI9c3VicHJvY2Vzcy5TVERPVVQsCisgICAgICAgICAgICAqKihkaWN0KGVuY29kaW5nPSd1dGYt OCcpIGlmIHN5cy52ZXJzaW9uX2luZm8gPj0gKDMsIDApIGVsc2UgZGljdCgpKQorICAgICAgICAp CiAKICAgICBkZWYgbGF1bmNoX3dlYmRyaXZlcihzZWxmLCB1cmwsIGRyaXZlcik6CiAgICAgICAg IHRyeToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5l ci9icm93c2VyX2RyaXZlci9vc3hfc2FmYXJpX2RyaXZlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2VyX2RyaXZlci9vc3hfc2FmYXJpX2RyaXZlci5w eQppbmRleCAxNmY5ZGNmMjhiMWEyZDU3MDNmZGYxYWZjYTZmYmI1NGUzYjY1NjgzLi40MThhOWFm YmM5ZDcwYTkzNTE4ODExZTMzOTYyNGVkNTdlOWExMjNkIDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIvb3N4X3NhZmFyaV9k cml2ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2Jy b3dzZXJfZHJpdmVyL29zeF9zYWZhcmlfZHJpdmVyLnB5CkBAIC02Nyw3ICs2NywxMSBAQCBjbGFz cyBPU1hTYWZhcmlEcml2ZXIoT1NYQnJvd3NlckRyaXZlcik6CiAgICAgICAgICAgICBfbG9nLmlu Zm8oJ0NoZWNraW5nIGlmIGFueSBvcGVuIGZpbGUgaXMgZnJvbSAie30iLicuZm9ybWF0KGJyb3dz ZXJfYnVpbGRfcGF0aCkpCiAgICAgICAgICAgICAjIENhbm5vdCB1c2UgJ2NoZWNrX2NhbGwnIGhl cmUgYXMgJytEJyBvcHRpb24gd2lsbCBoYXZlIG5vbi16ZXJvIHJldHVybiBjb2RlIHdoZW4gbm90 IGFsbCBmaWxlcyB1bmRlcgogICAgICAgICAgICAgIyBzcGVjaWZpZWQgZm9sZGVyIGFyZSB1c2Vk LgotICAgICAgICAgICAgcHJvY2VzcyA9IHN1YnByb2Nlc3MuUG9wZW4oWycvdXNyL3NiaW4vbHNv ZicsICctYScsICctcCcsIHN0cihzZWxmLl9zYWZhcmlfcHJvY2Vzcy5waWQpLCAnK0QnLCBicm93 c2VyX2J1aWxkX2Fic29sdXRlX3BhdGhdLCBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBFKQorICAgICAg ICAgICAgcHJvY2VzcyA9IHN1YnByb2Nlc3MuUG9wZW4oCisgICAgICAgICAgICAgICAgWycvdXNy L3NiaW4vbHNvZicsICctYScsICctcCcsIHN0cihzZWxmLl9zYWZhcmlfcHJvY2Vzcy5waWQpLCAn K0QnLCBicm93c2VyX2J1aWxkX2Fic29sdXRlX3BhdGhdLAorICAgICAgICAgICAgICAgIHN0ZG91 dD1zdWJwcm9jZXNzLlBJUEUsCisgICAgICAgICAgICAgICAgKiooZGljdChlbmNvZGluZz0ndXRm LTgnKSBpZiBzeXMudmVyc2lvbl9pbmZvID49ICgzLCAwKSBlbHNlIGRpY3QoKSkKKyAgICAgICAg ICAgICkKICAgICAgICAgICAgIG91dHB1dCA9IHByb2Nlc3MuY29tbXVuaWNhdGUoKVswXQogICAg ICAgICAgICAgaWYgaGFzX3NhZmFyaV9hcHA6CiAgICAgICAgICAgICAgICAgYXNzZXJ0ICdTYWZh cmkuYXBwL0NvbnRlbnRzL01hY09TL1NhZmFyaScgaW4gb3V0cHV0LCAnU2FmYXJpLmFwcCBpcyBu b3QgbGF1bmNoZWQgZnJvbSAie30iJy5mb3JtYXQoYnJvd3Nlcl9idWlsZF9wYXRoKQo= 440826 2021-10-11 12:57:32 -0700 2021-10-11 14:12:17 -0700 Patch for landing bug-231512-20211011125731.patch text/plain 3527 jbedard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzOTE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmNjN2MwNGM4NzJiZTRiNzc3MzI1M2Q3MTcwNzk3M2U5 OGNiZjgzOS4uZDhkYWVlNWVkMGJiNGM4YWFjMDI1MDJmM2NlMzUzNWYzZWRjZmUzZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTEwLTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKwor ICAgICAgICBbcnVuLWJlbmNobWFya10gTWFrZSBQeXRob24gMyBjb21wYXRpYmxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE1MTIKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzg0MDk4NzM2PgorCisgICAgICAgIFJldmlld2VkIGJ5IERld2VpIFpo dS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2Vy X2RyaXZlci9saW51eF9icm93c2VyX2RyaXZlci5weToKKyAgICAgICAgKExpbnV4QnJvd3NlckRy aXZlci5sYXVuY2hfdXJsKTogRW5jb2RlIFBvcGVuIGNhbGwgaWYgUHl0aG9uIDMuCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2Jyb3dzZXJfZHJpdmVyL29zeF9z YWZhcmlfZHJpdmVyLnB5OgorICAgICAgICAoT1NYU2FmYXJpRHJpdmVyLmxhdW5jaF91cmwpOiBE aXR0by4KKwogMjAyMS0xMC0xMSAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4K IAogICAgICAgICBCcmluZyB1cCBhbiBpT1MgR1BVIFByb2Nlc3MgdGVzdGVyCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIv bGludXhfYnJvd3Nlcl9kcml2ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFy a19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIvbGludXhfYnJvd3Nlcl9kcml2ZXIucHkKaW5kZXggODFl YTYwZmFmODU1N2YxNmQ1MjMyNjNkMTlkYjkxODExMWI3OThhZC4uMTVjZTcwZmY0MzlkMjk4NzYw MjBmMTY1MGYxM2IzMDQzYzZkZDZiNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9iZW5jaG1hcmtfcnVubmVyL2Jyb3dzZXJfZHJpdmVyL2xpbnV4X2Jyb3dzZXJfZHJpdmVyLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2VyX2Ry aXZlci9saW51eF9icm93c2VyX2RyaXZlci5weQpAQCAtOTksOSArOTksMTIgQEAgY2xhc3MgTGlu dXhCcm93c2VyRHJpdmVyKEJyb3dzZXJEcml2ZXIpOgogICAgICAgICAgICAgc2VsZi5fYnJvd3Nl cl9hcmd1bWVudHMgPSBbdXJsXQogICAgICAgICBleGVjX2FyZ3MgPSBbc2VsZi5wcm9jZXNzX25h bWVdICsgc2VsZi5fYnJvd3Nlcl9hcmd1bWVudHMKICAgICAgICAgX2xvZy5pbmZvKCdFeGVjdXRp bmc6IHticm93c2VyX2NtZGxpbmV9Jy5mb3JtYXQoYnJvd3Nlcl9jbWRsaW5lPScgJy5qb2luKGV4 ZWNfYXJncykpKQotICAgICAgICBzZWxmLl9icm93c2VyX3Byb2Nlc3MgPSBzdWJwcm9jZXNzLlBv cGVuKGV4ZWNfYXJncywgZW52PXNlbGYuX3Rlc3RfZW52aXJvbiwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBFLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0ZGVycj1z dWJwcm9jZXNzLlNURE9VVCkKKyAgICAgICAgc2VsZi5fYnJvd3Nlcl9wcm9jZXNzID0gc3VicHJv Y2Vzcy5Qb3BlbigKKyAgICAgICAgICAgIGV4ZWNfYXJncywgZW52PXNlbGYuX3Rlc3RfZW52aXJv biwKKyAgICAgICAgICAgIHN0ZG91dD1zdWJwcm9jZXNzLlBJUEUsCisgICAgICAgICAgICBzdGRl cnI9c3VicHJvY2Vzcy5TVERPVVQsCisgICAgICAgICAgICAqKihkaWN0KGVuY29kaW5nPSd1dGYt OCcpIGlmIHN5cy52ZXJzaW9uX2luZm8gPj0gKDMsIDYpIGVsc2UgZGljdCgpKQorICAgICAgICAp CiAKICAgICBkZWYgbGF1bmNoX3dlYmRyaXZlcihzZWxmLCB1cmwsIGRyaXZlcik6CiAgICAgICAg IHRyeToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5l ci9icm93c2VyX2RyaXZlci9vc3hfc2FmYXJpX2RyaXZlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2VyX2RyaXZlci9vc3hfc2FmYXJpX2RyaXZlci5w eQppbmRleCAxNmY5ZGNmMjhiMWEyZDU3MDNmZGYxYWZjYTZmYmI1NGUzYjY1NjgzLi5hYWIwN2Jh NGFkMzg2YmY4NzUzMzU0MTAyNWMxMTI2ZjdlYTJmZGM2IDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvYnJvd3Nlcl9kcml2ZXIvb3N4X3NhZmFyaV9k cml2ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2Jy b3dzZXJfZHJpdmVyL29zeF9zYWZhcmlfZHJpdmVyLnB5CkBAIC02Nyw3ICs2NywxMSBAQCBjbGFz cyBPU1hTYWZhcmlEcml2ZXIoT1NYQnJvd3NlckRyaXZlcik6CiAgICAgICAgICAgICBfbG9nLmlu Zm8oJ0NoZWNraW5nIGlmIGFueSBvcGVuIGZpbGUgaXMgZnJvbSAie30iLicuZm9ybWF0KGJyb3dz ZXJfYnVpbGRfcGF0aCkpCiAgICAgICAgICAgICAjIENhbm5vdCB1c2UgJ2NoZWNrX2NhbGwnIGhl cmUgYXMgJytEJyBvcHRpb24gd2lsbCBoYXZlIG5vbi16ZXJvIHJldHVybiBjb2RlIHdoZW4gbm90 IGFsbCBmaWxlcyB1bmRlcgogICAgICAgICAgICAgIyBzcGVjaWZpZWQgZm9sZGVyIGFyZSB1c2Vk LgotICAgICAgICAgICAgcHJvY2VzcyA9IHN1YnByb2Nlc3MuUG9wZW4oWycvdXNyL3NiaW4vbHNv ZicsICctYScsICctcCcsIHN0cihzZWxmLl9zYWZhcmlfcHJvY2Vzcy5waWQpLCAnK0QnLCBicm93 c2VyX2J1aWxkX2Fic29sdXRlX3BhdGhdLCBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBFKQorICAgICAg ICAgICAgcHJvY2VzcyA9IHN1YnByb2Nlc3MuUG9wZW4oCisgICAgICAgICAgICAgICAgWycvdXNy L3NiaW4vbHNvZicsICctYScsICctcCcsIHN0cihzZWxmLl9zYWZhcmlfcHJvY2Vzcy5waWQpLCAn K0QnLCBicm93c2VyX2J1aWxkX2Fic29sdXRlX3BhdGhdLAorICAgICAgICAgICAgICAgIHN0ZG91 dD1zdWJwcm9jZXNzLlBJUEUsCisgICAgICAgICAgICAgICAgKiooZGljdChlbmNvZGluZz0ndXRm LTgnKSBpZiBzeXMudmVyc2lvbl9pbmZvID49ICgzLCA2KSBlbHNlIGRpY3QoKSkKKyAgICAgICAg ICAgICkKICAgICAgICAgICAgIG91dHB1dCA9IHByb2Nlc3MuY29tbXVuaWNhdGUoKVswXQogICAg ICAgICAgICAgaWYgaGFzX3NhZmFyaV9hcHA6CiAgICAgICAgICAgICAgICAgYXNzZXJ0ICdTYWZh cmkuYXBwL0NvbnRlbnRzL01hY09TL1NhZmFyaScgaW4gb3V0cHV0LCAnU2FmYXJpLmFwcCBpcyBu b3QgbGF1bmNoZWQgZnJvbSAie30iJy5mb3JtYXQoYnJvd3Nlcl9idWlsZF9wYXRoKQo=