231505 2021-10-11 02:29:05 -0700 Error the encoder in case we cannot create a RemoteVideoSample 2021-11-12 16:13:54 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf arungane avasilko csantos daginge darius.chris.k engel.css eric.amram eric.carlson kuznetsov.trueconf makarand ppramod rychouwei shpuluga simmkyu tomasz.malik webkit-bug-importer youennf oldest_to_newest 1802556 0 youennf 2021-10-11 02:29:05 -0700 Error the encoder in case we cannot create a RemoteVideoSample 1802557 1 youennf 2021-10-11 02:29:16 -0700 <rdar://83975229> 1802559 2 440767 youennf 2021-10-11 02:33:05 -0700 Created attachment 440767 Patch 1802636 3 440767 eric.carlson 2021-10-11 08:57:27 -0700 Comment on attachment 440767 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440767&action=review > Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:451 > + if (!sample) > + return WEBRTC_VIDEO_CODEC_ERROR; It might be worth logging this error too. 1803028 4 440908 youennf 2021-10-12 01:35:18 -0700 Created attachment 440908 Patch for landing 1803046 5 ews-feeder 2021-10-12 02:45:24 -0700 Committed r283975 (242821@main): <https://commits.webkit.org/242821@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440908. 1807757 6 ap 2021-10-22 10:42:08 -0700 *** Bug 232006 has been marked as a duplicate of this bug. *** 1809567 7 gsnedders 2021-10-27 22:06:28 -0700 *** Bug 232381 has been marked as a duplicate of this bug. *** 1809569 8 gsnedders 2021-10-27 22:06:49 -0700 *** Bug 232416 has been marked as a duplicate of this bug. *** 1810040 9 youennf 2021-10-29 05:40:39 -0700 *** Bug 232445 has been marked as a duplicate of this bug. *** 1810215 10 gsnedders 2021-10-29 13:31:33 -0700 *** Bug 232490 has been marked as a duplicate of this bug. *** 1810349 11 arungane 2021-10-29 17:49:28 -0700 HI team whats the update about this issues . What release will it be merged ? 1810362 12 eric.amram 2021-10-29 18:48:33 -0700 OMG. How do you do QA at Apple? In times of Covid, you've just ruined WebRTC H264 on Safari? And it went all the way to iOS 15.1 "stable"? Now we have to tell ALL our clients NOT to use Apple products! Well done. 1810491 13 ppramod 2021-10-31 01:22:34 -0700 It would help to get an update on the plan to address this issue? 1811049 14 daginge 2021-11-02 00:02:34 -0700 There was an update here: https://bugs.webkit.org/show_bug.cgi?id=232006#c9 I can confirm this is fixed in iOS 15.2 Public Beta. 1812525 15 rychouwei 2021-11-07 19:00:32 -0800 two workaround: 1. Add this description to offer&answer sdp: "urn:3gpp:video-orientation", it will not cause page crash. 2. Use canvas.captureStream to capture a new video track from getUserMedia. Then, publish canvas track will not cause page crash. 1813936 16 shpuluga 2021-11-11 00:04:14 -0800 Hi Webkit team, Tried second workaround, used canvas captureStream from getUserMedia and publish canvas track but still crashes. Can you please provide a working sample or any other way to fix the issue. 1813941 17 rychouwei 2021-11-11 00:22:00 -0800 I'm not form webkit team. The second workround works for our product. You can try this sample to make a call on iOS 15.1: https://sdk-web-1252463788.cos.ap-hongkong.myqcloud.com/trtc/webrtc/test/rychou-test/addTransceiver/subscribe/index.html This sample use canvas.captureStream and H.264 codec. BTW, there is anothor workaround: use VP8 codec, do not use H.264 1814673 18 ap 2021-11-12 16:13:54 -0800 *** Bug 233038 has been marked as a duplicate of this bug. *** 440767 2021-10-11 02:33:05 -0700 2021-10-12 01:34:48 -0700 Patch bug-231505-20211011113303.patch text/plain 1982 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMwOTQ0OTA1MTg4ZDlmODg3 YTVlNTdmMzNjZTEyMjgyNDYxN2VjZTMuLjQ4YTEzZjUzOTk0M2VjMGJmMzk2NjE5YTRmYzAzMzM4 MzU5MDFiOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTAtMTEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEVycm9yIHRoZSBlbmNvZGVyIGlu IGNhc2Ugd2UgY2Fubm90IGNyZWF0ZSBhIFJlbW90ZVZpZGVvU2FtcGxlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE1MDUKKyAgICAgICAgPHJkYXI6 Ly84Mzk3NTIyOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFdlYlByb2Nlc3MvR1BVL3dlYnJ0Yy9MaWJXZWJSVENDb2RlY3MuY3BwOgorICAgICAg ICAoV2ViS2l0OjpMaWJXZWJSVENDb2RlY3M6OmVuY29kZUZyYW1lKToKKyAgICAgICAgUmVtb3Rl VmlkZW9TYW1wbGU6OmNyZWF0ZSBjYW4gcmV0dXJuIG51bGxwdHIgaWYgd2UgY2Fubm90IGdldCBh biBJT1N1cmZhY2UgZnJvbSB0aGUgcGl4ZWwgYnVmZmVyIG9yIGlmIHBpeGVsIGJ1ZmZlciBpcyBu dWxsCisgICAgICAgIGR1ZSB0byBWVFBpeGVsQnVmZmVyQ29uZm9ybWVyQ29weUNvbmZvcm1lZFBp eGVsQnVmZmVyIGZhaWxpbmcuCisgICAgICAgIEluIHRoYXQgY2FzZSwgd2UgZXJyb3IgdGhlIGVu Y29kZXIgaW5zdGVhZCBvZiB0cnlpbmcgdG8gZW5jb2RlIHRoZSBmcmFtZS4KKwogMjAyMS0xMC0x MCAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9y dCBmb3IgaXRlcmF0aW5nIEZpbGVTeXN0ZW1EaXJlY3RvcnlIYW5kbGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvd2VicnRjL0xpYldlYlJUQ0NvZGVjcy5jcHAgYi9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL3dlYnJ0Yy9MaWJXZWJSVENDb2RlY3MuY3BwCmlu ZGV4IDc4Y2I2YTk5ZjgzMmNiNmQ3NWEwYTRhYWJjMDA2ZDNmMGJjODlmYTkuLjU1NmU2MmMxMTY2 ZmUxN2FlN2FiYjMyZmMwMzZjZGVlZmE2ZTc1OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9HUFUvd2VicnRjL0xpYldlYlJUQ0NvZGVjcy5jcHAKKysrIGIvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvTGliV2ViUlRDQ29kZWNzLmNwcApAQCAtNDQ3LDYg KzQ0Nyw4IEBAIGludDMyX3QgTGliV2ViUlRDQ29kZWNzOjplbmNvZGVGcmFtZShFbmNvZGVyJiBl bmNvZGVyLCBjb25zdCB3ZWJydGM6OlZpZGVvRnJhbWUmCiAgICAgaWYgKCFzYW1wbGUpIHsKICAg ICAgICAgLy8gRklYTUU6IE9wdGltaXplIHRoaXMgY29kZSBwYXRoLCBjdXJyZW50bHkgd2UgaGF2 ZSBub24gQkdSQSBmb3IgbXV0ZWQgZnJhbWVzIGF0IGxlYXN0LgogICAgICAgICBzYW1wbGUgPSBS ZW1vdGVWaWRlb1NhbXBsZTo6Y3JlYXRlKGNvbnZlcnRUb0JHUkEocGl4ZWxCdWZmZXIuZ2V0KCkp LCBNZWRpYVRpbWUoZnJhbWUudGltZXN0YW1wX3VzKCkgKiAxMDAwLCAxMDAwMDAwKSwgdG9NZWRp YVNhbXBsZVZpZGVvUm90YXRpb24oZnJhbWUucm90YXRpb24oKSkpOworICAgICAgICBpZiAoIXNh bXBsZSkKKyAgICAgICAgICAgIHJldHVybiBXRUJSVENfVklERU9fQ09ERUNfRVJST1I7CiAgICAg fQogCiAgICAgZW5jb2Rlci5jb25uZWN0aW9uLT5zZW5kKE1lc3NhZ2VzOjpMaWJXZWJSVENDb2Rl Y3NQcm94eTo6RW5jb2RlRnJhbWUgeyBlbmNvZGVyLmlkZW50aWZpZXIsICpzYW1wbGUsIGZyYW1l LnRpbWVzdGFtcCgpLCBzaG91bGRFbmNvZGVBc0tleUZyYW1lIH0sIDApOwo= 440908 2021-10-12 01:35:18 -0700 2021-10-12 02:45:25 -0700 Patch for landing bug-231505-20211012103502.patch text/plain 2326 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMwOTQ0OTA1MTg4ZDlmODg3 YTVlNTdmMzNjZTEyMjgyNDYxN2VjZTMuLmVlMTk0ZGMyYjU5OWZhZDYzMzRjOWQ1M2U3NWVjZjk0 YzgwOWQ0ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTAtMTEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEVycm9yIHRoZSBlbmNvZGVyIGlu IGNhc2Ugd2UgY2Fubm90IGNyZWF0ZSBhIFJlbW90ZVZpZGVvU2FtcGxlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzE1MDUKKyAgICAgICAgPHJkYXI6 Ly84Mzk3NTIyOT4KKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL0dQVS93ZWJydGMvTGliV2ViUlRDQ29kZWNzLmNwcDoKKyAgICAgICAg KFdlYktpdDo6TGliV2ViUlRDQ29kZWNzOjplbmNvZGVGcmFtZSk6CisgICAgICAgIFJlbW90ZVZp ZGVvU2FtcGxlOjpjcmVhdGUgY2FuIHJldHVybiBudWxscHRyIGlmIHdlIGNhbm5vdCBnZXQgYW4g SU9TdXJmYWNlIGZyb20gdGhlIHBpeGVsIGJ1ZmZlciBvciBpZiBwaXhlbCBidWZmZXIgaXMgbnVs bAorICAgICAgICBkdWUgdG8gVlRQaXhlbEJ1ZmZlckNvbmZvcm1lckNvcHlDb25mb3JtZWRQaXhl bEJ1ZmZlciBmYWlsaW5nLgorICAgICAgICBJbiB0aGF0IGNhc2UsIHdlIGVycm9yIHRoZSBlbmNv ZGVyIGluc3RlYWQgb2YgdHJ5aW5nIHRvIGVuY29kZSB0aGUgZnJhbWUuCisKIDIwMjEtMTAtMTAg IFNpaHVpIExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQg Zm9yIGl0ZXJhdGluZyBGaWxlU3lzdGVtRGlyZWN0b3J5SGFuZGxlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL3dlYnJ0Yy9MaWJXZWJSVENDb2RlY3MuY3BwIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvTGliV2ViUlRDQ29kZWNzLmNwcAppbmRl eCA3OGNiNmE5OWY4MzJjYjZkNzVhMGE0YWFiYzAwNmQzZjBiYzg5ZmE5Li44Yzc1NmYwZDhjYjY2 NWZlYWI4ZTAxZDlkOTkwMWI1MmMzOWNlZjdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvR1BVL3dlYnJ0Yy9MaWJXZWJSVENDb2RlY3MuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9HUFUvd2VicnRjL0xpYldlYlJUQ0NvZGVjcy5jcHAKQEAgLTMxLDYgKzMx LDcgQEAKICNpbmNsdWRlICJHUFVQcm9jZXNzQ29ubmVjdGlvbi5oIgogI2luY2x1ZGUgIkxpYldl YlJUQ0NvZGVjc01lc3NhZ2VzLmgiCiAjaW5jbHVkZSAiTGliV2ViUlRDQ29kZWNzUHJveHlNZXNz YWdlcy5oIgorI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRlICJXZWJDb3JlQXJndW1lbnRD b2RlcnMuaCIKICNpbmNsdWRlICJXZWJQcm9jZXNzLmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9DVlV0 aWxpdGllcy5oPgpAQCAtNDQ3LDYgKzQ0OCwxMCBAQCBpbnQzMl90IExpYldlYlJUQ0NvZGVjczo6 ZW5jb2RlRnJhbWUoRW5jb2RlciYgZW5jb2RlciwgY29uc3Qgd2VicnRjOjpWaWRlb0ZyYW1lJgog ICAgIGlmICghc2FtcGxlKSB7CiAgICAgICAgIC8vIEZJWE1FOiBPcHRpbWl6ZSB0aGlzIGNvZGUg cGF0aCwgY3VycmVudGx5IHdlIGhhdmUgbm9uIEJHUkEgZm9yIG11dGVkIGZyYW1lcyBhdCBsZWFz dC4KICAgICAgICAgc2FtcGxlID0gUmVtb3RlVmlkZW9TYW1wbGU6OmNyZWF0ZShjb252ZXJ0VG9C R1JBKHBpeGVsQnVmZmVyLmdldCgpKSwgTWVkaWFUaW1lKGZyYW1lLnRpbWVzdGFtcF91cygpICog MTAwMCwgMTAwMDAwMCksIHRvTWVkaWFTYW1wbGVWaWRlb1JvdGF0aW9uKGZyYW1lLnJvdGF0aW9u KCkpKTsKKyAgICAgICAgaWYgKCFzYW1wbGUpIHsKKyAgICAgICAgICAgIFJFTEVBU0VfTE9HX0VS Uk9SKFdlYlJUQywgIlVuYWJsZSB0byBjb252ZXJ0IHJlbW90ZSB2aWRlbyBzYW1wbGUiKTsKKyAg ICAgICAgICAgIHJldHVybiBXRUJSVENfVklERU9fQ09ERUNfRVJST1I7CisgICAgICAgIH0KICAg ICB9CiAKICAgICBlbmNvZGVyLmNvbm5lY3Rpb24tPnNlbmQoTWVzc2FnZXM6OkxpYldlYlJUQ0Nv ZGVjc1Byb3h5OjpFbmNvZGVGcmFtZSB7IGVuY29kZXIuaWRlbnRpZmllciwgKnNhbXBsZSwgZnJh bWUudGltZXN0YW1wKCksIHNob3VsZEVuY29kZUFzS2V5RnJhbWUgfSwgMCk7Cg==