231500 2021-10-11 01:22:15 -0700 Beef up worker termination handling in ReadableStream routines 2021-10-26 02:46:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf darin mark.lam webkit-bug-importer oldest_to_newest 1802537 0 youennf 2021-10-11 01:22:15 -0700 Beef up worker termination handling in ReadableStream routines 1802538 1 youennf 2021-10-11 01:23:13 -0700 <rdar://83687915> 1802539 2 youennf 2021-10-11 01:24:05 -0700 I am not quite sure whether we need to check for termination after wrapping of an existing C++ object into a JS object. @Mark, any suggestion here? 1802540 3 440763 youennf 2021-10-11 01:26:31 -0700 Created attachment 440763 Patch 1808605 4 440763 darin 2021-10-25 14:50:01 -0700 Comment on attachment 440763 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440763&action=review > Source/WebCore/ChangeLog:10 > + Covered by existing tests. How can that be true? Why do we need to "beef up" if nothing is changing? 1808800 5 440763 youennf 2021-10-26 02:11:37 -0700 Comment on attachment 440763 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440763&action=review >> Source/WebCore/ChangeLog:10 >> + Covered by existing tests. > > How can that be true? Why do we need to "beef up" if nothing is changing? We are adding more checks so code is changing. I think it is covered by existing tests that are currently crashing on debug asserts, like https://bugs.webkit.org/show_bug.cgi?id=230984. 1808807 6 ews-feeder 2021-10-26 02:46:36 -0700 Committed r284861 (243538@main): <https://commits.webkit.org/243538@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440763. 440763 2021-10-11 01:26:31 -0700 2021-10-26 02:46:37 -0700 Patch bug-231500-20211011102629.patch text/plain 4259 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJhMDA2NDYzZjNkOGRk NzAxZTg2ODJlNGIzZmJiZjY5NGVkNWVkMC4uMzk3OGFlZTkyMjk2Mzk3Njk0MmU4ZjRmY2Y1NzJm YzliZDIyNTc0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTEwLTExICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBCZWVmIHVwIHdvcmtlciB0 ZXJtaW5hdGlvbiBoYW5kbGluZyBpbiBSZWFkYWJsZVN0cmVhbSByb3V0aW5lcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxNTAwCisgICAgICAgIDxy ZGFyOi8vODM2ODc5MTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIHNvbWUgdGVybWluYXRpb24vZXhjZXB0aW9uIGNoZWNrcyBhZnRlciBnZXR0 aW5nIHZhbHVlcyBmcm9tIGdsb2JhbCBvYmplY3RzLgorICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0 aW5nIHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3MvanMvUmVhZGFibGVTdHJlYW0uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVhZGFibGVTdHJlYW06OmNyZWF0ZSk6CisgICAgICAgIChXZWJD b3JlOjpSZWFkYWJsZVN0cmVhbTo6bG9jayk6CisgICAgICAgICogYmluZGluZ3MvanMvUmVhZGFi bGVTdHJlYW1EZWZhdWx0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjppbnZva2VS ZWFkYWJsZVN0cmVhbURlZmF1bHRDb250cm9sbGVyRnVuY3Rpb24pOgorICAgICAgICAoV2ViQ29y ZTo6UmVhZGFibGVTdHJlYW1EZWZhdWx0Q29udHJvbGxlcjo6ZW5xdWV1ZSk6CisKIDIwMjEtMTAt MTAgIFNpaHVpIExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBv cnQgZm9yIGl0ZXJhdGluZyBGaWxlU3lzdGVtRGlyZWN0b3J5SGFuZGxlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9SZWFkYWJsZVN0cmVhbS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9SZWFkYWJsZVN0cmVhbS5jcHAKaW5kZXggOTEzYTZmMTVjMTY1NDVk YTQyODMwZGZjMzVjZTg5NWQxMDhjMTllOC4uZWVlNTFlNjUzZDg3YzBmZGJmMWEzZmQxMzQwOTUx OWNjZjJiMjBhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvUmVhZGFi bGVTdHJlYW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1JlYWRhYmxlU3Ry ZWFtLmNwcApAQCAtNDYsNiArNDYsNyBAQCBFeGNlcHRpb25PcjxSZWY8UmVhZGFibGVTdHJlYW0+ PiBSZWFkYWJsZVN0cmVhbTo6Y3JlYXRlKEpTQzo6SlNHbG9iYWxPYmplY3QmIGxleAogICAgIGF1 dG8mIGdsb2JhbE9iamVjdCA9ICpKU0M6OmpzQ2FzdDxKU0RPTUdsb2JhbE9iamVjdCo+KCZsZXhp Y2FsR2xvYmFsT2JqZWN0KTsKIAogICAgIGF1dG8qIGNvbnN0cnVjdG9yID0gSlNDOjphc09iamVj dChnbG9iYWxPYmplY3QuZ2V0KCZsZXhpY2FsR2xvYmFsT2JqZWN0LCBjbGllbnREYXRhLmJ1aWx0 aW5OYW1lcygpLlJlYWRhYmxlU3RyZWFtUHJpdmF0ZU5hbWUoKSkpOworICAgIFJFVFVSTl9JRl9F WENFUFRJT04oc2NvcGUsIEV4Y2VwdGlvbiB7IEV4aXN0aW5nRXhjZXB0aW9uRXJyb3IgfSk7CiAK ICAgICBhdXRvIGNvbnN0cnVjdERhdGEgPSBnZXRDb25zdHJ1Y3REYXRhKHZtLCBjb25zdHJ1Y3Rv cik7CiAgICAgQVNTRVJUKGNvbnN0cnVjdERhdGEudHlwZSAhPSBDYWxsRGF0YTo6VHlwZTo6Tm9u ZSk7CkBAIC0xMTUsMTMgKzExNiwxNCBAQCB2b2lkIFJlYWRhYmxlU3RyZWFtOjpsb2NrKCkKIHsK ICAgICBhdXRvJiBsZXhpY2FsR2xvYmFsT2JqZWN0ID0gKm1fZ2xvYmFsT2JqZWN0OwogICAgIGF1 dG8mIHZtID0gbGV4aWNhbEdsb2JhbE9iamVjdC52bSgpOwotI2lmIEVOQUJMRShFWENFUFRJT05f U0NPUEVfVkVSSUZJQ0FUSU9OKQogICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX0NBVENIX1NDT1BF KHZtKTsKLSNlbmRpZgogCiAgICAgYXV0byYgY2xpZW50RGF0YSA9ICpzdGF0aWNfY2FzdDxKU1ZN Q2xpZW50RGF0YSo+KHZtLmNsaWVudERhdGEpOwogCiAgICAgYXV0byogY29uc3RydWN0b3IgPSBK U0M6OmFzT2JqZWN0KG1fZ2xvYmFsT2JqZWN0LT5nZXQoJmxleGljYWxHbG9iYWxPYmplY3QsIGNs aWVudERhdGEuYnVpbHRpbk5hbWVzKCkuUmVhZGFibGVTdHJlYW1EZWZhdWx0UmVhZGVyUHJpdmF0 ZU5hbWUoKSkpOworICAgIEVYQ0VQVElPTl9BU1NFUlQoIXNjb3BlLmV4Y2VwdGlvbigpIHx8IHZt Lmhhc1BlbmRpbmdUZXJtaW5hdGlvbkV4Y2VwdGlvbigpKTsKKyAgICBpZiAoc2NvcGUuZXhjZXB0 aW9uKCkpCisgICAgICAgIHJldHVybjsKIAogICAgIGF1dG8gY29uc3RydWN0RGF0YSA9IGdldENv bnN0cnVjdERhdGEodm0sIGNvbnN0cnVjdG9yKTsKICAgICBBU1NFUlQoY29uc3RydWN0RGF0YS50 eXBlICE9IENhbGxEYXRhOjpUeXBlOjpOb25lKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL1JlYWRhYmxlU3RyZWFtRGVmYXVsdENvbnRyb2xsZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvUmVhZGFibGVTdHJlYW1EZWZhdWx0Q29udHJvbGxlci5jcHAK aW5kZXggZDE1ODNhMzI0NDVkYzdiMTBhYjNiMzdkZmI0OTRiODFmNWJiYThmOS4uMzYwM2U3OTRk NDA1MGFiOGM3OWVlZDA3M2RmZDMzZmNmMDNmYjY0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvUmVhZGFibGVTdHJlYW1EZWZhdWx0Q29udHJvbGxlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvUmVhZGFibGVTdHJlYW1EZWZhdWx0Q29udHJvbGxl ci5jcHAKQEAgLTQ0LDEwICs0NCwxNCBAQCBzdGF0aWMgYm9vbCBpbnZva2VSZWFkYWJsZVN0cmVh bURlZmF1bHRDb250cm9sbGVyRnVuY3Rpb24oSlNDOjpKU0dsb2JhbE9iamVjdCYgbAogICAgIEpT Qzo6Vk0mIHZtID0gbGV4aWNhbEdsb2JhbE9iamVjdC52bSgpOwogICAgIEpTQzo6SlNMb2NrSG9s ZGVyIGxvY2sodm0pOwogCisgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfQ0FUQ0hfU0NPUEUodm0p OwogICAgIGF1dG8gZnVuY3Rpb24gPSBsZXhpY2FsR2xvYmFsT2JqZWN0LmdldCgmbGV4aWNhbEds b2JhbE9iamVjdCwgaWRlbnRpZmllcik7CisKKyAgICBFWENFUFRJT05fQVNTRVJUKCFzY29wZS5l eGNlcHRpb24oKSB8fCB2bS5oYXNQZW5kaW5nVGVybWluYXRpb25FeGNlcHRpb24oKSk7CisgICAg UkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZmFsc2UpOworCiAgICAgQVNTRVJUKGZ1bmN0aW9u LmlzQ2FsbGFibGUobGV4aWNhbEdsb2JhbE9iamVjdC52bSgpKSk7CiAKLSAgICBhdXRvIHNjb3Bl ID0gREVDTEFSRV9DQVRDSF9TQ09QRSh2bSk7CiAgICAgYXV0byBjYWxsRGF0YSA9IEpTQzo6Z2V0 Q2FsbERhdGEodm0sIGZ1bmN0aW9uKTsKICAgICBjYWxsKCZsZXhpY2FsR2xvYmFsT2JqZWN0LCBm dW5jdGlvbiwgY2FsbERhdGEsIEpTQzo6anNVbmRlZmluZWQoKSwgYXJndW1lbnRzKTsKICAgICBF WENFUFRJT05fQVNTRVJUKCFzY29wZS5leGNlcHRpb24oKSB8fCB2bS5oYXNQZW5kaW5nVGVybWlu YXRpb25FeGNlcHRpb24oKSk7CkBAIC0xMjAsMTAgKzEyNCw4IEBAIGJvb2wgUmVhZGFibGVTdHJl YW1EZWZhdWx0Q29udHJvbGxlcjo6ZW5xdWV1ZShSZWZQdHI8SlNDOjpBcnJheUJ1ZmZlcj4mJiBi dWZmZXIpCiAgICAgYXV0byBjaHVuayA9IEpTQzo6VWludDhBcnJheTo6Y3JlYXRlKFdURk1vdmUo YnVmZmVyKSwgMCwgbGVuZ3RoKTsKICAgICBhdXRvIHZhbHVlID0gdG9KUygmbGV4aWNhbEdsb2Jh bE9iamVjdCwgJmxleGljYWxHbG9iYWxPYmplY3QsIGNodW5rLmdldCgpKTsKIAotICAgIGlmIChV TkxJS0VMWShzY29wZS5leGNlcHRpb24oKSkpIHsKLSAgICAgICAgQVNTRVJUKHZtLmhhc1BlbmRp bmdUZXJtaW5hdGlvbkV4Y2VwdGlvbigpKTsKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0K KyAgICBFWENFUFRJT05fQVNTRVJUKCFzY29wZS5leGNlcHRpb24oKSB8fCB2bS5oYXNQZW5kaW5n VGVybWluYXRpb25FeGNlcHRpb24oKSk7CisgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwg ZmFsc2UpOwogCiAgICAgcmV0dXJuIGVucXVldWUodmFsdWUpOwogfQo=