231478 2021-10-09 09:03:16 -0700 AX: AccessibilityMenuListPopup shouldn't add ignored children 2021-10-12 07:09:07 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 tyler_w webkit-unassigned aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1802388 0 tyler_w 2021-10-09 09:03:16 -0700 An invariant of our accessibility tree is that it doesn't include things that are ignored. Most paths end up at AccessibilityObject::insertChild, which prevents ignored children from being inserted. However, AccessibilityMenuListPopup::addChildren directly calls m_children.append, so it should ensure the things it adds aren't ignored first. 1802389 1 webkit-bug-importer 2021-10-09 09:03:30 -0700 <rdar://problem/84062657> 1802390 2 440711 tyler_w 2021-10-09 09:09:02 -0700 Created attachment 440711 Patch 1802391 3 440711 cfleizach 2021-10-09 09:24:00 -0700 Comment on attachment 440711 Patch Is it possible to add an example of an ignored menu list item in a layout test? 1802399 4 tyler_w 2021-10-09 11:51:44 -0700 (In reply to chris fleizach from comment #3) > Comment on attachment 440711 [details] > Patch > > Is it possible to add an example of an ignored menu list item in a layout > test? We can't test this because AccessibilityMenuListPopup is ignored on Mac and iOS, so its addChildren method never gets called, and thus we can't exercise the changed code. This patch would make this class do the right thing should it become un-ignored. 1802406 5 cfleizach 2021-10-09 13:14:16 -0700 Which platforms will this have an effect on? 1803093 6 andresg_22 2021-10-12 07:09:07 -0700 (In reply to Tyler Wilcock from comment #4) > (In reply to chris fleizach from comment #3) > > Comment on attachment 440711 [details] > > Patch > > > > Is it possible to add an example of an ignored menu list item in a layout > > test? > > We can't test this because AccessibilityMenuListPopup is ignored on Mac and > iOS, so its addChildren method never gets called, and thus we can't exercise > the changed code. This patch would make this class do the right thing should > it become un-ignored. How can AccessibilityMenuListPopup become un-ignored? 440711 2021-10-09 09:09:02 -0700 2021-10-09 09:09:02 -0700 Patch bug-231478-20211009110901.patch text/plain 2318 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzODY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTc5NWE0MTUzNjlmYjMy NGEwOGI4ZWNmMWQ0YjAwZmQwZTcyYzk4Ni4uYTE5MWIzNTBlMzZiMzY5Y2UwYjRmYTQ5ODRmYTFi N2FjMzg3ZWIwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTEwLTA5ICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEFjY2Vzc2liaWxp dHlNZW51TGlzdFBvcHVwIHNob3VsZG4ndCBhZGQgaWdub3JlZCBjaGlsZHJlbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxNDc4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQW4gaW52YXJpYW50IG9mIG91 ciBhY2Nlc3NpYmlsaXR5IHRyZWUgaXMgdGhhdCBpdCBkb2Vzbid0IGluY2x1ZGUgdGhpbmdzCisg ICAgICAgIHRoYXQgYXJlIGlnbm9yZWQuIE1vc3QgcGF0aHMgZW5kIHVwIGF0IEFjY2Vzc2liaWxp dHlPYmplY3Q6Omluc2VydENoaWxkLAorICAgICAgICB3aGljaCBwcmV2ZW50cyBpZ25vcmVkIGNo aWxkcmVuIGZyb20gYmVpbmcgaW5zZXJ0ZWQuIEhvd2V2ZXIsIAorICAgICAgICBBY2Nlc3NpYmls aXR5TWVudUxpc3RQb3B1cDo6YWRkQ2hpbGRyZW4gZGlyZWN0bHkgY2FsbHMgbV9jaGlsZHJlbi5h cHBlbmQsCisgICAgICAgIHNvIGl0IHNob3VsZCBlbnN1cmUgdGhlIHRoaW5ncyBpdCBhZGRzIGFy ZW4ndCBpZ25vcmVkIGZpcnN0LgorCisgICAgICAgIE5vIHRlc3RzIGFkZGVkIGJlY2F1c2UgQWNj ZXNzaWJpbGl0eU1lbnVMaXN0UG9wdXAgaXMgaWdub3JlZCBieQorICAgICAgICBkZWZhdWx0IG9u IE1hYyBhbmQgaU9TLiBIb3dldmVyLCBzaG91bGQgaXQgYmVjb21lIHVuLWlnbm9yZWQsIGl0IHdp bGwKKyAgICAgICAgZG8gdGhlIHJpZ2h0IHRoaW5nIGluIG5vdCBhZGRpbmcgaWdub3JlZCBjaGls ZHJlbi4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9w dXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9wdXA6OmFk ZENoaWxkcmVuKToKKyAgICAgICAgRG9uJ3QgYWRkIGlnbm9yZWQgY2hpbGRyZW4uCisKIDIwMjEt MTAtMDggIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFtHUFUg UHJvY2Vzc10gc3VwcG9ydCByZW5kZXJpbmcgQXBwbGUgUGF5IGxvZ29zCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlNZW51TGlzdFBvcHVwLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9w dXAuY3BwCmluZGV4IDY1NzI5YWU5ZGIxNjEzNDk3N2VhYmRhYTFlNGE2YTFkZTQ5Zjc1MTAuLjZi ZmI4OWQ0NGY5MDhhYTI3YzFhMjkyM2RhMmY1YTM4OGUyZmIyNDkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9wdXAuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9w dXAuY3BwCkBAIC05Nyw5ICs5Nyw5IEBAIHZvaWQgQWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9wdXA6 OmFkZENoaWxkcmVuKCkKICAgICBtX2hhdmVDaGlsZHJlbiA9IHRydWU7CiAKICAgICBmb3IgKGNv bnN0IGF1dG8mIGxpc3RJdGVtIDogZG93bmNhc3Q8SFRNTFNlbGVjdEVsZW1lbnQ+KCpzZWxlY3RO b2RlKS5saXN0SXRlbXMoKSkgewotICAgICAgICAvLyBGSVhNRTogV2h5IGRvZXMgQWNjZXNzaWJp bGl0eUxpc3RCb3g6OmFkZENoaWxkcmVuIGNoZWNrIGFjY2Vzc2liaWxpdHlJc0lnbm9yZWQgYnV0 IHRoaXMgZG9lcyBub3Q/Ci0gICAgICAgIGlmIChhdXRvIG9wdGlvbiA9IG1lbnVMaXN0T3B0aW9u QWNjZXNzaWJpbGl0eU9iamVjdChsaXN0SXRlbSkpCi0gICAgICAgICAgICBtX2NoaWxkcmVuLmFw cGVuZChvcHRpb24pOworICAgICAgICBhdXRvKiBsaXN0T3B0aW9uID0gbWVudUxpc3RPcHRpb25B Y2Nlc3NpYmlsaXR5T2JqZWN0KGxpc3RJdGVtKTsKKyAgICAgICAgaWYgKGxpc3RPcHRpb24gJiYg IWxpc3RPcHRpb24tPmFjY2Vzc2liaWxpdHlJc0lnbm9yZWQoKSkKKyAgICAgICAgICAgIG1fY2hp bGRyZW4uYXBwZW5kKGxpc3RPcHRpb24pOwogICAgIH0KIH0KIAo=