231458 2021-10-08 15:19:20 -0700 Vectorize EqualPowerPanner::pan() 2021-11-29 13:38:47 -0800 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=233529 InRadar P2 Normal --- 1 cdumez cdumez cdumez crzwdjk eric.carlson ews-watchlist ggaren glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1802276 0 cdumez 2021-10-08 15:19:20 -0700 Vectorize EqualPowerPanner::pan() for performance. This is used by PannerNode. 1802277 1 440682 cdumez 2021-10-08 15:20:23 -0700 Created attachment 440682 Patch 1802333 2 ews-feeder 2021-10-08 17:41:34 -0700 Committed r283855 (242733@main): <https://commits.webkit.org/242733@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440682. 1802334 3 webkit-bug-importer 2021-10-08 17:42:18 -0700 <rdar://problem/84050699> 1816986 4 crzwdjk 2021-11-19 14:01:00 -0800 This caused a regression in the imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower.html test on GTK and WPE, with the following diff: --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-actual.txt @@ -14,7 +14,13 @@ PASS Mono: Left and right channels is identical to the array [expected array]. PASS < [mono source=listener] All assertions passed. (total 1 assertions) PASS > [stereo source=listener] Source and listener at the same position -PASS Stereo: Left and right channels is identical to the array [expected array]. -PASS < [stereo source=listener] All assertions passed. (total 1 assertions) -PASS # AUDIT TASK RUNNER FINISHED: 3 tasks ran successfully. +FAIL X Stereo: Left and right channels expected to be equal to the array [expected array] but differs in 8017 places: + Index Actual Expected + [129] -9.094678e-1 -9.937367e-1 + [130] -8.316806e-1 -9.996188e-1 + [131] -7.479767e-1 -9.983897e-1 + [132] -6.589519e-1 -9.900582e-1 + ...and 8013 more errors. assert_true: expected true got false +FAIL < [stereo source=listener] 1 out of 1 assertions were failed. assert_true: expected true got false +FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 3 tasks were failed. assert_true: expected true got false 1817001 5 cdumez 2021-11-19 14:32:17 -0800 (In reply to Arcady Goldmints-Orlov from comment #4) > This caused a regression in the > imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode- > interface/panner-equalpower.html test on GTK and WPE, with the following > diff: > > --- > /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/ > imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode- > interface/panner-equalpower-expected.txt > +++ > /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/ > imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode- > interface/panner-equalpower-actual.txt > @@ -14,7 +14,13 @@ > PASS Mono: Left and right channels is identical to the array [expected > array]. > PASS < [mono source=listener] All assertions passed. (total 1 assertions) > PASS > [stereo source=listener] Source and listener at the same position > -PASS Stereo: Left and right channels is identical to the array [expected > array]. > -PASS < [stereo source=listener] All assertions passed. (total 1 assertions) > -PASS # AUDIT TASK RUNNER FINISHED: 3 tasks ran successfully. > +FAIL X Stereo: Left and right channels expected to be equal to the array > [expected array] but differs in 8017 places: > + Index Actual Expected > + [129] -9.094678e-1 -9.937367e-1 > + [130] -8.316806e-1 -9.996188e-1 > + [131] -7.479767e-1 -9.983897e-1 > + [132] -6.589519e-1 -9.900582e-1 > + ...and 8013 more errors. assert_true: expected true got false > +FAIL < [stereo source=listener] 1 out of 1 assertions were failed. > assert_true: expected true got false > +FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 3 tasks were failed. > assert_true: expected true got false My bet is that the implementation of VectorMath::multiplyByScalarThenAddToVector() or VectorMath::multiplyByScalar() used by Glib ports is wrong somehow. The Apple ports are using a different implementation for these. 440682 2021-10-08 15:20:23 -0700 2021-10-08 17:41:35 -0700 Patch bug-231458-20211008152023.patch text/plain 3433 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzODQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzcxOGFjOGQxY2VjMDRm NWFjNmVmNTcxYTAwZTk1ZWJjNTA5MTM2NC4uZDk4ZmQ2YzEyNGE4N2RiNDA0ZDE2M2IxNzNkN2Nj NmEzZGZlM2NlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTEwLTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVmVjdG9yaXplIEVxdWFsUG93 ZXJQYW5uZXI6OnBhbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzE0NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBWZWN0b3JpemUgRXF1YWxQb3dlclBhbm5lcjo6cGFuKCkgZm9yIHBlcmZvcm1hbmNl LiBUaGlzIGlzIHVzZWQgYnkgUGFubmVyTm9kZS4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlv L0VxdWFsUG93ZXJQYW5uZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXF1YWxQb3dlclBhbm5l cjo6cGFuKToKKwogMjAyMS0xMC0wOCAgQWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogbV9jb2xsYXBzaWJsZUxvZ2ljYWxXaWR0aCA8PSBt X2xvZ2ljYWxXaWR0aCBpbiBXZWJDb3JlOjpMYXlvdXQ6OklubGluZUNvbnRlbnRCcmVha2VyOjpD b250aW51b3VzQ29udGVudDo6YXBwZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hdWRpby9FcXVhbFBvd2VyUGFubmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2F1ZGlvL0VxdWFsUG93ZXJQYW5uZXIuY3BwCmluZGV4IGY5ODVjNjQwZGJhMjczZDM2ZWZiODI1 YWU1OTM4ZjE3YWIxNWUwY2YuLjhjNTg2Y2NmYjU3YmI1YjJmMTFjNDczOWQwZGIxMWJmNmI4NGE3 YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0VxdWFsUG93ZXJQ YW5uZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0VxdWFsUG93ZXJQ YW5uZXIuY3BwCkBAIC0zMCw2ICszMCw3IEBACiAKICNpbmNsdWRlICJBdWRpb0J1cy5oIgogI2lu Y2x1ZGUgIkF1ZGlvVXRpbGl0aWVzLmgiCisjaW5jbHVkZSAiVmVjdG9yTWF0aC5oIgogI2luY2x1 ZGUgPGFsZ29yaXRobT4KICNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogCkBAIC0xMjYsMzMg KzEyNywxOCBAQCB2b2lkIEVxdWFsUG93ZXJQYW5uZXI6OnBhbihkb3VibGUgYXppbXV0aCwgZG91 YmxlIC8qZWxldmF0aW9uKi8sIGNvbnN0IEF1ZGlvQnVzKgogICAgICAgICB9CiAgICAgfQogCi0g ICAgZG91YmxlIGRlc2lyZWRHYWluTCA9IGNvcyhwaU92ZXJUd29Eb3VibGUgKiBkZXNpcmVkUGFu UG9zaXRpb24pOwotICAgIGRvdWJsZSBkZXNpcmVkR2FpblIgPSBzaW4ocGlPdmVyVHdvRG91Ymxl ICogZGVzaXJlZFBhblBvc2l0aW9uKTsKLSAgICAKLSAgICBpbnQgbiA9IGZyYW1lc1RvUHJvY2Vz czsKLQotICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgdmVjdG9yaXplIHRoaXMuCisgICAgZG91Ymxl IGRlc2lyZWRHYWluTCA9IHN0ZDo6Y29zKHBpT3ZlclR3b0RvdWJsZSAqIGRlc2lyZWRQYW5Qb3Np dGlvbik7CisgICAgZG91YmxlIGRlc2lyZWRHYWluUiA9IHN0ZDo6c2luKHBpT3ZlclR3b0RvdWJs ZSAqIGRlc2lyZWRQYW5Qb3NpdGlvbik7CiAgICAgaWYgKG51bWJlck9mSW5wdXRDaGFubmVscyA9 PSAxKSB7IC8vIEZvciBtb25vIHNvdXJjZSBjYXNlLgotICAgICAgICB3aGlsZSAobi0tKSB7Ci0g ICAgICAgICAgICBmbG9hdCBpbnB1dEwgPSAqc291cmNlTCsrOwotICAgICAgICAgICAgKmRlc3Rp bmF0aW9uTCsrID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+KGlucHV0TCAqIGRlc2lyZWRHYWluTCk7Ci0g ICAgICAgICAgICAqZGVzdGluYXRpb25SKysgPSBzdGF0aWNfY2FzdDxmbG9hdD4oaW5wdXRMICog ZGVzaXJlZEdhaW5SKTsKLSAgICAgICAgfQorICAgICAgICBWZWN0b3JNYXRoOjptdWx0aXBseUJ5 U2NhbGFyKHNvdXJjZUwsIGRlc2lyZWRHYWluTCwgZGVzdGluYXRpb25MLCBmcmFtZXNUb1Byb2Nl c3MpOworICAgICAgICBWZWN0b3JNYXRoOjptdWx0aXBseUJ5U2NhbGFyKHNvdXJjZUwsIGRlc2ly ZWRHYWluUiwgZGVzdGluYXRpb25SLCBmcmFtZXNUb1Byb2Nlc3MpOwogICAgIH0gZWxzZSB7IC8v IEZvciBzdGVyZW8gc291cmNlIGNhc2UuCiAgICAgICAgIGlmIChhemltdXRoIDw9IDApIHsgLy8g ZnJvbSAtOTAgLT4gMAotICAgICAgICAgICAgd2hpbGUgKG4tLSkgewotICAgICAgICAgICAgICAg IGZsb2F0IGlucHV0TCA9ICpzb3VyY2VMKys7Ci0gICAgICAgICAgICAgICAgZmxvYXQgaW5wdXRS ID0gKnNvdXJjZVIrKzsKLSAgICAgICAgICAgICAgICAqZGVzdGluYXRpb25MKysgPSBzdGF0aWNf Y2FzdDxmbG9hdD4oaW5wdXRMICsgaW5wdXRSICogZGVzaXJlZEdhaW5MKTsKLSAgICAgICAgICAg ICAgICAqZGVzdGluYXRpb25SKysgPSBzdGF0aWNfY2FzdDxmbG9hdD4oaW5wdXRSICogZGVzaXJl ZEdhaW5SKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIFZlY3Rvck1hdGg6Om11bHRpcGx5 QnlTY2FsYXJUaGVuQWRkVG9WZWN0b3Ioc291cmNlUiwgZGVzaXJlZEdhaW5MLCBzb3VyY2VMLCBk ZXN0aW5hdGlvbkwsIGZyYW1lc1RvUHJvY2Vzcyk7CisgICAgICAgICAgICBWZWN0b3JNYXRoOjpt dWx0aXBseUJ5U2NhbGFyKHNvdXJjZVIsIGRlc2lyZWRHYWluUiwgZGVzdGluYXRpb25SLCBmcmFt ZXNUb1Byb2Nlc3MpOwogICAgICAgICB9IGVsc2UgeyAvLyBmcm9tIDAgLT4gKzkwCi0gICAgICAg ICAgICB3aGlsZSAobi0tKSB7Ci0gICAgICAgICAgICAgICAgZmxvYXQgaW5wdXRMID0gKnNvdXJj ZUwrKzsKLSAgICAgICAgICAgICAgICBmbG9hdCBpbnB1dFIgPSAqc291cmNlUisrOwotICAgICAg ICAgICAgICAgICpkZXN0aW5hdGlvbkwrKyA9IHN0YXRpY19jYXN0PGZsb2F0PihpbnB1dEwgKiBk ZXNpcmVkR2FpbkwpOwotICAgICAgICAgICAgICAgICpkZXN0aW5hdGlvblIrKyA9IHN0YXRpY19j YXN0PGZsb2F0PihpbnB1dFIgKyBpbnB1dEwgKiBkZXNpcmVkR2FpblIpOwotICAgICAgICAgICAg fQorICAgICAgICAgICAgVmVjdG9yTWF0aDo6bXVsdGlwbHlCeVNjYWxhcihzb3VyY2VMLCBkZXNp cmVkR2FpbkwsIGRlc3RpbmF0aW9uTCwgZnJhbWVzVG9Qcm9jZXNzKTsKKyAgICAgICAgICAgIFZl Y3Rvck1hdGg6Om11bHRpcGx5QnlTY2FsYXJUaGVuQWRkVG9WZWN0b3Ioc291cmNlTCwgZGVzaXJl ZEdhaW5SLCBzb3VyY2VSLCBkZXN0aW5hdGlvblIsIGZyYW1lc1RvUHJvY2Vzcyk7CiAgICAgICAg IH0KICAgICB9CiB9Cg==